Ilod created this revision.
Ilod added a reviewer: hans.
Ilod added a subscriber: cfe-commits.
-finline-functions and /Ob2 are currently ignored by Clang. The only way to
enable inlining is to use the global O flags, which also enable other options,
or to emit LLVM bitcode using Clang, then runn
Ilod updated this revision to Diff 58302.
Ilod added a comment.
Thanks!
Updated to respect the 80-columns limit.
Updated the tests to have a clearer checks. (I don't know well the FileCheck,
so I took example from test/CodeGen/noinline.c, but this is indeed more
comprehensible).
http://review
Ilod added a comment.
I don't have commit access, so you can do it for me, thanks.
http://reviews.llvm.org/D20576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ilod added a comment.
Hello,
It seems the new test was commited as .cc instead of .c, which changes the name
mangling, making // NOINLINE-LABEL: @foo fail.
Either the file should be renamed, or -x c should be added to clang invocation,
or LABEL check updated.
Repository:
rL LLVM
http://rev
Ilod created this revision.
Ilod added a subscriber: cfe-commits.
Add two flags (-finline-implicit-hint and -fno-inline-implicit-hint) to allow
to add InlineHint on implicitly inline functions (constexpr and member
functions of class that was defined in the class body).
This is needed to add sup
Ilod added a reviewer: rnk.
Ilod updated this revision to Diff 61029.
Ilod added a comment.
Updated to head revision, and pinging this.
http://reviews.llvm.org/D20647
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Fro
Ilod added a comment.
I don't think weak linkage defines this.
For example, in:
struct A {
inline int foo() { return 0; }
int bar() { return 1; }
int baz();
};
int A::baz() { return 2; }
With /Ob1, we should inline foo and bar, but never baz. But baz doesn't have
weak linkage
Ilod updated this revision to Diff 61318.
Ilod added a comment.
New patch, which instead add NoInline to function not marked (implicitly or
explicitly) inline, when we use the -finline-hint-functions flag (effectily
inlining only implicitly and explicitly inline functions). Also adds support
fo
Ilod marked an inline comment as done.
Comment at: test/Driver/cl-options.c:283
@@ -282,3 +282,2 @@
// RUN:/nologo \
-// RUN:/Ob1 \
// RUN:/openmp- \
hans wrote:
> You're removing it from the ignored flags here, but I don't see any code
> change or
Ilod updated this revision to Diff 61418.
Ilod added a comment.
Fixed passing argument from clang driver to cc1.
Added driver tests.
http://reviews.llvm.org/D20647
Files:
include/clang/Driver/CLCompatOptions.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/
Ilod marked 2 inline comments as done.
Ilod added a comment.
http://reviews.llvm.org/D20647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ilod added a comment.
Thanks.
I will let you submit it for me if everything seems ok.
http://reviews.llvm.org/D20647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ilod added a subscriber: Ilod.
Ilod added a comment.
Hello,
When I tried your patch and added LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, I had
multiple errors on your python scripts, like:
File "utils/extract_symbols.py", line 399, in
calling_convention_decoration = is_32bit_windows(libs[0]
Ilod added a comment.
In http://reviews.llvm.org/D21385#472268, @john.brawn wrote:
> In http://reviews.llvm.org/D21385#471807, @Ilod wrote:
>
> > I gave up after this. I have Pyhton 3.5 64 bits, and was building clang
> > 32-bits on Windows with Visual Studio 2015 Update 2.
>
>
> python 3 isn't
Ilod added a comment.
The PrintFunctionNames plugin works fine, but not the SampleAnalyzerPlugin? The
checker-plugins test fails. Not sure, but I suppose it's because the
regitration method for checkers is different (a C method called
clang_registerCheckers is retrieved in the DLL from the main
Ilod added a comment.
LGTM
Plugins tests are still disabled by lit.cfg I think, as it only checks for
enable_shared, which is disabled. I suppose we could wait for both this and the
SampleAnalyzerPlugin to be patched before enabling plugins tests if we have
LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, as
Ilod added a comment.
LGTM.
Do you known if there is any good reason Analyzer plugins aren't using the
Registry system (thus forcing plugin writers to manually export the functions)?
Repository:
rL LLVM
http://reviews.llvm.org/D21971
___
cfe-co
Ilod added a comment.
I don't have write access to SVN, so IIUC LLVM policy says I can't approve a
patch.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
18 matches
Mail list logo
