[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling updated this revision to Diff 146355. rkirsling added a comment. Updated patch to resolve conflict and include full diff context. Repository: rC Clang https://reviews.llvm.org/D46024 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. If there are no objections to this change, may I request a commit based on the approval that @jfb provided? Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. @klimek In our IRC discussion yesterday, I know you expressed disapproval of WebKit's choice, but given its reality, am I correct in concluding that this can be landed? Repository: rC Clang https://reviews.llvm.org/D46024 ___

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling updated this revision to Diff 149395. rkirsling added a comment. Resolved another rebase conflict to keep this patch mergeable. Repository: rC Clang https://reviews.llvm.org/D46024 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp l

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. FWIW, please note that this space-before-brace style is not specific to WebKit; CppCoreGuidelines exhibits it as well: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax Repository: rC Clang https://reviews.llvm.org/D460

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling updated this revision to Diff 150984. rkirsling added a comment. Addressed feedback—thank you for the review! Repository: rC Clang https://reviews.llvm.org/D46024 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/TokenAnn

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. I'll need someone to commit. Thanks! Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling created this revision. rkirsling added reviewers: djasper, klimek. Herald added a subscriber: cfe-commits. WebKit C++ style for object initialization is as follows: Foo foo { bar }; Yet using `clang-format -style=webkit` changes this to: Foo foo{ bar }; As there is no existing co

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. In https://reviews.llvm.org/D46024#1079390, @klimek wrote: > Is this written down somewhere? https://webkit.org/code-style-guidelines/ > doesn't seem to mention it. I agree that it really ought to be mentioned there—I'll try to bring that up with the original author

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. Guidelines page has been updated (https://trac.webkit.org/changeset/231085), though it may take a bit for the website to update. Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-com

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. Rule has been published: https://webkit.org/code-style-guidelines/#spacing-braced-init Hopefully that suffices for motivation. :) Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-co

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. Any further commentary? :) Repository: rC Clang https://reviews.llvm.org/D46024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits