RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Thanks! I just committed the patch. Katya. > -Original Message- > From: Jonathan Roelofs [mailto:jonat...@codesourcery.com] > Sent: Tuesday, October 13, 2015 3:40 PM > To: Romanova, Katya; al...@leftfield.org; Robinson, Paul; > echri...@gmail.com; filcab+llvm.phabrica...@gmail.com; > jonat

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Sorry for causing the trouble with the build. I will try to look later why my partial rebuild didn't catch the issue. I have fixed the error, rebuilt and ran the tests. This is a very big patch. Please be understanding, because this patch has a big impact. I apologize in advance if it causes som

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Hi Sean, I don’t think that the whole patch should have been reverted. There were much easier way to make the PS4 bot green. A single test could have been marked as “XFAIL: ps4” for a few hours until a better solution is implemented. Reverting this huge patch is more drastic measure that might

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Thank you, Filipe! Katya. Sent from my iPhone On Oct 14, 2015, at 6:12 AM, "Filipe Cabecinhas" mailto:filcab+llvm.phabrica...@gmail.com>> wrote: Hi all, I have harnessed the powers of time zones and did the last tweak we needed to get it comitted. It's still going through some bots, but I do

RE: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Filipe, I have one question regarding the change in debug-option.c that you made to get the builds green again… (r250294). Basically you changed the generic run line that used to test the drivers for every single platform // RUN: %clang -### -g %s 2>&1 | FileCheck -check-prefix=CI %s into the r

RE: [PATCH] D16913: Adding doxygen comments to the LLVM intrinsics (part 4, pmmintrin.h)

Thank you! Paul Robinson did a very detailed code review yesterday, so I suspect that this doxygen comment patch is of very good quality. ☺ Katya. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Thursday, February 04, 2016 6:47 PM To: reviews+d16913+public+13cb39057c425...@reviews.llvm.o

RE: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

My apologies… From: David Blaikie [mailto:dblai...@gmail.com] Sent: Tuesday, February 09, 2016 4:42 PM To: reviews+d17021+public+89c4dbb2f75e8...@reviews.llvm.org; Romanova, Katya Cc: Gao, Yunzhong; Robinson, Paul; Eric Christopher; Dmitri Gribenko; Craig Topper; Jonathan Roelofs; cfe-commits Sub

RE: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Hi Eric, Everywhere else in this file formal parameter “a” is used. This one “__a” was inconsistent. However, if you don’t like it, I could change it back. Katya. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, February 10, 2016 3:16 PM To: Romanova, Katya; cfe-commits@lists

RE: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Sure. I’ll change it. Do you mind if I do it when I’m back from vacation (i.e. a couple of weeks from now)? I will send a patch. Thank you! Katya. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, February 10, 2016 5:08 PM To: Romanova, Katya; cfe-commits@lists.llvm.org Subject:

RE: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Hello, I don’t think it will too hard to convert C++ style doxygen comments into C style doxygen comments by writing a post-processing python script. However, at first we need to decide if we really want to do that. If so, we need to settle on the exact format. After that, I need to make sure t

RE: D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

Hi Simon, Thank you for the patch and for fixing the doxygen comments. There is no need to update Sony's intrinsics document. Very soon our documentation team is planning to release the documentation based on the doxygen headers in the upstream headers, so your change will funnel through autom

RE: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Hi Dmitri, Could you please let us know your opinion about C++ vs C-style doxygen comments. Read this thread for ‘pro’ and ‘con’ arguments about using C++ headers. Will LLVM online documentation look proper if we decide to use C-style headers? Which style do you personally prefer to see? Note,

RE: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Hi Dmitri, Thank you for your reply. I have double-checked that compiling a test invoking an intrinsic that has C++ style doxygen comments in the corresponding header doesn't cause compile-time errors/warnings in -std=c89 (and in gnu89, c99, gnu99, c11, gnu11) modes. I will continue committing

RE: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

I see. I was hoping that if you were, I could have used the same benchmark and compare what build time increase caused by using target attributes (might be much more substantial) and by adding doxygen comments. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, January 20, 2016

RE: r255281 - Do not generate DW_TAG_imported_module for anonymous namespaces (even nested) for all the platforms except PS4.

Hi David, Thank you so much for the review. I copied and pasted the diff file. Let me know if it’s OK to commit. >> Could/should this ^ just be: Opts.DebugExplicitImport = Triple.isPS4CPU(); ? Done. >> Extra semicolon here ^ Done. >> And is there any reason not to just use nullptr here and els