On Tue, Dec 11, 2018 at 12:07 AM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Mon Dec 10 13:04:04 2018
> New Revision: 348798
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348798&view=rev
> Log:
> Fix nits
Can you *please* write proper commit messages, pretty please?
I have
Doesn't look like this patch added 'znver2'?
On Tue, Feb 26, 2019 at 10:20 PM Craig Topper via cfe-commits
wrote:
>
> Author: ctopper
> Date: Tue Feb 26 11:20:04 2019
> New Revision: 354915
>
> URL: http://llvm.org/viewvc/llvm-project?rev=354915&view=rev
> Log:
> [X86] Add 'znver2' and 'cascadela
Author: lebedevri
Date: Tue Mar 5 23:45:10 2019
New Revision: 355486
URL: http://llvm.org/viewvc/llvm-project?rev=355486&view=rev
Log:
[clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"
Summary:
This reverts rL352390 / D57280.
As discussed in https://reviews.llvm.org/D5
You probably want to submit this patchset to phabricator.
It will get lost in mailing list.
On Sat, Mar 9, 2019 at 1:38 AM Connor Kuehl via cfe-commits
wrote:
>
> This patch set introduces structure field layout randomization into the Clang
> compiler. The Randstruct feature is a compile-time har
Author: lebedevri
Date: Tue Mar 12 14:31:00 2019
New Revision: 355987
URL: http://llvm.org/viewvc/llvm-project?rev=355987&view=rev
Log:
[NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`
Summary:
These ObjC AST classes inherit from Stmt, but don't call `VisitStmt(S);`.
Some were founded wit
This was reviewed by someone already familiar with, and active with
the code in question?
On Wed, Mar 13, 2019 at 11:25 AM Paul Hoad via cfe-commits
wrote:
>
> Author: paulhoad
> Date: Wed Mar 13 01:26:39 2019
> New Revision: 356031
>
> URL: http://llvm.org/viewvc/llvm-project?rev=356031&view=rev
test?
On Thu, Mar 14, 2019 at 1:17 AM Stephane Moore via Phabricator via
cfe-commits wrote:
>
> stephanemoore created this revision.
> Herald added subscribers: cfe-commits, jdoerfert, xazax.hun.
> Herald added a project: clang.
>
> In contrast to Google C++, Objective-C often uses built-in integ
Author: lebedevri
Date: Wed Mar 20 10:14:49 2019
New Revision: 356577
URL: http://llvm.org/viewvc/llvm-project?rev=356577&view=rev
Log:
[AST] Disable ast-dump-openmp-parallel-master-XFAIL.c test
Fails on MSVC buildbot (but not locally).
Not important as it is 'testing' something that isn't suppor
Author: lebedevri
Date: Wed Mar 20 10:15:47 2019
New Revision: 356578
URL: http://llvm.org/viewvc/llvm-project?rev=356578&view=rev
Log:
[NFC][ASTMatchers] Alphabetically sort REGISTER_MATCHER() macros in
RegistryMaps::RegistryMaps()
As noted in https://reviews.llvm.org/D59453#inline-526253
Modi
Author: lebedevri
Date: Thu Mar 21 08:33:10 2019
New Revision: 356674
URL: http://llvm.org/viewvc/llvm-project?rev=356674&view=rev
Log:
[ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher.
Summary:
A simple matcher for `OMPExecutableDirective` Stmt type.
Split off from D57113.
Review
Author: lebedevri
Date: Thu Mar 21 08:33:24 2019
New Revision: 356675
URL: http://llvm.org/viewvc/llvm-project?rev=356675&view=rev
Log:
[ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling
Summary:
`OMPClause` is the base class, it is not descendant from **any**
other class, therefore for it t
Author: lebedevri
Date: Thu Mar 21 08:33:35 2019
New Revision: 356676
URL: http://llvm.org/viewvc/llvm-project?rev=356676&view=rev
Log:
[ASTMatchers][OpenMP] OpenMP Structured-block-related matchers
Summary: Exposes to the for ASTMatchers the interface/modelling
of OpenMP structured-block.
Revi
Author: lebedevri
Date: Thu Mar 21 08:33:43 2019
New Revision: 356677
URL: http://llvm.org/viewvc/llvm-project?rev=356677&view=rev
Log:
[ASTMatcher] Add clang-query disclaimer to two more matchers that take enum
As we have figured out in
https://reviews.llvm.org/D57112
and
https://bugs.llvm.org/s
Author: lebedevri
Date: Thu Mar 21 08:50:54 2019
New Revision: 356679
URL: http://llvm.org/viewvc/llvm-project?rev=356679&view=rev
Log:
[AST] OMPStructuredBlockTest: two matchers were promoted into ASTMatchers.h
Modified:
cfe/trunk/unittests/AST/OMPStructuredBlockTest.cpp
Modified: cfe/trunk
Thank you for the fix.
I remembered of the yesterday's fix, but either forgot about it here,
or incorrectly recalled this code would be relying on the yesterday's code
(as in, no fix would be needed.)
Roman.
On Thu, Mar 21, 2019 at 10:11 PM Jordan Rupprecht via cfe-commits
wrote:
>
> Author: ru
Author: lebedevri
Date: Fri Mar 22 06:40:36 2019
New Revision: 356749
URL: http://llvm.org/viewvc/llvm-project?rev=356749&view=rev
Log:
[AST] OMPStructuredBlockTest: avoid using multiline string literals in macros
That is what i have been doing elsewhere in these tests, maybe that's it?
Maybe th
Author: lebedevri
Date: Fri Mar 22 12:45:51 2019
New Revision: 356799
URL: http://llvm.org/viewvc/llvm-project?rev=356799&view=rev
Log:
[NFC] ExceptionEscapeCheck: small refactoring
Summary:
D59466 wants to analyse the `Stmt`, and `ExceptionEscapeCheck` does not
have that as a possible entry poin
Author: lebedevri
Date: Fri Mar 22 12:46:01 2019
New Revision: 356800
URL: http://llvm.org/viewvc/llvm-project?rev=356800&view=rev
Log:
[clang-tidy] A new OpenMP module
Summary:
Just the empty skeleton.
Previously reviewed as part of D57113.
Reviewers: JonasToth, aaron.ballman, alexfh, xazax.hun
Author: lebedevri
Date: Fri Mar 22 12:46:12 2019
New Revision: 356801
URL: http://llvm.org/viewvc/llvm-project?rev=356801&view=rev
Log:
[clang-tidy] openmp-use-default-none - a new check
Summary:
Finds OpenMP directives that are allowed to contain `default` clause,
but either don't specify it, or
Author: lebedevri
Date: Fri Mar 22 12:46:25 2019
New Revision: 356802
URL: http://llvm.org/viewvc/llvm-project?rev=356802&view=rev
Log:
[clang-tidy] openmp-exception-escape - a new check
Summary:
Finally, we are here!
Analyzes OpenMP Structured Blocks and checks that no exception escapes
out of
Best to submit patches to phabricator https://reviews.llvm.org/
On Tue, Apr 2, 2019 at 8:30 PM George Koehler via cfe-commits
wrote:
>
> Hello cfe-commits,
>
> The attached patch is for clang to use -fomit-frame-pointer by default
> for all PowerPC targets when optimizing code. Right now, clang
On Sat, Apr 27, 2019 at 3:29 AM Jorge Gorbe Moya via cfe-commits
wrote:
>
> Author: jgorbe
> Date: Fri Apr 26 17:32:04 2019
> New Revision: 359361
>
> URL: http://llvm.org/viewvc/llvm-project?rev=359361&view=rev
> Log:
> Revert Fix interactions between __builtin_constant_p and constexpr to match
Author: lebedevri
Date: Sun May 5 14:26:32 2019
New Revision: 360002
URL: http://llvm.org/viewvc/llvm-project?rev=360002&view=rev
Log:
[clang-tidy] openmp-exception-escape check: point to the structured-block
I'm not sure what i was thinking when i wrote it to point at the directive.
It's at the
Thank you!
On Mon, May 6, 2019 at 8:46 PM Alexey Bataev via cfe-commits
wrote:
>
> Author: abataev
> Date: Mon May 6 10:49:22 2019
> New Revision: 360061
>
> URL: http://llvm.org/viewvc/llvm-project?rev=360061&view=rev
> Log:
> [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clau
Thank you!
On Mon, May 6, 2019 at 11:05 PM Alexey Bataev via cfe-commits
wrote:
>
> Author: abataev
> Date: Mon May 6 13:07:20 2019
> New Revision: 360073
>
> URL: http://llvm.org/viewvc/llvm-project?rev=360073&view=rev
> Log:
> [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with
> d
Author: lebedevri
Date: Thu May 9 03:47:45 2019
New Revision: 360326
URL: http://llvm.org/viewvc/llvm-project?rev=360326&view=rev
Log:
Revert "[OPENMP]Fix PR41767: diagnose DSA for variables in clauses with
default(none)."
This implementation isn't sound as per the standard.
It erroneously diag
Author: lebedevri
Date: Thu May 9 03:48:13 2019
New Revision: 360327
URL: http://llvm.org/viewvc/llvm-project?rev=360327&view=rev
Log:
Revert "[OPENMP]Fix PR41768: check DSA for globals with `default(none)`
clauses."
This has introduced (exposed?) a crash in clang sema,
that does not happen wit
... and i had to revert this & the other commit. Sorry :(
This implementation isn't sound as per the standard.
It erroneously diagnoses e.g. the following case:
```
$ cat test.cpp
void f(int n) {
#pragma omp parallel default(none) if(n)
;
}
```
```
$ ./bin/clang -fopenmp test.cpp
test.cpp:2:40
On Tue, Sep 18, 2018 at 10:09 PM, Kirill Bobyrev
wrote:
> Hi Roman,
>
> Is there any benefit of doing so? Also, I’m not sure whether I understood you
> correctly. Consuming benchmark options *before* trimming would probably not
> be the desired behaviour since the first two arguments arguments a
Author: lebedevri
Date: Wed Sep 26 06:08:44 2018
New Revision: 343105
URL: http://llvm.org/viewvc/llvm-project?rev=343105&view=rev
Log:
[analyzer] scan-build: if --status-bugs is passed, don't forget about the exit
status of the actual build
Summary:
This has been bothering me for a while, but o
Author: lebedevri
Date: Thu Sep 27 12:07:48 2018
New Revision: 343251
URL: http://llvm.org/viewvc/llvm-project?rev=343251&view=rev
Log:
[clang][ubsan][NFC] Slight test cleanup in preparation for D50901
Reviewers: vsk, vitalybuka, filcab
Reviewed By: vitalybuka
Subscribers: cfe-commits
Differen
On Tue, Oct 2, 2018 at 5:54 PM Jonas Toth via Phabricator via
cfe-commits wrote:
>
> JonasToth added a comment.
>
> Verified that it does not block other clang-extra tools if clangd tests fail.
> Thank you very much for fixing!
Would be great to get check-clang-tidy target 'while there'.
>
> Repo
On Sat, Oct 6, 2018 at 10:06 PM Owen Pan via Phabricator via
cfe-commits wrote:
>
> owenpan added a comment.
>
> I'd greatly appreciate it if someone could review this before I commit it
> next week.
That is not how LLVM reviews work.
Commit-without-review mostly is only for NFC changes in the co
Author: lebedevri
Date: Fri Feb 1 00:23:23 2019
New Revision: 352841
URL: http://llvm.org/viewvc/llvm-project?rev=352841&view=rev
Log:
[clangd] Fix -DBUILD_SHARED_LIBS=ON build - SwapIfBranches needs clangAST.
Else, fails with:
[1/2] Linking CXX executable bin/clangd
FAILED: bin/clangd
: && /us
Author: lebedevri
Date: Fri Feb 1 00:58:37 2019
New Revision: 352843
URL: http://llvm.org/viewvc/llvm-project?rev=352843&view=rev
Log:
[clangd] clangDaemonTweaks - fix -DBUILD_SHARED_LIBS=ON build
Followup for rL352841.
Modified:
clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt
Author: lebedevri
Date: Fri Feb 1 07:41:54 2019
New Revision: 352882
URL: http://llvm.org/viewvc/llvm-project?rev=352882&view=rev
Log:
[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks
Summary:
I'm working on a clang-tidy check, much like existing [[
http://clang.llvm
Author: lebedevri
Date: Fri Feb 1 14:43:08 2019
New Revision: 352933
URL: http://llvm.org/viewvc/llvm-project?rev=352933&view=rev
Log:
Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured
blocks"
Further reviews (D57594, D57615) have revealed that this was not reviewed,
Author: lebedevri
Date: Wed Feb 6 11:17:30 2019
New Revision: 353327
URL: http://llvm.org/viewvc/llvm-project?rev=353327&view=rev
Log:
[clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)
Summary:
The check should ignore the main function, the program entry point.
It is not possi
Thank you.
On Thu, Feb 7, 2019 at 2:03 PM Hans Wennborg wrote:
>
> Merged in r353391.
>
> On Wed, Feb 6, 2019 at 8:17 PM Roman Lebedev via cfe-commits
> wrote:
> >
> > Author: lebedevri
> > Date: Wed Feb 6 11:17:30 2019
> > New Revision: 353327
> >
On Sat, Feb 9, 2019 at 3:45 AM Mikhail R. Gadelha via cfe-commits
wrote:
>
> Author: mramalho
> Date: Fri Feb 8 16:46:12 2019
> New Revision: 353590
>
> URL: http://llvm.org/viewvc/llvm-project?rev=353590&view=rev
> Log:
> This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.
> and commit
On Mon, Feb 11, 2019 at 7:38 PM Aaron Ballman via cfe-commits
wrote:
>
> On Mon, Feb 11, 2019 at 11:36 AM Nico Weber via cfe-commits
> wrote:
> >
> > Author: nico
> > Date: Mon Feb 11 08:37:02 2019
> > New Revision: 353718
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=353718&view=rev
> > L
On Fri, Feb 15, 2019 at 5:42 PM Yitzhak Mandelbaum via cfe-commits
wrote:
>
> Author: ymandel
> Date: Fri Feb 15 06:43:10 2019
> New Revision: 354136
>
> URL: http://llvm.org/viewvc/llvm-project?rev=354136&view=rev
> Log:
> Exteded test of .
Were last few commits were meant to be committed?
Regard
Author: lebedevri
Date: Thu Sep 7 15:14:25 2017
New Revision: 312750
URL: http://llvm.org/viewvc/llvm-project?rev=312750&view=rev
Log:
[Sema] -Wtautological-compare: handle comparison of unsigned with 0S.
Summary:
This is a first half(?) of a fix for the following bug:
https://bugs.llvm.org/show
with a technically-incorrect mental model.
> If this is the case, should we move these to a -Wtautological-compare-enum
> subcategory?
(Did not look at this yet)
Roman.
> On Fri, Sep 8, 2017 at 12:14 AM, Roman Lebedev via cfe-commits
> wrote:
>>
>> Author: lebedevri
>&
Author: lebedevri
Date: Fri Sep 8 06:56:45 2017
New Revision: 312792
URL: http://llvm.org/viewvc/llvm-project?rev=312792&view=rev
Log:
[Sema] Put tautological comparison of unsigned and zero into it's own flag
Summary:
As requested by Sam McCall.
```
$ /build/llvm-build-Clang-release/./bin/clan
>> subcategory?
> (Did not look at this yet)
https://reviews.llvm.org/D37629 i hope that is what you meant.
> Roman.
Roman.
>> On Fri, Sep 8, 2017 at 12:14 AM, Roman Lebedev via cfe-commits
>> wrote:
>>>
>>> Author: lebedevri
>>> Date: Thu Sep 7 15:
pe < NUM_MEDIA_DEVICE_TYPES;
}
But it still seem to warn, and *that* sounds like a bug.
Please open a new bugreport.
As for different default signedness, i'm not sure what is there to do. Does
not sound like a problem for this diagnostic to intentionally avoid to
be honest.
>> On F
e type) {
>> return type >= 0U && type < NUM_MEDIA_DEVICE_TYPES;
>> }
>>
>> But it still seem to warn, and *that* sounds like a bug.
>> Please open a new bugreport.
>
> I'm reporting it here :-)
Here i might forget :)
But as soon as i get a LGTM o
Author: lebedevri
Date: Mon Sep 11 06:12:31 2017
New Revision: 312912
URL: http://llvm.org/viewvc/llvm-project?rev=312912&view=rev
Log:
[clang-tidy] FunctionSizeCheck: wrap FunctionASTVisitor into anon namespace, NFC
This check is relatively simple, and is often being used
as an example. I'm awar
On Fri, Sep 8, 2017 at 9:33 PM, Roman Lebedev via Phabricator via
cfe-commits wrote:
> lebedev.ri added a comment.
>
> In https://reviews.llvm.org/D37629#865068, @lebedev.ri wrote:
>
>> And finish reducing the code by for-range-loop`ing over array + use
>> `std::array`.
>
>
> I will need to fix h
Author: lebedevri
Date: Tue Sep 19 14:11:35 2017
New Revision: 313677
URL: http://llvm.org/viewvc/llvm-project?rev=313677&view=rev
Log:
[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare
Summary:
As requested by Sam McCall:
> Enums (not new I guess). Typical case: if (enum < 0
ay
>>> somewhat compatible with a technically-incorrect mental model.
>>> If this is the case, should we move these to a -Wtautological-compare-enum
>>> subcategory?
>> (Did not look at this yet)
> https://reviews.llvm.org/D37629 i hope that is what you meant.
An
Author: lebedevri
Date: Tue Sep 19 14:40:41 2017
New Revision: 313683
URL: http://llvm.org/viewvc/llvm-project?rev=313683&view=rev
Log:
Revert "[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare"
This reverts commit r313677.
Buildbots fail with assertion failure
Failing Tests
Author: lebedevri
Date: Wed Sep 20 02:54:47 2017
New Revision: 313745
URL: http://llvm.org/viewvc/llvm-project?rev=313745&view=rev
Log:
[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare
Recommit. Original commit was reverted because buildbots broke.
The error was only reproduc
Author: lebedevri
Date: Wed Sep 20 03:15:27 2017
New Revision: 313747
URL: http://llvm.org/viewvc/llvm-project?rev=313747&view=rev
Log:
[Sema] CheckTautologicalComparisonWithZero(): always complain about enums
Hopefully fixes test-clang-msc-x64-on-i686-linux-RA build.
The underlying problem is t
On Sat, Sep 9, 2017 at 12:56 AM, Aaron Ballman wrote:
> On Fri, Sep 8, 2017 at 5:49 PM, Hans Wennborg via cfe-commits
> wrote:
>> On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli
>> wrote:
>>> On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote:
On Fri, Sep 8, 2017 at 2:09 PM, Roman
Author: lebedevri
Date: Wed Sep 20 06:50:01 2017
New Revision: 313756
URL: http://llvm.org/viewvc/llvm-project?rev=313756&view=rev
Log:
Replace r313747, don't always warn on enums, rework testcases.
As Aaron Ballman has pointed out, that is not really correct.
So the key problem there is the inva
On Thu, May 30, 2019 at 5:48 PM Csaba Dabis via cfe-commits
wrote:
>
> Thanks you!
>
> Fixed by
> https://github.com/llvm/llvm-project/commit/17604c3486cbe7c27cadac1757cd0a9109a92792
The non-determinism is still there though, so this isn't correct fix.
> On Thu, May 30, 2019 at 4:16 PM Russell G
I think we're still talking past each other.
I'm saying that *any* commit that does not fix the underlying nondeterminizm,
but only hides it by deleting tests that showed that said determinism
exists in the first place,
is not a fix.
Roman.
On Thu, May 30, 2019 at 6:14 PM Csaba Dabis wrote:
>
>
nd by my opinion that it is a preexisting tooling issue.
(same with clang codegen tests, diags, etc etc)
Roman.
> On Wed, 20 Mar 2019 at 11:16, Roman Lebedev via cfe-commits
> wrote:
>>
>> Author: lebedevri
>> Date: Wed Mar 20 09:31:47 2019
>> New Revision: 356
Thank you!
On Sun, Jun 2, 2019 at 6:57 AM Richard Smith via cfe-commits
wrote:
>
> Author: rsmith
> Date: Sat Jun 1 21:00:38 2019
> New Revision: 362316
>
> URL: http://llvm.org/viewvc/llvm-project?rev=362316&view=rev
> Log:
> Add script to update OpenMP -ast-dump test expectations, and use it t
On Fri, Jun 14, 2019 at 12:48 PM Thomas Manceau via Phabricator via
cfe-commits wrote:
>
> Blackhart created this revision.
> Blackhart created this object with edit policy "Only User: Blackhart (Thomas
> Manceau)".
You might want to unset that :)
> Blackhart added a project: clang-tools-extra.
Missing a test, and if this is a patch and not a commit you want to
submit it via https://llvm.org/docs/Phabricator.html
On Tue, Jun 18, 2019 at 2:20 PM Andreas Schwab via cfe-commits
wrote:
>
> ---
> clang/lib/Driver/ToolChains/Gnu.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
On Tue, Jun 18, 2019 at 3:06 PM Andreas Schwab wrote:
>
> On Jun 18 2019, Roman Lebedev wrote:
>
> > Missing a test, and if this is a patch and not a commit you want to
> > submit it via https://llvm.org/docs/Phabricator.html
>
> http://llvm.org/docs/DeveloperPolicy.html says I should send it her
On Wed, Jun 26, 2019 at 1:58 AM Rumeet Dhindsa via cfe-commits
wrote:
>
> Author: rdhindsa
> Date: Tue Jun 25 15:58:25 2019
> New Revision: 364359
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364359&view=rev
> Log:
> Revert Devirtualize destructor of final class.
>
> This reverts r364100 (git
It might be best to submit the patch to phabricator so it does not get lost.
https://llvm.org/docs/Phabricator.html
On Thu, May 23, 2019 at 3:13 PM Rudolf Kastl via cfe-commits
wrote:
>
> A pretty trivial patch to successfully build clang.
> ___
> cfe-c
On Thu, Dec 13, 2018 at 10:48 AM Serge Guelton via cfe-commits
wrote:
>
> Author: serge_sans_paille
> Date: Wed Dec 12 23:45:55 2018
> New Revision: 349010
>
> URL: http://llvm.org/viewvc/llvm-project?rev=349010&view=rev
> Log:
> Portable Python script across Python version
>
> SocketServer has be
test?
On Thu, Dec 27, 2018 at 5:47 PM David Chisnall via cfe-commits
wrote:
>
> Author: theraven
> Date: Thu Dec 27 06:44:36 2018
> New Revision: 350092
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350092&view=rev
> Log:
> [objc-gnustep] Fix a copy-and-paste error.
>
> We were emitting the nu
eparate, and in -Wall, too.)
Roman.
> On Tue, Nov 20, 2018 at 2:01 PM Roman Lebedev via cfe-commits
> wrote:
>>
>> Author: lebedevri
>> Date: Tue Nov 20 10:59:05 2018
>> New Revision: 347339
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=347339&
Just a thought: reproducible builds will surely be interested in this.
Did gcc already solve this problem? And if yes, it would be best to be
compatible.
On Thu, Jan 3, 2019 at 6:41 PM Nolan O'Brien via Phabricator via
cfe-commits wrote:
>
> NSProgrammer added a comment.
>
> To throw in my 2 cent
No, that is the opposite of the solution, actually, i think.
https://tests.reproducible-builds.org/debian/issues/unstable/gcc_captures_build_path_issue.html
And:
https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00513.html
^ i suspect clang should be compatible with whatever approach is
suggested ther
Thanks!
On Tue, Jan 8, 2019 at 6:57 PM Alexey Bataev via cfe-commits
wrote:
>
> Author: abataev
> Date: Tue Jan 8 07:53:42 2019
> New Revision: 350634
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350634&view=rev
> Log:
> [OPENMP]Fix PR40191: Do not allow orphaned cancellation constructs.
>
>
You might want to submit the patch to phabricator, mail may be lost.
On Tue, Sep 10, 2019 at 3:44 AM Rayson Ho via cfe-commits
wrote:
>
> Found 2 typos when I was trying to use the context sensitive profiling
> feature earlier today:
>
>
Author: lebedevri
Date: Mon Sep 16 10:46:01 2019
New Revision: 372014
URL: http://llvm.org/viewvc/llvm-project?rev=372014&view=rev
Log:
[Clang][Codegen] Relax available-externally-suppress.c test
That test is broken by design.
It depends on llvm middle-end behavior.
No clang codegen test should b
Author: lebedevri
Date: Mon Sep 16 10:46:08 2019
New Revision: 372015
URL: http://llvm.org/viewvc/llvm-project?rev=372015&view=rev
Log:
[Clang][Codegen] Disable arm_acle.c test.
This test is broken by design. Clang codegen tests should not depend
on llvm middle-end behaviour, they should *only* t
Oh, that looked like it was due to r372012 but apparently it wasn't.
Fixed in r372019.
Sorry for the breakage.
Roman
On Mon, Sep 16, 2019 at 9:11 PM Nico Weber wrote:
>
> CodeGen/ARM/CGP/arm-gcp-casts.ll is broken too.
>
> On Mon, Sep 16, 2019 at 1:44 PM Roman Lebedev via cfe-
I'm just wondering, was this not caught in `ninja check-clang` before
the patch that added the warning landed?
On Mon, Sep 30, 2019 at 11:39 PM David Bolvansky via cfe-commits
wrote:
>
> Author: xbolva00
> Date: Mon Sep 30 13:41:56 2019
> New Revision: 373258
>
> URL: http://llvm.org/viewvc/llvm-
Test?
On Thu, Apr 12, 2018 at 8:41 AM, Zinovy Nis via cfe-commits
wrote:
> Author: zinovy.nis
> Date: Wed Apr 11 22:41:24 2018
> New Revision: 329873
>
> URL: http://llvm.org/viewvc/llvm-project?rev=329873&view=rev
> Log:
> [clang-tidy] [modernize-use-auto] Get only a length of token, not the tok
Also, i guess you now can remove linking to clangTooling that was
required to unbreak the build.
I'm guessing clangLex contains Lexer::MeasureTokenLength() ?
On Thu, Apr 12, 2018 at 10:22 AM, Roman Lebedev wrote:
> Test?
>
> On Thu, Apr 12, 2018 at 8:41 AM, Zinovy Nis via cfe-commits
> wrote:
>>
On Thu, Apr 12, 2018 at 10:30 AM, Zinovy Nis wrote:
> Yes, due to to incorrect token length returned by the old code, the test was
> passing. I fixed it.
Let me rephrase.
If i revert just the
clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp change,
will the corresponding tests in
clan
Author: lebedevri
Date: Thu Apr 12 03:01:20 2018
New Revision: 329892
URL: http://llvm.org/viewvc/llvm-project?rev=329892&view=rev
Log:
[clang-apply-replacements] Don't forget to link to clangToolingRefactor
Fixes build:
[1/3] Linking CXX shared library lib/libclangApplyReplacements.so.7svn
FAIL
Author: lebedevri
Date: Thu Apr 12 05:06:42 2018
New Revision: 329902
URL: http://llvm.org/viewvc/llvm-project?rev=329902&view=rev
Log:
[clang-tidy] readability-function-size: add VariableThreshold param.
Summary:
Pretty straight-forward, just count all the variable declarations in the
function'
On Thu, Apr 12, 2018 at 10:47 PM, Zinovy Nis via cfe-commits
wrote:
> I composed a test and you are right - for multi-token type names new code
> returns wrong result. So this new code was a premature optimization. Sorry.
> I'll see how to fix it in a better way and create a review on it. Thanks f
Author: lebedevri
Date: Mon Apr 23 14:35:21 2018
New Revision: 330651
URL: http://llvm.org/viewvc/llvm-project?rev=330651&view=rev
Log:
[Sema] Add -Wno-self-assign-overloaded
Summary:
It seems there isn't much enthusiasm for `-wtest` D45685.
This is more conservative version, which i had in the
Author: lebedevri
Date: Tue Apr 24 01:40:44 2018
New Revision: 330694
URL: http://llvm.org/viewvc/llvm-project?rev=330694&view=rev
Log:
Link to AggressiveInstCombine in a few places. Unbreaks build for me.
/usr/local/bin/ld.lld: error: undefined symbol:
llvm::createAggressiveInstCombinerPass()
>
Author: lebedevri
Date: Tue May 8 06:14:21 2018
New Revision: 331763
URL: http://llvm.org/viewvc/llvm-project?rev=331763&view=rev
Log:
[clang-tidy] Profile is a per-AST (per-TU) data.
Summary:
As discussed in D45931, currently, profiling output of clang-tidy is somewhat
not great.
It outputs on
Author: lebedevri
Date: Tue Jul 17 00:12:08 2018
New Revision: 337249
URL: http://llvm.org/viewvc/llvm-project?rev=337249&view=rev
Log:
Harden/relax clang/test/CodeGen/opt-record-MIR.c test
Summary:
If the build path is short, `Line` field can end up fitting on the same line as
`File`,
but the `
Author: lebedevri
Date: Thu Oct 10 05:22:42 2019
New Revision: 374328
URL: http://llvm.org/viewvc/llvm-project?rev=374328&view=rev
Log:
[AST] ASTReader::ReadSLocEntry(): move computation of FirstDecl into the branch
where it's used
The existing code is not defined, you are not allowed
to produce
This seems suspicious.
Does clang-reorder-fields actually explicitly needs something from
FrontendOpenMP?
If not, it looks like there dependency is missing elsewhere, or
there's wrong layering.
On Mon, Apr 6, 2020 at 5:03 PM Johannes Doerfert via cfe-commits
wrote:
>
>
> Author: Johannes Doerfert
On Mon, Apr 6, 2020 at 5:23 PM Johannes Doerfert wrote:
>
> On 4/6/20 9:06 AM, Roman Lebedev wrote:
>
> This seems suspicious.
>
>
> Agreed, especially since this is also not the only place.
>
> I was hoping to unblock the builders with this.
>
>
> Does clang-reorder-fields actually explicitly nee
Reproducers?
On Mon, Jun 15, 2020 at 9:47 AM Sam Parker via cfe-commits
wrote:
>
>
> Author: Sam Parker
> Date: 2020-06-15T07:46:28+01:00
> New Revision: 3e39760f8eaad4770efa05824768e67237915cf5
>
> URL:
> https://github.com/llvm/llvm-project/commit/3e39760f8eaad4770efa05824768e67237915cf5
> DIF
Author: Roman Lebedev
Date: 2020-07-04T18:26:22+03:00
New Revision: 7fed3cfadbdfe1880e16c217a0edac97cbe288d2
URL:
https://github.com/llvm/llvm-project/commit/7fed3cfadbdfe1880e16c217a0edac97cbe288d2
DIFF:
https://github.com/llvm/llvm-project/commit/7fed3cfadbdfe1880e16c217a0edac97cbe288d2.diff
Author: Roman Lebedev
Date: 2020-08-16T23:27:56+03:00
New Revision: ae7f08812e0995481eb345cecc5dd4529829ba44
URL:
https://github.com/llvm/llvm-project/commit/ae7f08812e0995481eb345cecc5dd4529829ba44
DIFF:
https://github.com/llvm/llvm-project/commit/ae7f08812e0995481eb345cecc5dd4529829ba44.diff
Author: Roman Lebedev
Date: 2020-08-18T00:57:35+03:00
New Revision: 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a
URL:
https://github.com/llvm/llvm-project/commit/790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a
DIFF:
https://github.com/llvm/llvm-project/commit/790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a.diff
This seems to be missing a test
On Wed, May 20, 2020 at 12:12 AM Dávid Bolvanský via cfe-commits
wrote:
>
>
> Author: Dávid Bolvanský
> Date: 2020-05-19T23:12:08+02:00
> New Revision: 6d2b75e0887ee87e247756c4d51733616bb2f356
>
> URL:
> https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e
Author: Roman Lebedev
Date: 2022-02-08T18:27:54+03:00
New Revision: eaac0e87fb0249f9b87b9929b1afa24504db9792
URL:
https://github.com/llvm/llvm-project/commit/eaac0e87fb0249f9b87b9929b1afa24504db9792
DIFF:
https://github.com/llvm/llvm-project/commit/eaac0e87fb0249f9b87b9929b1afa24504db9792.diff
Where was this reviewed?
On Wed, Feb 16, 2022 at 12:59 AM Zahira Ammarguellat via cfe-commits
wrote:
>
>
> Author: Zahira Ammarguellat
> Date: 2022-02-15T13:59:27-08:00
> New Revision: 4bafe65c2b2f1ce745894a509a6d80c87fb1c335
>
> URL:
> https://github.com/llvm/llvm-project/commit/4bafe65c2b2f1ce
When reverting a commit it is customary to mention *why* it is getting reverted.
On Mon, Sep 2, 2019 at 2:33 PM Nandor Licker via cfe-commits
wrote:
>
> Author: nand
> Date: Mon Sep 2 04:34:47 2019
> New Revision: 370642
>
> URL: http://llvm.org/viewvc/llvm-project?rev=370642&view=rev
> Log:
> R
Author: lebedevri
Date: Mon Sep 2 05:34:21 2019
New Revision: 370650
URL: http://llvm.org/viewvc/llvm-project?rev=370650&view=rev
Log:
[unittests][AST] CommentParser: don't name variable 'DEBUG'
It's may be an already-defined macro name,
resulting in compilation errors.
Modified:
cfe/trunk/
Author: lebedevri
Date: Wed Sep 4 03:57:06 2019
New Revision: 370874
URL: http://llvm.org/viewvc/llvm-project?rev=370874&view=rev
Log:
Revert "[Clang Interpreter] Initial patch for the constexpr interpreter"
Breaks BUILD_SHARED_LIBS build, introduces cycles in library dependency
graphs. (clangIn
101 - 200 of 321 matches
Mail list logo
