[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3926319 , @arsenm wrote: > I think SROA after unroll is important. It's practically the main reason to > unroll Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1200-1201 FPM.addPass(W

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. @vitalybuka @rjmccall thank you for taking a look! Since posting this, there has been a conversation in `#llvm` with @jyknight, where it was established that the situation is even worse than i though. Essentially, there are two situations: 1. exception escape out of no

[PATCH] D137901: [Clang] `nothrow`-implying attributes should actually manifest `nothrow` attribute (PR58798)

lebedev.ri abandoned this revision. lebedev.ri added a comment. Actually, apparently those attributes really do introduce UB, so it is correct that they do not cause program termination. https://reviews.llvm.org/D137381#3927923 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3928663 , @asbirlea wrote: > IIUC compile time impact for adding another SROA (the one outside LTO) is > negligible? Yup. > Regarding the principle of adding another pass and where in the pipeline, > we're still

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 475649. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. @rjmccall thank you for taking a look! I do believe this now does the right thing. I would like to keep this patch minimal. I have not looked into `-fno-exceptions`, and i'm n

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2028 +// FIXME: what about FuncletPads? +if (llvm::BasicBlock *InvokeBB = Builder.GetInsertBlock(); +SanOpts.has(SanitizerKind::Exception

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri updated this revision to Diff 475894. lebedev.ri added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137381/new/ https://reviews.llvm.org/D137381 Files: clang/docs/ReleaseNotes.rst clang/docs/UndefinedBehavi

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = Emi

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3931860 , @spatel wrote: > LGTM based on the timing, results, and alternatives discussed Thank you for the review. > There's some testing in progress according to previous comments, so best to > wait for that to f

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri updated this revision to Diff 475925. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Herald added a subscriber: pcwang-thead. Adjust full LTO pipeline, for symmetry with non-full LTO pipeline. Looks like there is test coverage shortage. Repository: rG LLVM

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3932369 , @asbirlea wrote: > As far as performance, this looks fine. Not seeing measurable gains. Thank you for checking! Is the evaluation still ongoing, or is this the green light to go ahead? Repository: rG L

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3934445 , @asbirlea wrote: > Green light perf-wise. > I cannot comment on whether the position is "the right" one though. I'm > deferring to the other reviewers. Thank you! Repository: rG LLVM Github Monorepo

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8adfa29706e5: [Pipelines] Introduce SROA after (final, run-time) loop unrolling (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHA

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 488343. lebedev.ri marked an inline comment as done. lebedev.ri edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 Files: clang-t

[PATCH] D141561: [clang] True `noexcept` (`-fstrict-noexcept` language dialect)

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rjmccall, efriedma, jcranmer, jyknight, rsmith. lebedev.ri added a project: LLVM. Herald added subscribers: StephenFan, dschuff. Herald added a project: All. lebedev.ri requested review of this revision. Herald added subs

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. In D138958#4045567 , @efriedma wrote: > From an IR semantics standpoint, I'm not sure the `memory(none)` marking is > right if the function throws an exception. Then `memory(read)` would be wrong, either. A bit of a hot take:

[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: StephenFan, mgehre. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relev

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan, mgehre. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, co

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SIN

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longe

[PATCH] D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180)

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Mon

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: Naghasan, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer rel

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. CHANGES SINCE LAST ACTION https:/

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monore

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG L

[PATCH] D115848: tidy-llvm

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision now requires review to proceed. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review may be stuck/dead, consider abandoning if no longer relevant. Removin

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Reposit

[PATCH] D125272: [clang] Add -fcheck-new support

lebedev.ri resigned from this revision. lebedev.ri added a comment. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D78028: move shebangs from python2 to python3

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: cfe-commits, llvm-commits, Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, stephenne

[PATCH] D79636: [LangRef] Clarify the semantics of the `byval` attribute

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository:

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D105497: [clang] Serialize source locations as 64-bit in PCH.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D105495: [clang] Make negative getLocWithOffset widening-safe.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHA

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: njames93. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121629: clang: also check alloc_alignment claims in return

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: NoQ. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Gith

[PATCH] D97204: [RFC] Clang 64-bit source locations

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to c

[PATCH] D130209: [clang-tidy][NFC] Update tests to specify CheckOptions using new syntax

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D431

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. What's the status here? Should this be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added subscribers: nlopes, regehr. lebedev.ri added a comment. In D138958#4054903 , @jdoerfert wrote: > In D138958#4045567 , @efriedma > wrote: > >> From an IR semantics standpoint, I'm not sure the `m

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. @jdoerfert can you please clarify, do you believe we are fine as-is, or need to change attributes we emit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

lebedev.ri added a comment. Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is sufficient to link to `LLVMTargetParser`? Does `RISCVTargetParserTableGen` itself not link to `LLVMTargetParser`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

lebedev.ri added a comment. In D141899#4058173 , @LuoYuanke wrote: > @zixuan-wu, changing x86_amx would break our internal code. May I know the > motivation to change the type? I just want to point out that generally "causes [too much] churn downstream"

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. Docs still missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 489975. lebedev.ri added subscribers: Anastasia, arsenm. lebedev.ri added a comment. Ok, if we must not unconditionally emit the memory attributes, then let's not. Please stamp? :) @Anastasia @venvh @arsenm This breaks opencl headers in a way i do not und

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added a comment. Ok, so. I looked really hard, and essentially i'm not sure we can just change those attributes from implying `readonly`/`readnone`. Things kinda just fall apart Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.C

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGenOpenCL/fdeclare-opencl-builtins.cl:20 // Test that Attr.Const from OpenCLBuiltins.td is lowered to a readnone attribute. +// FIXME: we don't, though. // CHECK-LABEL: @t

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142033/new/ https://reviews.llvm.org/D142033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063597 , @friss wrote: > In D136651#4060071 , @lebedev.ri > wrote: > >> Docs still missing. > > Sorry @lebedev.ri I missed your earlier comment about this. What format of

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063818 , @friss wrote: > In D136651#4063632 , @lebedev.ri > wrote: > >> In D136651#4063597 , @friss wrote: >> >>> In D136651#40600

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

lebedev.ri added a comment. In D142123#4066351 , @njames93 wrote: > Given the fact its non-standard, it has caveats and peoples eagerness to > blindly enable all checks (or all checks from a module). > I feel this check would likely cause more harm than

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

lebedev.ri added a comment. In D142123#4066460 , @aaron.ballman wrote: > In D142123#4066447 , @lebedev.ri > wrote: > >> In D142123#4066351 , @njames93 >> wrote: >> >>>

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); + Builder.Cr

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping. We need to get this going, reminder, this was caught because it caused a visible miscompilation. @rjmccall are you satisfied with the way we emit srcloc info? @aaron.ballman thoughts on the docs changes? One unanswered question i have, is if we can get the excep

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. Thanks! There's also the one for MCA, but this situation basically never happens for those tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.llvm.org/D138836 _

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. In D138836#3954850 , @mtrofin wrote: > In D138836#3954782 , @lebedev.ri > wrote: > >> Thanks! >> There's also the one for MCA, but this situation basically never happens for >> those

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Anyways, assuming you tested that this works, LG. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.l

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a reviewer: efriedma. lebedev.ri added a comment. @rjmccall thank you for taking a look! In D137381#3955100 , @rjmccall wrote: > In D137381#3953178 , @lebedev.ri > wrote: > >> ping. We need to g

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); + Builder.Cre

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, erichkeane, rjmccall. lebedev.ri added a project: LLVM. Herald added subscribers: carlosgalvezp, jdoerfert. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. lebedev.ri requested

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM. I do think this is an important fix, not the least because i've also just hit that, but i do want to explicitly call out that this will cause a massive test case churn, so i do w

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri added a comment. In D139006#3960466 , @mtrofin wrote: > LGTM, but I'd wait for Johannes to review it, too (because of > e67f6477fd1ed29acbeddf8482c25d8db826912f > . I for >

[PATCH] D139017: Changed the intentional spelling errors back to the original, made more slight grammar corrections

lebedev.ri added a comment. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139017/new/ https://reviews.llvm.org/D139017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 479413. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. @erichkeane thank you for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D1

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/docs/ReleaseNotes.rst:841 operator. -- ``clang_Cursor_getNumTemplateArguments``, ``clang_Cursor_getTemplateArgumentKind``, - ``clang_Cursor_getTemplateArgumentType``, ``clang_Cursor_getTemplateArgumentValue`` and +- ``cl

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2725 NoReturn = true; -if (FD->hasAttr()) +if (FD->hasAttr() || FD->hasAttr()) AddEHEdge = false; erichkeane wrote: > lebed

[PATCH] D139197: Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. This patch should not land before that one does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/ https://reviews.llvm.org/D139197 ___ cfe-commits mailing list cfe-co

[PATCH] D139197: Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. I was commenting because we already have a similar diagnostic in clang-tidy 15: namespace { static void foo(); static void bar(){} void foo() {} static int x; } $ clang-tidy-15 -checks=\*,-llvmlibc-* /tmp/test.cpp Error while trying to load a

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. > This shouldn't be a blocker for this patch though, it's just removing > functionality that belongs in another check. As said, the check is 1 day old > so it's unlikely anyone is relying on it yet :) SGTM in general. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135658: demangle OptFunction trace names

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Old pass manager is dead. There is no point in making improvements to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. I've been thinking, and it seems to me that explicitly opting into `__attribute__((nounwind))`-provided semantics should override the `__attribute__((nothrow))`/`noexcept` semantics. So looks like i should look into exception

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a subscriber: tentzen. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitChec

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

lebedev.ri added a comment. Whoops, i did not see cfe-commits again got sidestepped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76435/new/ https://reviews.llvm.org/D76435 ___ cfe-commits mailing lis

[PATCH] D76140: [InlineFunction] update attributes during inlining

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; anna wrote: > Noticed while ad

[PATCH] D76140: [InlineFunction] update attributes during inlining

lebedev.ri added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 + if (NumInstChecked++ > MaxInstCheckedForThrow || + isGuaranteedToTransferExecutionToSuccessor(&I)) +return true; anna wrote: > lebedev.ri wrote

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

lebedev.ri added a comment. Passing-by remark: > I wrote a Clang warning [not pictured] to diagnose any use of `T(x)` which > was not equivalent to `static_cast(x)`. I'm not sure whether or not this will pass the bar for a clang diagnostic, but that does sound like a good clang-tidy readability

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

lebedev.ri added a comment. In D75591#1936116 , @jdoerfert wrote: > Did you add the warning @lebedev.ri mentioned? (@lebedev.ri I assume/hope a > warning is sufficient here?) It should be handled consistently with how other newer openmp features are ha

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. In D74918#1937237 , @zoecarver wrote: > @lebedev.ri Where should I put this? Could you maybe point me to another LLVM > target API that clang uses that I could base this off? Maybe it should go > inside the triple or just be a

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

lebedev.ri added a comment. SGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76622/new/ https://reviews.llvm.org/D76622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. Like i said in previous comments, this can be moved later, that is not a blocker. Ship it first :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

lebedev.ri added a comment. Hello. 2 points: rG512767eb3fe9c34c655a480d034147c54f1d4f85 doesn't reference this review, so it's a bit hard to find. Please try to reference it next time. Is this check really intentionally comp

[PATCH] D77219: UBSan ␇ runtime

lebedev.ri added inline comments. Comment at: compiler-rt/lib/ubsan_bel/ubsan_bel_handlers.cpp:40-42 +static std::random_device r; +static std::default_random_engine e(r()); +static std::uniform_int_distribution d(0, sizeof(quips) / sizeof(quips[0]) - 1); ---

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

lebedev.ri added a comment. In D70265#1954925 , @vingeldal wrote: > After looking more closely at the code I think the issue is within > hasLocalStorage() which is called in hasGlobalStorage(). My expectation would > be that anything inside of function s

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri accepted this revision. lebedev.ri added a comment. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

lebedev.ri added inline comments. Comment at: include/clang/Format/Format.h:2341 /// directory if ``FileName`` is empty. +/// * "file=" to explicitly specify the configuration file to use. /// So is it `:` or `=`? Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri added a comment. In D73996#1883360 , @erichkeane wrote: > 1 nit, otherwise LGTM. Thank you for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996 +def warn_alignment_not_power_of_two : Warning< +

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

lebedev.ri added a comment. This seems like the reasonable fix to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri updated this revision to Diff 245622. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73996/new/ https://reviews.llvm.org/D73996 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 245625. lebedev.ri added a comment. Rebased ontop of patch demoting call-site-based align attr checking from error into a warning, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://revie

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea5d17cc954: [Sema] Demote call-site-based 'alignment is a power of two' check for… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 245656. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

<    13   14   15   16   17   18   19   20   21   22   >