[PATCH] D120870: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks for the cleanup @khchen ! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120870/new/ https://reviews.llvm.org/D120870

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

rogfer01 added a comment. In D100821#2710998 , @HsiangKai wrote: > Rebase. Thanks, I had missed that and my comment above was wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100821/new/ https://revie

[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

rogfer01 added a comment. This is just a suggestion, feel free to ignore: a sequence of `T`s was easy to parse for the prototype but may be want to consider something like `T3v` rather than `TTTv`. I think it would simplify the `TString` tblgen class and those `std::string(N, 'T')`.

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

rogfer01 added a comment. I was under the impression we didn't want to use class-member access syntax for vector tuples (see https://github.com/riscv/rvv-intrinsic-doc/issues/17#issuecomment-628998077 ) so we don't need a record type, do we? Perhaps it is possible to model them like opaque ent

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

rogfer01 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1486 + BuiltinType::Kind K, unsigned NF) { + auto TypeIter = llvm::find_if(Types, [&K](Type *Ty) { + if (Ty->isBuiltinType()) { -

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

rogfer01 added a comment. In D99741#2690156 , @craig.topper wrote: > In D99741#2690124 , @thakis wrote: > >> One of the ten commits that landed here >> (https://github.com/llvm/llvm-project/compare/a3bfddbb6a27...

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

rogfer01 added a comment. I've left a PoC of my approach here https://reviews.llvm.org/D100529 in case we can use that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 __

[PATCH] D100821: [RISCV] Implement the vmmv.m/vmnot.m builtin.

rogfer01 added a comment. I can reproduce the crash above in my computer, so something is definitely off. Looks like we emit this case RISCV::BI__builtin_rvv_vmmv_m_b8: case RISCV::BI__builtin_rvv_vmmv_m_b4: case RISCV::BI__builtin_rvv_vmmv_m_b2:

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

rogfer01 added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:923 + + const RVVIntrinsicInfo *Intrinsic = std::find_if( + std::begin(RVVIntrinsicInfos), std::end(RVVIntrinsicInfos), Not for this patch: I think this table may be a bit large so al

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

rogfer01 added a comment. In D111617#3060377 , @HsiangKai wrote: > Although it reduces the header size, this patch will increase the binary size > of clang. Options we can consider to mitigate this: - See if we can be more economical reprenting the tab

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

rogfer01 added a comment. Looks good to me too. Thanks a lot @craig.topper ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list cfe-co

<    1   2   3