https://github.com/ro-i updated https://github.com/llvm/llvm-project/pull/146093
>From b01bdf107f80f0f023270326e4a16b1dcadd69d8 Mon Sep 17 00:00:00 2001
From: Robert Imschweiler
Date: Fri, 27 Jun 2025 10:07:01 -0500
Subject: [PATCH 1/2] [OpenMP][clang] 6.0: parsing/sema for message/severity
for
@@ -960,6 +960,8 @@ def OMP_Parallel : Directive<[Spelling<"parallel">]> {
VersionedClause,
VersionedClause,
VersionedClause,
+VersionedClause,
+VersionedClause,
ro-i wrote:
thanks, done
https://github.com/llvm/llvm-project/pull/146093
___
ro-i wrote:
Ping.
https://github.com/llvm/llvm-project/pull/146093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1214,6 +1214,12 @@ void __kmp_serialized_parallel(ident_t *loc, kmp_int32
global_tid) {
// Reset for next parallel region
this_thr->th.th_set_proc_bind = proc_bind_default;
+ // OpenMP 6.0 12.1.2 requires the num_threads 'strict' modifier to also have
+ // effect wh
ro-i wrote:
> Please split the PR into three: front end, device runtime, and libomp for
> faster and better review.
Ok, will do
https://github.com/llvm/llvm-project/pull/146346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
ro-i wrote:
Created #146403 #146404 #146405
https://github.com/llvm/llvm-project/pull/146346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/146346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1214,6 +1214,12 @@ void __kmp_serialized_parallel(ident_t *loc, kmp_int32
global_tid) {
// Reset for next parallel region
this_thr->th.th_set_proc_bind = proc_bind_default;
+ // OpenMP 6.0 12.1.2 requires the num_threads 'strict' modifier to also have
+ // effect wh
ro-i wrote:
> Unresolved Tests (1):
> lldb-api :: tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
Tests being flaky again I guess
https://github.com/llvm/llvm-project/pull/145900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/ro-i created https://github.com/llvm/llvm-project/pull/146093
Implement parsing and semantic analysis support for the message and severity
clauses that have been added to the parallel directive in OpenMP 6.0, 12.1.
>From b01bdf107f80f0f023270326e4a16b1dcadd69d8 Mon Sep 17 00:
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/145900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/145490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro-i wrote:
merged, thanls for the review!
https://github.com/llvm/llvm-project/pull/145490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/143504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro-i wrote:
Merged. Thanks for the review :)
https://github.com/llvm/llvm-project/pull/143504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i created https://github.com/llvm/llvm-project/pull/145490
Implement parsing and semantic analysis support for the optional 'strict'
modifier of the num_threads clause. This modifier has been introduced in OpenMP
6.0, section 12.1.2.
Note: this is basically 1:1 https://re
https://github.com/ro-i created https://github.com/llvm/llvm-project/pull/145900
Fix small typo.
>From 935946e76a4a6728acc486f2c419f21256a55cc1 Mon Sep 17 00:00:00 2001
From: Robert Imschweiler
Date: Thu, 26 Jun 2025 09:10:38 -0500
Subject: [PATCH] [OpenMP] Fix comma -> semicolon
Fix small typ
ro-i wrote:
As far as I can see the test failures (TypeSanitizer-x86_64) are unrelated to
this PR.
https://github.com/llvm/llvm-project/pull/143504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/ro-i auto_merge_enabled
https://github.com/llvm/llvm-project/pull/156525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro-i wrote:
@tbaederr you added some test using num_threads strict (+message/severity) for
target in
https://github.com/llvm/llvm-project/commit/83ca87715974d386e1ffee8ae8797d8f0f1db205.
Can we substitute this by something else?
https://github.com/llvm/llvm-project/pull/157893
___
ro-i wrote:
No, there will be no `message` clause in the context of the target directive
until I re-implement it. Is it important that it's a target directive?
Otherwise, I could just remove the `target` and use the host `parallel`
directive.
https://github.com/llvm/llvm-project/pull/157893
_
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/157893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -843,7 +857,8 @@ void CGOpenMPRuntimeGPU::emitTargetOutlinedFunction(
assert(!ParentName.empty() && "Invalid target region parent name!");
bool Mode = supportsSPMDExecutionMode(CGM.getContext(), D);
- if (Mode)
+ bool IsBareKernel = D.getSingleClause();
+ if (Mode ||
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/155839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1506,8 +1506,10 @@ def err_omp_unexpected_directive : Error<
"unexpected OpenMP directive %select{|'#pragma omp %1'}0">;
def err_omp_expected_punc : Error<
"expected ',' or ')' in '%0' %select{clause|directive}1">;
-def warn_clause_expected_string : Warning<
+def warn_c
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/146405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i closed https://github.com/llvm/llvm-project/pull/155809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ro-i edited https://github.com/llvm/llvm-project/pull/146405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro-i wrote:
(rebased on main after https://github.com/llvm/llvm-project/pull/146404 has
been merged)
https://github.com/llvm/llvm-project/pull/146405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/ro-i auto_merge_enabled
https://github.com/llvm/llvm-project/pull/146405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -843,7 +857,8 @@ void CGOpenMPRuntimeGPU::emitTargetOutlinedFunction(
assert(!ParentName.empty() && "Invalid target region parent name!");
bool Mode = supportsSPMDExecutionMode(CGM.getContext(), D);
- if (Mode)
+ bool IsBareKernel = D.getSingleClause();
+ if (Mode ||
ro-i wrote:
That's a good point. I think the argument for the error was that it makes it
clearer that this unsupported. A warning might be easy to overlook for larger
builds, which might then lead the user believe that everything went as they
expected.
https://github.com/llvm/llvm-project/pul
ro-i wrote:
(`Transforms/LoopVectorize/AArch64/epilogue-vectorization-fix-scalar-resume-values.ll`
is currently broken, unrelated to this PR)
https://github.com/llvm/llvm-project/pull/160659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/ro-i auto_merge_enabled
https://github.com/llvm/llvm-project/pull/157893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
34 matches
Mail list logo