[PATCH] D101387: remove single quotes around sugguestion diagnostic

rtrieu added a comment. In D101387#2720500 , @MaskRay wrote: > @rtrieu Do we have a way appending arbitrary messages to a diagnostic > template? Not an arbitrary number. The diagnostic format string is indexed, so it diagnostic string needs to know ah

[PATCH] D117376: Remove reference type when checking const structs

rtrieu created this revision. rtrieu added reviewers: rsmith, cfe-commits. rtrieu requested review of this revision. Herald added a project: clang. ConstStructBuilder::Finalize in CGExprConstant.ccp assumes that the passed in QualType is a RecordType. In some instances, the type is a reference t

[PATCH] D108794: Fully qualify template template parameters when printing

rtrieu added a comment. It looks like a strict improvement on printing and most callers using the default args won't need to be updated. There's one more function call that should be updated: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298 Fixing that an

[PATCH] D108794: Fully qualify template template parameters when printing

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. In D108794#2978134 , @dblaikie wrote: > Ping > > In D108794#2976063 , @rtrieu wrote: > >> It looks like a str

<    1   2   3   4   5