Author: rtrieu
Date: Tue May 16 21:29:02 2017
New Revision: 303231
URL: http://llvm.org/viewvc/llvm-project?rev=303231&view=rev
Log:
[ODRHash] Support more types in the ODR checker.
Added support for TagType, TypeWithKeyword, and all children types.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Tue May 16 22:23:35 2017
New Revision: 303233
URL: http://llvm.org/viewvc/llvm-project?rev=303233&view=rev
Log:
[ODRHash] Support NestedNameSpecifier
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/lib/Serialization/ASTReader.cpp
cfe/trunk/test/Modules/odr_hash.
Author: rtrieu
Date: Fri May 19 15:05:16 2017
New Revision: 303450
URL: http://llvm.org/viewvc/llvm-project?rev=303450&view=rev
Log:
[ODRHash] Support TemplateName and TemplateArgument
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST
Author: rtrieu
Date: Fri May 19 17:35:41 2017
New Revision: 303459
URL: http://llvm.org/viewvc/llvm-project?rev=303459&view=rev
Log:
[ODRHash] Revert r303450 to fix buildbot
r303450
[ODRHash] Support TemplateName and TemplateArgument
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/tes
rtrieu updated this revision to Diff 75970.
rtrieu marked 2 inline comments as done.
https://reviews.llvm.org/D21675
Files:
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/Stmt.h
include/clang/AST/TemplateBase.h
include/clang/AST/Type.h
include/clang/Basic/D
rtrieu added a comment.
In https://reviews.llvm.org/D21675#560297, @rsmith wrote:
> There are a bunch of cases here that do this:
>
> if (auto t = getThing())
> ID.addThing(t);
> if (auto t = getOtherThing())
> ID.addThing(t);
>
>
> That will result in hash collisions between objects
Author: rtrieu
Date: Thu Oct 27 19:15:24 2016
New Revision: 285370
URL: http://llvm.org/viewvc/llvm-project?rev=285370&view=rev
Log:
Fix a crash on invalid code.
The diagnostic was attempting to access the QualType of a TypeDecl by calling
TypeDecl::getTypeForDecl. However, the Type pointer stor
Author: rtrieu
Date: Fri Nov 11 14:51:04 2016
New Revision: 286630
URL: http://llvm.org/viewvc/llvm-project?rev=286630&view=rev
Log:
When a DecompositionDecl is marked invalid, also set the child BindingDecl's to
invalid.
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
cfe/trunk/test/SemaCXX/cxx
I didn't see anything when making this patch, but I will go take a closer
look now.
On Fri, Nov 11, 2016 at 1:19 PM, Richard Smith
wrote:
> Thanks. We have some code in SemaDecl(CXX?) that was trying to do the same
> thing; can it be removed now?
>
> On 11 Nov 2016 1:00 pm, &
Author: rtrieu
Date: Fri Nov 11 15:50:39 2016
New Revision: 286641
URL: http://llvm.org/viewvc/llvm-project?rev=286641&view=rev
Log:
Remove double setting of invalid flag.
In r286630, Decl::setInvalidDecl will automatically set the invalid flag for
BindingDecl for children in invalid Decompositio
That's the only one I found. Fixed in r286641.
On Fri, Nov 11, 2016 at 1:46 PM, Richard Smith
wrote:
> Sema::FinalizeDeclaration contains the code I was thinking about.
>
>
> On Fri, Nov 11, 2016 at 1:33 PM, Richard Trieu wrote:
>
>> I didn't see anything when m
rtrieu added a comment.
Why are you leaking the raw encoding of locations from the SourceManager? This
is an internal implementation detail and should not be relied on externally.
SourceLocation is the typical way to use locations.
http://reviews.llvm.org/D12379
__
rtrieu added a comment.
In http://reviews.llvm.org/D12379#245850, @zhengkai wrote:
> In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
>
> > Why are you leaking the raw encoding of locations from the SourceManager?
> > This is an internal implementation detail and should not be relied on
rtrieu added a comment.
In http://reviews.llvm.org/D12379#245868, @zhengkai wrote:
> In http://reviews.llvm.org/D12379#245861, @rtrieu wrote:
>
> > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote:
> >
> > > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
> > >
> > > > Why are y
rtrieu added inline comments.
Comment at: include/clang/Basic/SourceManager.h:333
@@ -332,2 +332,3 @@
+
bool isMacroBodyExpansion() const {
Remove unrelated whitespace change.
Comment at: include/clang/Basic/SourceManager.h:1155-1164
@@ -1
Author: rtrieu
Date: Fri Sep 18 18:18:39 2015
New Revision: 248064
URL: http://llvm.org/viewvc/llvm-project?rev=248064&view=rev
Log:
Split off the binary literal warning into a subgroup of C++14 warnings
Binary literals predate C++14, but they are listed as a C++14 extension since
this was the fi
rtrieu added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1008
@@ -1008,1 +1007,3 @@
+bool SourceManager::isMacroArgExpansion(SourceLocation Loc,
+ SourceLocation *NewLoc) const {
if (!Loc.isMacroID()) return false;
rtrieu added inline comments.
Comment at: lib/Frontend/DiagnosticRenderer.cpp:455
@@ -419,1 +454,3 @@
+static bool checkLocForMacroArgExpansion(SourceLocation Loc,
+ const SourceManager &SM,
rtrieu wrote:
> zhengkai wrote:
rtrieu added inline comments.
Comment at: lib/Frontend/DiagnosticRenderer.cpp:442
@@ -419,1 +441,3 @@
+static bool checkLocForMacroArgExpansion(SourceLocation Loc,
+ const SourceManager &SM,
zhengkai wrote:
> I have stated
Author: rtrieu
Date: Wed Sep 23 20:21:01 2015
New Revision: 248454
URL: http://llvm.org/viewvc/llvm-project?rev=248454&view=rev
Log:
Improve the printing of ranges when macros are involved.
Trace the ranges through the macro backtrace better. This allows better
range highlighting through all lev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248454: Improve the printing of ranges when macros are
involved. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D12379?vs=35575&id=35580#toc
Repository:
rL LLVM
http://review
rtrieu accepted this revision.
rtrieu added a comment.
Fix the comments, then it should be ready to commit.
Comment at: lib/Analysis/CFG.cpp:49
@@ +48,3 @@
+tryNormalizeBinaryOperator(const BinaryOperator *B) {
+ auto TryTransformToIntOrEnumConstant = [](const Expr *E) -> const
rtrieu added a comment.
Next time, add
> Differential Revision:
to your commit and Phabricator will close the diff automatically.
http://llvm.org/docs/Phabricator.html
Comment at: lib/Analysis/CFG.cpp:99-104
@@ +98,8 @@
+ // Currently we're only given EnumConstantDecls or
the other? If not, I'll go ahead
> and take them out.
>
> George
>
> On Thu, Oct 1, 2015 at 12:03 PM, Aaron Ballman
> wrote:
>
>> On Thu, Oct 1, 2015 at 3:01 PM, Richard Trieu wrote:
>> > rtrieu added a comment.
>> >
>> > Next ti
rtrieu added a comment.
> There are still a lot of other cases in which my method still works as the
> old version did.
> And I think there are several bugs in the existing functions like
> "emitDiagnostic" and "mapDiagnosticRanges".
> This is issued as a bug, the link is
> https://llvm.or
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
This is a first step towards making macro diagnostics better.
http://reviews.llvm.org/D11778
___
cfe-commits mailing list
cfe-commits@lists.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244788: Stop printing macro backtraces that don't help
diagnostics. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D11778?vs=31425&id=31965#toc
Repository:
rL LLVM
http://rev
Author: rtrieu
Date: Wed Aug 12 13:24:59 2015
New Revision: 244788
URL: http://llvm.org/viewvc/llvm-project?rev=244788&view=rev
Log:
Stop printing macro backtraces that don't help diagnostics.
When displaying the macro backtrace, ignore some of the backtraces that do not
provide extra information
Author: rtrieu
Date: Mon Aug 17 17:18:30 2015
New Revision: 245250
URL: http://llvm.org/viewvc/llvm-project?rev=245250&view=rev
Log:
Make a test less brittle.
Capture line numbers in a variable for FileCheck instead of hardcoding them.
Modified:
cfe/trunk/test/SemaCXX/warn-logical-not-compar
Author: rtrieu
Date: Wed Aug 19 16:33:54 2015
New Revision: 245507
URL: http://llvm.org/viewvc/llvm-project?rev=245507&view=rev
Log:
Fix -Wlogical-not-parentheses to work better with C code.
Remove the assumption of a Boolean type by checking if an expression is known
to have a boolean value. Di
Author: rtrieu
Date: Thu Aug 20 22:43:09 2015
New Revision: 245666
URL: http://llvm.org/viewvc/llvm-project?rev=245666&view=rev
Log:
Fix a few things with -Winfinite-recursion. NFC
Now that -Winfinite-recursion no longer uses recursive calls to before path
analysis, several bits of the code can
Author: rtrieu
Date: Thu Aug 27 18:38:45 2015
New Revision: 246237
URL: http://llvm.org/viewvc/llvm-project?rev=246237&view=rev
Log:
Fix macro backtrace printing.
Sometimes, a macro that expands to another macro name will not be printed in
the macro backtrace. This patch finds the missed macro e
Author: rtrieu
Date: Thu Aug 4 21:39:30 2016
New Revision: 277796
URL: http://llvm.org/viewvc/llvm-project?rev=277796&view=rev
Log:
Allow -1 to assign max value to unsigned bitfields.
Silence the -Wbitfield-constant-conversion warning for when -1 or other
negative values are assigned to unsigned
Author: rtrieu
Date: Thu Aug 4 22:16:36 2016
New Revision: 277797
URL: http://llvm.org/viewvc/llvm-project?rev=277797&view=rev
Log:
Fix crash in template type diffing.
When the type being diffed is a type alias, and the orginal type is not a
templated type, then there will be no unsugared Templa
Author: rtrieu
Date: Fri Aug 5 16:02:34 2016
New Revision: 277866
URL: http://llvm.org/viewvc/llvm-project?rev=277866&view=rev
Log:
Fix false positive in -Wunsequenced and templates.
For builtin logical operators, there is a well-defined ordering of argument
evaluation. For overloaded operator
Author: rtrieu
Date: Fri Aug 5 18:24:47 2016
New Revision: 277889
URL: http://llvm.org/viewvc/llvm-project?rev=277889&view=rev
Log:
Fix two false positives in -Wreturn-stack-address
If the return type is a pointer and the function returns the reference to a
pointer, don't warn since only the val
Hans, Richard,
These are some last minute diagnostic improvements for 3.9.
http://llvm.org/viewvc/llvm-project?rev=277796&view=rev
r277796
Don't warn when negative values, like -1, are used to initialize unsigned
bit fields.
http://llvm.org/viewvc/llvm-project?rev=277797&view=rev
r277797
Fix cra
Author: rtrieu
Date: Fri Aug 5 20:44:06 2016
New Revision: 277900
URL: http://llvm.org/viewvc/llvm-project?rev=277900&view=rev
Log:
Fix typos from r277797 and unused variable from r277889.
Modified:
cfe/trunk/lib/AST/ASTDiagnostic.cpp
cfe/trunk/test/SemaCXX/return-stack-addr-2.cpp
Modif
t that one. The others fix warning false
>> positives (which are not regressions) and look fairly safe.
>>
>
> Correction: looks like the final one is in fact a fix for a diagnostic
> regression.
>
>
>> On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote:
>>
_cast from uint8_t to char is annoying). Maybe this shouldn't
> fire for char arrays?
>
> On Fri, Jan 29, 2016 at 6:51 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Fri Jan 29 17:51:16 2016
>> New Revision:
Author: rtrieu
Date: Mon Feb 1 18:36:59 2016
New Revision: 259445
URL: http://llvm.org/viewvc/llvm-project?rev=259445&view=rev
Log:
Template Type Diffing change
When all the arguments of a template are elided, print "A<...>" instead of
"A<[2 * ...]>". Also remove comment fragment that means not
On Mon, Feb 1, 2016 at 2:10 PM, Richard Smith wrote:
> On Thu, Jan 14, 2016 at 2:57 PM, Richard Trieu via cfe-commits
> wrote:
> > Author: rtrieu
> > Date: Thu Jan 14 16:56:39 2016
> > New Revision: 257831
> >
> > URL: http://llvm.org/viewvc/llvm
rtrieu added a comment.
Oops, forget to hit send on my last comment.
My concern is something like:
printf(condition ? "first message: %d" : "second message: %d", 5, 10);
There's nothing in the code implying that either message is the one that should
be using two arguments, so which one will
rtrieu added a comment.
In http://reviews.llvm.org/D15636#343856, @AndyG wrote:
> In your case, the first string would be highlighted only. Yes, I see what
> you mean. Is it possible to have multiple ranges for the diagnostic? By
> which I mean, to produce the following:
>
> test.cpp:x:y:
Author: rtrieu
Date: Fri Feb 5 17:02:38 2016
New Revision: 259947
URL: http://llvm.org/viewvc/llvm-project?rev=259947&view=rev
Log:
Exempt char array initializers from -Wconstant-converion.
Sometimes, char arrays are used as bit storage, with no difference made between
signed and unsigned char.
r259947 will stop this warning on char arrays.
On Mon, Feb 1, 2016 at 1:40 PM, Richard Trieu wrote:
> C++11 narrowing only happens during certain conversions while this warning
> checks all conversions.
>
> We might be able to avoid char array initialization, but it would be a
>
So, this week got consumed by -Wconstant-conversion. We'll see how next
week goes.
On Fri, Jan 29, 2016 at 7:16 PM, Richard Trieu wrote:
> rtrieu added a comment.
>
> Not sure what happened. Will check it out on Monday.
>
>
> http:/
Author: rtrieu
Date: Fri Feb 12 18:58:53 2016
New Revision: 260776
URL: http://llvm.org/viewvc/llvm-project?rev=260776&view=rev
Log:
Make -Wnull-conversion more useful.
When a null constant is used in a macro, walk through the macro stack to
determine where the null constant is written and where
Author: rtrieu
Date: Thu Feb 18 16:34:54 2016
New Revision: 261271
URL: http://llvm.org/viewvc/llvm-project?rev=261271&view=rev
Log:
Remove use of builtin comma operator.
Cleanup for upcoming Clang warning -Wcomma. No functionality change intended.
Modified:
cfe/trunk/lib/Analysis/FormatStr
Author: rtrieu
Date: Thu Feb 18 17:58:40 2016
New Revision: 261278
URL: http://llvm.org/viewvc/llvm-project?rev=261278&view=rev
Log:
Add -Wcomma warning to Clang.
-Wcomma will detect and warn on most uses of the builtin comma operator. It
currently whitelists the first and third statements of th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261278: Add -Wcomma warning to Clang. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D3976?vs=21170&id=48419#toc
Repository:
rL LLVM
http://reviews.llvm.org/D3976
Files:
cf
Author: rtrieu
Date: Thu Feb 18 18:15:50 2016
New Revision: 261285
URL: http://llvm.org/viewvc/llvm-project?rev=261285&view=rev
Log:
Fix my typo from r261278
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
rtrieu added a comment.
In http://reviews.llvm.org/D15636#352532, @AndyG wrote:
> Richard, are you happy with this latest version? Can I proceed to commit it?
>
> Thanks.
No, this is not ready yet. This code is old and needs a bit of clean up, and
because your patch touches it, you will be o
rtrieu added a comment.
A few more comments.
In http://reviews.llvm.org/D15636#358588, @AndyG wrote:
> Patch additionally re-based off r261522.
It's usually a bad idea to rebase in the middle of a string of patches.
Phabricator isn't aware of revisions, so while a base to latest patch will s
rtrieu added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1729
@@ +1728,3 @@
+/// defined in the current TU.
+static void diagnoseCallingConvCast(Sema &Self, const ExprResult &SrcExpr,
+QualType DstType, SourceRange OpRange) {
rtrieu added a comment.
While this change does add the intended error messages, it won't produce a
correct a typo-corrected AST. For instance:
void run(int sss) {
sss = ? : ;
}
Will produce an empty function body:
`-FunctionDecl 0x7082ef0 line:1:6 run 'void (int)'
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
The other issues brought up in this review can go in follow up patches.
http://reviews.llvm.org/D15636
___
cfe-commits mailing list
cfe-comm
rtrieu added a comment.
This seems rather strange. Usually, a OpaqueValueExpr will hold an expression
that is held elsewhere in the AST. However, in this case, it appears that all
the references to --i are all behind OpaqueValueExpr's, so they aren't
processed.
`-CStyleCastExpr 0x5675d30
rtrieu added inline comments.
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
-if (Same) {
+if (Same && FromTD) {
OS << "template " << FromTD->getNameAsString();
dblaikie wrote:
> Should this be a condition, or just an assertion?
rtrieu added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9629
@@ -9628,3 +9628,3 @@
// Track if the current expression is the result of a derefence, and if the
// next checked expression is the result of a derefence.
bool IsDereference = false;
Add
rtrieu added inline comments.
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
-if (Same) {
+if (Same && FromTD) {
OS << "template " << FromTD->getNameAsString();
apelete wrote:
> rtrieu wrote:
> > dblaikie wrote:
> > > Should this
Author: rtrieu
Date: Wed Mar 30 17:23:00 2016
New Revision: 264940
URL: http://llvm.org/viewvc/llvm-project?rev=264940&view=rev
Log:
Fix Clang crash with template type diffing.
Fixes https://llvm.org/bugs/show_bug.cgi?id=27129 which is crash involving type
aliases and template type diffing. Temp
Author: rtrieu
Date: Wed Mar 30 23:18:07 2016
New Revision: 264991
URL: http://llvm.org/viewvc/llvm-project?rev=264991&view=rev
Log:
Fix -Wdynamic-class-memaccess to skip invalid classes.
This warning sometimes will infinitely recurse on CXXRecordDecl's from
ill-formed recursive classes that have
Author: rtrieu
Date: Tue Apr 5 16:13:54 2016
New Revision: 265467
URL: http://llvm.org/viewvc/llvm-project?rev=265467&view=rev
Log:
Fix a crash on invalid with template handling
This is a fix for https://llvm.org/bugs/show_bug.cgi?id=25561 which was a
crash on invalid. Change the handling of in
Author: rtrieu
Date: Mon Apr 11 15:37:04 2016
New Revision: 265991
URL: http://llvm.org/viewvc/llvm-project?rev=265991&view=rev
Log:
Adjust tests to have consistent integer sizes.
Add a triple to the run lines so that integers will the same sizes across runs.
Also add a compile time check to ensu
Author: rtrieu
Date: Thu Apr 21 16:04:55 2016
New Revision: 267054
URL: http://llvm.org/viewvc/llvm-project?rev=267054&view=rev
Log:
Split interesting warnings off from -Wfloat-conversion
Restructure the implict floating point to integer conversions so that
interesting sub-groups are under differ
rtrieu added a subscriber: rtrieu.
rtrieu added a comment.
Have you looked at http://reviews.llvm.org/D6561 which was a previous attempt
at this warning?
http://reviews.llvm.org/D19312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
on-zero should all be done without equality comparisons."). So
> making this a warning for floats but not for others seems weird to me.
>
> Nico
>
>
> On Thu, Apr 21, 2016 at 5:04 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Aut
On Fri, Apr 22, 2016 at 10:50 AM, David Blaikie wrote:
>
>
> On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Thu Apr 21 16:04:55 2016
>> New Revision: 267054
>>
&g
Author: rtrieu
Date: Fri Apr 22 17:14:32 2016
New Revision: 267234
URL: http://llvm.org/viewvc/llvm-project?rev=267234&view=rev
Log:
Revert the bool portion of r267054
Remove the floating point to bool conversion warnings. Some of these
conversions will be caught by -Wliteral-conversion and -Wfl
Author: rtrieu
Date: Thu Jun 9 17:03:04 2016
New Revision: 272318
URL: http://llvm.org/viewvc/llvm-project?rev=272318&view=rev
Log:
Fix a crash in the AST dumper.
Boxed expressions in a template context may have a null method decl. If so,
don't try to access the selector.
Modified:
cfe/tru
Author: rtrieu
Date: Thu Jun 9 17:39:20 2016
New Revision: 272325
URL: http://llvm.org/viewvc/llvm-project?rev=272325&view=rev
Log:
Redirect unused output in test to /dev/null
Discard unused output so when the test fails, it only prints information that
is helpful about the failure. No function
Author: rtrieu
Date: Thu Jun 9 23:52:09 2016
New Revision: 272368
URL: http://llvm.org/viewvc/llvm-project?rev=272368&view=rev
Log:
Check for null pointers before calling the Stmt Profiler
Some calls from OMPClauseProfiler were calling the Stmt Profiler with null
pointers, but the profiler can o
rtrieu created this revision.
rtrieu added a subscriber: cfe-commits.
Early prototype of an improved ODR checker for Clang and modules. The current
ODR checking of classes is limited to a small number of attributes such as
number of methods and base classes. This still allows a number of ODR
Author: rtrieu
Date: Fri Mar 4 22:04:57 2016
New Revision: 262765
URL: http://llvm.org/viewvc/llvm-project?rev=262765&view=rev
Log:
Add null check to diagnostic path for lambda captures.
Previously, the failed capture of a variable in nested lambdas may crash when
the lambda pointer is null. On
Author: rtrieu
Date: Wed Mar 9 22:04:12 2016
New Revision: 263091
URL: http://llvm.org/viewvc/llvm-project?rev=263091&view=rev
Log:
Disable failing test and fix RUN line.
See https://llvm.org/bugs/show_bug.cgi?id=26894 for details. This change
fixes the incorrect flags to Clang and the piping i
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
The most complex things these warnings use is an AST visitor, so the compile
time impact should be minimal.
http://reviews.llvm.org/D15928
___
Author: rtrieu
Date: Wed Jan 6 15:11:18 2016
New Revision: 256976
URL: http://llvm.org/viewvc/llvm-project?rev=256976&view=rev
Log:
Improve conditional checking during template instantiation.
When the condition in an if statement, while statement, or for loop is created
during template instantia
Author: rtrieu
Date: Fri Jan 8 17:35:06 2016
New Revision: 257231
URL: http://llvm.org/viewvc/llvm-project?rev=257231&view=rev
Log:
Exclude function calls for functions which have return type nullptr_t from
-Wnull-conversion warning.
These functions are basically equivalent to other pointer retu
Author: rtrieu
Date: Fri Jan 8 19:10:17 2016
New Revision: 257240
URL: http://llvm.org/viewvc/llvm-project?rev=257240&view=rev
Log:
Only take NULL macros instead of all macros into account for -Wnull-conversion.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/trunk/test/SemaCXX/convers
Author: rtrieu
Date: Thu Jan 14 16:56:39 2016
New Revision: 257831
URL: http://llvm.org/viewvc/llvm-project?rev=257831&view=rev
Log:
Refactor template type diffing
1) Instead of using pairs of From/To* fields, combine fields into a struct
TemplateArgInfo and have two in each DiffNode.
2) Use defa
Author: rtrieu
Date: Thu Jan 14 17:30:12 2016
New Revision: 257838
URL: http://llvm.org/viewvc/llvm-project?rev=257838&view=rev
Log:
Change the TSTiterator in Template Type Diffing.
Modify the TSTiterator to have two internal iterators, which will walk
the provided sugared type and the desugared
Author: rtrieu
Date: Thu Jan 14 19:08:56 2016
New Revision: 257853
URL: http://llvm.org/viewvc/llvm-project?rev=257853&view=rev
Log:
Make template type diffing use the new desguared iterator.
If available, use the canonical template argument to fill in information for
template type diffing instea
Author: rtrieu
Date: Thu Jan 14 20:55:17 2016
New Revision: 257861
URL: http://llvm.org/viewvc/llvm-project?rev=257861&view=rev
Log:
Save the integer type for integral template arguments.
Save the integer type when diffing integers in template type diffing. When
integers are different sizes, pri
Author: rtrieu
Date: Thu Jan 14 23:01:53 2016
New Revision: 257869
URL: http://llvm.org/viewvc/llvm-project?rev=257869&view=rev
Log:
Add new diff modes to template type diffing.
Remove an old assertion that does not hold. It is possible for a template
argument to be a declaration in one instanti
Author: rtrieu
Date: Thu Jan 14 23:48:38 2016
New Revision: 257870
URL: http://llvm.org/viewvc/llvm-project?rev=257870&view=rev
Log:
Fixing more issues with template type diffing
1) Print qualifiers for templates with zero arguments
2) Add a few more tests for the template type diffing refactorin
rtrieu added a comment.
I've fixed this issue as part of the template type diffing refactoring.
r257870 was the last of the refactoring, and includes your test case in it.
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lis
rtrieu added a comment.
Hi Andy,
Could you give some motivation for this patch? From your example:
printf(minimal ? "%i\n" : "%i: %s\n", code, msg);
I would expect the first format string to produce a warning that msg is not
used.
http://reviews.llvm.org/D15636
Author: rtrieu
Date: Mon Jan 25 20:51:55 2016
New Revision: 258778
URL: http://llvm.org/viewvc/llvm-project?rev=258778&view=rev
Log:
Fix -Wnull-conversion for long macros.
Move the function to get a macro name from DiagnosticRenderer.cpp to Lexer.cpp
so that other files can use it. Lexer now has
rtrieu added a comment.
It looks like you are limiting to one diagnostic per printf, no matter the
number of format strings. How is the case when multiple format strings would
trigger the warning?
http://reviews.llvm.org/D15636
___
cfe-commits ma
Author: rtrieu
Date: Fri Jan 29 17:51:16 2016
New Revision: 259271
URL: http://llvm.org/viewvc/llvm-project?rev=259271&view=rev
Log:
Improve -Wconstant-conversion
Switch the evaluation from isIntegerConstantExpr to EvaluateAsInt.
EvaluateAsInt will evaluate more types of expressions than
isIntege
rtrieu added a comment.
Not sure what happened. Will check it out on Monday.
http://reviews.llvm.org/D3976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rtrieu created this revision.
rtrieu added a subscriber: cfe-commits.
Track whether the initialization came from a GNU statement expression. If it
does, prevent the -Wpessiming-move warning from being emitted since the
suggested fix can cause a compile error.
Fix for https://llvm.org/bugs/show
rtrieu added a comment.
So there's three or four semi-related failures around this part template
diffing. I'm investigating the best way to handle these bugs.
http://reviews.llvm.org/D15384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Author: rtrieu
Date: Wed Dec 16 22:46:48 2015
New Revision: 255875
URL: http://llvm.org/viewvc/llvm-project?rev=255875&view=rev
Log:
Add QualType case to operator< for DynTypedNode.
This allows sorting DynTypedNode's which are QualType's since QualType does
not have memoization.
Modified:
cf
Author: rtrieu
Date: Thu Dec 17 15:56:22 2015
New Revision: 255929
URL: http://llvm.org/viewvc/llvm-project?rev=255929&view=rev
Log:
Fix r255875, use '<' instead of '==' for 'operator<'
Aaron Ballman pointed out a typo from the copy and paste in r255875. This will
preserve the strict weak orderi
On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman
wrote:
> On Wed, Dec 16, 2015 at 11:46 PM, Richard Trieu via cfe-commits
> wrote:
> > Author: rtrieu
> > Date: Wed Dec 16 22:46:48 2015
> > New Revision: 255875
> >
> > URL: http://llvm.org/viewvc/llvm-project?
Author: rtrieu
Date: Thu Dec 17 17:20:57 2015
New Revision: 255937
URL: http://llvm.org/viewvc/llvm-project?rev=255937&view=rev
Log:
Add a test for r255875 & r255929, comparisons on DynTypeNode wrapped QualType.
Modified:
cfe/trunk/unittests/AST/ASTTypeTraitsTest.cpp
Modified: cfe/trunk/unit
37 has a small test case which demonstrates where the assert used to
happen.
On Thu, Dec 17, 2015 at 2:05 PM, Aaron Ballman
wrote:
> On Thu, Dec 17, 2015 at 5:02 PM, Richard Trieu wrote:
> > On Thu, Dec 17, 2015 at 5:47 AM, Aaron Ballman
> > wrote:
> >>
> >>
Author: Richard Trieu
Date: 2024-12-01T19:21:42-08:00
New Revision: c4a1e0efe6b0767dfb5861a7e8814d7db0c0de8a
URL:
https://github.com/llvm/llvm-project/commit/c4a1e0efe6b0767dfb5861a7e8814d7db0c0de8a
DIFF:
https://github.com/llvm/llvm-project/commit/c4a1e0efe6b0767dfb5861a7e8814d7db0c0de8a.diff
201 - 300 of 404 matches
Mail list logo
