Author: rtrieu
Date: Fri Jul 6 17:17:25 2018
New Revision: 336475
URL: http://llvm.org/viewvc/llvm-project?rev=336475&view=rev
Log:
Check returned type is valid before using it.
Add a .isNull() check to returned QualType. Fixes PR38077
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Author: rtrieu
Date: Mon Jul 9 15:09:33 2018
New Revision: 336610
URL: http://llvm.org/viewvc/llvm-project?rev=336610&view=rev
Log:
Rename function calls missed in r336605
NextIsLatest -> isFirst
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
Author: rtrieu
Date: Mon Jul 9 18:40:50 2018
New Revision: 336632
URL: http://llvm.org/viewvc/llvm-project?rev=336632&view=rev
Log:
[ODRHash] Merge the two function hashes into one.
Functions that are a sub-Decl of a record were hashed differently than other
functions. This change keeps the Add
Author: rtrieu
Date: Fri Oct 18 17:57:23 2019
New Revision: 375318
URL: http://llvm.org/viewvc/llvm-project?rev=375318&view=rev
Log:
New tautological warning for bitwise-or with non-zero constant always true.
Taking a value and the bitwise-or it with a non-zero constant will always
result in a no
Author: rtrieu
Date: Fri Oct 18 18:47:49 2019
New Revision: 375326
URL: http://llvm.org/viewvc/llvm-project?rev=375326&view=rev
Log:
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Extend -Wparentheses to cover mixing bitwise-and and bitwise-or with the
conditional o
Author: rtrieu
Date: Tue Sep 27 17:28:59 2016
New Revision: 282547
URL: http://llvm.org/viewvc/llvm-project?rev=282547&view=rev
Log:
Fix defaulted member functions for templated classes.
In some cases, non-special member functions were being marked as being defaulted
in templated classes. This c
Author: rtrieu
Date: Tue Sep 27 18:44:07 2016
New Revision: 282555
URL: http://llvm.org/viewvc/llvm-project?rev=282555&view=rev
Log:
Revert r282547 and add test to show correct behavior.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
cfe/trunk/test/SemaCXX/cxx0x-defaulted-functions.cpp
Mod
B
> };
>
> On Tue, Sep 27, 2016 at 3:28 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Tue Sep 27 17:28:59 2016
>> New Revision: 282547
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=282547&
Currently, this warning is on by default. As you said, the results you
found look intentional in many cases, so there is a high false positive
rate. For on by default warnings, we expect a high true positive rate and
intend for users to not disable the warning. From my analysis on a
separate cod
Author: rtrieu
Date: Fri Sep 30 19:15:24 2016
New Revision: 282989
URL: http://llvm.org/viewvc/llvm-project?rev=282989&view=rev
Log:
Fix crash when emitting error.
With templated classes, is possible to not be able to determine is a member
function is a special member function before the class is
On Sat, Oct 1, 2016 at 9:34 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Sep 30, 2016 at 03:41:53PM -0700, Richard Trieu via cfe-commits
> wrote:
> > Currently, this warning is on by default. As you said, the results you
> > found
gt; Mobile: +46 (0)709 12 42 62
> E-mail: daniel.marjam...@evidente.se
>
> www.evidente.se
>
>
> Från: Richard Trieu [rtr...@google.com]
> Skickat: den 1 oktober 2016 00:41
> Till: reviews+d24861+public+1ab
rtrieu updated this revision to Diff 73388.
rtrieu added a comment.
Add a more detailed error message to let users know where the two records
differ. This replaces the generic error which only stated that two definitions
are different without any details.
https://reviews.llvm.org/D21675
File
rtrieu marked 2 inline comments as done.
rtrieu added inline comments.
> dblaikie wrote in DeclBase.cpp:1810-1812
> Inconsistent {} on single line block (in VisitEnumConstantDecl above {} are
> not used on a single line block) - usually drop the {} on single line blocks.
>
> (several other inst
M, Vassil Vassilev
wrote:
> Hi Richard,
>
> Is there a way to get an ODRHashing which is stable across translation
> units? I'd like to use the TemplateArgument ODRHash to lookup template
> specializations and deserialize them only if they are required.
>
> Many thanks!
&g
Author: rtrieu
Date: Fri Dec 8 17:29:40 2017
New Revision: 320230
URL: http://llvm.org/viewvc/llvm-project?rev=320230&view=rev
Log:
[ODRHash] Support ODR violation detection in functions.
Extend the hashing to functions, which allows detection of function definition
mismatches across modules.
M
Author: rtrieu
Date: Fri Dec 8 19:02:21 2017
New Revision: 320239
URL: http://llvm.org/viewvc/llvm-project?rev=320239&view=rev
Log:
Revert r320230 to fix buildbots.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/include/clang/Basic/Diagno
Author: rtrieu
Date: Fri Aug 4 17:54:19 2017
New Revision: 310158
URL: http://llvm.org/viewvc/llvm-project?rev=310158&view=rev
Log:
[ODRHash] Treat some non-templated classes as templated.
When using nested classes, if the inner class is not templated, but the outer
class is templated, the inner
Author: rtrieu
Date: Tue Aug 8 19:03:59 2017
New Revision: 310435
URL: http://llvm.org/viewvc/llvm-project?rev=310435&view=rev
Log:
Allow operator delete to be an invalid Decl.
Do not discard invalid Decl when searching for the operator delete function.
The lookup for this function always expect
Author: rtrieu
Date: Tue Aug 22 19:43:59 2017
New Revision: 311519
URL: http://llvm.org/viewvc/llvm-project?rev=311519&view=rev
Log:
[ODRHash] Diagnose differing template parameters.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
Thanks for the simplified test case. I've pushed it at 02e73d4
On Mon, Aug 16, 2021 at 10:31 PM David Blaikie wrote:
> Perhaps the test case could be stripped down a bit?
>
> template
> class Array {};
>
> template
> class S {};
>
> template
> Array Make();
>
> void Call() {
> Array> v = Mak
Author: rtrieu
Date: Fri Mar 23 17:52:44 2018
New Revision: 328404
URL: http://llvm.org/viewvc/llvm-project?rev=328404&view=rev
Log:
[ODRHash] Support pointer and reference types.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST/ODRH
Author: rtrieu
Date: Tue Mar 27 21:16:13 2018
New Revision: 328688
URL: http://llvm.org/viewvc/llvm-project?rev=328688&view=rev
Log:
Fix some handling of AST nodes with diagnostics.
The diagnostic system for Clang can already handle many AST nodes. Instead
of converting them to strings first, ju
Author: rtrieu
Date: Wed Mar 28 22:14:17 2018
New Revision: 328763
URL: http://llvm.org/viewvc/llvm-project?rev=328763&view=rev
Log:
Refactor some code for a warning. NFC.
Use range-based for-loops instead of iterators to walk over vectors.
Switch the key of the DenseMap so a custom key handler
Author: rtrieu
Date: Tue Oct 31 20:57:27 2017
New Revision: 317073
URL: http://llvm.org/viewvc/llvm-project?rev=317073&view=rev
Log:
Change assertion to quick exit from checking function.
Remove the assertion that could be triggered by invalid code. Replace it with
an early exit from the checkin
Author: rtrieu
Date: Fri Nov 3 18:20:50 2017
New Revision: 317394
URL: http://llvm.org/viewvc/llvm-project?rev=317394&view=rev
Log:
Update ODR hashing tests
Add a mix of postive and negative tests to check that wrong Decls won't be
flagged in the diagnostic. Split the check everything test and
Author: rtrieu
Date: Fri Nov 10 16:54:25 2017
New Revision: 317957
URL: http://llvm.org/viewvc/llvm-project?rev=317957&view=rev
Log:
Handle lambda captures of variable length arrays in profiling and printing.
From http://reviews.llvm.org/D4368 these cases were thought to not be reachable
and the
Author: rtrieu
Date: Tue Nov 21 14:53:19 2017
New Revision: 318811
URL: http://llvm.org/viewvc/llvm-project?rev=318811&view=rev
Log:
[OpenMP] Fix tests after r318789
Update use of __tgt_target that had some 32bit types updated to 64bit.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parall
Author: rtrieu
Date: Tue Jan 3 18:46:30 2017
New Revision: 290920
URL: http://llvm.org/viewvc/llvm-project?rev=290920&view=rev
Log:
Extend -Wtautological-overlap-compare to more cases.
Previously, -Wtautological-overlap-compare did not warn on cases where the
boolean expression was in an assignm
rtrieu updated this revision to Diff 68278.
rtrieu added a comment.
Add function void ODRHash(llvm::FoldingSetNodeID &ID) to several classes for
computing the hash. Decl, Stmt, TemplateArgument, Type and QualType now have
this function, and can call among each others' functions.
https://revie
Author: rtrieu
Date: Tue Aug 30 16:12:48 2016
New Revision: 280157
URL: http://llvm.org/viewvc/llvm-project?rev=280157&view=rev
Log:
Fix memory leak by storing returned pointer in std::unique_ptr
Modified:
cfe/trunk/lib/Tooling/Tooling.cpp
Modified: cfe/trunk/lib/Tooling/Tooling.cpp
URL:
ht
Author: rtrieu
Date: Tue Aug 30 20:57:12 2016
New Revision: 280189
URL: http://llvm.org/viewvc/llvm-project?rev=280189&view=rev
Log:
Concatenate two FileCheck lines in a test.
'cc1' is a valid sequence of hexadecimal and sometimes can occur in the path
when testing. This can lead to FileCheck ma
Author: rtrieu
Date: Mon Sep 12 20:20:40 2016
New Revision: 281286
URL: http://llvm.org/viewvc/llvm-project?rev=281286&view=rev
Log:
Fix interaction between serialization and c++1z feature.
In c++1z, static_assert is not required to have a StringLiteral message, where
previously it was required.
Author: rtrieu
Date: Mon Sep 12 20:37:01 2016
New Revision: 281287
URL: http://llvm.org/viewvc/llvm-project?rev=281287&view=rev
Log:
Handle empty message in static_asserts.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL:
http://llvm.org/viewv
Author: rtrieu
Date: Fri Mar 24 16:17:48 2017
New Revision: 298742
URL: http://llvm.org/viewvc/llvm-project?rev=298742&view=rev
Log:
[ODRHash] Add error messages for mismatched parameters in methods.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST
Author: rtrieu
Date: Fri Mar 24 19:48:52 2017
New Revision: 298754
URL: http://llvm.org/viewvc/llvm-project?rev=298754&view=rev
Log:
[ODRHash] Add support for array and decayed types.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Tue Apr 11 16:31:00 2017
New Revision: 299989
URL: http://llvm.org/viewvc/llvm-project?rev=299989&view=rev
Log:
[ODRHash] Improve handling of hash values
Calculating the hash in Sema::ActOnTagFinishDefinition could happen before
all sub-Decls were parsed or processed, which w
Author: rtrieu
Date: Tue Apr 11 17:32:03 2017
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
Revert r298824 & r298816, recommit r298742 & r298754
r299989 fixes the underlying issue by waiting long enough to late parsed
arguments to be processed before doing
r299989 should prevent the build breakages. I have recommited my changes
in r31.
On Sun, Mar 26, 2017 at 11:32 AM, Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vvassilev
> Date: Sun Mar 26 13:32:53 2017
> New Revision: 298816
>
> URL: http://llvm.org/viewvc/
r299989 should prevent the build breakages. I have recommited my changes
in r31.
On Sun, Mar 26, 2017 at 2:39 PM, Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vvassilev
> Date: Sun Mar 26 16:39:16 2017
> New Revision: 298824
>
> URL: http://llvm.org/viewvc/l
; modules buildbot:
>>
>> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhos
>> t-modules-2/builds/6274/steps/compile.llvm.stage2/logs/stdio
>>
>> On 11 April 2017 at 15:32, Richard Trieu via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
Author: rtrieu
Date: Mon Jan 30 19:44:15 2017
New Revision: 293585
URL: http://llvm.org/viewvc/llvm-project?rev=293585&view=rev
Log:
Add better ODR checking for modules.
When objects are imported for modules, there is a chance that a name collision
will cause an ODR violation. Previously, only a
Author: rtrieu
Date: Thu Jun 29 15:53:04 2017
New Revision: 306753
URL: http://llvm.org/viewvc/llvm-project?rev=306753&view=rev
Log:
[ODRHash] Improve typedef handling.
Follow typedef chains to find the root type when processing types, and also
keep track of qualifiers.
Modified:
cfe/trunk/l
Author: rtrieu
Date: Fri Jun 30 15:40:33 2017
New Revision: 306904
URL: http://llvm.org/viewvc/llvm-project?rev=306904&view=rev
Log:
[ODRHash] Support Type TemplateArgument
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Fri Jun 30 19:00:05 2017
New Revision: 306926
URL: http://llvm.org/viewvc/llvm-project?rev=306926&view=rev
Log:
[ODRHash] Revert r305104 - Skip inline namespaces when hashing.
Test inline namespaces and handle them in the ODR hash again.
Modified:
cfe/trunk/lib/AST/ODRHa
Author: rtrieu
Date: Fri Jul 7 19:04:42 2017
New Revision: 307458
URL: http://llvm.org/viewvc/llvm-project?rev=307458&view=rev
Log:
[ODRHash] Support FriendDecl
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/lib/Seriali
Author: rtrieu
Date: Tue Jul 11 15:10:49 2017
New Revision: 307720
URL: http://llvm.org/viewvc/llvm-project?rev=307720&view=rev
Log:
[ODRHash] Support more method types.
Hash CXXConstructorDecl and CXXDestructorDecl. Extend the diagnostics from
CXXMethodDecl to include constructors and destructo
Author: rtrieu
Date: Tue Jul 11 17:38:27 2017
New Revision: 307743
URL: http://llvm.org/viewvc/llvm-project?rev=307743&view=rev
Log:
[ODRHash] Revert r307720 to fix buildbot.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trun
Author: rtrieu
Date: Thu Jul 13 18:36:41 2017
New Revision: 307986
URL: http://llvm.org/viewvc/llvm-project?rev=307986&view=rev
Log:
[ODRHash] Avoid taking the types of FunctionDecl's
FunctionDecl already hashes most of the information in the function's type.
Add hashing of the return type, and s
Author: rtrieu
Date: Fri Jul 14 19:55:13 2017
New Revision: 308077
URL: http://llvm.org/viewvc/llvm-project?rev=308077&view=rev
Log:
[ODRHash] Revert r307743 which reverted r307720
Reapply r307720 to allow processing of constructors and destructors. Reuse
the diagnostics for CXXMethodDecl for th
Author: rtrieu
Date: Thu Jul 20 21:56:48 2017
New Revision: 308714
URL: http://llvm.org/viewvc/llvm-project?rev=308714&view=rev
Log:
Fix tblgen error.
tblgen couldn't determing a unique name between "long_call" and "far", so it
errored out when generating documentation. Copy the documentation, a
Author: rtrieu
Date: Fri Jul 21 13:32:22 2017
New Revision: 308777
URL: http://llvm.org/viewvc/llvm-project?rev=308777&view=rev
Log:
Fix tblgen error
Add Heading string to attribute documentation.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/At
Author: rtrieu
Date: Fri Jul 21 14:29:35 2017
New Revision: 308783
URL: http://llvm.org/viewvc/llvm-project?rev=308783&view=rev
Log:
Inline variable into assert to fix unused warning.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.or
Author: rtrieu
Date: Thu Jan 11 20:42:27 2018
New Revision: 322350
URL: http://llvm.org/viewvc/llvm-project?rev=322350&view=rev
Log:
[ODRHash] Don't hash friend functions.
In certain combinations of templated classes and friend functions, the body
of friend functions does not get propagated along
issue as well.
>
> Please let me know if there is anything I can do to get this fixed quickly.
>
> /Eric
>
> On Wed, Jan 3, 2018 at 5:20 PM, Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Vedant,
>>
>> I'm looking in
Author: rtrieu
Date: Fri Jan 12 13:49:20 2018
New Revision: 322405
URL: http://llvm.org/viewvc/llvm-project?rev=322405&view=rev
Log:
Disable test for Windows to fix Windows buildbots.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
UR
Author: rtrieu
Date: Fri Jan 12 15:13:33 2018
New Revision: 322420
URL: http://llvm.org/viewvc/llvm-project?rev=322420&view=rev
Log:
Try to suppress Windows testing again.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
URL:
http://l
ons with definitions
> inline and the friend declaration site - doesn't a similar issue occur with
> member functions of templates that are not instantiated in some (similar)
> contexts?
>
> Is there a common solution that could be used for both cases?
>
>
> On Thu, Jan 11,
Author: rtrieu
Date: Tue Jan 16 11:53:06 2018
New Revision: 322593
URL: http://llvm.org/viewvc/llvm-project?rev=322593&view=rev
Log:
Add context to why test was disabled on Windows
test/Modules/odr_hash-Friend.cpp triggers an assertion in MicrosoftMangle.cpp
This has been reported in PR35939
Mo
y this test isn't supported on
> windows?
>
> On Fri, Jan 12, 2018 at 1:50 PM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Fri Jan 12 13:49:20 2018
>> New Revision: 322405
>>
>> URL:
URA Takumi
wrote:
> If r322350 is temporary fix, I suggest r321395 may be reverted in
> release_60. Richard, how do you think?
>
> On Wed, Jan 17, 2018 at 4:27 AM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> There was a different, possib
Author: rtrieu
Date: Wed Jan 17 20:28:56 2018
New Revision: 322813
URL: http://llvm.org/viewvc/llvm-project?rev=322813&view=rev
Log:
Fix Scope::dump()
The dump function for Scope only has 20 out of the 24 flags. Since it looped
until no flags were left, having an unknown flag lead to an infinite
Author: rtrieu
Date: Fri Jan 19 12:46:19 2018
New Revision: 322984
URL: http://llvm.org/viewvc/llvm-project?rev=322984&view=rev
Log:
Allow BlockDecl in CXXRecord scope to have no access specifier.
Using a BlockDecl in a default member initializer causes it to be attached to
CXXMethodDecl without
Hans,
I recommend merging this revision into the release. It fixes an infinite
loop in Scope::dump()
Richard
On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Wed Jan 17 20:28:56 2018
> New Revision:
Hans,
I recommend merging this revision into the release. It fixes an assertion
error when mixing modules and blocks.
Richard
On Fri, Jan 19, 2018 at 12:46 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Fri Jan 19 12:46:19 2018
&g
Author: rtrieu
Date: Tue Jan 23 13:58:56 2018
New Revision: 323267
URL: http://llvm.org/viewvc/llvm-project?rev=323267&view=rev
Log:
Fix test Driver/solaris-ld.c
Allow test to accept calls to ld without full path.
Modified:
cfe/trunk/test/Driver/solaris-ld.c
Modified: cfe/trunk/test/Driver/
Hi Eric,
I am getting a build failure after this revision:
llvm/projects/libcxx/include/tuple:175:27: error: no return statement in
constexpr function
static constexpr bool __can_bind_reference() {
^
1 error generated.
It looks like if the #if in __can_bind_referenc
Thanks, Eric.
On Wed, Jan 24, 2018 at 3:11 PM, Eric Fiselier wrote:
> Sorry for the breakage. Fixed in r323389.
>
> On Wed, Jan 24, 2018 at 4:08 PM, Eric Fiselier wrote:
>
>> Looking.
>>
>> On Wed, Jan 24, 2018 at 3:52 PM, Richard Trieu wrote:
>>
>&
Author: rtrieu
Date: Fri Feb 10 18:52:01 2017
New Revision: 294815
URL: http://llvm.org/viewvc/llvm-project?rev=294815&view=rev
Log:
Move test include file from include/ to Inputs/
The Inputs/ directory is the recommended location for extra files for test
cases. No functional change.
Added:
Author: rtrieu
Date: Tue Feb 14 17:56:55 2017
New Revision: 295125
URL: http://llvm.org/viewvc/llvm-project?rev=295125&view=rev
Log:
Remove unused variable. No functional change.
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
Modified: cfe/trunk/lib/Parse/ParseDecl.cpp
URL:
http://llvm.org/vi
Author: rtrieu
Date: Wed Feb 15 22:53:40 2017
New Revision: 295284
URL: http://llvm.org/viewvc/llvm-project?rev=295284&view=rev
Log:
Add better ODR checking for modules.
Recommit r293585 that was reverted in r293611 with new fixes. The previous
issue was determined to be an overly aggressive AST
Author: rtrieu
Date: Wed Feb 15 23:48:25 2017
New Revision: 295286
URL: http://llvm.org/viewvc/llvm-project?rev=295286&view=rev
Log:
Loosen a Type check ODR checking to try to fix the build bot.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTRead
Author: rtrieu
Date: Thu Feb 16 01:09:18 2017
New Revision: 295293
URL: http://llvm.org/viewvc/llvm-project?rev=295293&view=rev
Log:
Revert r295284: Add better ODR checking for modules.
Fix modules build bot.
Removed:
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/lib/AST/ODRHash.cpp
Author: rtrieu
Date: Thu Feb 16 23:54:30 2017
New Revision: 295421
URL: http://llvm.org/viewvc/llvm-project?rev=295421&view=rev
Log:
Add better ODR checking for modules.
A slightly weaker form of ODR checking than previous attempts, but hopefully
won't break the modules build bot. Future work wi
Author: rtrieu
Date: Fri Feb 17 01:19:24 2017
New Revision: 295427
URL: http://llvm.org/viewvc/llvm-project?rev=295427&view=rev
Log:
Revert r295421, new ODR checker for modules, to fix build bot.
Removed:
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/te
Author: rtrieu
Date: Fri Feb 17 20:09:28 2017
New Revision: 295533
URL: http://llvm.org/viewvc/llvm-project?rev=295533&view=rev
Log:
Part of adding an improved ODR checker.
Reserve a spot for ODR hash in CXXRecordDecl and in its modules storage.
Default the hash value to 0 for all classes.
Diffe
Author: rtrieu
Date: Tue Feb 21 19:11:25 2017
New Revision: 295800
URL: http://llvm.org/viewvc/llvm-project?rev=295800&view=rev
Log:
Add more ODR checking.
Add the basics for the ODRHash class, which will only process Decl's from
a whitelist, which currently only has AccessSpecDecl. Different ac
Author: rtrieu
Date: Wed Feb 22 16:22:42 2017
New Revision: 295890
URL: http://llvm.org/viewvc/llvm-project?rev=295890&view=rev
Log:
[ODRHash] static_cast and Stmt hashing.
Add support for static_cast in classes. Add pointer-independent profiling for
Stmt's, sharing most of the logic with Stmt::
Author: rtrieu
Date: Wed Feb 22 18:23:01 2017
New Revision: 295911
URL: http://llvm.org/viewvc/llvm-project?rev=295911&view=rev
Log:
[ODRHash] Add IdentiferInfo and FieldDecl support.
IdentifierInfo is hashed based on the stored string. FieldDecl versus other
Decl is now detected, as well as dif
Author: rtrieu
Date: Wed Feb 22 21:25:57 2017
New Revision: 295931
URL: http://llvm.org/viewvc/llvm-project?rev=295931&view=rev
Log:
[ODRHash] Handle types in ODR hashing.
Fields will now have their types added to the hash, allowing for detection of
mismatched field types. This detection allows
Author: rtrieu
Date: Thu Feb 23 20:59:12 2017
New Revision: 296078
URL: http://llvm.org/viewvc/llvm-project?rev=296078&view=rev
Log:
[ODRHash] Add handling of TypedefType and DeclarationName
Differential Revision: https://reviews.llvm.org/D21675
Modified:
cfe/trunk/include/clang/Basic/Diagno
Author: rtrieu
Date: Fri Feb 24 14:59:28 2017
New Revision: 296170
URL: http://llvm.org/viewvc/llvm-project?rev=296170&view=rev
Log:
[ODRHash] Add handling of bitfields
Differential Revision: https://reviews.llvm.org/D21675
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds
Author: rtrieu
Date: Fri Feb 24 17:35:37 2017
New Revision: 296198
URL: http://llvm.org/viewvc/llvm-project?rev=296198&view=rev
Log:
[ODRHash] Finish FieldDecl support by handling mutable and initializers.
https://reviews.llvm.org/rL296170
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSe
Author: rtrieu
Date: Fri Feb 24 19:29:34 2017
New Revision: 296221
URL: http://llvm.org/viewvc/llvm-project?rev=296221&view=rev
Log:
[ODRHash] Move inherited visitor call to end of function.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
Modified: cfe/trunk/lib/AST/ODRHash.cpp
URL:
http://llvm.org
Author: rtrieu
Date: Tue Feb 28 15:24:38 2017
New Revision: 296521
URL: http://llvm.org/viewvc/llvm-project?rev=296521&view=rev
Log:
[ODRHash] Add basic support for CXXRecordDecl
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/lib/AST/ODRHash.cpp
cfe/
y test cases, or
> "NFC" in the description) would be handy here.
>
> On Fri, Feb 24, 2017 at 5:41 PM Richard Trieu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Fri Feb 24 19:29:34 2017
>> New Revision: 296221
>&
Author: rtrieu
Date: Tue Feb 28 21:07:55 2017
New Revision: 296572
URL: http://llvm.org/viewvc/llvm-project?rev=296572&view=rev
Log:
Add warning for inconsistent overrides on destructor.
The exisiting warning for inconsistent overrides does not include the destructor
as it was noted in review tha
Author: rtrieu
Date: Fri Mar 3 18:08:58 2017
New Revision: 296932
URL: http://llvm.org/viewvc/llvm-project?rev=296932&view=rev
Log:
[ODRHash] Add support for detecting different method properties.
Now print diagnostics for static, virtual, inline, volatile, and const
differences in methods. Als
Author: rtrieu
Date: Fri Mar 3 20:05:13 2017
New Revision: 296953
URL: http://llvm.org/viewvc/llvm-project?rev=296953&view=rev
Log:
[ODRHash] Change test to try to appease buildbot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm
Author: rtrieu
Date: Fri Mar 3 20:42:41 2017
New Revision: 296956
URL: http://llvm.org/viewvc/llvm-project?rev=296956&view=rev
Log:
Handle null QualType better in Stmt::Profile
If the QualType is null, calling ASTContext::getCanonicalType on it will lead
to an assert. This was found while testi
Author: rtrieu
Date: Fri Mar 3 21:04:15 2017
New Revision: 296958
URL: http://llvm.org/viewvc/llvm-project?rev=296958&view=rev
Log:
[ODRHash] Try again to fix build bot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm.org/viewvc/
Author: rtrieu
Date: Tue Mar 7 18:13:19 2017
New Revision: 297246
URL: http://llvm.org/viewvc/llvm-project?rev=297246&view=rev
Log:
[ODRHash] Hash typedefs and usings statements in classes.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/l
Author: rtrieu
Date: Mon Dec 5 17:41:46 2016
New Revision: 288732
URL: http://llvm.org/viewvc/llvm-project?rev=288732&view=rev
Log:
Warn on unsigned zero in call to std::max
New default warning that triggers when an unsigned zero is used in a call to
std::max. For unsigned values, zero is the m
Author: rtrieu
Date: Mon Dec 5 18:27:21 2016
New Revision: 288740
URL: http://llvm.org/viewvc/llvm-project?rev=288740&view=rev
Log:
Add test for r288732, warn on unsigned zero in std::max
Added:
cfe/trunk/test/SemaCXX/warn-max-unsigned-zero.cpp
Added: cfe/trunk/test/SemaCXX/warn-max-unsigne
Author: rtrieu
Date: Mon Dec 5 19:42:28 2016
New Revision: 288756
URL: http://llvm.org/viewvc/llvm-project?rev=288756&view=rev
Log:
Clean up some Sema checking code. NFC
- Rename CheckMinZero to CheckMaxUnsignedZero to reflect its actual purpose.
- Remove unused parameters from CheckAbsoluteVal
Author: rtrieu
Date: Wed Apr 19 21:53:53 2017
New Revision: 300814
URL: http://llvm.org/viewvc/llvm-project?rev=300814&view=rev
Log:
[ODRHash] clean up test and add new examples. NFC
Use a macro to generate the struct with all decls. Previously, four identical
changes would be needed to update
Author: rtrieu
Date: Fri Apr 28 17:03:28 2017
New Revision: 301701
URL: http://llvm.org/viewvc/llvm-project?rev=301701&view=rev
Log:
[ODRHash] Add testcase with different paramter names. NFC
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
ht
Author: rtrieu
Date: Tue May 2 18:58:52 2017
New Revision: 301989
URL: http://llvm.org/viewvc/llvm-project?rev=301989&view=rev
Log:
[ODRHash] Add support for array and decayed types, and parameter names and
types.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
c
Author: rtrieu
Date: Fri May 5 15:47:50 2017
New Revision: 302284
URL: http://llvm.org/viewvc/llvm-project?rev=302284&view=rev
Log:
[ODRHash] Fix typo, NFC
NestedNameSpecifer to NestedNameSpecifier. This was not a problem before since
one of the included headers transitively brought in the defi
Author: rtrieu
Date: Mon May 8 22:24:34 2017
New Revision: 302505
URL: http://llvm.org/viewvc/llvm-project?rev=302505&view=rev
Log:
[ODRHash] Loosen checks on typedefs.
When a type in a class is from a typedef, only check the canonical type. Skip
checking the intermediate underlying types. Thi
101 - 200 of 404 matches
Mail list logo
