Author: rsmith
Date: Sat Jan 9 00:58:48 2016
New Revision: 257251
URL: http://llvm.org/viewvc/llvm-project?rev=257251&view=rev
Log:
[modules] If we're treating an elaborated-type-specifier as if it introduces a
tag (because the previous declaration was found in a different module), inject
the tag
tal error:
> could not build module 'LLVM_Utils'
> #include "llvm/Support/ARMBuildAttributes.h"
> ^~~
> 5 errors generated.
>
> Reverting r256907 just works for me. Lemme know if you would like more
> information.
>
Author: rsmith
Date: Mon Jan 11 16:41:53 2016
New Revision: 257403
URL: http://llvm.org/viewvc/llvm-project?rev=257403&view=rev
Log:
When a tag is declared in prototype scope in C, if we've decided that it
redeclares an existing tag but are creating a new declaration anyway (because
it has attribu
rsmith added a comment.
Would this be expected to degrade performance for people building with
-fno-exceptions who use iterators with non-noexcept operations (such as LLVM
and Clang)?
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe
rsmith added inline comments.
Comment at: include/iterator:442
@@ +441,3 @@
+struct __is_exactly_input_iterator
+: public integral_constant::iterator_category, input_iterator_tag>::value> {};
+
Is it permitted for people to derive their own tag types from
inp
Author: rsmith
Date: Tue Jan 12 14:34:32 2016
New Revision: 257512
URL: http://llvm.org/viewvc/llvm-project?rev=257512&view=rev
Log:
[modules] Don't diagnose a conflict between two using-declarations that name
equivalent internal linkage entities.
Added:
cfe/trunk/test/Modules/Inputs/using-d
Author: rsmith
Date: Tue Jan 12 15:59:26 2016
New Revision: 257529
URL: http://llvm.org/viewvc/llvm-project?rev=257529&view=rev
Log:
Improve AST dumping:
1) When dumping a declaration that declares a name for a type, also dump the
named type.
2) Add a #pragma clang __debug dump X, that dumps t
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGExprScalar.cpp:816-817
@@ +815,4 @@
+// the same as the vector's element type (sans qualifiers)
+assert(DstType->castAs()->getElementType().getTypePtr() ==
+
On Fri, Jan 8, 2016 at 1:54 PM, Philippe Canal wrote:
> Hi Richard,
>
> In our use (Persistency of C++ objects, including the (meta)description of
> their data content as well as use the name as key to access the class'
> reflection information at run-time), the 'context' is indeed always the "at
rsmith added a comment.
I think this functionality can be provided more simply by adding another flag
to `PrintingPolicy` to request fully-qualified names always be produced. It
already usually provides fully-qualified names; the only notable exception I
can see is that if a qualifier was alrea
rsmith added inline comments.
Comment at: include/clang/Basic/Builtins.h:216-219
@@ -215,3 +215,6 @@
/// \brief This names the __make_integer_seq BuiltinTemplateDecl.
BTK__make_integer_seq
+
+ /// \brief This names the __nth_element BuiltinTemplateDecl.
+ , BTK__nth_elemen
rsmith added a comment.
Bikeshedding on the name a bit... how about `__type_pack_element`?
http://reviews.llvm.org/D15421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jan 13, 2016 at 2:31 PM, Nathan Wilson wrote:
> nwilson added a comment.
>
> In http://reviews.llvm.org/D15421#326144, @rsmith wrote:
>
> > Bikeshedding on the name a bit... how about `__type_pack_element`?
>
> Hmm, I kind of felt like having `nth` in there implied we're indexing into
> s
The right way to update this file is to change the www/make_cxx_dr_status
script and then rerun it. (It expects to find a copy of the cwg_index.html
page from the wg21 website in the current directory.) Done in r257695.
On Wed, Jan 13, 2016 at 11:20 AM, Hans Wennborg wrote:
> Richard, can you ch
Author: rsmith
Date: Wed Jan 13 16:51:59 2016
New Revision: 257695
URL: http://llvm.org/viewvc/llvm-project?rev=257695&view=rev
Log:
Update make_cxx_dr_status after the 3.8 branch.
Modified:
cfe/trunk/www/make_cxx_dr_status
Modified: cfe/trunk/www/make_cxx_dr_status
URL:
http://llvm.org/vie
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Following Louis' suggestion, how about __pack_nth?
>
Maybe just __pack_element, to mirror its intended use to implement things
like tuple_element? (I'm not completely happy about using this gene
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Lex/PPExpressions.cpp:104-105
@@ +103,4 @@
+ // #else branch. Emit a warning about this undefined behavior.
+ if (beginLoc.isMacroID())
+PP.Diag(beginLoc, diag::warn_defined_in_m
rsmith added a comment.
I think you missed this from my previous review:
> This should be checked and diagnosed in Sema, not in CodeGen.
Comment at: lib/CodeGen/CGDeclCXX.cpp:333-337
@@ +332,7 @@
+ [](const CXXMethodDecl *Method) { return Method->isVirtual(); }))
+
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
LGTM, thanks!
Comment at: test/SemaCUDA/cxx11-kernel-call.cu:8
@@ +7,3 @@
+template void k1Wrapper() {
+ void (*f)() = [] { k1<<>>(); }; // expected-error
{{initializer contains unexpanded
Author: rsmith
Date: Thu Jan 14 21:24:18 2016
New Revision: 257863
URL: http://llvm.org/viewvc/llvm-project?rev=257863&view=rev
Log:
When copying whitespace flags from the token naming a macro argument onto the
first token of the expansion, don't forget to copy the "is at the start of a
line" toke
rsmith added a comment.
This isn't quite the right way to fix this issue.
Comment at: lib/Parse/ParseDeclCXX.cpp:3206-3209
@@ -3205,6 +3205,6 @@
// we're just missing a comma.
else if (Tok.isOneOf(tok::identifier, tok::coloncolon)) {
SourceLocation Loc = PP.getL
rsmith added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:312
@@ +311,3 @@
+ // the checks have been done in Sema by now. Whatever initializers
+ // areallowed are empty and we just need to ignore them here.
+ if (getLangOpts().CUDA && getLangOpts().CUDAIsDevice &&
--
On Fri, Jan 15, 2016 at 4:22 PM, Artem Belevich wrote:
> tra added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenModule.cpp:2334
> @@ -2339,1 +2333,3 @@
> + D->hasAttr())
> Init = llvm::UndefValue::get(getTypes().ConvertType(ASTTy));
> + else if (!InitExpr) {
>
On Fri, Jan 15, 2016 at 5:29 PM, Richard Smith wrote:
> On Fri, Jan 15, 2016 at 4:22 PM, Artem Belevich wrote:
>> tra added inline comments.
>>
>>
>> Comment at: lib/CodeGen/CodeGenModule.cpp:2334
>> @@ -2339,1 +2333,3 @@
>> + D->hasAttr())
>> Init = llvm::UndefValue::g
+ // the when comparing #1 and #2 we should go through their elements
types.
Typo "the when"
+ QualType VarXTy = VarX->getType();
+ QualType VarYTy = VarY->getType();
+ if (VarXTy->isIncompleteArrayType() ||
VarYTy->isIncompleteArrayType())
+return C.hasSameType(C.getA
LGTM
On Jan 18, 2016 12:06 PM, "Vassil Vassilev" wrote:
> Attaching v3 of the patch. Added your case to the current test and fixed
> my silly non-array mistake.
> -- Vassil
> On 18/01/16 20:38, Richard Smith wrote:
>
> Please also add a test case that your old patch would have failed on, such
> a
On Jan 7, 2016 7:13 PM, "Bruno Cardoso Lopes"
wrote:
>
> bruno updated this revision to Diff 44306.
> bruno added a comment.
>
> Hi Richard,
>
> Thanks for the detailed explanation, it now makes sense to me. I updated
the patch with another approach! Let me know if it's the right direction.
>
>
>
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! Do you need someone to commit for you?
http://reviews.llvm.org/D16216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
rsmith added inline comments.
Comment at: lib/AST/StmtPrinter.cpp:132
@@ -131,2 +131,3 @@
SubPolicy.SuppressSpecifiers = false;
+ SubPolicy.SuppressTag = false;
Decl::printGroup(Decls.data(), Decls.size(), OS, SubPolicy, IndentLevel);
Maybe we should instea
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! Do you have SVN commit access?
http://reviews.llvm.org/D16438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Approved for branch.
On 23 Jan 2016 11:56 p.m., "Joerg Sonnenberger"
wrote:
> On Sat, Jan 16, 2016 at 03:51:11PM +0100, Joerg Sonnenberger via
> cfe-commits wrote:
> > Hello Richard,
> > can this be merged into 3.8? It creates some trivial noise under
> > valgrind.
>
> Ping?
>
> Joerg
>
_
LGTM, assuming this is the same behaviour as GCC.
On 26 Jan 2016 1:59 a.m., "Yunzhong Gao"
wrote:
> ygao added a comment.
>
> A gentle ping.
>
>
> http://reviews.llvm.org/D16365
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
rsmith added a subscriber: rsmith.
rsmith added a comment.
LGTM, assuming this is the same behaviour as GCC.
http://reviews.llvm.org/D16365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
What's the benefit of storing this? You can get the same effect by
re-lexing. We don't guarantee that the pretty printed version of the AST
comprises the same sequence of tokens in general.
On 27 Jan 2016 3:03 p.m., "Aaron Ballman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> aaron.ballm
On 29 Jan 2016 5:50 a.m., "Yaron Keren via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: yrnkrn
> Date: Fri Jan 29 07:46:15 2016
> New Revision: 259192
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259192&view=rev
> Log:
> Implement TemplateArgument::dump() method for debugging,
On Fri, Jan 29, 2016 at 11:13 AM, Yaron Keren wrote:
> OK. There are more un-annotated dump() methods such as
> TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(),
> ModuleMap::dump(), MacroInfo::dump(), ...
>
> Annotate all dump() methods LLVM_DUMP_METHOD ?
SGTM
> 2016-01-29
Author: rsmith
Date: Thu Nov 12 15:42:39 2015
New Revision: 252955
URL: http://llvm.org/viewvc/llvm-project?rev=252955&view=rev
Log:
Additional tests from r252690 that I forgot to 'svn add'.
From a patch by Nicholas Allegra!
Added:
cfe/trunk/test/Sema/auto-type.c
cfe/trunk/test/SemaCXX/a
Author: rsmith
Date: Thu Nov 12 15:55:58 2015
New Revision: 252957
URL: http://llvm.org/viewvc/llvm-project?rev=252957&view=rev
Log:
Revert r240335.
This failed to solve the problem it was aimed at, and introduced just as many
issues as it resolved. Realistically, we need to deal with the possibi
Author: rsmith
Date: Thu Nov 12 16:04:34 2015
New Revision: 252959
URL: http://llvm.org/viewvc/llvm-project?rev=252959&view=rev
Log:
DR407: Rationalize how we handle tags being hidden by typedefs. Even with
DR407, the C++ standard doesn't really say how this should work. Here's what we
do (which i
Author: rsmith
Date: Thu Nov 12 16:19:45 2015
New Revision: 252960
URL: http://llvm.org/viewvc/llvm-project?rev=252960&view=rev
Log:
[modules] Simplify and generalize the existing rule for finding hidden
declarations in redeclaration lookup. A declaration is now visible to
lookup if:
* It is vis
Author: rsmith
Date: Thu Nov 12 16:40:09 2015
New Revision: 252967
URL: http://llvm.org/viewvc/llvm-project?rev=252967&view=rev
Log:
Avoid duplicated diagnostic when lookup for a nested-name-specifier fails due
to ambiguity.
Modified:
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
cfe/trunk/tes
On Wed, Nov 11, 2015 at 10:11 PM, Daniel Marjamäki <
daniel.marjam...@evidente.se> wrote:
> danielmarjamaki added a comment.
>
> In http://reviews.llvm.org/D12359#287522, @rsmith wrote:
>
> > Why does this construct justify the compiler emitting a warning? It
> seems to be reporting a fact about t
Author: rsmith
Date: Thu Nov 12 21:52:13 2015
New Revision: 253010
URL: http://llvm.org/viewvc/llvm-project?rev=253010&view=rev
Log:
[modules] Follow the C++ standard's rule for linkage of enumerators: they have
the linkage of the enumeration. For enumerators of unnamed enumerations, extend
the -W
Author: rsmith
Date: Thu Nov 12 23:14:45 2015
New Revision: 253012
URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev
Log:
[modules] When a declaration has non-trivial visibility, check whether it's
actually hidden before we check its linkage. This avoids computing the linkage
"too early
On Fri, Nov 13, 2015 at 4:03 PM, Ben Langmuir via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This time sending to the right list address.
Likewise =)
> On Nov 13, 2015, at 4:00 PM, Ben Langmuir wrote:
> >
> > Hey Richard,
> >
> > After your commit r233345 we started diagnosing “redefin
On Nov 13, 2015 7:23 PM, "Sean Silva" wrote:
>
>
>
> On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>>
>> Author: rsmith
>> Date: Thu Nov 12 23:14:45 2015
>> New Revision: 253012
>>
&
Rather than trying to maintain the horrible duplication between
DataRecursiveASTVisitor and RecursiveASTVisitor, can we just delete
DataRecursiveASTVisitor? RecursiveASTVisitor is data-recursive too these
days (and has a smarter implementation than DataRecursiveASTVisitor's from
what I can see), bu
On Mon, Nov 16, 2015 at 5:17 PM, Li, Charles <
charles...@playstation.sony.com> wrote:
> Hi Everyone,
>
>
>
> Here is the forth Lit tests C++11 compatibility patch.
>
> This patch mainly added new diagnostics expected for C++11.
>
> There are 34 tests in total. They fall into 3 categories.
>
>
>
>
Author: rsmith
Date: Mon Nov 16 21:02:41 2015
New Revision: 253283
URL: http://llvm.org/viewvc/llvm-project?rev=253283&view=rev
Log:
[modules] Fix some more cases where we used to reject a conflict between two
declarations that are not simultaneously visible, and where at least one of
them has int
On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote:
> On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith
> wrote:
>
>> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote:
>> >
>> >
>> >
>> > On Thu, Nov 12, 2015 at 9:14 PM, Richard
LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> Richard, this is still optional, right? (the AST matchers need to control
visitation)
This doesn't change RAV semantics at all (or if it does, it's a bug). If
any of the extension points are overridden in the derived class, data
recursion is aut
Author: rsmith
Date: Tue Nov 17 17:32:01 2015
New Revision: 253398
URL: http://llvm.org/viewvc/llvm-project?rev=253398&view=rev
Log:
[modules] When a #include is mapped to a module import and appears somewhere
other than the top level, we issue an error. This breaks a fair amount of C++
code wrapp
On Tue, Nov 17, 2015 at 3:40 PM, David Blaikie wrote:
> On Tue, Nov 17, 2015 at 3:32 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Tue Nov 17 17:32:01 2015
>> New Revision: 253398
>>
>> URL: h
Author: rsmith
Date: Tue Nov 17 19:19:02 2015
New Revision: 253420
URL: http://llvm.org/viewvc/llvm-project?rev=253420&view=rev
Log:
Don't expose iterators into the list of types on the ASTContext; these are
unsafe, since many operations on the types can trigger lazy deserialization of
more types
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7659
@@ +7658,3 @@
+Diag(D.getDeclSpec().getConceptSpecLoc(),
+ diag::err_concept_specified_specialization) << 1;
+ }
hubert.reinterpretcast wrote:
> nwilson wrote:
> > hubert
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:631-634
@@ -630,1 +630,6 @@
+ /// \brief If the current Expr is either a pointer, this will try to
+ /// statically determine the number of bytes available where the pointer is
+ /// pointing. Returns true if
Author: rsmith
Date: Wed Nov 18 20:36:35 2015
New Revision: 253535
URL: http://llvm.org/viewvc/llvm-project?rev=253535&view=rev
Log:
[coroutines] Tweak diagnostics to always use fully-qualified name for
std::coroutine_traits.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Author: rsmith
Date: Thu Nov 19 20:54:01 2015
New Revision: 253641
URL: http://llvm.org/viewvc/llvm-project?rev=253641&view=rev
Log:
[coroutines] Per latest wording paper, co_* are no longer permitted in any
unevaluated operands.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Author: rsmith
Date: Fri Nov 20 16:40:06 2015
New Revision: 253725
URL: http://llvm.org/viewvc/llvm-project?rev=253725&view=rev
Log:
[coroutines] Synthesize yield_value call for co_yield.
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
cfe/trunk/test/SemaCXX/coroutines.cpp
Modified: cfe/t
Author: rsmith
Date: Fri Nov 20 16:47:10 2015
New Revision: 253726
URL: http://llvm.org/viewvc/llvm-project?rev=253726&view=rev
Log:
[coroutines] Support braced-init-list as operand of co_yield expression.
Modified:
cfe/trunk/lib/Parse/ParseExprCXX.cpp
cfe/trunk/test/SemaCXX/coroutines.cp
Author: rsmith
Date: Fri Nov 20 16:57:24 2015
New Revision: 253731
URL: http://llvm.org/viewvc/llvm-project?rev=253731&view=rev
Log:
[coroutines] Better handling of placeholder types.
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
cfe/trunk/test/SemaCXX/coroutines.cpp
Modified: cfe/trunk
It would seem cleaner to build an ImplicitCastExpr node in Sema between the
operand and the splat node.
On Nov 20, 2015 11:04 AM, "George Burgess IV"
wrote:
> george.burgess.iv created this revision.
> george.burgess.iv added a reviewer: rsmith.
> george.burgess.iv added a subscriber: cfe-commits
Author: rsmith
Date: Sat Nov 21 20:57:17 2015
New Revision: 253811
URL: http://llvm.org/viewvc/llvm-project?rev=253811&view=rev
Log:
[coroutines] Factor out co_await representation into common base class for
co_await and co_yield, and use it to hold await_* calls.
Modified:
cfe/trunk/include
Author: rsmith
Date: Sat Nov 21 21:13:02 2015
New Revision: 253812
URL: http://llvm.org/viewvc/llvm-project?rev=253812&view=rev
Log:
[coroutines] Materialize the awaitable before generating the await_* calls.
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib/Sema/SemaCor
Author: rsmith
Date: Sun Nov 22 01:05:16 2015
New Revision: 253816
URL: http://llvm.org/viewvc/llvm-project?rev=253816&view=rev
Log:
[coroutines] Build implicit return_value / return_void calls for co_return.
Modified:
cfe/trunk/include/clang/AST/StmtCXX.h
cfe/trunk/lib/Sema/SemaCoroutine
Author: rsmith
Date: Sun Nov 22 01:33:28 2015
New Revision: 253817
URL: http://llvm.org/viewvc/llvm-project?rev=253817&view=rev
Log:
[coroutines] Check for overload sets in co_yield / co_return operands being
resolved by a call to yield_value / return_value before rejecting them.
Modified:
c
Author: rsmith
Date: Mon Nov 23 20:34:39 2015
New Revision: 253946
URL: http://llvm.org/viewvc/llvm-project?rev=253946&view=rev
Log:
[coroutines] Build a CoroutineBodyStmt when finishing parsing a coroutine, and
form the initial_suspend, final_suspend, and get_return_object calls.
Modified:
Ping.
On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith wrote:
> Ping.
>
> On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith
> wrote:
>
>> Hi,
>>
>> The attached patch undoes the revert of r249929, and adds an extension to
>> allow (and ) to work properly even in environments such
>> as iOS where the
Author: rsmith
Date: Mon Nov 23 21:55:01 2015
New Revision: 253949
URL: http://llvm.org/viewvc/llvm-project?rev=253949&view=rev
Log:
Remove DataRecursiveASTVisitor; it no longer serves any purpose, since it's
just an alias for RecursiveASTVisitor.
Removed:
cfe/trunk/include/clang/AST/DataRec
Author: rsmith
Date: Mon Nov 23 22:22:21 2015
New Revision: 253950
URL: http://llvm.org/viewvc/llvm-project?rev=253950&view=rev
Log:
[modules] Add -cc1 flag -fmodules-embed-all-files.
This flag causes all files that were read by the compilation to be embedded
into a produced module file. This is
Author: rsmith
Date: Tue Nov 24 01:13:06 2015
New Revision: 253958
URL: http://llvm.org/viewvc/llvm-project?rev=253958&view=rev
Log:
Reduce the stack usage per recursive step when RecursiveASTVisitor cannot
perform data recursion.
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Author: rsmith
Date: Tue Nov 24 17:50:47 2015
New Revision: 254041
URL: http://llvm.org/viewvc/llvm-project?rev=254041&view=rev
Log:
Teach RAV to pass its DataRecursionQueue to derived classes if they ask for it,
to allow them to explicitly opt into data recursion despite having overridden
Travers
ncreases the stack usage, so do you think there's more to fix here,
> or we should just disable the test under ASan?
>
I think this should work even under ASan conditions; fixed in r254041.
> On Mon, Nov 23, 2015 at 11:13 PM, Richard Smith via cfe-commits <
> cfe-commits@list
Author: rsmith
Date: Tue Nov 24 20:41:42 2015
New Revision: 254053
URL: http://llvm.org/viewvc/llvm-project?rev=254053&view=rev
Log:
Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid
on this).
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified:
/sanitizer-x86_64-linux-autoconf/builds/12237
>
> On Tue, Nov 24, 2015 at 3:50 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Tue Nov 24 17:50:47 2015
>> New Revision: 254041
>>
>> URL: http://llvm.or
Author: rsmith
Date: Wed Nov 25 13:33:20 2015
New Revision: 254083
URL: http://llvm.org/viewvc/llvm-project?rev=254083&view=rev
Log:
Stop using SFINAE to detect whether a derived-class override of Traverse* can
take a queue; some supported versions of GCC believe that this substitution
failure is
Author: rsmith
Date: Wed Nov 25 15:34:21 2015
New Revision: 254097
URL: http://llvm.org/viewvc/llvm-project?rev=254097&view=rev
Log:
P0001R1: 'register' storage class specifier is no longer permitted in C++1z.
We will still allow it in system headers, in macros from system headers, when
combined
On Nov 25, 2015 1:53 PM, "hfin...@anl.gov via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> hfinkel added inline comments.
>
>
> Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783
> @@ -2783,1 +2782,3 @@
> + "the newer semantic is provided here">,
> + InGroup>;
>
ks like we can't compile Clang itself after this change (with
>>> GCC):
>>>
>>>
>>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/12237
>>>
>>> On Tue, Nov 24, 2015 at 3:50 PM, Richard Smith via cfe-commits <
>>
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
What about `CK_Generic`? Also, if `CK_i486` can be used for th
Author: rsmith
Date: Wed Nov 25 20:04:16 2015
New Revision: 254121
URL: http://llvm.org/viewvc/llvm-project?rev=254121&view=rev
Log:
[modules] Refactor handling of -fmodules-embed-*. Track this properly rather
than reusing the "overridden buffer" mechanism. This will allow us to make
embedded file
Author: rsmith
Date: Wed Nov 25 20:16:37 2015
New Revision: 254122
URL: http://llvm.org/viewvc/llvm-project?rev=254122&view=rev
Log:
P0002R1: increment on expressions of type bool is no longer allowed in C++1z.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/
Author: rsmith
Date: Wed Nov 25 20:23:21 2015
New Revision: 254123
URL: http://llvm.org/viewvc/llvm-project?rev=254123&view=rev
Log:
Update reference to final TM TS spec.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project
rsmith added a subscriber: rsmith.
rsmith added a comment.
GCC's behavior (`aligned` on a field specifies the alignment of the start of
that field) makes a little more sense to me than Clang's behavior (the type and
alignment of a field specify a flavour of storage unit, and the field goes in
t
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2548
@@ +2547,3 @@
+ // All X86 processors but i386 have X87.
+ if (Kind != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
aturetsk wrote:
> rsmith wrote:
> > What about `CK_Generic`? A
On Mon, Nov 30, 2015 at 11:33 AM, John McCall wrote:
> rjmccall added a comment.
>
> In http://reviews.llvm.org/D14980#298754, @rsmith wrote:
>
> > GCC's behavior (`aligned` on a field specifies the alignment of the
> start of that field) makes a little more sense to me than Clang's behavior
> (t
Author: rsmith
Date: Mon Nov 30 19:10:48 2015
New Revision: 254359
URL: http://llvm.org/viewvc/llvm-project?rev=254359&view=rev
Log:
Fix use-after-free when a C++ thread_local variable gets replaced (because its
type changes when the initializer is attached). Don't hold onto the
GlobalVariable*; r
rsmith added a subscriber: rsmith.
Comment at: lib/Basic/Diagnostic.cpp:251-257
@@ -250,2 +250,9 @@
SourceLocation Loc) {
+ // Special handling for pragma clang diagnostic ... "-Weverything"
+ // There is no formal group named "everyt
Author: rsmith
Date: Mon Nov 30 21:32:49 2015
New Revision: 254365
URL: http://llvm.org/viewvc/llvm-project?rev=254365&view=rev
Log:
[modules] Don't reject multiple modules providing contents for the same
embedded file.
Added:
cfe/trunk/test/Modules/embed-files.cpp
Modified:
cfe/trunk/li
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, a couple of trivial changes then I think this is fine to commit.
Comment at: include/clang/Basic/AttrDocs.td:351-355
@@ +350,7 @@
+
+* Only one use of ``pass_object_size``
On Tue, Dec 1, 2015 at 3:42 PM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> > On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: aaronballman
> > Date: Tue Dec 1 11:15:13 2015
> > New Revision: 254423
rsmith added a comment.
In http://reviews.llvm.org/D15121#300033, @LegalizeAdulthood wrote:
> I'm wondering if there isn't an existing module that would be a good fit for
> this check. Why not in the modernize module?
This isn't really modernization, it's a bug fix. ADL has always been the ri
rsmith added a subscriber: rsmith.
rsmith added a comment.
Your http://reviews.llvm.org/D14419 removes a lot of the code added here. Can
you update this patch to not add that code? I'd prefer not to review the
portion of this code that you're about to delete.
Comment at: lib/C
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks fine (subject to the observation in http://reviews.llvm.org/D13603
that `MarkWriteOnceWrittenRAII` can just be a f
rsmith added a subscriber: rsmith.
Comment at: lib/CodeGen/CGDecl.cpp:933
@@ +932,3 @@
+ ASTContext &Ctx = getContext();
+ auto &OffsetsInfo = InvariantOffsets.FindAndConstruct(Record).second;
+ OffsetsType &Args = OffsetsInfo.Offsets;
Instead of tracking a sep
rsmith added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1081-1083
@@ -1080,3 +1080,5 @@
}
- Kind = CK_BitCast;
+ unsigned SrcAS = SrcPointee.getAddressSpace();
+ unsigned DestAS = DestPointee.getAddressSpace();
+ Kind = SrcAS
Author: rsmith
Date: Wed Dec 2 19:36:22 2015
New Revision: 254574
URL: http://llvm.org/viewvc/llvm-project?rev=254574&view=rev
Log:
PR17381: Treat undefined behavior during expression evaluation as an unmodeled
side-effect, so that we don't allow speculative evaluation of such expressions
during
Author: rsmith
Date: Thu Dec 3 17:24:04 2015
New Revision: 254663
URL: http://llvm.org/viewvc/llvm-project?rev=254663&view=rev
Log:
PR25731: namespace alias declarations can appear at block scope; ensure that we
do scope-based lookup when looking for redeclarations of them. Add some related
missi
rsmith added a comment.
I would expect that people who are using this for hardening would be upset
about a 5% binary size increase. I'm OK with having this behind a flag, though.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits
3701 - 3800 of 4285 matches
Mail list logo
