rsmith added a comment.
Thank you for working on this! Please also add a test to
test/CXX/drs/dr15xx.cpp with a "// dr1579: 3.9" comment (we have a script that
turns those comments into www/cxx_dr_status.html).
Comment at: include/clang/Sema/Sema.h:3473
@@ -3472,3 +3472,3 @@
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please also add the testcase from PR27601.
http://reviews.llvm.org/D21653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
On Thu, Jun 23, 2016 at 10:37 AM, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> erik.pilkington created this revision.
> erik.pilkington added reviewers: rsmith, faisalv.
> erik.pilkington added a subscriber: cfe-commits.
>
> Previously, Clang would incorrectly accept the
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This seems fine to me.
http://reviews.llvm.org/D21501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
rsmith added a comment.
Thank you! I'm happy with this implementation (other than some data structure
improvements), and cxx-abi-dev discussion seems to be settling on this approach
(mangling the return type / variable type to extract attributes) being the
right one.
(Minor nit: please make su
rsmith added a comment.
Well OK then, commit away! :)
http://reviews.llvm.org/D21653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Jun 28 18:26:18 2016
New Revision: 274080
URL: http://llvm.org/viewvc/llvm-project?rev=274080&view=rev
Log:
Function declarations are, in fact, permitted in the init-statement of a for
loop. Don't confuse Sema by saying they're not.
Modified:
cfe/trunk/include/clang/S
Author: rsmith
Date: Tue Jun 28 20:10:27 2016
New Revision: 274088
URL: http://llvm.org/viewvc/llvm-project?rev=274088&view=rev
Log:
Mark inheriting constructors as deleted if the corresponding defaulted default
constructor would be; this is effectively required by P0136R1. This has the
effect of
Hi all!
I'd like to establish a policy for Clang's default language standard (if
none is specified with -std), as follows:
Clang defaults to the most recent published standard for the selected
language that it fully implements.
The practical impact of this is that clang++ will default to C++14
or the transition in the C++
default in time for 3.9, then so be it.
> On Wed, Jun 29, 2016 at 3:09 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi all!
>>
>> I'd like to establish a policy for Clang's default language stand
On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva wrote:
>
>
> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi all!
>>
>> I'd like to establish a policy for Clang's default language standar
On Wed, Jun 29, 2016 at 12:55 PM, Hal Finkel via cfe-dev <
cfe-...@lists.llvm.org> wrote:
>
> --
>
> *From: *"Richard Smith via cfe-commits"
> *To: *"cfe-commits" , "Clang Dev" <
> cfe-...@lists.llvm.org>
&g
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907
@@ -7904,1 +7906,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL version 2.2 feature">;
} // end of sema category
As
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thank you so much for your patience and hard work on this change!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@l
Author: rsmith
Date: Wed Jun 29 16:06:51 2016
New Revision: 274165
URL: http://llvm.org/viewvc/llvm-project?rev=274165&view=rev
Log:
Switch to an RAII object to revert tentative parsing automatically.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseTentative.cpp
Author: rsmith
Date: Wed Jun 29 16:12:37 2016
New Revision: 274167
URL: http://llvm.org/viewvc/llvm-project?rev=274167&view=rev
Log:
Convert another case over to RevertingTentativeParsingAction.
Modified:
cfe/trunk/lib/Parse/ParseTentative.cpp
Modified: cfe/trunk/lib/Parse/ParseTentative.cpp
Author: rsmith
Date: Wed Jun 29 16:17:59 2016
New Revision: 274169
URL: http://llvm.org/viewvc/llvm-project?rev=274169&view=rev
Log:
P0305R1: Parsing support for init-statements in 'if' and 'switch' statements.
No semantic analysis yet.
This is a pain to disambiguate correctly, because the parsin
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
The proposal has changed since the pre-meeting mailing, and now covers `switch`
as well as `if`. You also need to handle the //expression-statement// form of
//init-statement//.
As
On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote:
> > Hi all!
> >
> > I'd like to establish a policy for Clang's default language standard (if
> > none is specified w
Author: rsmith
Date: Thu Jun 30 13:36:34 2016
New Revision: 274260
URL: http://llvm.org/viewvc/llvm-project?rev=274260&view=rev
Log:
PR28373: fix crash-on-invalid if the condition of an if-statement fails
typo-correction.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/SemaCXX/c
rsmith added a comment.
There are a few missing pieces here:
1. Analysis/CFG.cpp needs to be taught to build a correct CFG for these. You
can test this with an example like 'if (bool b; b)' which should give a
-Wuninitialized warning.
2. AST/ExprConstant.cpp needs to be taught to perform consta
Author: rsmith
Date: Thu Jun 30 15:24:30 2016
New Revision: 274267
URL: http://llvm.org/viewvc/llvm-project?rev=274267&view=rev
Log:
Fix typo-correction crash if a typo occurs within the operand of a
function-style cast to a non-dependent type which is then used in an invalid
way. We'd lose the "t
On Thu, Jun 30, 2016 at 2:02 AM, David Chisnall wrote:
> On 29 Jun 2016, at 23:07, Richard Smith via cfe-dev <
> cfe-...@lists.llvm.org> wrote:
> >
> > Yes, those are real problems, but it's not reasonable for us to keep the
> default at C++98/03 forever. GCC has already taken the plunge here, so
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+}
EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+if (Size) {
Seems like you should push the cleanup before you emit the initializer; the
cleanup sh
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D21619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
On Fri, Jul 1, 2016 at 4:22 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Fri Jul 1 18:22:25 2016
> New Revision: 274403
>
> URL: http://llvm.org/viewvc/llvm-project?rev=274403&view=rev
> Log:
> Work around ABI break caused by C++17 inline variabl
On Fri, Jul 1, 2016 at 4:37 PM, Eric Fiselier wrote:
> The attribute is ignored unless it is placed on the in-class declaration
> of the member. It has no effect when applied to the explicit definition.
>
Ugh, right, attributes added after the definition aren't well-treated.
Seems reasonable to
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: rsmith
Date: Fri Jul 1 20:32:16 2016
New Revision: 274416
URL: http://llvm.org/viewvc/llvm-project?rev=274416&view=rev
Log:
PR28394: For compatibility with c++11 and c++14, if a static constexpr data
member is redundantly redeclared outside the class definition in code built in
c++17 mode
rsmith added a comment.
This looks really good. Some minor comments then this is ready to commit.
Comment at: include/clang/AST/Stmt.h:890
@@ -889,3 +889,3 @@
IfStmt(const ASTContext &C, SourceLocation IL,
- bool IsConstexpr, VarDecl *var, Expr *cond,
+ bool I
rsmith added a comment.
You have two independent functional changes in this patch: one adds a flag to
control the emission of timestamps into PCH files, and the other re-enables
timestamp checking on Win32. Please separate them out into distinct patches to
be committed separately.
Both parts o
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3861
@@ -3860,3 +3860,3 @@
// static data members until a definition of the variable is needed. We need
- // it right away if the type contains 'auto'.
+ // it right away if the type contains '
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3227
@@ -3226,1 +3226,3 @@
+def note_ovl_candidate_ambiguous_base_classes : Note<
+"candidate template ignored: ambiguous base classes of %0 match %1">;
ambiguous -> multipl
Author: rsmith
Date: Wed Jul 13 19:11:03 2016
New Revision: 275350
URL: http://llvm.org/viewvc/llvm-project?rev=275350&view=rev
Log:
P0305R0: Semantic analysis and code generation for C++17 init-statement for
'if' and 'switch':
if (stmt; condition) { ... }
Patch by Anton Bikineev! Some minor
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thank you again! I've fixed some over-long lines and committed this as r275350.
http://reviews.llvm.org/D21834
___
cfe-commits mailing list
cfe-c
Author: rsmith
Date: Wed Jul 13 19:14:59 2016
New Revision: 275351
URL: http://llvm.org/viewvc/llvm-project?rev=275351&view=rev
Log:
www/cxx_status: give more precise links to initialization order wording
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
h
On Thu, Jul 14, 2016 at 10:15 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> this fires on (at least) usrsctplib [1]:
>
> FAILED: obj/third_party/usrsctp/usrsctp/sctp_input.o
> ../../third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:1708:15:
> error: tak
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/ASTImporter.cpp:2253-2254
@@ +2252,4 @@
+ return nullptr;
+ }
+ else {
+ToRequiresClause = nullptr;
`else` on same line as `}` please.
https://reviews.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Yeah, I think this makes sense on balance, even though it does create a weird
situation for the `ASTPrinter` case, where we don't really want to transfer
ownership of the stream.
===
Author: rsmith
Date: Thu Jul 14 16:50:09 2016
New Revision: 275481
URL: http://llvm.org/viewvc/llvm-project?rev=275481&view=rev
Log:
[modules] Don't pass interesting decls to the consumer for a module file that's
passed on the command line but never actually used. We consider a (top-level)
module
Author: rsmith
Date: Thu Jul 14 17:15:06 2016
New Revision: 275490
URL: http://llvm.org/viewvc/llvm-project?rev=275490&view=rev
Log:
Add test inputs missed by r275481.
Added:
cfe/trunk/test/Modules/Inputs/unused-global-init/
cfe/trunk/test/Modules/Inputs/unused-global-init/init.h
cfe/
rsmith accepted this revision.
rsmith added a comment.
Thanks!
https://reviews.llvm.org/D22113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
It's not meaningful to ask whether a value-dependent expression is an integral
constant expression. The answer is not knowable, so the function asserting
doesn't seem unreasonable. Any value we returned from that function would be a
lie.
Repository:
rL LLVM
https://
On Thu, Jul 14, 2016 at 3:52 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Why did we upgrade the unaligned reference binding from a warning to an
> error? That will make it hard to roll this change out across many codebases.
>
GCC has given an error on this since versi
rsmith added a comment.
I don't see how this approach can work; the fact that we happened to ask the
expression evaluator to evaluate an expression is not sufficient reason for us
to issue this warning. For instance:
auto a = []{};
void (*p)() = a;
... will ask the evaluator to evaluate th
It appears that GCC accepts that case. More generally, it looks like GCC
suppresses the warning when the reference is a function parameter (any
function, not just a copy constructor or similar). I'm not sure if that's
an intentional feature or a bug, but it should be pretty easy for us to be
compat
OK, actually, GCC is doing something a lot more clever here.
Here's what seems to really be going on:
Packed members are modeled somewhat like bitfield members: a packed member
lvalue is a different kind of lvalue to which a reference cannot be bound
(like a bitfield). An attempt to bind a const
Author: rsmith
Date: Fri Jul 15 15:53:25 2016
New Revision: 275612
URL: http://llvm.org/viewvc/llvm-project?rev=275612&view=rev
Log:
Push alias-declarations and alias-template declarations into scope even if
they're redeclarations. This is necessary in order for name lookup to correctly
find the m
Author: rsmith
Date: Fri Jul 15 16:33:46 2016
New Revision: 275624
URL: http://llvm.org/viewvc/llvm-project?rev=275624&view=rev
Log:
Revert r275481, r275490. This broke modules bootstrap.
Removed:
cfe/trunk/test/Modules/Inputs/unused-global-init/
cfe/trunk/test/Modules/unused-global-init.
Author: rsmith
Date: Fri Jul 15 19:35:14 2016
New Revision: 275653
URL: http://llvm.org/viewvc/llvm-project?rev=275653&view=rev
Log:
Reimplement ExternalSemaSource delegation in terms of
MultiplexExternalSemaSource to remove one of the places that needs updating
every time the ExternalSemaSource i
Author: rsmith
Date: Sun Jul 17 14:24:51 2016
New Revision: 275727
URL: http://llvm.org/viewvc/llvm-project?rev=275727&view=rev
Log:
PR28589: attempt to work around MSVC rejects-valid.
Modified:
cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp
Modified: cfe/trunk/lib/Frontend/ChainedIncludes
Author: rsmith
Date: Sun Jul 17 15:00:59 2016
New Revision: 275730
URL: http://llvm.org/viewvc/llvm-project?rev=275730&view=rev
Log:
Attempt to work around MSVC rejects-valid, round 2.
Modified:
cfe/trunk/lib/Frontend/ChainedIncludesSource.cpp
Modified: cfe/trunk/lib/Frontend/ChainedIncludes
uilders/clang-x86-win2008-selfhost/builds/9110
>
> On Fri, Jul 15, 2016 at 5:35 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Fri Jul 15 19:35:14 2016
>> New Revision: 275653
>>
>> URL: http:
rsmith added a comment.
We stand no hope of being bug-for-bug compatible with MSVC's constant
expression evaluator -- we should assume there will be expressions that we
evaluate as a constant and they do not, and vice versa. For reference, we have
the same problem between code built by Clang an
Author: rsmith
Date: Fri Feb 26 20:36:43 2016
New Revision: 262105
URL: http://llvm.org/viewvc/llvm-project?rev=262105&view=rev
Log:
Fix bug in using shadow decl checking: a using shadow decl should not conflict
with a prior UsingDecl -- those should not even really be found by the lookup
here, ex
On Wed, Mar 2, 2016 at 12:06 PM, Aaron Ballman via cfe-commits
wrote:
> On Wed, Mar 2, 2016 at 2:01 PM, Julian Bangert via cfe-commits
> wrote:
>> This adds a matcher for C++ in Class initializers.
>>
>> ---
>> include/clang/ASTMatchers/ASTMatchers.h | 14 ++
>> unittests/ASTMatche
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM
Comment at: lib/Sema/SemaExpr.cpp:377
@@ +376,3 @@
+ auto *DRD = dyn_cast(CurContext);
+ if ((LangOpts.OpenMP != 0u) && (DRD != nullptr) &&
+
On 3 Mar 2016 3:18 a.m., "Argyrios Kyrtzidis via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Mind if we keep -fmodule-implementation-of as an alias so that we can
gradually transition to -fmodule-name ?
Sure, no problem.
> > On Feb 19, 2016, at 2:25 PM, R
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaOverload.cpp:1966-1967
@@ -1955,4 +1965,4 @@
// C99 6.3.1.5p1:
// When a float is promoted to double or long double, or a
Author: rsmith
Date: Fri Mar 4 15:01:14 2016
New Revision: 262743
URL: http://llvm.org/viewvc/llvm-project?rev=262743&view=rev
Log:
Update cxx_status with likely new features from Jacksonville WG21 meeting.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
Author: rsmith
Date: Fri Mar 4 15:27:21 2016
New Revision: 262747
URL: http://llvm.org/viewvc/llvm-project?rev=262747&view=rev
Log:
Implement P0036R0: remove support for empty unary folds of +, *, |, &.
Modified:
cfe/trunk/lib/Sema/SemaTemplateVariadic.cpp
cfe/trunk/test/SemaTemplate/cxx
Author: rsmith
Date: Fri Mar 4 16:32:06 2016
New Revision: 262753
URL: http://llvm.org/viewvc/llvm-project?rev=262753&view=rev
Log:
Update diagnostics now that hexadecimal literals look likely to be part of
C++17.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
cfe/trunk/i
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:772
@@ +771,3 @@
+def warn_cxx14_compat_constexpr_on_lambda : Warning<
+ "constexpr on lambda expressions are incompatible with C++14">,
+ InGroup, DefaultIgnore;
are -> is
==
Author: rsmith
Date: Mon Mar 7 18:32:55 2016
New Revision: 262881
URL: http://llvm.org/viewvc/llvm-project?rev=262881&view=rev
Log:
P0188R1: add support for standard [[fallthrough]] attribute. This is almost
exactly the same as clang's existing [[clang::fallthrough]] attribute, which
has been upd
Author: rsmith
Date: Mon Mar 7 18:34:49 2016
New Revision: 262882
URL: http://llvm.org/viewvc/llvm-project?rev=262882&view=rev
Log:
Add accidentally forgotten testcase from r262881.
Added:
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.fallthrough/
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.a
Author: rsmith
Date: Mon Mar 7 18:40:32 2016
New Revision: 262887
URL: http://llvm.org/viewvc/llvm-project?rev=262887&view=rev
Log:
Define __has_cpp_attribute(fallthrough) to a more reasonable value. (What year
is it?!)
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/test/Prep
Author: rsmith
Date: Mon Mar 7 18:44:49 2016
New Revision: 262888
URL: http://llvm.org/viewvc/llvm-project?rev=262888&view=rev
Log:
Move [[nodiscard]] tests into test/CXX tree.
Added:
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nod
Author: rsmith
Date: Mon Mar 7 18:45:37 2016
New Revision: 262889
URL: http://llvm.org/viewvc/llvm-project?rev=262889&view=rev
Log:
Use class="svn" for features with SVN status.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm
there for debug builds. I suppose this means projects now need an
> UNREACHED_CASE macro that expands to assert(false) in debug and to
> fallthrough in release (with clang; and to something else with other
> compilers)?
>
> On Mon, Mar 7, 2016 at 7:32 PM, Richard Smith via cfe-commits
projects now need an
>> > UNREACHED_CASE macro that expands to assert(false) in debug and to
>> > fallthrough in release (with clang; and to something else with other
>> > compilers)?
>> >
>> > On Mon, Mar 7, 2016 at 7:32 PM, Richard Smith via cfe-commits
Author: rsmith
Date: Tue Mar 8 16:17:41 2016
New Revision: 262963
URL: http://llvm.org/viewvc/llvm-project?rev=262963&view=rev
Log:
P0017R1: In C++1z, an aggregate class can have (public non-virtual) base
classes; these are initialized as if they were data members.
Added:
cfe/trunk/test/CXX
Author: rsmith
Date: Tue Mar 8 17:16:16 2016
New Revision: 262965
URL: http://llvm.org/viewvc/llvm-project?rev=262965&view=rev
Log:
Fix -Werror build.
Modified:
cfe/trunk/lib/CodeGen/CGExprAgg.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: rsmith
Date: Tue Mar 8 17:17:35 2016
New Revision: 262966
URL: http://llvm.org/viewvc/llvm-project?rev=262966&view=rev
Log:
Fix crash in access check for aggregate initialization of base classes. It's
not obvious how to access-check these, so pick a conservative rule until we get
feedback
Author: rsmith
Date: Tue Mar 8 18:12:38 2016
New Revision: 262971
URL: http://llvm.org/viewvc/llvm-project?rev=262971&view=rev
Log:
Readd testcase accidentally removed in r262888.
Modified:
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/p1.cpp
Modified: cfe/trunk/test/CXX/dcl.dcl/dc
rsmith added a comment.
`-f(no-)strict-nonnull-this` maybe?
http://reviews.llvm.org/D17993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Mar 10 13:22:21 2016
New Revision: 263155
URL: http://llvm.org/viewvc/llvm-project?rev=263155&view=rev
Log:
Add test for r263138.
Added:
cfe/trunk/test/SemaCXX/switch-implicit-fallthrough-off-by-default.cpp
Added: cfe/trunk/test/SemaCXX/switch-implicit-fallthrough-of
ng enabled?" and the warning
>>>> group contains multiple diagnostics, we don't check them all...
>>>>
>>>> There's an easy fix for clang: warn_fallthrough_attr_unreachable
>>>> should be marked DefaultIgnore.
>>>
&
On 14 Mar 2016 6:28 a.m., "Benjamin Kramer via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: d0k
> Date: Mon Mar 14 08:23:58 2016
> New Revision: 263429
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263429&view=rev
> Log:
> [Frontend] Disable value name discarding for all sanitiz
Author: rsmith
Date: Mon Mar 14 12:52:37 2016
New Revision: 263449
URL: http://llvm.org/viewvc/llvm-project?rev=263449&view=rev
Log:
[modules] Don't diagnose non-modular includes from modular files that are
implementation units of modules rather than interface units.
Added:
cfe/trunk/test/Mod
module]
> #import "blah.h"
> ^
> 1 error generated.
>
>
>
> On Mar 3, 2016, at 5:28 AM, Richard Smith via cfe-commits
> wrote:
>
> On 3 Mar 2016 3:18 a.m., "Argyrios Kyrtzidis via cfe-commits"
> wrote:
>>
>> Mind if we keep
On Mon, Mar 14, 2016 at 10:45 AM, Yaxun Liu via cfe-commits
wrote:
> yaxunl added a comment.
>
> Thanks for your comments.
>
> It works like this, e.g.
>
> $ cat prog.ll
> declare i32 @foo()
>
> define void @use_foo() {
>
> %a = call i32 @foo()
> ret void
>
> }
>
> $ cat lib_common.ll
> define
rsmith added inline comments.
Comment at: include/clang/AST/LambdaCapture.h:41
@@ -41,3 +40,3 @@
SourceLocation EllipsisLoc;
-
+ bool IsStarThis : 1;
friend class ASTStmtReader;
I'm not a fan of this representation. Please use `Capture_ByCopy` to indicate a
02/02/16 02:52, Richard Smith via cfe-commits wrote:
>>>
>>> On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev
>>> wrote:
>>>>
>>>> Would this patch be more reasonable? It follows what
>>>> RegisterTemplateSpecialization (introduced in r
rsmith added a comment.
All the changes other than 'modelled' look fine :) Do you need someone to
commit this for you?
Comment at: lib/AST/ASTContext.cpp:1631
@@ -1630,3 +1630,3 @@
case BuiltinType::OCLSampler:
- // Samplers are modeled as integers.
+ // Samplers
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:1732
@@ +1731,3 @@
+ unsigned FieldIdx = 0;
+ std::vector SeenFields;
+ RecordDecl::field_iterator FieldStart = Field;
Please use an `llvm::BitVector` here instead.
Comment at: li
rsmith added a subscriber: rsmith.
rsmith added a comment.
It seems useful to warn on this, but I'm concerned that there are valid code
patterns that this will warn about where there is no reasonable way to rewrite
the code that would suppress the warning. For instance:
template class X {
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1153
@@ -1152,3 +1152,3 @@
unsigned Virtuality = 0;
- unsigned VIndex = 0;
+ unsigned VIndex = -1u;
Is this what debug info consumers expect for the non-virtual case?
http://reviews.llv
rsmith added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:10419
@@ -10418,3 +10429,1 @@
- ResultTy) ||
- (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) {
Matches.push_back(std::make_pair(
---
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lib/Sema/SemaExprCXX.cpp:4698
@@ +4697,3 @@
+ // constraint that in the conversion the reference must bind directly to
+ // E1.
+ // -
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: include/clang/AST/LambdaCapture.h:48
@@ +47,3 @@
+ // by value or reference.
+ // - or, points to the VLASentinel if this represents a by VLA cap
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8380
@@ +8379,3 @@
+def warn_unused_abi_stability_attr : Warning<
+ "unused C++ ABI stability attribute on non-dynamic class">,
+ InGroup>;
How valuable is it to warn on this? I
rsmith added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:272-299
@@ -265,1 +271,30 @@
+ // abi_tag is a gcc attribute, taking one or more strings called "tags".
+ //
+ // The goal is to annotate against which version of a library an object was
+ // build and to be
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:2050
@@ +2049,3 @@
+if (!Result && isLambdaCallOperator(Frame->Callee) &&
+VD->getDeclContext() != Frame->Callee) {
+ // Assume variables referenced within a lambda's call operator that were
--
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:1815-1816
@@ -1814,1 +1814,4 @@
// worthwhile to skip over the rest of the initializer, though.
+ unsigned FieldIdx = 0;
+ unsigned MaxFieldIdx = 0;
+ llvm::BitVector SeenFields;
You don't need
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added a comment.
Have you done any performance testing on this code? In modules-heavy builds,
bitcode reading is *very* hot.
http://reviews.llvm.org/D17299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
rsmith added a comment.
Can you explain a bit more about the problem? It seems to me that if I have:
struct Base {
char k[1];
};
struct Derived : Base {};
... then the 'k' subobject of a `Derived` object is known to be exactly 1 byte
long -- it doesn't seem obviously appropriate for o
rsmith added a comment.
From a code standpoint, this looks fine to me, but I'd like to understand a bit
more about what you aim to achieve with the various parts here.
Comment at: include/clang/Frontend/CodeGenOptions.def:57
@@ -56,1 +56,3 @@
+CODEGENOPT(EmbedBitcode , 1,
rsmith added a comment.
Couple more things:
1. Please add some testing to tests/CXX/expr/expr.prim/expr.prim.lambda
2. Please update cxx_status.html
http://reviews.llvm.org/D18139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
3501 - 3600 of 4285 matches
Mail list logo
