mething like
template void f(T t) {
if (t) ...
}
with T being nullptr_t. That probably doesn't justify a warning.
> On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>>
>> Author: rsmith
>> Date: Tue Jul 19 15:35:09 2
Yes please :)
On 25 Jul 2016 10:13 p.m., "Vassil Vassilev via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> It could, it fixes a set of issues wrt to modules.
> On 25/07/16 22:39, Hans Wennborg wrote:
>
>> Should this be merged to 3.9?
>>
>> On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev
These all look OK for the branch. Hans, the second one fixes a crasher, so
I'd like to take at least that one. The others fix warning false positives
(which are not regressions) and look fairly safe.
On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote:
> Hans, Richard,
>
> These are some last mi
On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith wrote:
> These all look OK for the branch. Hans, the second one fixes a crasher, so
> I'd like to take at least that one. The others fix warning false positives
> (which are not regressions) and look fairly safe.
>
Correction: looks like the final on
rsmith added a subscriber: rsmith.
rsmith added a comment.
This doesn't seem like quite the right user interface for this feature. The
module cache is volatile, and it's not really reasonable for people to assume
they know what is and isn't within it. Instead, it seems like what we want to
prov
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:1483
@@ +1482,3 @@
+ HSOpts.ModulesUsePrebuiltModules ?
+ ASTReader::ARR_ConfigurationMismatch :
+ ARRF
rsmith added a comment.
Discussion on the core reflector suggests that we should use odr-style
equivalence when identifying the current instantiation, and not look through
static const member initializers as the example in the standard suggests. Let's
hold off on this until CWG has a chance to
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:1413
@@ +1412,3 @@
+for (auto *EnableIf : Method->specific_attrs()) {
+ if (EnableIf->getCond()->isTypeDependent())
+return false;
You should presumably be checking `isValueDependent` here
rsmith added a comment.
If `IncludePossibleEffects` is false, the goal of `HasSideEffect` is to
determine whether we think the user intended for the expression to have a
side-effect. It seems reasonable to assume that any use of an assignment
operator had that intent, so (since it seems like th
rsmith added inline comments.
Comment at: include/clang/Lex/HeaderSearchOptions.h:96-97
@@ -95,1 +95,4 @@
+ /// \brief The directory used to load prebuilt module files.
+ std::string PrebuiltModulePath;
+
It would seem preferable to allow multiple of these, to
Yes, this should be merged. It's not quite right, but it's certainly better
than what we had before.
On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote:
> Richard: ping?
>
> On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote:
> > Should this be merged to 3.9?
> >
> > Thanks,
> > Hans
> >
> >
Well, the whole approach here is still wrong (per the FIXME in
CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent.
Let's take this for 3.9 to at least stem the bleeding.
On Tue, Aug 9, 2016 at 11:57 AM, Hans Wennborg wrote:
> For the record, this was for PR28666.
>
> Rich
On Thu, Aug 11, 2016 at 1:38 PM, Faisal Vali wrote:
> On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith
> wrote:
> > Yes, this should be merged. It's not quite right, but it's certainly
> better
> > than what we had before.
>
> I would agree that the comment is broken - but, unless i'm missing
> s
Author: rsmith
Date: Thu Aug 11 17:25:46 2016
New Revision: 278435
URL: http://llvm.org/viewvc/llvm-project?rev=278435&view=rev
Log:
P0217R3: Perform semantic checks and initialization for the bindings in a
decomposition declaration for arrays, aggregate-like structs, tuple-like
types, and (as an
Author: rsmith
Date: Thu Aug 11 19:39:32 2016
New Revision: 278447
URL: http://llvm.org/viewvc/llvm-project?rev=278447&view=rev
Log:
P0217R3: Constant expression evaluation for decomposition declarations.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/lib/AST/DeclCXX.cpp
cf
Author: rsmith
Date: Thu Aug 11 19:53:41 2016
New Revision: 278448
URL: http://llvm.org/viewvc/llvm-project?rev=278448&view=rev
Log:
Remove unused and undesirable reference from BindingDecl to DecompositionDecl.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/lib/AST/DeclCXX.cpp
Author: rsmith
Date: Thu Aug 11 20:55:21 2016
New Revision: 278458
URL: http://llvm.org/viewvc/llvm-project?rev=278458&view=rev
Log:
P0217R3: template instantiation support for decomposition declarations.
Added:
cfe/trunk/test/SemaTemplate/cxx1z-decomposition.cpp
Modified:
cfe/trunk/inclu
Author: rsmith
Date: Thu Aug 11 21:21:25 2016
New Revision: 278460
URL: http://llvm.org/viewvc/llvm-project?rev=278460&view=rev
Log:
P0217R3: serialization/deserialization support for c++17 decomposition
declarations.
Added:
cfe/trunk/test/PCH/cxx1z-decomposition.cpp
Modified:
cfe/trunk/
rsmith added a comment.
Have you considered modelling this as an attribute on the declaration of the
variable instead of as a separate check? If so, why do you prefer this
approach? (If I were to suggest this for standardization, an attribute is the
approach I'd probably take.)
==
Sure, looks safe enough to me.
On 11 Aug 2016 9:23 p.m., "George Burgess IV"
wrote:
Hi Richard,
Would you mind if I merged this into the 3.9 branch? :)
Thanks,
George
On Thu, Aug 11, 2016 at 9:12 PM, George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Date
rsmith added a comment.
Attributes are specified in include/clang/Basic/Attr.td with a (hopefully)
fairly self-explanatory declarative syntax. You'll then need to add code to
lib/Sema/SemaDeclAttr.cpp to create a corresponding attribute object and attach
it to the declaration.
Two implementati
rsmith added a comment.
Sorry about the redundant previous comment, the thread got forked by the change
of subject and I missed the updated patch.
Comment at: lib/Sema/SemaDecl.cpp:10484-10485
@@ -10478,1 +10483,4 @@
+ if (var->hasAttr() && !Init)
+ Diag(var->getLocation
Author: rsmith
Date: Sun Aug 14 18:15:52 2016
New Revision: 278640
URL: http://llvm.org/viewvc/llvm-project?rev=278640&view=rev
Log:
Explicitly generate a reference variable to hold the initializer for a
tuple-like decomposition declaration. This significantly simplifies the
semantics of BindingDe
Author: rsmith
Date: Sun Aug 14 20:33:41 2016
New Revision: 278642
URL: http://llvm.org/viewvc/llvm-project?rev=278642&view=rev
Log:
P0217R3: code generation support for decomposition declarations.
Added:
cfe/trunk/test/CodeGenCXX/cxx1z-decomposition.cpp
Modified:
cfe/trunk/lib/AST/ASTCon
Author: rsmith
Date: Sun Aug 14 21:24:00 2016
New Revision: 278647
URL: http://llvm.org/viewvc/llvm-project?rev=278647&view=rev
Log:
Add a triple to this test to make buildbots happier.
Modified:
cfe/trunk/test/CodeGenCXX/cxx1z-decomposition.cpp
Modified: cfe/trunk/test/CodeGenCXX/cxx1z-deco
Author: rsmith
Date: Sun Aug 14 21:34:23 2016
New Revision: 278648
URL: http://llvm.org/viewvc/llvm-project?rev=278648&view=rev
Log:
Disable lambda-capture of decomposition declaration bindings for now, until CWG
agrees on how they're supposed to work.
Modified:
cfe/trunk/include/clang/Basic/
Author: rsmith
Date: Sun Aug 14 21:37:43 2016
New Revision: 278649
URL: http://llvm.org/viewvc/llvm-project?rev=278649&view=rev
Log:
cxx_status: mark decomposition declarations as "partial": the implementation is
essentially complete, other than parts where design questions have been raised
(lambd
Author: rsmith
Date: Sun Aug 14 21:47:23 2016
New Revision: 278650
URL: http://llvm.org/viewvc/llvm-project?rev=278650&view=rev
Log:
cxx_status: update features implemented in clang 3.9 from "svn" to "Clang 3.9"
now that svn trunk is 4.0.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cf
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:1546-1548
@@ -1545,5 +1549,5 @@
// definition of it, because parameters aren't "within" the definition.
if ((D->isTemplateParameter() || isa(D))
? isVisible(SemaRef, cast(DC))
: S
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4791-4802
@@ -4790,1 +4790,14 @@
+CallStackFrame *getNearestContainingCallFrame(CallStackFrame *CurFrame,
+ const VarDecl *VD) {
+ if (auto *FD =
+dyn_cas
rsmith added a comment.
This is a bug -- we intend to reuse `Stmt` nodes across the template and its
instantiations, but we should have separate `Decl` nodes in each instantiation
(otherwise the `Decl`'s parent will be wrong etc).
Comment at: lib/Sema/SemaTemplateInstantiate.c
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Some minor things, but feel free to commit after addressing them.
I agree that we should figure out what to do about the zero/undef
initialization separately.
Comment at: li
LGTM for 3.8.
On Wed, Jan 13, 2016 at 4:03 PM, Hans Wennborg wrote:
> Thanks! Richard, what say the code owner?
>
> On Wed, Jan 13, 2016 at 3:59 PM, George Burgess IV
> wrote:
>> FYI: This patch should to be merged into the clang 3.8.0 branch.
>>
>> Thank you!
>> George
>>
>> On Wed, Jan 13, 201
LGTM for 3.8.
On Thu, Jan 21, 2016 at 1:10 PM, Hans Wennborg wrote:
> Richard, it was suggested (in
> https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged
> to 3.8. I believe this falls under your ownership.
>
> On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits
> wr
On Mon, Jan 25, 2016 at 8:03 PM, Xiuli Pan via cfe-commits
wrote:
> Author: pxl
> Date: Mon Jan 25 22:03:48 2016
> New Revision: 258782
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258782&view=rev
> Log:
> Recommit: R258773 [OpenCL] Pipe builtin functions
> Fix arc patch fuzz error.
> Summary:
On Thu, Jan 28, 2016 at 11:25 AM, Hans Wennborg wrote:
> I don't think we have a specific code owner for OpenCL in Clang, which
> means Richard is the owner.
>
> Richard, what do you think?
Is there a reason we want to push this new feature into 3.8 rather
than waiting for the next release?
> On
On Thu, Jan 14, 2016 at 2:57 PM, Richard Trieu via cfe-commits
wrote:
> Author: rtrieu
> Date: Thu Jan 14 16:56:39 2016
> New Revision: 257831
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257831&view=rev
> Log:
> Refactor template type diffing
>
> 1) Instead of using pairs of From/To* fields,
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1525-1530
@@ -1524,18 +1524,8 @@
for (unsigned I = 0, E = FP.getNumParams(); I != E; ++I) {
-ParmVarDecl *P = FP.g
rsmith added a subscriber: rsmith.
Comment at: test/CodeGen/aapcs-bitfield.c:312-317
@@ +311,8 @@
+
+ // BE: %[[PTR3:.*]] = bitcast %struct.st5a* %[[PTR2]] to i32*
+ // BE-NEXT: %[[LD:.*]] = load volatile i32, i32* %[[PTR3]], align 4
+ // BE-NEXT: %[[CLR:.*]] = and i32 %[[LD]],
rsmith added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1598-1599
@@ -1597,1 +1597,4 @@
+// PS4 remains compatible to pre r257462 behavior.
+bool isPS4ABI = (Context.getTargetInfo().getCXXABI().getKind() ==
TargetCXXABI::PS4);
+
Please
On Thu, Jan 28, 2016 at 8:23 AM, Vassil Vassilev wrote:
> Would this patch be more reasonable? It follows what
> RegisterTemplateSpecialization (introduced in r245779) does. AFAICT this
> adds an update record far less often.
It's still adding redundant update records. We'll write the
appropriate
rsmith added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:374
@@ +373,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
I would prefer to not have a setter at all, but i
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Yuck. Yeah, LGTM. Do you need someone to commit this for you?
Hans, this should go into 3.8 as well.
http://reviews.llvm.org/D16819
___
cfe-comm
Author: rsmith
Date: Tue Feb 2 17:11:49 2016
New Revision: 259598
URL: http://llvm.org/viewvc/llvm-project?rev=259598&view=rev
Log:
Work around build failure due to GCC 4.8.1 bug. We don't completely understand
the details of the bug, but avoiding overloading llvm::cast with another
function temp
rsmith closed this revision.
rsmith added a comment.
Thanks, committed as r259598.
http://reviews.llvm.org/D16819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hans, this fixes a compile failure with one of our supported host
compilers (GCC 4.8.1). Can we get this patch into 3.8?
On Tue, Feb 2, 2016 at 3:11 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Tue Feb 2 17:11:49 2016
> New Revision: 259598
>
> URL: http://
Author: rsmith
Date: Tue Feb 2 17:34:49 2016
New Revision: 259604
URL: http://llvm.org/viewvc/llvm-project?rev=259604&view=rev
Log:
Fix rejects-valid when forming a pointer-to-member with 'decltype(expr)::*'.
Modified:
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/test/Parser/cxx0x-decl.cp
Author: rsmith
Date: Tue Feb 2 17:58:56 2016
New Revision: 259609
URL: http://llvm.org/viewvc/llvm-project?rev=259609&view=rev
Log:
PR24989: Stop trying to use the C++11 rules for lambda return type inference in
C++14 generic lambdas. It conflicts with the C++14 return type deduction
mechanism, a
Hi Guy,
> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428&r1=170427&r2=170428&view=diff
> ==
> --- cfe/trunk/lib/CodeGen/CGRTTI.cpp (orig
Author: rsmith
Date: Tue Feb 2 19:32:42 2016
New Revision: 259616
URL: http://llvm.org/viewvc/llvm-project?rev=259616&view=rev
Log:
Fix Itanium RTTI emission so that we emit fundamental type information into the
C++ ABI library for the same set of types for which we expect the C++ ABI
library to
Fixed as part of r259616.
On Tue, Feb 2, 2016 at 4:45 PM, Richard Smith wrote:
> Hi Guy,
>
>> Modified: cfe/trunk/lib/CodeGen/CGRTTI.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRTTI.cpp?rev=170428&r1=170427&r2=170428&view=diff
>> ===
Author: rsmith
Date: Tue Feb 2 19:43:59 2016
New Revision: 259618
URL: http://llvm.org/viewvc/llvm-project?rev=259618&view=rev
Log:
Fix typo in OpenCL type mangling. This is still bogus (we should either use the
actual source name of the typedef or a vendor mangling) but at least it stands
a chan
Author: rsmith
Date: Tue Feb 2 20:58:20 2016
New Revision: 259622
URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev
Log:
Fix miscompile and rejects-valids when disambiguating after an ambiguous
C-style-cast to function/array type or parenthesized function-style cast/array
indexing.
Mo
Author: rsmith
Date: Wed Feb 3 12:48:43 2016
New Revision: 259677
URL: http://llvm.org/viewvc/llvm-project?rev=259677&view=rev
Log:
Fix regression from r259622: the operand of an increment that is the operand of
a cast expression is not the operand of a cast expression itself, so if it's
parenthe
On Wed, Feb 3, 2016 at 9:30 AM, Renato Golin wrote:
> On 3 February 2016 at 02:58, Richard Smith via cfe-commits
> wrote:
>> Author: rsmith
>> Date: Tue Feb 2 20:58:20 2016
>> New Revision: 259622
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=259622&am
Author: rsmith
Date: Wed Feb 3 14:15:01 2016
New Revision: 259687
URL: http://llvm.org/viewvc/llvm-project?rev=259687&view=rev
Log:
Refactor conversion of deduced template arguments to reduce repetition.
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
Modified: cfe/trunk/lib/Sema/Sem
Author: rsmith
Date: Wed Feb 3 14:40:30 2016
New Revision: 259688
URL: http://llvm.org/viewvc/llvm-project?rev=259688&view=rev
Log:
Ensure that we substitute into the declaration of a template parameter pack
(that is not a pack expansion) during template argument deduction, even if we
deduced tha
On Wed, Feb 3, 2016 at 11:08 AM, Anastasia Stulova <
anastasia.stul...@arm.com> wrote:
> I think the main reason is that we have committed pipe type before the
> release branch was taken. It appears to have no use without the pipe
> builtin functions.
>
> Are there any risks of adding this now?
>
rsmith added inline comments.
Comment at: include/clang/Driver/Options.td:1463
@@ +1462,3 @@
+Group;
+def mnofloat128 : Flag<["-"], "mno-float128">,
+Group;
Per the mangling rules at the top of this file, this should be named
`mno_float128`.
On Wed, Feb 3, 2016 at 3:52 PM, Hubert Tong <
hubert.reinterpretc...@gmail.com> wrote:
> hubert.reinterpretcast added inline comments.
>
>
> Comment at: lib/Sema/SemaExpr.cpp:1156-1159
> @@ +1155,6 @@
> +
> + QualType LHSElemType = dyn_cast(LHSType) ?
> +cast(LHSType)->getEle
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D16148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith closed this revision.
rsmith added a comment.
Committed as r259836.
Repository:
rL LLVM
http://reviews.llvm.org/D16148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Feb 4 16:54:41 2016
New Revision: 259836
URL: http://llvm.org/viewvc/llvm-project?rev=259836&view=rev
Log:
PR25271: When attaching default template arguments to redeclarations of a
template, keep looking for default arguments if we see a template parameter
pack. There may
Author: rsmith
Date: Thu Feb 4 19:40:54 2016
New Revision: 259866
URL: http://llvm.org/viewvc/llvm-project?rev=259866&view=rev
Log:
[modules] Factor out common code to mark identifier being "from AST", and add a
call in one more place to reduce the size of identifier tables in non-leaf
modules. N
I suspect we'll need to do a little more than this: when we rebuild the
redeclaration chain, we should probably propagate the complete type to
later redeclarations in the same scope. Otherwise, if we import a module
that has a complete type and one that has an incomplete type, the
declaration found
This is causing my links to fail with:
FAILED: : && /usr/local/google/home/richardsmith/bin/clang++
-fcolor-diagnostics -std=c++11 -stdlib=libc++ -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings
-Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long
-Wcov
This build might be using gold, I don't recall how that machine is
configured. I won't be able to test the fix until tomorrow, hopefully the
bits will give you enough.
On 4 Feb 2016 7:07 p.m., "Chris Bieneman" wrote:
> Actually r259871 includes the code to cleanup the “bad” order file…
>
> -Chris
e" should work.
> On 05/02/16 02:50, Richard Smith via cfe-commits wrote:
>
> I suspect we'll need to do a little more than this: when we rebuild the
> redeclaration chain, we should probably propagate the complete type to
> later redeclarations in the same scope. Ot
Author: rsmith
Date: Fri Feb 5 13:03:40 2016
New Revision: 259901
URL: http://llvm.org/viewvc/llvm-project?rev=259901&view=rev
Log:
[modules] Separately track whether an identifier's preprocessor information and
name lookup information have changed since deserialization. For a C++ modules
build,
rsmith added a comment.
Thanks for tackling this!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6889
@@ +6888,3 @@
+def err_literal_operator_invalid_param : Error<
+ "invalid literal operator parameter type %0">;
+def err_literal_operator_param : Error<
---
ble?
>>
>
> It's not safe to call into Sema while we're in a partially-deserialized
> state. We know the only interesting case here is complete versus incomplete
> array types, so we don't need anything like the complexity of
> MergeVarDeclTypes -- something as e
Author: rsmith
Date: Fri Feb 5 20:06:43 2016
New Revision: 259976
URL: http://llvm.org/viewvc/llvm-project?rev=259976&view=rev
Log:
[modules] Compress files embedded into a .pcm file, to reduce the disk usage of
-fembed-all-files mode.
Added:
cfe/trunk/test/Modules/embed-files-compressed.cp
On 5 Feb 2016 11:12 p.m., "Dmitri Gribenko" wrote:
>
> On Fri, Feb 5, 2016 at 6:06 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Fri Feb 5 20:06:43 2016
> > New Revision: 259976
> >
> > URL: http://llvm.org/viewvc/llvm-
Author: rsmith
Date: Mon Feb 8 13:10:14 2016
New Revision: 260124
URL: http://llvm.org/viewvc/llvm-project?rev=260124&view=rev
Log:
Remove dead code.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
On Mon, Feb 8, 2016 at 10:46 AM, Jonathan Wakely via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 8 February 2016 at 18:31, H.J. Lu wrote:
> > On Mon, Feb 8, 2016 at 10:30 AM, Jonathan Wakely
> wrote:
> >> On 8 February 2016 at 18:26, Jonathan Wakely
> wrote:
> >>> On 8 February 2016 a
On Mon, Feb 8, 2016 at 11:25 AM, Vassil Vassilev
wrote:
> On 08/02/16 20:10, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Mon Feb 8 13:10:14 2016
>> New Revision: 260124
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260124&
rsmith added a comment.
Can we implement all of DR253 instead? (That is, don't restrict this change to
libstdc++'s types.) We don't have precise wording for DR253 yet, but do have
the guidance that "if the implicit default constructor initializes all
subobjects, no initializer should be require
rsmith added a comment.
In http://reviews.llvm.org/D16552#346678, @thakis wrote:
> Will do, thanks! In "If the implicit default constructor initializes all
> subobjects, no initializer should be required", is "initializes all
> subobjects meant recursively?
I think so, or more specifically, t
On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
> wrote:
> > On 8 February 2016 at 19:23, Richard Smith wrote:
> >> "POD for the purpose of layout" is defined in the Itanium C++ ABI here:
> >>
> >> http://mentorembedded.github.io/cxx-abi/abi.h
rsmith added a comment.
Thanks, this looks good. I think we can make the control flow a little more
obvious by moving the `return true;`s right after we emit each diagnostic, and
that also lets us remove the `goto`.
Comment at: lib/Sema/SemaDeclCXX.cpp:11769
@@ +11768,3 @@
+st
On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>
> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith wrote:
> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
> >>
> >> On Mon, Feb 8, 2016 at 11:33 AM, Jonathan Wakely
> >> wrote:
> >> > On 8 February 2016 at 19:23, Richard Smith wrote:
> >> >> "P
Do we really need an 'empty type' special case?
The x86_64 psABI already seems clear that empty types with size <= 16
are not passed at all. Following the algorithm in section 3.2.3, each
eightbyte is classified as NO_CLASS, and thus is not passed. So the
proposed change would only affect the beha
On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>>>
>>> On Mon, Feb 8, 2016 at 12:38 PM, Richard Smith
>>> wrote:
>>> > On Mon, Feb 8, 2016 at 12:05 PM, H.J. Lu wrote:
>>> >>
>>> >> On Mon,
On Mon, Feb 8, 2016 at 2:49 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:42 PM, Richard Smith wrote:
>> Do we really need an 'empty type' special case?
>>
>> The x86_64 psABI already seems clear that empty types with size <= 16
>> are not passed at all. Following the algorithm in section 3.2.3,
On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
>>> On Mon, Feb 8, 2016 at 2:35 PM, Richard Smith wrote:
On Mon, Feb 8, 2016 at 1:40 PM, H.J. Lu wrote:
>
> On Mon, Feb 8, 2016 a
On Mon, Feb 8, 2016 at 3:01 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:58 PM, Richard Smith wrote:
>> On Mon, Feb 8, 2016 at 2:54 PM, H.J. Lu wrote:
>>> On Mon, Feb 8, 2016 at 2:51 PM, Richard Smith wrote:
On Mon, Feb 8, 2016 at 2:46 PM, H.J. Lu wrote:
> On Mon, Feb 8, 2016 at 2:35
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
OK, let's go ahead with this approach for now; we can investigate replacing the
implementation with a `PrintingPolicy` flag later.
Comment at: lib/Tooling/Core/QualTypeNames.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks great, thanks, do you need someone to commit this for you?
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.ll
Thanks!
On Sun, Feb 7, 2016 at 1:00 PM, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Sun Feb 7 15:00:17 2016
> New Revision: 260056
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260056&view=rev
> Log:
> Disable failing nozlibcompress.c
>
> This test hasn't been running after it wa
Author: rsmith
Date: Mon Feb 8 19:05:04 2016
New Revision: 260181
URL: http://llvm.org/viewvc/llvm-project?rev=260181&view=rev
Log:
Fix undefined behavior when compiling in C++14 due to sized operator delete
being called with the wrong size: convert CGFunctionInfo to use TrailingObjects
and ask T
Author: rsmith
Date: Mon Feb 8 19:57:24 2016
New Revision: 260189
URL: http://llvm.org/viewvc/llvm-project?rev=260189&view=rev
Log:
Remove 'llvm::TrailingObjects::operator delete', clang side.
Modified:
cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h
Modified: cfe/trunk/include/clang/CodeG
On Tue, Feb 9, 2016 at 9:03 AM, Cong Liu via cfe-commits
wrote:
> Hi Richard,
>
> I need to use the function (line 747 of ASTMatchFinder.cpp):
>
> static CXXRecordDecl *getAsCXXRecordDecl(const Type *TypeNode)
>
> in the misc-virtual-near-miss check of clang-tidy, because it can correctly
> get
Patch looks good. Please also add a testcase to test/Headers.
On Tue, Feb 9, 2016 at 12:08 PM, Hubert Tong via cfe-commits
wrote:
> I see no immediate issue with this patch, but I am not one of the usual
> reviewers for this part of the code base.
>
> -- HT
>
>
> On Tue, Feb 9, 2016 at 2:56 PM, J
Author: rsmith
Date: Tue Feb 9 14:59:05 2016
New Revision: 260277
URL: http://llvm.org/viewvc/llvm-project?rev=260277&view=rev
Log:
Simplify and rename ASTMatchFinder's getCXXRecordDecl to make it more obvious
what it's actually trying to do.
Modified:
cfe/trunk/lib/ASTMatchers/ASTMatchFinde
Author: rsmith
Date: Tue Feb 9 15:04:04 2016
New Revision: 260278
URL: http://llvm.org/viewvc/llvm-project?rev=260278&view=rev
Log:
Add Tooling functionality to get a name for a QualType that can be used to name
that type from the global scope.
Patch by Sterling Augustine, derived (with permissi
rsmith closed this revision.
rsmith added a comment.
In r260278.
http://reviews.llvm.org/D15861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Feb 9 16:34:35 2016
New Revision: 260307
URL: http://llvm.org/viewvc/llvm-project?rev=260307&view=rev
Log:
PR26349: correctly check whether a digit sequence is empty in the presence of
digit separators.
Modified:
cfe/trunk/include/clang/Lex/LiteralSupport.h
cfe/
Author: rsmith
Date: Tue Feb 9 16:48:14 2016
New Revision: 260311
URL: http://llvm.org/viewvc/llvm-project?rev=260311&view=rev
Log:
Update documentation to reflect that libc++abi provides __cxa_thread_atexit
(and has for quite a while). Also document that we have not yet implemented the
new inh
On Tue, Feb 9, 2016 at 2:43 PM, Jorge Teixeira
wrote:
> Richard,
>
> Can you be more specific?
>
> I assume you mean something like my newly attached .h file that tests
> very basic implementation compliance (i.e., it's required, but not
> sufficient), but I would need a bit more guidance about th
3001 - 3100 of 4285 matches
Mail list logo
