r288449 - Recover better from an incompatible .pcm file being provided by -fmodule-file=.

2016-12-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 1 19:52:28 2016 New Revision: 288449 URL: http://llvm.org/viewvc/llvm-project?rev=288449&view=rev Log: Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing t

r288452 - p0012r1: define corresponding feature test macro

2016-12-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 1 20:02:23 2016 New Revision: 288452 URL: http://llvm.org/viewvc/llvm-project?rev=288452&view=rev Log: p0012r1: define corresponding feature test macro Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trunk/test/Lexer/cxx-features.cpp Modified: cfe/

[libcxxabi] r288457 - Update implementation of ABI support for throwing noexcept function pointers

2016-12-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 1 20:06:53 2016 New Revision: 288457 URL: http://llvm.org/viewvc/llvm-project?rev=288457&view=rev Log: Update implementation of ABI support for throwing noexcept function pointers and catching as non-noexcept to match the final design per discusson on cxx-abi-dev. Mo

Re: [libcxxabi] r288457 - Update implementation of ABI support for throwing noexcept function pointers

2016-12-02 Thread Richard Smith via cfe-commits
> On 2 December 2016 at 10:13, Renato Golin wrote: > > On 2 December 2016 at 02:06, Richard Smith via cfe-commits > > wrote: > >> Author: rsmith > >> Date: Thu Dec 1 20:06:53 2016 > >> New Revision: 288457 > >> > >> URL: http://llvm.o

[libcxxabi] r288539 - Fix up r288457 for compilers that don't support noexcept function types:

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 15:43:36 2016 New Revision: 288539 URL: http://llvm.org/viewvc/llvm-project?rev=288539&view=rev Log: Fix up r288457 for compilers that don't support noexcept function types: disable the test entirely for those cases. This is a quick patch, I'll look at a proper feat

Re: [libcxxabi] r288457 - Update implementation of ABI support for throwing noexcept function pointers

2016-12-02 Thread Richard Smith via cfe-commits
een a while, and new patches are coming. Should we just revert >> this for now? >> >> --renato >> >> On 2 December 2016 at 10:13, Renato Golin >> wrote: >> > On 2 December 2016 at 02:06, Richard Smith via cfe-commits >> > wrote: >> >&

[libcxxabi] r288543 - Check for SD-6 feature test macro when determining which tests should be

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 16:14:59 2016 New Revision: 288543 URL: http://llvm.org/viewvc/llvm-project?rev=288543&view=rev Log: Check for SD-6 feature test macro when determining which tests should be available, rather than #ifdef'ing away the relevant tests if it's unavailable. Modified:

r288545 - Mass-rename the handful of error_* diagnostics to err_*.

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 16:38:31 2016 New Revision: 288545 URL: http://llvm.org/viewvc/llvm-project?rev=288545&view=rev Log: Mass-rename the handful of error_* diagnostics to err_*. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td cfe/trunk/include/clang/Basic/Diagn

r288548 - More diagnostic name fixups: w_ -> warn_, warning_ -> warn_, not_ -> note_.

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 17:00:28 2016 New Revision: 288548 URL: http://llvm.org/viewvc/llvm-project?rev=288548&view=rev Log: More diagnostic name fixups: w_ -> warn_, warning_ -> warn_, not_ -> note_. In passing, add a warning group for "ignored qualifier in inline assembly" warnings. Mo

r288558 - PR31244: Use the exception specification from the callee's type directly to

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 18:29:06 2016 New Revision: 288558 URL: http://llvm.org/viewvc/llvm-project?rev=288558&view=rev Log: PR31244: Use the exception specification from the callee's type directly to compute whether a call is noexcept, even if we can't map the callee expression to a calle

r288563 - DR616, and part of P0135R1: member access (or pointer-to-member access) on a

2016-12-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 2 19:14:32 2016 New Revision: 288563 URL: http://llvm.org/viewvc/llvm-project?rev=288563&view=rev Log: DR616, and part of P0135R1: member access (or pointer-to-member access) on a temporary produces an xvalue, not a prvalue. Support this by materializing the temporary

Re: r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules se

2016-12-04 Thread Richard Smith via cfe-commits
On 4 Dec 2016 2:44 pm, "Daniel Jasper via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: djasper Date: Sun Dec 4 16:34:37 2016 New Revision: 288626 URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev Log: Revert "Recover better from an incompatible .pcm file being provided by

r288654 - DR1213: element access on an array xvalue or prvalue produces an xvalue. In the

2016-12-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Dec 5 01:49:14 2016 New Revision: 288654 URL: http://llvm.org/viewvc/llvm-project?rev=288654&view=rev Log: DR1213: element access on an array xvalue or prvalue produces an xvalue. In the latter case, a temporary array object is materialized, and can be lifetime-extended b

Re: [PATCH] D27334: [OpenCL] Ambiguous function call.

2016-12-05 Thread Richard Smith via cfe-commits
On 5 Dec 2016 9:42 am, "Anastasia Stulova via Phabricator via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Anastasia added a comment. In https://reviews.llvm.org/D27334#612858, @bader wrote: > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > This change seems to modify nor

Re: [PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

2016-12-05 Thread Richard Smith via cfe-commits
On 5 December 2016 at 11:34, Mehdi AMINI via Phabricator < revi...@reviews.llvm.org> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D26376#597614, @mclow.lists wrote: > > > More info - The following code: > > > > #include > > int main () {} > > > > > > fails to compile

r288737 - [modules] Use the "redundant #include" diagnostic rather than the "module

2016-12-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Dec 5 18:12:39 2016 New Revision: 288737 URL: http://llvm.org/viewvc/llvm-project?rev=288737&view=rev Log: [modules] Use the "redundant #include" diagnostic rather than the "module import can't appear here" diagnostic if an already-visible module is textually entered (bec

r288738 - Additional test file missed from r288737.

2016-12-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Dec 5 18:14:22 2016 New Revision: 288738 URL: http://llvm.org/viewvc/llvm-project?rev=288738&view=rev Log: Additional test file missed from r288737. Added: cfe/trunk/test/Modules/redundant-include.mm Added: cfe/trunk/test/Modules/redundant-include.mm URL: http://ll

r288741 - Revert r288626, which reverts r288449. Original commit message:

2016-12-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Dec 5 18:40:17 2016 New Revision: 288741 URL: http://llvm.org/viewvc/llvm-project?rev=288741&view=rev Log: Revert r288626, which reverts r288449. Original commit message: Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include t

Re: r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules se

2016-12-05 Thread Richard Smith via cfe-commits
On 4 December 2016 at 20:44, Richard Smith wrote: > On 4 Dec 2016 2:44 pm, "Daniel Jasper via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: djasper > Date: Sun Dec 4 16:34:37 2016 > New Revision: 288626 > > URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev > Log: > R

r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 6 17:52:28 2016 New Revision: 288866 URL: http://llvm.org/viewvc/llvm-project?rev=288866&view=rev Log: [c++17] P0135R1: Guaranteed copy elision. When an object of class type is initialized from a prvalue of the same type (ignoring cv qualifications), use the prvalue

r288870 - Fix test.

2016-12-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 6 18:24:40 2016 New Revision: 288870 URL: http://llvm.org/viewvc/llvm-project?rev=288870&view=rev Log: Fix test. Modified: cfe/trunk/test/SemaCXX/cxx1z-copy-omission.cpp Modified: cfe/trunk/test/SemaCXX/cxx1z-copy-omission.cpp URL: http://llvm.org/viewvc/llvm-p

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Richard Smith via cfe-commits
On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: malcolm.parsons Date: Wed Dec 7 11:39:04 2016 New Revision: 288923 URL: http://llvm.org/viewvc/llvm-project?rev=288923&view=rev Log: [RecursiveASTVisitor] Fix post-order traversal of UnaryOperat

Re: r288923 - [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator

2016-12-07 Thread Richard Smith via cfe-commits
On 7 December 2016 at 10:11, Malcolm Parsons wrote: > On 7 December 2016 at 17:56, Richard Smith wrote: > > On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits" > > wrote: > > > > Author: malcolm.parsons > > Date: Wed Dec 7 11:39:04 2016 > > New Revision: 288923 > > > > URL: http://llvm.or

r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Dec 7 20:49:07 2016 New Revision: 289019 URL: http://llvm.org/viewvc/llvm-project?rev=289019&view=rev Log: [c++1z] P0003R5: Removing dynamic exception specifications. We continue to support dynamic exception specifications in C++1z as an extension, but produce an error-b

r289021 - [c++1z] P0490R0, NB comment GB 20: if std::tuple_size is complete, use the

2016-12-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Dec 7 21:24:55 2016 New Revision: 289021 URL: http://llvm.org/viewvc/llvm-project?rev=289021&view=rev Log: [c++1z] P0490R0, NB comment GB 20: if std::tuple_size is complete, use the tuple-like interpretation of decomposition declaration even if there is no ::value member.

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

2016-12-08 Thread Richard Smith via cfe-commits
m.buffers/streambuf/streambuf.cons/copy.fail.cpp down to this commit. > > I will follow up once I have a better understanding what is going on there. > > -- adrian > >> On Dec 6, 2016, at 3:52 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: >> &g

r289250 - DR1295 and cleanup for P0135R1: Make our initialization code more directly

2016-12-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 9 12:49:13 2016 New Revision: 289250 URL: http://llvm.org/viewvc/llvm-project?rev=289250&view=rev Log: DR1295 and cleanup for P0135R1: Make our initialization code more directly mirror the description in the standard. Per DR1295, this means that binding a const / rval

r289255 - cxx_dr_status: update to latest issue list and add a couple more tests.

2016-12-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 9 13:11:50 2016 New Revision: 289255 URL: http://llvm.org/viewvc/llvm-project?rev=289255&view=rev Log: cxx_dr_status: update to latest issue list and add a couple more tests. Modified: cfe/trunk/test/CXX/drs/dr15xx.cpp cfe/trunk/test/CXX/drs/dr16xx.cpp cf

r289258 - Add tests for a couple more DRs.

2016-12-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 9 13:35:45 2016 New Revision: 289258 URL: http://llvm.org/viewvc/llvm-project?rev=289258&view=rev Log: Add tests for a couple more DRs. Added: cfe/trunk/test/CXX/drs/dr118.cpp cfe/trunk/test/CXX/drs/dr158.cpp Modified: cfe/trunk/test/CXX/drs/dr0xx.cpp

Re: [PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

2016-12-09 Thread Richard Smith via cfe-commits
On 9 December 2016 at 03:59, Richard Smith via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rsmith added a comment. > > Looks like we might only be making macros visible, and failing to emit the > annot_module_import token for Sema. Hmm, no, we inject that token immediately

r289286 - [c++17] P0490R0, NB comment FI 20: allow direct-initialization of decomposition declarations.

2016-12-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Dec 9 16:56:20 2016 New Revision: 289286 URL: http://llvm.org/viewvc/llvm-project?rev=289286&view=rev Log: [c++17] P0490R0, NB comment FI 20: allow direct-initialization of decomposition declarations. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: r289019 - [c++1z] P0003R5: Removing dynamic exception specifications.

2016-12-10 Thread Richard Smith via cfe-commits
Thanks Eric! On 10 Dec 2016 5:58 pm, "Eric Fiselier via cfe-commits" < cfe-commits@lists.llvm.org> wrote: To others who follow the libc++abi test failures back to this commit: The unwind_* failures have been addressed in r289353 by using -Wno-dynamic-exception-spec to suppress the C++17 behavior

r289413 - Add two new AST nodes to represent initialization of an array in terms of

2016-12-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Dec 11 20:53:20 2016 New Revision: 289413 URL: http://llvm.org/viewvc/llvm-project?rev=289413&view=rev Log: Add two new AST nodes to represent initialization of an array in terms of initialization of each array element: * ArrayInitLoopExpr is a prvalue of array type with

r289618 - Remove custom handling of array copies in lambda by-value array capture and

2016-12-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 13 18:03:17 2016 New Revision: 289618 URL: http://llvm.org/viewvc/llvm-project?rev=289618&view=rev Log: Remove custom handling of array copies in lambda by-value array capture and copy constructors of classes with array members, instead using ArrayInitLoopExpr to repre

r289623 - When emitting a multidimensional array copy, only emit a single flattened

2016-12-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 13 19:32:13 2016 New Revision: 289623 URL: http://llvm.org/viewvc/llvm-project?rev=289623&view=rev Log: When emitting a multidimensional array copy, only emit a single flattened cleanup loop for exception handling. Modified: cfe/trunk/lib/CodeGen/CGExprAgg.cpp

r289630 - [c++1z] P0217R3: Allow by-value structured binding of arrays.

2016-12-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 13 21:22:16 2016 New Revision: 289630 URL: http://llvm.org/viewvc/llvm-project?rev=289630&view=rev Log: [c++1z] P0217R3: Allow by-value structured binding of arrays. Modified: cfe/trunk/include/clang/Sema/Initialization.h cfe/trunk/lib/Sema/SemaDecl.cpp cf

r300762 - Fix assertion failure in codegen on non-template deduction guide.

2017-04-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 19 16:15:45 2017 New Revision: 300762 URL: http://llvm.org/viewvc/llvm-project?rev=300762&view=rev Log: Fix assertion failure in codegen on non-template deduction guide. Added: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified: cfe/trunk/lib/CodeGen

r300803 - Add a triple to codegen test.

2017-04-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 19 20:02:29 2017 New Revision: 300803 URL: http://llvm.org/viewvc/llvm-project?rev=300803&view=rev Log: Add a triple to codegen test. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp URL:

Re: r300762 - Fix assertion failure in codegen on non-template deduction guide.

2017-04-19 Thread Richard Smith via cfe-commits
ilders/llvm-clang-x86_64- > expensive-checks-win/builds/1267 > > Please have a look at this? > > Thanks > > Galina > > > > On Wed, Apr 19, 2017 at 2:15 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmit

r300805 - PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides.

2017-04-19 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 19 20:15:31 2017 New Revision: 300805 URL: http://llvm.org/viewvc/llvm-project?rev=300805&view=rev Log: PR32673: Don't wrap parameter packs in SubstTemplateTypeParmPackType nodes when forming implicit deduction guides. Doing so thwarts template type deduction. Instea

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-20 Thread Richard Smith via cfe-commits
>>> libstdc++'s __alloctr_rebind (undefined template with a default argument, >>> specializations, etc): >>> https://github.com/gcc-mirror/gcc/blob/gcc-4_9-branch/ >>> libstdc++-v3/include/bits/alloc_traits.h#L58-L73 >>> >>> At least, I&#x

r300938 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 20 20:15:13 2017 New Revision: 300938 URL: http://llvm.org/viewvc/llvm-project?rev=300938&view=rev Log: [modules] Properly look up the owning module for an instantiation of a merged template. When looking for the template instantiation pattern of a templated entity,

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

2017-04-20 Thread Richard Smith via cfe-commits
o debug, but let me know if not. I'm >>> going to revert this temporarily to unbreak our modules builds using this >>> version of libstdc++. >>> >>> On Tue, Apr 18, 2017 at 8:14 PM Chandler Carruth >>> wrote: >>> >>>> This appears to

r301056 - P0629R0: Switch to latest proposal for distinguishing module interface from implementation.

2017-04-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 21 17:39:18 2017 New Revision: 301056 URL: http://llvm.org/viewvc/llvm-project?rev=301056&view=rev Log: P0629R0: Switch to latest proposal for distinguishing module interface from implementation. This switches from the prototype syntax in P0273R0 ('module' and 'modul

r301066 - Rearrange some Modules TS testcases into test/CXX/modules-ts.

2017-04-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 21 19:47:53 2017 New Revision: 301066 URL: http://llvm.org/viewvc/llvm-project?rev=301066&view=rev Log: Rearrange some Modules TS testcases into test/CXX/modules-ts. Added: cfe/trunk/test/CXX/modules-ts/ cfe/trunk/test/CXX/modules-ts/basic/ cfe/trunk/test/

r301271 - [modules ts] Diagnose 'export' declarations outside of a module interface.

2017-04-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Apr 24 18:12:30 2017 New Revision: 301271 URL: http://llvm.org/viewvc/llvm-project?rev=301271&view=rev Log: [modules ts] Diagnose 'export' declarations outside of a module interface. Added: cfe/trunk/test/CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.interface/p1.cpp M

r301285 - Placate MSVC's narrowing conversion unhappiness.

2017-04-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Apr 24 19:40:40 2017 New Revision: 301285 URL: http://llvm.org/viewvc/llvm-project?rev=301285&view=rev Log: Placate MSVC's narrowing conversion unhappiness. Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp URL:

r301442 - Refactor frontend InputKind to prepare for treating module maps as a distinct kind of input.

2017-04-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 26 13:57:40 2017 New Revision: 301442 URL: http://llvm.org/viewvc/llvm-project?rev=301442&view=rev Log: Refactor frontend InputKind to prepare for treating module maps as a distinct kind of input. No functionality change intended. Modified: cfe/trunk/include/cla

r301497 - Don't accept -std= values that would switch us to a different source language.

2017-04-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 26 18:44:33 2017 New Revision: 301497 URL: http://llvm.org/viewvc/llvm-project?rev=301497&view=rev Log: Don't accept -std= values that would switch us to a different source language. We already prohibited this in most cases (in r130710), but had some bugs in our enfor

r301500 - Remove unnecessary and somewhat inaccurate "C89" flag from language standards.

2017-04-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 26 18:49:57 2017 New Revision: 301500 URL: http://llvm.org/viewvc/llvm-project?rev=301500&view=rev Log: Remove unnecessary and somewhat inaccurate "C89" flag from language standards. Modified: cfe/trunk/include/clang/Frontend/LangStandard.h cfe/trunk/include/c

r301507 - Improve diagnostics for bad -std= flag.

2017-04-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 26 20:17:05 2017 New Revision: 301507 URL: http://llvm.org/viewvc/llvm-project?rev=301507&view=rev Log: Improve diagnostics for bad -std= flag. Don't list deprecated -std= values (c++0x etc). Only produce one line of output per standard, even if we know it by multiple

r301610 - Move functionality for handling module maps as inputs from the -emit-module

2017-04-27 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 27 20:49:42 2017 New Revision: 301610 URL: http://llvm.org/viewvc/llvm-project?rev=301610&view=rev Log: Move functionality for handling module maps as inputs from the -emit-module action to the general FrontendAction infrastructure. This permits applying -E, -ast-dump

r301725 - Add pragma to perform module import and use it in -E output.

2017-04-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 28 19:34:47 2017 New Revision: 301725 URL: http://llvm.org/viewvc/llvm-project?rev=301725&view=rev Log: Add pragma to perform module import and use it in -E output. Many of our supported configurations support modules but do not have any first-class syntax to perform

r301726 - Remove unused, empty test directories.

2017-04-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 28 19:46:27 2017 New Revision: 301726 URL: http://llvm.org/viewvc/llvm-project?rev=301726&view=rev Log: Remove unused, empty test directories. Removed: cfe/trunk/test/Frontend/Rewriter/ ___ cfe-commits mailing list cfe-

r301727 - PR26771: don't forget the " 2" (returning from #included file) linemarker after including an empty file with -frewrite-includes.

2017-04-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 28 19:54:03 2017 New Revision: 301727 URL: http://llvm.org/viewvc/llvm-project?rev=301727&view=rev Log: PR26771: don't forget the " 2" (returning from #included file) linemarker after including an empty file with -frewrite-includes. Added: cfe/trunk/test/Frontend

r301731 - Fix "REQUIRES: system-darwin" failing tests after r301725.

2017-04-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 28 20:29:44 2017 New Revision: 301731 URL: http://llvm.org/viewvc/llvm-project?rev=301731&view=rev Log: Fix "REQUIRES: system-darwin" failing tests after r301725. Also remove the apparently-unneeded REQUIRES (the tests also pass on at least Linux, and don't appear to

r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

2017-04-28 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Apr 28 20:38:29 2017 New Revision: 301732 URL: http://llvm.org/viewvc/llvm-project?rev=301732&view=rev Log: Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests. Let's see if any buildbots actually have trouble with these. (They at least pass on Linux.

r301822 - Improve handling of arrays of unknown bound in constant expressions.

2017-05-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 1 13:49:04 2017 New Revision: 301822 URL: http://llvm.org/viewvc/llvm-project?rev=301822&view=rev Log: Improve handling of arrays of unknown bound in constant expressions. Do not spuriously reject constexpr functions that access elements of an array of unknown bound;

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

2017-05-01 Thread Richard Smith via cfe-commits
for non-asan'd builds of clang? On 1 May 2017 at 10:54, Vitaly Buka wrote: > > crash-vfs-ivfsoverlay.m does not work > > http://lab.llvm.org:8011/builders/sanitizer-x86_64- > linux-bootstrap/builds/1322/steps/check-clang%20asan/logs/stdio > > > On Fri, Apr 28, 2

r301840 - Put back REQUIRES: system-darwin to fix asan bot.

2017-05-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 1 16:49:54 2017 New Revision: 301840 URL: http://llvm.org/viewvc/llvm-project?rev=301840&view=rev Log: Put back REQUIRES: system-darwin to fix asan bot. These tests do not appear to be Darwin-specific, and this REQUIRES: appears to be hiding a real bug; this change i

r301846 - Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

2017-05-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 1 17:10:47 2017 New Revision: 301846 URL: http://llvm.org/viewvc/llvm-project?rev=301846&view=rev Log: Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas. If a file has no diagnostic pragmas, we build its diagnostic state lazily, bu

r301847 - New file missed from r301846.

2017-05-01 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 1 17:11:08 2017 New Revision: 301847 URL: http://llvm.org/viewvc/llvm-project?rev=301847&view=rev Log: New file missed from r301846. Added: cfe/trunk/test/Modules/Inputs/diag_flags.h Added: cfe/trunk/test/Modules/Inputs/diag_flags.h URL: http://llvm.org/viewvc/

Re: r301846 - Fix initial diagnostic state setup for an explicit module with no diagnostic pragmas.

2017-05-02 Thread Richard Smith via cfe-commits
y 2, 2017 at 7:23 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon May 1 17:10:47 2017 > New Revision: 301846 > > URL: http://llvm.org/viewvc/llvm-project?rev=301846&view=rev > Log: > Fix initial diagnostic state setup

Re: r301963 - Revert r301822 (and dependent r301825), which tried to improve the

2017-05-02 Thread Richard Smith via cfe-commits
On 2 May 2017 at 12:21, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Tue May 2 14:21:42 2017 > New Revision: 301963 > > URL: http://llvm.org/viewvc/llvm-project?rev=301963&view=rev > Log: > Revert r301822 (and dependent r301825), which tried to impr

r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 2 19:28:49 2017 New Revision: 301992 URL: http://llvm.org/viewvc/llvm-project?rev=301992&view=rev Log: [modules] Round-trip -Werror flag through explicit module build. The intent for an explicit module build is that the diagnostics produced within the module are thos

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-03 Thread Richard Smith via cfe-commits
correct recursion check in EmitCurrentDiagnostic too. > I will commit a fix for this now. > Thank you! > Alex > > > On 3 May 2017 at 01:28, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Tue May 2 19:2

Re: r302037 - DiagnosticsEngine should clear DelayedDiagID before reporting the

2017-05-03 Thread Richard Smith via cfe-commits
On 3 May 2017 at 08:41, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Wed May 3 10:41:16 2017 > New Revision: 302037 > > URL: http://llvm.org/viewvc/llvm-project?rev=302037&view=rev > Log: > DiagnosticsEngine should clear DelayedDiagID before reportin

r302098 - Add #pragma clang module begin/end pragmas and generate them when preprocessing a module.

2017-05-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 3 19:29:54 2017 New Revision: 302098 URL: http://llvm.org/viewvc/llvm-project?rev=302098&view=rev Log: Add #pragma clang module begin/end pragmas and generate them when preprocessing a module. These pragmas are intended to simulate the effect of entering or leaving

r302309 - Add support for building modules from preprocessed source.

2017-05-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 5 17:18:51 2017 New Revision: 302309 URL: http://llvm.org/viewvc/llvm-project?rev=302309&view=rev Log: Add support for building modules from preprocessed source. To support this, an optional marker "#pragma clang module contents" is recognized in module map files, an

r302312 - Permit keywords in module names in #pragma clang module *.

2017-05-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 5 17:34:07 2017 New Revision: 302312 URL: http://llvm.org/viewvc/llvm-project?rev=302312&view=rev Log: Permit keywords in module names in #pragma clang module *. This is necessary to be able to build a libc++ module from preprocessed source (due to the submodule std.

Re: [PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

2017-05-05 Thread Richard Smith via cfe-commits
On 1 May 2017 at 16:43, Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk created this revision. > > When building with implicit modules it's possible to hit a scenario > where modules are built without -fsanitize=address, and are subsequently > imported into CUs with -fsanitiz

r302463 - If we are building a module, and we read a second description of the same

2017-05-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 8 15:30:47 2017 New Revision: 302463 URL: http://llvm.org/viewvc/llvm-project?rev=302463&view=rev Log: If we are building a module, and we read a second description of the same module from a different module map, ignore it. This happens during builds of preprocessed

Re: [PATCH] D24933: Enable configuration files in clang

2017-05-09 Thread Richard Smith via cfe-commits
On 1 March 2017 at 02:50, Serge Pavlov via Phabricator < revi...@reviews.llvm.org> wrote: > sepavloff added a comment. > > Glad to know that someone is interested in this feature! > Below is actual proposal. > > **Adding named configuration files to clang driver** > > A configuration file is a col

r302596 - Don't mark a member as a member specialization until we know we're keeping the specialization.

2017-05-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 9 18:02:10 2017 New Revision: 302596 URL: http://llvm.org/viewvc/llvm-project?rev=302596&view=rev Log: Don't mark a member as a member specialization until we know we're keeping the specialization. This improves our behavior in a few ways: * We now guarantee that

r302603 - When instantiating a friend function template, don't forget to inherit default template arguments from other declarations.

2017-05-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 9 19:01:13 2017 New Revision: 302603 URL: http://llvm.org/viewvc/llvm-project?rev=302603&view=rev Log: When instantiating a friend function template, don't forget to inherit default template arguments from other declarations. Modified: cfe/trunk/lib/Sema/SemaTem

r302615 - When we see a '<' operator, check whether it's a probable typo for a template-id.

2017-05-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 9 21:30:28 2017 New Revision: 302615 URL: http://llvm.org/viewvc/llvm-project?rev=302615&view=rev Log: When we see a '<' operator, check whether it's a probable typo for a template-id. The heuristic that we use here is: * the left-hand side must be a simple identif

r302732 - Improve diagnosis of unknown template name.

2017-05-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 10 16:32:16 2017 New Revision: 302732 URL: http://llvm.org/viewvc/llvm-project?rev=302732&view=rev Log: Improve diagnosis of unknown template name. When an undeclared identifier in a context that requires a type is followed by '<', only look for type templates when ty

r302737 - Changes missed from r302732.

2017-05-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 10 16:47:30 2017 New Revision: 302737 URL: http://llvm.org/viewvc/llvm-project?rev=302737&view=rev Log: Changes missed from r302732. Modified: cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/Parse/ParseDeclCXX.cpp cfe/trunk/lib/Parse/ParseExprCXX.cpp

r302750 - PR22877: When constructing an array via a constructor with a default argument

2017-05-10 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 10 19:17:17 2017 New Revision: 302750 URL: http://llvm.org/viewvc/llvm-project?rev=302750&view=rev Log: PR22877: When constructing an array via a constructor with a default argument in list-initialization, run cleanups for the default argument after each iteration of t

Re: r302777 - Reverted r302775

2017-05-11 Thread Richard Smith via cfe-commits
When you revert a patch (even one of your own), please say why you reverted it in the commit message. On 11 May 2017 1:38 am, "Serge Pavlov via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: sepavloff Date: Thu May 11 03:25:22 2017 New Revision: 302777 URL: http://llvm.org/viewvc/llvm

r302817 - PR22877: When constructing an array via a constructor with a default argument

2017-05-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 11 13:58:24 2017 New Revision: 302817 URL: http://llvm.org/viewvc/llvm-project?rev=302817&view=rev Log: PR22877: When constructing an array via a constructor with a default argument in list-initialization, run cleanups for the default argument after each iteration of t

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

2017-05-11 Thread Richard Smith via cfe-commits
s/1518 > > > > Sorry, > > Diana > > > > On 11 May 2017 at 02:17, Richard Smith via cfe-commits > > wrote: > >> Author: rsmith > >> Date: Wed May 10 19:17:17 2017 > >> New Revision: 302750 > >> > >> URL: http://llvm.or

r302818 - Work around different -std= default for PS4 target.

2017-05-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 11 14:17:54 2017 New Revision: 302818 URL: http://llvm.org/viewvc/llvm-project?rev=302818&view=rev Log: Work around different -std= default for PS4 target. Modified: cfe/trunk/test/CodeGenCXX/array-default-argument.cpp Modified: cfe/trunk/test/CodeGenCXX/array-de

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

2017-05-11 Thread Richard Smith via cfe-commits
n 11 May 2017 at 13:17, Krzysztof Parzyszek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hexagon is still broken. :( > > http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/7942 > > -Krzysztof > > > On 5/11/2017 1:58 PM, Richard Smith via cfe-commits wro

r302825 - XFAIL this test for Hexagon.

2017-05-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 11 16:18:27 2017 New Revision: 302825 URL: http://llvm.org/viewvc/llvm-project?rev=302825&view=rev Log: XFAIL this test for Hexagon. It's failing due to Hexagon calling convention lowering being broken (empty structs are not passed even if they have nontrivial destruc

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

2017-05-11 Thread Richard Smith via cfe-commits
he hexagon bot appears to be failing to send mail. > > On 11 May 2017 at 13:17, Krzysztof Parzyszek via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hexagon is still broken. :( >> >> http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/7942 >>

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

2017-05-11 Thread Richard Smith via cfe-commits
{ f(A()); } >> >> ... prints: >> >> A::A() 0x7ffd54d95658 >> void f(A) 0x7ffd54d95638 >> A::~A() 0x7ffd54d95658 >> >> Also, the hexagon bot appears to be failing to send mail. >> >> On 11 May 2017 at 13:17, Krzysztof Parzyszek via cfe-commits &l

r302842 - Remove unnecessary mapping from SourceLocation to Module.

2017-05-11 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu May 11 18:11:16 2017 New Revision: 302842 URL: http://llvm.org/viewvc/llvm-project?rev=302842&view=rev Log: Remove unnecessary mapping from SourceLocation to Module. When we parse a redefinition of an entity for which we have a hidden existing declaration, make it visible

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

2017-05-11 Thread Richard Smith via cfe-commits
On 11 May 2017 at 15:59, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu May 11 17:59:19 2017 > New Revision: 302840 > > URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev > Log: > Module Debug Info: Emit namespaced C++ forward decls in the

r302932 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

2017-05-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 12 13:56:03 2017 New Revision: 302932 URL: http://llvm.org/viewvc/llvm-project?rev=302932&view=rev Log: [modules] Simplify module macro handling in non-local-submodule-visibility mode. When reaching the end of a module, we used to convert its macros to ModuleMacros bu

r302947 - Revert r302932, as it appears to be breaking stage2 for some of our modules-enabled buildbots.

2017-05-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 12 15:42:54 2017 New Revision: 302947 URL: http://llvm.org/viewvc/llvm-project?rev=302947&view=rev Log: Revert r302932, as it appears to be breaking stage2 for some of our modules-enabled buildbots. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/tru

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

2017-05-12 Thread Richard Smith via cfe-commits
On 12 May 2017 at 13:24, Renato Golin wrote: > On 12 May 2017 at 20:46, Diana Picus wrote: > > On 11 May 2017 at 21:14, Richard Smith wrote: > >> Thanks for the revert, fixed up and recommitted in r302817. > >> > >> Any idea why not a single buildbot sent me any email about this? :( (A > >> cou

Re: r302932 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

2017-05-12 Thread Richard Smith via cfe-commits
IOHIDEventStruct > Already reverted, I'm investigating. > Cheers, > Juergen > > > On Fri, May 12, 2017 at 11:56 AM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Fri May 12 13:56:03 2017 >> N

r302965 - [modules] When creating a declaration, cache its owning module immediately

2017-05-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 12 18:27:00 2017 New Revision: 302965 URL: http://llvm.org/viewvc/llvm-project?rev=302965&view=rev Log: [modules] When creating a declaration, cache its owning module immediately rather than waiting until it's queried. Currently this is only applied to local submodule

r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 12 18:40:52 2017 New Revision: 302966 URL: http://llvm.org/viewvc/llvm-project?rev=302966&view=rev Log: Remove unused tracking of owning module for MacroInfo objects. Modified: cfe/trunk/include/clang/Lex/MacroInfo.h cfe/trunk/include/clang/Lex/Preprocessor.h

r302969 - Add LangOptions method to query whether we are tracking the owning module for a local declaration.

2017-05-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri May 12 19:00:16 2017 New Revision: 302969 URL: http://llvm.org/viewvc/llvm-project?rev=302969&view=rev Log: Add LangOptions method to query whether we are tracking the owning module for a local declaration. In preparation for expanding this behavior to cover additional c

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-16 Thread Richard Smith via cfe-commits
t; // CHECK: "1a-b2-3cd4" > ^ > :34:1: note: scanning from here > "1a-b2- 3cd4" > ^ > > > On Mon, May 15, 2017 at 10:28 AM Jordan Rose via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi, Richard. Swift was using this inf

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-16 Thread Richard Smith via cfe-commits
k macros(true) and query getModuleMacro(module, identifier) on each one. Thanks, > Jordan > > > > On May 12, 2017, at 16:40, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: rsmith > > Date: Fri May 12 18:40:52 2017 >

r303224 - [modules] When creating a declaration, cache its owning module immediately

2017-05-16 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 16 19:24:14 2017 New Revision: 303224 URL: http://llvm.org/viewvc/llvm-project?rev=303224&view=rev Log: [modules] When creating a declaration, cache its owning module immediately rather than waiting until it's queried. Currently this is only applied to local submodule

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-17 Thread Richard Smith via cfe-commits
gt; ^ >>>>> /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux- >>>>> bootstrap/build/llvm/tools/clang/test/Preprocessor/macro_paste_msextensions.c:42:1: >>>>> error: pasting formed '-3c', an invalid preproces

<    19   20   21   22   23   24   25   26   27   28   >