[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

2019-07-25 Thread Richard Musil via Phabricator via cfe-commits
risa2000 created this revision. risa2000 added a reviewer: phosek. risa2000 added a project: LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers. The folder expansion in install scripts created by CMake for "Visual Studio" genera

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

2019-07-27 Thread Richard Musil via Phabricator via cfe-commits
risa2000 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:190 +if(CMAKE_CONFIGURATION_TYPES) + string(REPLACE "${CMAKE_CFG_INTDIR}" "$" output_dir "${output_dir}") beanz wrote: > I think this will break Xcode I guess I put it in since it see

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

2020-01-28 Thread Richard Musil via Phabricator via cfe-commits
risa2000 added a comment. I wonder if someone could explain what happened and if this has been dropped because of the comment from @beanz? I am not using XCode so I cannot comment on its requirements nor fix the code for it. Someone has subscribed to this bug on https://bugs.llvm.org/show_bug.