rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. I'll add the test to LLVM as a separate commit.
Comment at: lib/Driver/ToolChain.cpp:499
@@ -498,1 +498,3 @@
+ options::
rengolin added inline comments.
Comment at: test/Driver/thumb-attributes.s:1
@@ +1,2 @@
+@ RUN: %clang -target armv7-windows-itanium -c -o - %s \
+@ RUN: | llvm-readobj -s - | FileCheck %s
mstorsjo wrote:
> rengolin wrote:
> > But we don't usually do asm tests i
Author: rengolin
Date: Wed Jul 27 09:12:20 2016
New Revision: 276869
URL: http://llvm.org/viewvc/llvm-project?rev=276869&view=rev
Log:
[ARM] Pass thumb as architecture to the underlying tools, when targeting windows
This makes sure that the thumb section flag gets set by the assembler.
Patch by
rengolin closed this revision.
rengolin added a comment.
Committed as r276869.
https://reviews.llvm.org/D22855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a subscriber: compnerd.
rengolin added a comment.
I'll just echo @compnerd comments, since Phab didn't get it.
- Change the syntax to __asm__, to be more portable
- Add Microsoft asm block syntax
cheers,
--renato
https://reviews.llvm.org/D22857
___
rengolin requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/CodeGen/arm-inline-asm-windows.c:2
@@ +1,3 @@
+// REQUIRES: arm-registered-target
+// RUN: %clang -target armv7-windows -c -o - %s
+
Also, I just noticed,
rengolin added a comment.
In https://reviews.llvm.org/D22857#497805, @ahatanak wrote:
> Is r276859 fixing a bug in the assembler?
Sort of. It was just adding a comment character to ; instead of #.
> I'm trying to understand why we have to add a clang test in this particular
> case because I d
rengolin added a comment.
Ok, sounds good. Feel free to abandon this one as well.
cheers,
--renato
https://reviews.llvm.org/D22857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 27 July 2016 at 21:57, Nirav Davé wrote:
> Looks like I missed the target triple. Should work now.
Still failing on *all* ARM targets.
'No available targets are compatible with this triple.'
Please move the test to an x86 directory.
http://llvm.org/docs/TestingGuide.html#platform-specific-t
rengolin added a comment.
Hi Lei,
Thanks for the fix. A few comments. Also, please, add some tests.
cheers,
--renato
Comment at: lib/Driver/ToolChains.cpp:4266
@@ -4266,1 +4265,3 @@
+ if (Triple.isAndroid()) {
return Triple.isArch64Bit() ? "/system/bin/linker64" :
"/sys
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
rengolin added a reviewer: compnerd.
rengolin added a subscriber: compnerd.
rengolin added a comment.
Can you add a test on test/Headers, like the others, please?
I'm not well versed on Windows. @compnerd?
Comment at: lib/Headers/armintr.h:1
@@ +1,2 @@
+/*=== armintr.h - AR
rengolin added inline comments.
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
mstorsjo wrote:
> rengolin wrote:
> > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix
> > environments?
> I can add the same as at the top of intr
rengolin added inline comments.
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
mstorsjo wrote:
> rengolin wrote:
> > mstorsjo wrote:
> > > rengolin wrote:
> > > > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix
> > > > enviro
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
rengolin added a subscriber: rengolin.
rengolin added a comment.
All tests should have the target explicit, so I'd advocate for all of them to
be changed.
Also, we need to make sure --target=x86_64 is enough on Windows. I remember
some -target=arm not being enough (arm-eabi was enough, for some
On 2 August 2016 at 13:21, Artem Dergachev via cfe-commits
wrote:
> Author: dergachev
> Date: Tue Aug 2 07:21:09 2016
> New Revision: 277449
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277449&view=rev
> Log:
> [analyzer] Respect statement-specific data in CloneDetection.
Hi Artem,
Just to
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Hi Oliver,
The driver part looks good to me, thanks!
I haven't looked at the LLVM side of the patch. The other reviews probably know
more than I do about that, anyway. :)
cheers,
--renat
rengolin added a comment.
The include_next is to make sure that, whatever other environment that happens
to have the same include name, should pick it up if the user or the environment
provides one, or errors out if it doesn't. Pretty standard.
https://reviews.llvm.org/D22774
__
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
More trivial changes. LGTM. Thanks!
https://reviews.llvm.org/D23293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rengolin added subscribers: labrinea, bsmith.
rengolin added a comment.
Hi,
I think it's clear now to me that this strategy isn't going to work. What you
need is to add support for AArch64 in the TargetParser and simplify the name
matching in the same way we did for ARM. There really is no othe
On 3 February 2016 at 02:58, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Tue Feb 2 20:58:20 2016
> New Revision: 259622
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259622&view=rev
> Log:
> Fix miscompile and rejects-valids when disambiguating after an ambiguous
> C-style-ca
On 3 February 2016 at 18:53, Richard Smith wrote:
> Fixed in r259677, sorry about that!
No worries, thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rengolin
Date: Sun Feb 7 09:43:09 2016
New Revision: 260036
URL: http://llvm.org/viewvc/llvm-project?rev=260036&view=rev
Log:
Revert "Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code
generation for different devices."
This reverts commit r259985, as it still fails o
On 6 February 2016 at 06:52, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Sat Feb 6 00:52:48 2016
> New Revision: 259985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259985&view=rev
> Log:
> Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code
> generation f
On 7 February 2016 at 17:29, Samuel F Antao wrote:
> Hi Renato,
>
> This is not related with my patch, I'm afraid your buildbot won't go green
> with the revert. This looks to be related with r259976. My patch
> triggered the problem because it touched a CmakeList.txt. The code itself
> is comple
Hi Alexey,
It's still broken on ARM:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/10409
cheers,
--renato
On 8 February 2016 at 14:25, Alexey Bataev via cfe-commits
wrote:
> Ok, thanks a lot! Hope it will fix win-based buildbots completely.
>
> Best regards,
> Alexey Bat
rengolin added a comment.
I'm assuming you also have the LLVM counterpart?
http://reviews.llvm.org/D17124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
In http://reviews.llvm.org/D17124#350229, @mcrosier wrote:
> Committed r260555.
It would have been better to commit the LLVM parts first. Now, there will be a
range where kyro will be accepted by Clang but broken when it gets to setup the
target.
--renato
http://r
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Sorry, this fell out of my radar. I'm ok with the changes. Ping me when you
commit so I can monitor the bot for a while.
http://reviews.llvm.org/D14293
Author: rengolin
Date: Thu Feb 11 15:22:57 2016
New Revision: 260595
URL: http://llvm.org/viewvc/llvm-project?rev=260595&view=rev
Log:
[AArch64] Fix libunwind build when using GNU assembler
Use x29 and x30 for fp and lr respectively.
This does not change the code generation with integrated asm
b
On 12 February 2016 at 23:11, Argyrios Kyrtzidis via cfe-commits
wrote:
> Author: akirtzidis
> Date: Fri Feb 12 17:10:59 2016
> New Revision: 260760
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260760&view=rev
> Log:
> [libclang] Separate the underlying indexing functionality of libclang and
rengolin added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
I agree with Tim, I think this should be more generic.
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
In http://reviews.llvm.org/D20089#425525, @bsmith wrote:
> There is an awful lot of duplication/passing through to another class in
> this, it strikes me that this whole thing could benefit from some level of
> inheritance. I think it would be good to have a base class
rengolin added a comment.
In http://reviews.llvm.org/D20089#425542, @bsmith wrote:
> I think that made sense when we only had ARM using this, but not so much now
> since we essentially have two implementations of the same thing.
What about the argument of doing slow and steady changes instead
rengolin added a comment.
Jojo,
Thanks for putting this forward. Regarding Bradley's point, it may be clearer
if we go directly with a class based design, but if it changes the ARM part at
the same time (especially testing), than I'd prefer to avoid it. Can you try
this different approach whil
rengolin added a comment.
Bradley, Jojo,
I'm a bit rusty in that part of the code, but that's not really what I was
thinking either.
The way we started this was to have the TargetParser have *all* parsing. So
both check*ArchValid, if necessary, will have to use the TargetParser to parse
the s
rengolin added a comment.
In http://reviews.llvm.org/D20088#425589, @rengolin wrote:
> In this case, it may be simpler to just rely on the Triple object that
> already exists in the driver, or just the fact that this is in
> getAArch64ArchFeaturesFromMarch() and pass an extra flag to parseArch(
rengolin added a subscriber: rengolin.
Comment at: include/libunwind.h:49
@@ -48,1 +48,3 @@
struct unw_context_t {
+#if defined(_LIBUNWIND_NATIVE_I386)
+ uint64_t data[8];
Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or
something and
rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.
Please, re-submit this change once the documents have been made public.
Feel free to submit the assembly test to LLVM, using llc, on their own.
cheers,
--renato
===
rengolin added a comment.
In http://reviews.llvm.org/D20325#432086, @t.p.northover wrote:
> I don't think we need to wait until the document is public, necessarily. The
> entire AArch64 backend went in before the encodings were public outside ARM
> (except maybe in binutils source?) and releasi
rengolin added inline comments.
Comment at: include/clang/Basic/BuiltinsARM.def:55
@@ -54,3 +54,3 @@
BUILTIN(__builtin_arm_mrc2, "UiUIiUIiUIiUIiUIi", "")
-BUILTIN(__builtin_arm_cdp, "vUiUiUiUiUiUi", "")
-BUILTIN(__builtin_arm_cdp2, "vUiUiUiUiUiUi", "")
+BUILTIN(__builtin_arm_cdp,
On 18 May 2016 at 03:45, Tim Northover via cfe-commits
wrote:
> Well yes, it's probably got orders of magnitude less bugs than the
> backend for a start.
:D
> Generally we're far more relaxed as long as a specification is on the
> way. We're up to to v8.2 in LLVM proper already, and I don't thi
rengolin added a comment.
Thanks Ranjeet,
The tests don't really need the new builtin to exist at all and can be added
now.
When you submit the __arm_cdp patch, you just need to make sure Clang generates
a call to @llvm.arm.cdp and everything else will be covered.
cheers,
--renato
Repositor
On 18 May 2016 at 13:18, James Molloy wrote:
> The ACLE in particular stays in draft for some time, because it often waits
> for implementations to be done in GCC and LLVM to see if the specification
> is actually workable!
I can't imagine ARM sharing a draft, so this is actually a better
argumen
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D20394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rengolin added a reviewer: rengolin.
Comment at: lib/Basic/Targets.cpp:4931
@@ -4931,1 +4930,3 @@
+if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") &&
+(FPU & VFP4FPU))
Builder.defineMacro("__ARM_FEATURE_FMA", "1");
I think just t
rengolin added a subscriber: rengolin.
rengolin added a comment.
En passant comment: I really wish we wouldn't.
The C++ standard had some very careful considerations on VLAs and decided *not*
to support. It wasn't for lack of interest, it was a well informed decision.
Comment
rengolin added a comment.
In http://reviews.llvm.org/D18823#397112, @hfinkel wrote:
> However, as an implementation extension, this concern is not relevant. I'm in
> favor of this; I have uses who use this feature in GCC. It is certainly true
> that most HPC users are using these on PODs, but t
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rengolin added inline comments.
Comment at: test/Sema/arm_vfma.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-fsyntax-only -verify %s
+// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon
-target-feature +vfp4 -fsyn
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
On 21 April 2016 at 11:59, Denis Zobnin via cfe-commits
wrote:
> Author: dzobnin
> Date: Thu Apr 21 05:59:18 2016
> New Revision: 266976
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266976&view=rev
> Log:
> Correctly parse GCC-style asm line following MS-style asm line.
>
> Quit parsing MS-sty
Author: rengolin
Date: Thu Apr 21 09:40:06 2016
New Revision: 266993
URL: http://llvm.org/viewvc/llvm-project?rev=266993&view=rev
Log:
[x86] Force mixes asm syntax test to check for x86
Modified:
cfe/trunk/test/CodeGen/inline-asm-mixed-style.c
Modified: cfe/trunk/test/CodeGen/inline-asm-mixe
On 21 April 2016 at 14:58, Krzysztof Parzyszek via cfe-commits
wrote:
> Same thing on Hexagon:
> http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/37972
Trying to fix in r266993.
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:4710
@@ -4709,1 +4709,3 @@
const std::vector &FeaturesVec) const override {
+if (CPU == "")
+ CPU = "generic";
This change is unrelated and may bring side effects into cla
On 22 May 2016 at 19:18, Simon Atanasyan via cfe-commits
wrote:
> Author: atanasyan
> Date: Sun May 22 13:18:07 2016
> New Revision: 270373
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270373&view=rev
> Log:
> [driver][mips] Support new versions of MIPS CodeScape toolchains
Hi Simon,
http://
rengolin added a comment.
Hi Jojo,
This is looking better, thanks!
While I agree with Bradley that the repetition is not pretty, but I think it
will expose all issues to make a class design simple and straightforward, once
we get all the sharp edges out. But we need to know what are the diffic
On 22 May 2016 at 23:16, Simon Atanasyan wrote:
> Hope r270380 fixes the problem.
All green, thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a subscriber: rengolin.
rengolin added a comment.
Ping?
Can we get some traction on this one, please? The 3.8.1 deadline is tomorrow
and I'd really like to see these two patches (plus the related fixes) in it, or
some LTS Linux distributions will live without them, and thus with
rengolin added a comment.
Hi Jojo,
I've just mapped these changes to the current ARM implementation and they look
correct. I only have two minor comments and I'm happy with it, but I'll let
Bradley have the final review.
Bradley,
If history is of any help, Jojo will have to change a few thing
On 24 May 2016 at 16:13, Mads Ravn via cfe-commits
wrote:
> Author: madsravn
> Date: Tue May 24 10:13:44 2016
> New Revision: 270567
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270567&view=rev
> Log:
> [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
>
> Adding to revisio
On 24 May 2016 at 17:09, Mads Ravn via cfe-commits
wrote:
> Author: madsravn
> Date: Tue May 24 11:09:24 2016
> New Revision: 270575
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270575&view=rev
> Log:
> [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
This seems to have d
rengolin added a comment.
LGTM. James? Bradley? Tim?
Repository:
rL LLVM
http://reviews.llvm.org/D20089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Looks great, thanks Jojo!
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D20089#438937, @jmolloy wrote:
> As far as I'm concerned, if you're happy I'm happy. You know this area more
> than me.
Ok, I'll go ahead and commit this, and
Author: rengolin
Date: Wed May 25 07:02:58 2016
New Revision: 270688
URL: http://llvm.org/viewvc/llvm-project?rev=270688&view=rev
Log:
[AArch64] Using new TargetParser in Clang
Using AArch64TargetParser in clang to avoid repetitive string parsing.
Use TargetParser to do ARCH/CPU/ArchExt parsing
rengolin closed this revision.
rengolin added a comment.
Committed in r270687.
Repository:
rL LLVM
http://reviews.llvm.org/D20089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin closed this revision.
rengolin added a comment.
Committed in r270688.
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rengolin
Date: Wed May 25 07:16:28 2016
New Revision: 270689
URL: http://llvm.org/viewvc/llvm-project?rev=270689&view=rev
Log:
[AArch64] Try to fix test from r270688 with unordered output
Modified:
cfe/trunk/test/Preprocessor/aarch64-target-features.c
Modified: cfe/trunk/test/Preproc
Author: rengolin
Date: Wed May 25 07:36:31 2016
New Revision: 270691
URL: http://llvm.org/viewvc/llvm-project?rev=270691&view=rev
Log:
Revert "[AArch64] Using new TargetParser in Clang"
This reverts commit r270688 and r270689. The issue is not a random order, but a
different order for some target
rengolin added a comment.
In http://reviews.llvm.org/D20709#443950, @srhines wrote:
> Correct. This is only used by RenderScript, and unfortunately can't be done
> any differently. We had hoped to just predicate this with our own LangOpt
> (the patch that adds the RenderScript LangOpt is coming
rengolin added a comment.
In http://reviews.llvm.org/D18035#440107, @rsmith wrote:
> Please try to appropriately apportion the responsibility here; if your
> distribution opted into a non-standard ABI for their C++ standard library,
> you should point out to them that they made a mistake.
I t
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM Thanks!
http://reviews.llvm.org/D20864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D20908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rengolin added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3817
@@ +3816,3 @@
+
+Value *Arg0 = EmitScalarExpr(E->getArg(0)); /* coproc */
+Value *Arg1 = EmitScalarExpr(E->getArg(1)); /* opc1 */
Would be better to use the comments as names and av
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Thanks Ranjeet, looks much better now! LGTM, Thanks!
http://reviews.llvm.org/D21179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rengolin added inline comments.
Comment at: lib/Basic/Targets.cpp:5709
@@ -5716,3 +5708,3 @@
void getTargetDefines(const LangOptions &Opts,
MacroBuilder &Builder) const override {
We'll have to re-work these parts anyway. When I was l
rengolin added a comment.
Hi Jojo,
This looks good to me, and I recommend you squash this patch with
http://reviews.llvm.org/D21276 before commit. But I'll let @echristo and
@compnerd have the final say.
cheers,
--renato
Repository:
rL LLVM
http://reviews.llvm.org/D21277
__
rengolin added a comment.
In http://reviews.llvm.org/D21277#459703, @jojo wrote:
> Do you mean updating the diff to let it include the change of
> http://reviews.llvm.org/D21276,or commiting these two reviews as one commit?
Committing them as one, after they're both approved.
Repository:
r
On 18 June 2016 at 05:10, Eric Fiselier via cfe-commits
wrote:
> Author: ericwf
> Date: Fri Jun 17 23:10:23 2016
> New Revision: 273078
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273078&view=rev
> Log:
> Fix 3 bugs in filesystem tests and implementation.
Hi Eric,
Thanks for he fixes, but j
On 24 June 2016 at 10:39, Cong Liu via cfe-commits
wrote:
> Author: congliu
> Date: Fri Jun 24 04:39:28 2016
> New Revision: 273660
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273660&view=rev
> Log:
> Remove ignoringImplicit from clang-tidy.
Hi Cong,
Isn't this leaving untested code in tree
rengolin added a comment.
If this patch was abandoned, please "Abandon" it. If not, please implement it
using the AArch64 TargetParser.
http://reviews.llvm.org/D14471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rengolin added a comment.
Sorry, this was committed and reverted (bugs, being fixed by
http://reviews.llvm.org/D21785). We should start a new one when that's in.
Ignore this one. :)
Repository:
rL LLVM
http://reviews.llvm.org/D21277
___
cfe-com
rengolin reopened this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Reopening, as this is the right patch.
This patch is approved, waiting on http://reviews.llvm.org/D21785, which fixes
the issue that made us revert http://reviews.llvm.org/D20088 in the fi
rengolin requested changes to this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision now requires changes to proceed.
Hi Weiming,
We've discussed about creating builtins when I added support for named
registers and the consensus was that, since there is alrea
rengolin added a reviewer: kristof.beyls.
rengolin added a comment.
I don't mind either way, but would be good to be compatible with gcc in that
respect. Least surprise and all.
ARM was naming it fpv8 for the command line options and other things, might
also be good to keep the consistency.
Wo
rengolin added a comment.
In http://reviews.llvm.org/D22254#481972, @mgrang wrote:
> Hi Tim/Renato,
>
> On a similar note, I have a patch which adds the breakpoint intrinsic (for
> ARM and Thumb):
>
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html
Hi Mande
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:127
@@ +126,3 @@
+* The projects' repositories will remain identical, with a new address
(GitHub).
+* They'll continue to have SVN RW access, but will also gain Git RW access.
+* The linear history can still be
rengolin created this revision.
rengolin added reviewers: lattner, chandlerc, jyknight, mehdi_amini, MatzeB,
probinson, t.p.northover, chapuni, delcypher, dberlin, rsmith, beanz,
cmatthews, asl, aaron.ballman, bcraig, Bigcheese, jroelofs, theraven, greened,
hong.gyu.kim, rafael, AlexDenisov, sil
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:129
@@ +128,3 @@
+* The linear history can still be accessed in the (RO) submodule meta project,
+ Which will continue to have SVN access.
+
compnerd wrote:
> "Which will continue to have SVN a
rengolin removed rL LLVM as the repository for this revision.
rengolin updated this revision to Diff 64334.
rengolin added a comment.
First round of changes reflecting reviews.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
=
rengolin added a comment.
Hi,
The error is very sensible, but I'm not sure why you're adding compiler-rt in
the second change. Why is that necessary, and where are the tests for it.
Thanks!
--renato
http://reviews.llvm.org/D17453
___
cfe-commits
rengolin added a comment.
Great work, Tim! Thank you!
http://reviews.llvm.org/D17999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D18052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
On 13 March 2016 at 02:56, Nico Weber via cfe-commits
wrote:
> Author: nico
> Date: Sat Mar 12 13:55:59 2016
> New Revision: 263344
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263344&view=rev
> Log:
> clang-cl: Add a test for the interaction of /Yc and /showIncludes.
>
> We almost get this ri
On 14 March 2016 at 18:42, Peter Collingbourne via cfe-commits
wrote:
> Author: pcc
> Date: Mon Mar 14 13:41:59 2016
> New Revision: 263464
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263464&view=rev
> Log:
> CodeGen: Mark functions used in vtables as unnamed_addr.
>
> This marks virtual func
On 20 March 2016 at 11:33, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Sun Mar 20 05:33:40 2016
> New Revision: 263895
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263895&view=rev
> Log:
> P0184R0: Allow types of 'begin' and 'end' expressions in range-based for
> loops to di
rengolin added inline comments.
Comment at: test/Preprocessor/arm-target-features.c:349
@@ -349,1 +348,3 @@
+// Test whether predefines are as expected when targeting ARMv8-A Cortex
implementations
+// RUN: %clang -target armv8 -mcpu=cortex-a32 -x c -E -dM %s -o - | FileCheck
--
201 - 300 of 337 matches
Mail list logo
