Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

I think on Linux overload resolution was selecting 'DiagnosticBuilder&operator<<(DiagnosticBuilder&DB,int)' for you, which is probably not right anyway. I didn't find any tests for this diagnostic, so I couldn't fix it, and ended up reverting the change in r310661. On Thu, Aug 10, 2017 at 12:15 PM

r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

Author: rnk Date: Mon Aug 14 18:17:47 2017 New Revision: 310905 URL: http://llvm.org/viewvc/llvm-project?rev=310905&view=rev Log: Avoid PointerIntPair of constexpr EvalInfo structs They are stack allocated, so their alignment is not to be trusted. 32-bit MSVC only guarantees 4 byte stack alignmen

r311594 - Parse and print DIExpressions inline to ease IR and MIR testing

Author: rnk Date: Wed Aug 23 13:31:27 2017 New Revision: 311594 URL: http://llvm.org/viewvc/llvm-project?rev=311594&view=rev Log: Parse and print DIExpressions inline to ease IR and MIR testing Summary: Most DIExpressions are empty or very simple. When they are complex, they tend to be unique, so

[clang] 780d306 - [VFS] Don't run symlink test on Windows, it may pass or fail

Author: Reid Kleckner Date: 2019-12-27T10:39:47-08:00 New Revision: 780d30660e965992cf10d390e8ff102e4bf82aa4 URL: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4 DIFF: https://github.com/llvm/llvm-project/commit/780d30660e965992cf10d390e8ff102e4bf82aa4.diff

[clang] 0acfc49 - Allow redeclaration of __declspec(uuid)

Author: Zachary Henkel Date: 2019-12-28T13:13:46-08:00 New Revision: 0acfc493171a880215327ecd70e3e01e1cd493df URL: https://github.com/llvm/llvm-project/commit/0acfc493171a880215327ecd70e3e01e1cd493df DIFF: https://github.com/llvm/llvm-project/commit/0acfc493171a880215327ecd70e3e01e1cd493df.diff

[clang] 0f9cf42 - Allow /D flags absent during PCH creation under msvc-compat

Author: Zachary Henkel Date: 2020-01-14T17:26:01-08:00 New Revision: 0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b URL: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b DIFF: https://github.com/llvm/llvm-project/commit/0f9cf42facaf9eff47dc0b9eb7e6ed8803d3bc3b.diff

[clang] 8e78025 - [X86] ABI compat bugfix for MSVC vectorcall

Author: Reid Kleckner Date: 2020-01-14T17:49:13-08:00 New Revision: 8e780252a7284be45cf1ba224cabd884847e8e92 URL: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92 DIFF: https://github.com/llvm/llvm-project/commit/8e780252a7284be45cf1ba224cabd884847e8e92.diff

[clang] c42116c - Fix up ms-pch-macro.c test to pass on non-Windows

Author: Reid Kleckner Date: 2020-01-14T22:19:30-08:00 New Revision: c42116cc653ae1618cc49dab367d9f6addd8cfd9 URL: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9 DIFF: https://github.com/llvm/llvm-project/commit/c42116cc653ae1618cc49dab367d9f6addd8cfd9.diff

[clang] 3b3a165 - [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

Author: Reid Kleckner Date: 2020-09-21T11:49:17-07:00 New Revision: 3b3a16548568f5b6c4146ca5129eb6af5000e4ff URL: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff DIFF: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff.diff

[clang] b62fd43 - Revert "Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

Author: Reid Kleckner Date: 2020-09-24T11:16:55-07:00 New Revision: b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 URL: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 DIFF: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.diff

[clang] 3453b69 - Revert "Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions""

Author: Reid Kleckner Date: 2020-09-24T11:16:54-07:00 New Revision: 3453b6928da332bb67f902add71f5cd80f61c136 URL: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136 DIFF: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136.diff

[clang] b8a50e9 - [MS] Simplify rules for passing C++ records

Author: Reid Kleckner Date: 2020-09-24T16:29:47-07:00 New Revision: b8a50e920704436ddcbe0cc9d2020935d7e37095 URL: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095 DIFF: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095.diff

[clang] ecfc9b9 - [MS] For unknown ISAs, pass non-trivially copyable arguments indirectly

Author: Reid Kleckner Date: 2020-09-24T16:29:48-07:00 New Revision: ecfc9b971269a86b101cddf1fd9f0976be4096d0 URL: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0 DIFF: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0.diff

[clang] a32feed - Add a static_assert confirming that DiagnosticBuilder is small

Author: Reid Kleckner Date: 2020-09-24T16:38:41-07:00 New Revision: a32feed0dbeac7606d042d0d7e041c9eaf12cd51 URL: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51 DIFF: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51.diff

[clang] 276f68e - Revert "Add a static_assert confirming that DiagnosticBuilder is small"

Author: Reid Kleckner Date: 2020-09-24T16:39:46-07:00 New Revision: 276f68eace7c27f6805d69a30a4b2f186e42c56c URL: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c DIFF: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c.diff

[clang] d7098ff - De-templatify EmitCallArgs argument type checking, NFCI

Author: Reid Kleckner Date: 2020-12-09T11:08:00-08:00 New Revision: d7098ff29c58dd08ede8314818b7de7fd2fea4cc URL: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc DIFF: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc.diff

[clang] df28221 - Don't setup inalloca for swiftcc on i686-windows-msvc

Author: Reid Kleckner Date: 2020-12-09T11:08:48-08:00 New Revision: df282215d497e15104ae9e182e083cdfa0bae3c2 URL: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2 DIFF: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2.diff

[clang] d2ed9d6 - Revert "ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC"

Author: Reid Kleckner Date: 2020-12-14T17:04:06-08:00 New Revision: d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b URL: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b DIFF: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b.diff

[clang] b7905e8 - Fix split-debug.c test on Windows

Author: Reid Kleckner Date: 2020-12-16T13:48:57-08:00 New Revision: b7905e81fc3d7b045a5346442ce92ee87bdb7b21 URL: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21 DIFF: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21.diff

[clang] d2e7dca - [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

Author: Jan Ole Hüser Date: 2020-11-05T12:57:17-08:00 New Revision: d2e7dca5ca92c655e451d6fcb806df38d7f2d56b URL: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b DIFF: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b.diff

[clang] efd0472 - BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542

Author: Zahira Ammarguellat Date: 2020-09-28T17:10:32-07:00 New Revision: efd04721c9a2a856dd47e47a08c42d21efd5dd2b URL: https://github.com/llvm/llvm-project/commit/efd04721c9a2a856dd47e47a08c42d21efd5dd2b DIFF: https://github.com/llvm/llvm-project/commit/efd04721c9a2a856dd47e47a08c42d21efd5dd2b

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < lldb-comm...@lists.llvm.org> wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do som

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

[clang] 0ec1cf1 - Revert "DirectoryWatcher: add an implementation for Windows"

Author: Reid Kleckner Date: 2020-10-13T12:35:22-07:00 New Revision: 0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 URL: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 DIFF: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577.diff

[clang] 8b6d1c0 - [ADT] Use alignas + sizeof for inline storage, NFC

Author: Reid Kleckner Date: 2020-10-14T16:16:02-07:00 New Revision: 8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b URL: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b DIFF: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b.diff

[clang] 5fbab40 - [MS] Apply `inreg` to AArch64 sret parms on instance methods

Author: Reid Kleckner Date: 2020-10-15T14:54:42-07:00 New Revision: 5fbab4025eb57b12f2842ab188ff07a110708e1d URL: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d DIFF: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d.diff

[clang] 64802d4 - Make check-clang depend on the LLVM split-file utility

Author: Reid Kleckner Date: 2020-11-23T12:21:44-08:00 New Revision: 64802d48d51d651bd2e4567b2f228f8795569542 URL: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542 DIFF: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542.diff

[clang] 09ba206 - Fix compilation issue reported by MSVC user on cfe-dev

Author: Reid Kleckner Date: 2020-11-24T17:31:25-08:00 New Revision: 09ba2063dc9339957b999c08d3810a3cec2b745b URL: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b DIFF: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b.diff

[clang] 3bd0672 - [MS] Fix double evaluation of MSVC builtin arguments

Author: Reid Kleckner Date: 2020-11-25T11:55:01-08:00 New Revision: 3bd06727267184223464f11d4e2470048ac40cb1 URL: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1 DIFF: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1.diff

[clang] 1e843a9 - [MS] Add more 128bit cmpxchg intrinsics for AArch64

Author: Reid Kleckner Date: 2020-11-25T12:07:28-08:00 New Revision: 1e843a987d847da48aaf41801b79cfb364937e8f URL: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f DIFF: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f.diff

[clang] 43b5b48 - Fix GCC 5.3 compile error in ASTImporter code

Author: Reid Kleckner Date: 2020-11-30T16:29:29-08:00 New Revision: 43b5b485a203f190ee4d5d3cab19c44ca865d316 URL: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316 DIFF: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316.diff

[clang] d2f4b7d - Use enum comparison instead of generated switch/case, NFC

Author: Reid Kleckner Date: 2021-05-13T20:26:50-07:00 New Revision: d2f4b7d77828dba831f4b7429a7c970d71eb853b URL: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b DIFF: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b.diff

[clang] 8f20ac9 - [PGO] Don't reference functions unless value profiling is enabled

Author: Reid Kleckner Date: 2021-05-20T11:09:24-07:00 New Revision: 8f20ac9595c8b279641dace6f212b8a9673b24e4 URL: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4 DIFF: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4.diff

[clang] e32a92c - Remove unnecessary triple from test

Author: Yuki Okushi Date: 2021-06-15T09:49:45-07:00 New Revision: e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed URL: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed DIFF: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed.diff L

[clang] 718c632 - Simplify dllexport class member code, NFC

Author: Reid Kleckner Date: 2021-08-11T11:42:20-07:00 New Revision: 718c63258202e8e674c47c9ece16f396065e7c2a URL: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a DIFF: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a.diff

[clang] 1c2e7d2 - [MS] Fix crash involving gnu stmt exprs and inalloca

Author: Reid Kleckner Date: 2021-03-04T13:57:46-08:00 New Revision: 1c2e7d200df27e91631ba300965245518bfe252c URL: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c DIFF: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c.diff

[clang] 35ab2a1 - Fix a buglet in remove_dots().

Author: Paul Pluzhnikov Date: 2022-06-02T11:07:44-07:00 New Revision: 35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d URL: https://github.com/llvm/llvm-project/commit/35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d DIFF: https://github.com/llvm/llvm-project/commit/35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d.dif

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

rnk wrote: It is true that the MSVC mangler doesn't generally canonicalize types, but I think we can canonicalize in the `mangleTypeName` entry point, because it exists to create unique type names for TBAA and CFI. You can audit the callers, they all relate to either of those two things. Unre

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

@@ -2218,6 +2218,9 @@ printTo(raw_ostream &OS, ArrayRef Args, const PrintingPolicy &Policy, } else { if (!FirstArg) OS << Comma; + //if (Argument.getKind() == TemplateArgument::Type) + // OS << "class "; + rnk wrote: I would move

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

rnk wrote: Seems reasonable to me, but I want @efriedma-quic to approve as well, if this is a reasonable implementation of your direction. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. --- clang/lib/AST/Expr.cp

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk commented: I wanted to make some minor naming suggestions, and I used the GitHub "edit this file" feature for the first time to commit them as new commits to your branch. I've never done this before, so I don't really know how it works, but clang-format isn't available,

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

https://github.com/rnk approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

https://github.com/rnk approved this pull request. Yep, looks good to me. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

https://github.com/rnk approved this pull request. I was going to delegate the review to @aeubanks, who was the last one I'm aware of to touch the strict vptr feature, but I think this is a pretty straightforward fix. https://github.com/llvm/llvm-project/pull/68169

[clang] 47d1789 - Add Adrian and David as owners for debug info

Author: Reid Kleckner Date: 2023-07-24T11:11:35-07:00 New Revision: 47d178939e96d388c8d28dff2f937e340f12c31d URL: https://github.com/llvm/llvm-project/commit/47d178939e96d388c8d28dff2f937e340f12c31d DIFF: https://github.com/llvm/llvm-project/commit/47d178939e96d388c8d28dff2f937e340f12c31d.diff

[clang] 0d9919d - Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

Author: Reid Kleckner Date: 2023-08-22T18:10:41-07:00 New Revision: 0d9919d362a7a70b2a7970861d897ecc47ec9e4d URL: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d DIFF: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d.diff

[clang-tools-extra] ba52a10 - [clang-tidy] Fix test to not depend on D153156, which was reverted

Author: Reid Kleckner Date: 2023-08-22T18:39:19-07:00 New Revision: ba52a10fca6fc7b791894c584233db012def68a5 URL: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5 DIFF: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5.diff

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext &Ctx) const { if (!CXXRD->isEmpty()) return false; + // MS ABI: nonzero if class type with class type fields + if (Ctx.getTargetInfo().getCXXABI().isMicrosoft() && + llvm::any_of(CXXRD->fields(), [

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -2937,14 +2964,97 @@ void MicrosoftRecordLayoutBuilder::layoutNonVirtualBase( BaseOffset = CharUnits::Zero(); } else { // Otherwise, lay the base out at the end of the MDC. - BaseOffset = Size = Size.alignTo(Info.Alignment); + BaseOffset = DataSize

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk created https://github.com/llvm/llvm-project/pull/65692: MSVC allows users to pass structures with required alignments greater than 4 to variadic functions. It does not pass them indirectly to correctly align them. Instead, it passes them directly with the usual 4 byte st

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

https://github.com/rnk commented: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/65692: >From 98d560c8057b171c81b43d93c1a0c26f1d27cf5b Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 29 Aug 2023 14:26:10 -0700 Subject: [PATCH 1/2] [MS] Follow up fix to pass aligned args to variadic x86_32 funct

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState &State, } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 201

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk resolved https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/rnk commented: This seems fine to me, but it's hard to understand if this is redundant with some other "ParseFunction" scope from the tests. WDYT @MaskRay ? https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing lis

[clang] ce5173c - Use FinishThunk to finish musttail thunks

Author: Reid Kleckner Date: 2020-03-20T09:02:21-07:00 New Revision: ce5173c0e174870934d1b3a026f631d996136191 URL: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191 DIFF: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191.diff

[clang] 753a324 - Make FunctionDecl::isDefined non-virtual, NFC

Author: Reid Kleckner Date: 2020-03-31T10:12:05-07:00 New Revision: 753a3245f7231ffd86b8af02e57da6ceb2ec5669 URL: https://github.com/llvm/llvm-project/commit/753a3245f7231ffd86b8af02e57da6ceb2ec5669 DIFF: https://github.com/llvm/llvm-project/commit/753a3245f7231ffd86b8af02e57da6ceb2ec5669.diff

[clang] 0edb212 - [MS] Mark vectorcall FP and vector args inreg

Author: Reid Kleckner Date: 2020-02-19T16:37:50-08:00 New Revision: 0edb2129258c727e9efe6fa234b28880ff64c1b9 URL: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9 DIFF: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9.diff

[clang] 04da3df - Forward declare special case lists

Author: Reid Kleckner Date: 2020-02-27T10:05:30-08:00 New Revision: 04da3dfecc199a7fdd262b06eeb399fc8ce0d1f6 URL: https://github.com/llvm/llvm-project/commit/04da3dfecc199a7fdd262b06eeb399fc8ce0d1f6 DIFF: https://github.com/llvm/llvm-project/commit/04da3dfecc199a7fdd262b06eeb399fc8ce0d1f6.diff

[clang] bc88366 - Forward declare FileEntry and DirectoryEntry in Module.h

Author: Reid Kleckner Date: 2020-02-27T10:18:06-08:00 New Revision: bc8836651fba3304d92e1025ff6a918f25e9e209 URL: https://github.com/llvm/llvm-project/commit/bc8836651fba3304d92e1025ff6a918f25e9e209 DIFF: https://github.com/llvm/llvm-project/commit/bc8836651fba3304d92e1025ff6a918f25e9e209.diff

[clang] 86565c1 - Avoid SourceManager.h include in RawCommentList.h, add missing incs

Author: Reid Kleckner Date: 2020-02-27T13:49:40-08:00 New Revision: 86565c13094236e022d2238f5653641aaca7d31f URL: https://github.com/llvm/llvm-project/commit/86565c13094236e022d2238f5653641aaca7d31f DIFF: https://github.com/llvm/llvm-project/commit/86565c13094236e022d2238f5653641aaca7d31f.diff

[clang] 0f6959f - Add some missing header dependencies

Author: Reid Kleckner Date: 2020-02-27T14:32:12-08:00 New Revision: 0f6959f3632a1131fe74f7dde33cc52778b02280 URL: https://github.com/llvm/llvm-project/commit/0f6959f3632a1131fe74f7dde33cc52778b02280 DIFF: https://github.com/llvm/llvm-project/commit/0f6959f3632a1131fe74f7dde33cc52778b02280.diff

[clang] 4c2a656 - Avoid ASTContext.h -> TargetInfo.h dep

Author: Reid Kleckner Date: 2020-02-27T14:35:00-08:00 New Revision: 4c2a6567bb12559cfc091bca2b25ae907cbd4e0f URL: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f DIFF: https://github.com/llvm/llvm-project/commit/4c2a6567bb12559cfc091bca2b25ae907cbd4e0f.diff

[clang] af450ea - Avoid including FileSystem.h from MemoryBuffer.h

Author: Reid Kleckner Date: 2020-02-29T12:30:23-08:00 New Revision: af450eabb925a8735434282d4cab6280911c229a URL: https://github.com/llvm/llvm-project/commit/af450eabb925a8735434282d4cab6280911c229a DIFF: https://github.com/llvm/llvm-project/commit/af450eabb925a8735434282d4cab6280911c229a.diff

[clang] 07ee46d - [MS] Fix constexpr data member pointer conversions

Author: Reid Kleckner Date: 2019-10-29T16:58:00-07:00 New Revision: 07ee46d613d7c1862878d7c7d1208a7b3e37459d URL: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d DIFF: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d.diff

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Mon, Oct 28, 2019 at 4:42 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If the intended behavior is to show the crash at the call site like >> LangRef in the patch suggest then line 0 will certainly not achieve that. I >> implicitly assumed the wording in LangRef would

[clang] 812bdb3 - [MS] Don't reference deleted copy ctors from catchable types

Author: Reid Kleckner Date: 2019-10-30T15:06:26-07:00 New Revision: 812bdb3c13210759341e8a1b08b864a539ce9dc7 URL: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7 DIFF: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7.diff

[clang] 5219435 - Disable new clang-scan-deps test on Windows due to backslash path matching problems

Author: Reid Kleckner Date: 2019-10-30T15:51:34-07:00 New Revision: 52194350cfe834f27e41771c315fe0656067fdc4 URL: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4 DIFF: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4.diff

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes might need to match two slashes, and the PREFIX variable ends up having inconsistent slash direction. On Wed, Oct 30, 2019 at 3:27 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Michael Spencer >

[clang] 19f1dc7 - Remove unneeded template alias, causes issues with some MSVC version

Author: Reid Kleckner Date: 2019-10-31T14:20:54-07:00 New Revision: 19f1dc7b527eade11dae9425c420cc9f450393b6 URL: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6 DIFF: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6.diff

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

r is convenient. On Wed, Oct 30, 2019 at 4:03 PM Michael Spencer wrote: > On Wed, Oct 30, 2019 at 3:54 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes >> might need to match tw

[clang] f37b5c8 - [RISCV] Fix up tests on Windows after new usage of sys::path::append

Author: Reid Kleckner Date: 2019-11-07T09:53:56-08:00 New Revision: f37b5c800e150ad915c4e0571edd2c92c0160d89 URL: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89 DIFF: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89.diff

[clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

Author: Reid Kleckner Date: 2019-11-07T10:39:29-08:00 New Revision: dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 URL: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 DIFF: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571.diff

[clang] 7177ce9 - [SEH] Defer checking filter expression types until instantiaton

Author: Reid Kleckner Date: 2019-11-07T14:52:04-08:00 New Revision: 7177ce978e8f8e5409cec90bad07df92441656e3 URL: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3 DIFF: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3.diff

[clang-tools-extra] e2369fd - [clang-include-fixer] Skip .rc files when finding symbols

Author: Reid Kleckner Date: 2019-11-14T10:04:35-08:00 New Revision: e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 URL: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 DIFF: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691.diff

[clang] 631be5c - Remove Support/Options.h, it is unused

Author: Reid Kleckner Date: 2019-11-15T13:32:52-08:00 New Revision: 631be5c0d41161057d02fe08a7aeb4fbde1a91d6 URL: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6 DIFF: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6.diff

[clang] 9053574 - Don't use end-of-line comments for the DebugInfoKind enum, NFC

Author: Reid Kleckner Date: 2019-11-15T14:06:23-08:00 New Revision: 905357440c98ae06aac692d7adbccc70f1ce9d28 URL: https://github.com/llvm/llvm-project/commit/905357440c98ae06aac692d7adbccc70f1ce9d28 DIFF: https://github.com/llvm/llvm-project/commit/905357440c98ae06aac692d7adbccc70f1ce9d28.diff

[clang] a77b66a - Allocate builtins table earlier to fix bug found by ubsan

Author: Reid Kleckner Date: 2019-11-18T10:41:30-08:00 New Revision: a77b66a05625ea4271c2d76f65428cce02e4699e URL: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e DIFF: https://github.com/llvm/llvm-project/commit/a77b66a05625ea4271c2d76f65428cce02e4699e.diff

[clang] 1ff5f0c - Revert "[Remarks][Driver] Use different remark files when targeting multiple architectures"

Author: Reid Kleckner Date: 2019-11-18T10:52:41-08:00 New Revision: 1ff5f0ced3163e457c799bd3bd838153806d6320 URL: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320 DIFF: https://github.com/llvm/llvm-project/commit/1ff5f0ced3163e457c799bd3bd838153806d6320.diff

Re: [clang] b4e2b11 - [Remarks][Driver] Use different remark files when targeting multiple architectures

I reverted this, the test fails for me locally. Does -arch work on non-Mac targets? On Mon, Nov 18, 2019 at 10:39 AM Francis Visoiu Mistrih via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Francis Visoiu Mistrih > Date: 2019-11-18T10:38:10-08:00 > New Revision: b4e2b112b58154a8917

[clang] 586f65d - Add a key method to Sema to optimize debug info size

Author: Reid Kleckner Date: 2019-11-19T12:42:33-08:00 New Revision: 586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8 URL: https://github.com/llvm/llvm-project/commit/586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8 DIFF: https://github.com/llvm/llvm-project/commit/586f65d31f32ca6bc8cfdb8a4f61bee5057bf6c8.diff

<    1   2   3   4   5   6   7   8   9   10   >