[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. This unfortunately breaks using Debian distribution CUDA. The Debian/Ubuntu special case

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tambre added a comment. In D108247#3025238 , @tra wrote: > So, what's the current state of affairs regarding CUDA SDK layout in debian? `/usr/bin`: most executables , `nvcc` and `

[PATCH] D110596: [CUDA] Move CUDA SDK include path further down the include search path.

tambre added a comment. Thank you for your quick turnaround. I can confirm that this works for me on Debian Unstable with my vendored LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110596/new/ https://reviews.llvm.org/D110596 ___

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre abandoned this revision. tambre added a comment. Abandoning since I don't think there's any further review/actions to be done here. D58531 would be the solution for the raised `pthread_create()` issue. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#3038277 , @ychen wrote: > In D77491#3038204 , @tambre wrote: > >> Abandoning since I don't think there's any further review/actions to be done >> here. >> D58531

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3041127 , @ricejasonf wrote: > I rebased onto `main` and made one small style fix. I don't think the rebase > changes anything. > > I do not understand why random things are failing in the CI. Even on my own > build m

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added inline comments. Comment at: clang/test/CodeGenCXX/pr45964-decomp-transform.cpp:1 +// RUN: %clang_cc1 -std=c++1z -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s + I'd prefer `-std=c++17` since the standard and flag have been finalized.

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

tambre added inline comments. Comment at: clang/test/SemaCXX/cxx2a-lambda-decltype-this.cpp:1-4 +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -emit-llvm-only %s +// RUN: %clang_cc1 -std=c++2a -fsyntax-only -fblocks -fdelayed-template-parsing %s +// RUN: %clang_cc1 -std=c

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2870291 , @jdoerfert wrote: > First: > Do I assume right this this feature was simply disabled without any plan to: > > - inform the authors (me) > - update the documentation > - re-enable support eventually or provide alt

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. This breaks the following code: struct sub { char data; }; struct main { constexpr main() { member = {}; } sub member; }; constexpr main a{}; With: fmt.cpp:16:16: error: constexpr variable '

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. In D103395#3105668 , @sepavloff wrote: > Strange, I see that it cannot be compiled neither by gcc nor by clang: > https://godbolt.org/z/1dY9Gs6zM. Do I miss something? Sorry, should've been more specific. Try in C++20 mode: http

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. I presume you lack the permissions to push this to the main repo yourself. Would you like me to do that for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 __

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3108013 , @ricejasonf wrote: > In D108482#3105889 , @tambre wrote: > >> I presume you lack the permissions to push this to the main repo yourself. >> Would you like me to do th

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb5aef90d4656: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964) (authored by ricejasonf, committed by tambre). R

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. A Clang 16 release note for this would be nice. I didn't immediately notice and got a bit broken by this change. 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133375/new/ https://reviews.llvm.org/D133375

[PATCH] D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited

tambre added a comment. In D127379#3581009 , @tschuett wrote: > Do you believe an entry in the ReleaseNotes would get this achievement more > visibility? I second that this would be worthy of a release note. Seems like quite a big improvement. I wonde

[PATCH] D61549: Fix use of 'is' operator for comparison

tambre added a comment. In D61549#1785369 , @Jim wrote: > @j-carl Could you give a Python 3.8 syntax reference for this change. This is not a language change in Python 3.8. AFAICT, the behaviour of `is` has been the same as long as Python has been in us

[PATCH] D75806: [CUDA] Add CUDA 10.2 detection

tambre created this revision. tambre added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75806 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Driver/

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre created this revision. tambre added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:642 + *this, CudaTriple, *HostTC, C.getInputArgs(), OFK); +

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:642 + *this, CudaTriple, *HostTC, C.getInputArgs(), OFK); + C.getArgs().AddJoinedArg( + nullptr, getOpts().getOption(options::OPT_cuda_version_EQ), This isn't very pr

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre updated this revision to Diff 248949. tambre added a comment. Add missing error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75811/new/ https://reviews.llvm.org/D75811 Files: clang/include/clang/Basic/Cuda.h clang/include/clang

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2579 + if (Version == CudaVersion::UNKNOWN) { +C.getDriver().Diag(clang::diag::err_drv_cuda_unknown_version) +<< VersionString; This error is hit when simply running `c

[PATCH] D75806: [CUDA] Add CUDA 10.2 detection

tambre added a comment. Thanks for the context! To avoid other people stepping into this trap, maybe it'd make sense to reword this warning to say "unsupported" instead of "unknown"? Or maybe add detection for newer versions, but introduce a separate warning for unsupported versions? Reposito

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. > Magically changing compiler target based on something external to compiler is > a bad idea IMO. I would expect a compilation with exactly the same compiler > options to do exactly the same thing. If we magically change default target, > that will not be the case. It'd

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. Thank you for the long and detailed explanation. It's been of great help! I've gone with the approach of trying the architectures in the most recent non-deprecated order – sm_52, sm_30. A problem with bumping the default architecture would have been that there are alre

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. In D75811#1923278 , @csigg wrote: > > I'll be adding a `CUDA_ROOT` option to CMake that will be passed to clang > > as `--cuda-path`. > > I'm not familiar with CMake and whether that option is picked up from an > environment varia

[PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

tambre added a comment. Your help here and over on CMake's side has been very helpful. Thank you! I'll @ you on CMake's side if I need any help while working on CUDA support. Hopefully you won't mind. :) I'm progressing on this and hope to have initial support in a mergeable state within two we

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

tambre added a comment. I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument '-std=c++2b' not allowed with 'C'`. This is invoked by Meson during its configuration process and causes it to fail. Am I doing

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. > > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all inside libc++. > Nothin

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195955 , @ldionne wrote: > @tambre Any appetite for a libc++ patch? :) > > Otherwise, let me know and I'll put it in my list of things to fix up. Sure, I can take it up during the weekend. CHANGES SINCE LAST ACTION

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. In D100046#2674311 , @sdesmalen wrote: > The fact that Clang chooses to (explicitly) forget about a builtin in > SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't > fully understand how the builtin mechani

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967 if (unsigned BuiltinID = NewFD->getBuiltinID()) { ASTContext::GetBuiltinTypeError Error; LookupNecessaryTypesForBuiltin(S, BuiltinID); QualType T = Context.GetBuiltinType(B

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre accepted this revision. tambre added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Probably worth mentioning what I had in my comment in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. Summary also looks good. 👍 You probably don't need to wait for more approvals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new/ https://reviews.llvm.org/D100046 ___ cfe-c

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre created this revision. tambre added a reviewer: phosek. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, lebedev.ri,

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre added a reviewer: ldionne. tambre added a comment. ldionne: for libc++ review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre updated this revision to Diff 315847. tambre added a comment. Don't modify third-party checked-in libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 Files: clang/CMakeLists.txt compiler-r

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added inline comments. Comment at: libcxx/utils/google-benchmark/CMakeLists.txt:3 - -project (benchmark) - ldionne wrote: > I don't think we want to change this. It's a third-party project (which is > inconvenientl

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-co

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://review

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

tambre requested changes to this revision. tambre added a comment. This revision now requires changes to proceed. Please: - Add a test case based on the one in the bug. Hopefully you'll be able to reduce it further now that you understand the bug. - Use imperative style for the commit message, i

<    1   2