[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

teemperor added a comment. I can land it, seems to pass all LLDB tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-commits mailing list cfe-com

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

This revision was automatically updated to reflect the committed changes. Closed by commit rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 139963. teemperor added a comment. - Added more test cases for reverse include order and clang modules. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp test/CXX/except/except.spec/Inputs/clang/mm_malloc.

[PATCH] D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource

teemperor created this revision. The MultiplexExternalSemaSource doesn't correctly overload the `getModule` function, causing the multiplexer to not forward this call as intended. https://reviews.llvm.org/D39416 Files: include/clang/Sema/MultiplexExternalSemaSource.h lib/Sema/MultiplexExte

[PATCH] D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource

teemperor updated this revision to Diff 120808. teemperor added a comment. - Removed `virtual` keyword when we already have `override`. https://reviews.llvm.org/D39416 Files: include/clang/Sema/MultiplexExternalSemaSource.h lib/Sema/MultiplexExternalSemaSource.cpp Index: lib/Sema/Multiple

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93180. teemperor added a comment. Herald added a subscriber: mgorny. Thanks for the review Artem! Changes: - No longer including the old LLVM hashing header. - Fixed the messed up comment formatting when i removed all the `\brief`s... - `CloneConstraint` i

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor marked 7 inline comments as done. teemperor added a comment. Hey Leslie, regarding performance: Last time I checked we spend most of the time on the verification of the hash values. We can do some tricks to make this faster (like delaying the verification to the end of the constraints

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor marked an inline comment as done. teemperor added a comment. Well this patch won't change a lot with the false-positives or performance (it's more refactoring) :) https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93270. teemperor added a comment. - Remove the `assert(ChildHash)` which is obviously wrong code that just rarely fails. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyz

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93302. teemperor added a comment. - `auto` to `const auto` to be more consistent with LLVM style. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 93503. teemperor added a comment. - Remove the mysterious unicode-character at the start of CloneDetection.cpp - Fixed formatting of the comment in CloneDetectionTest.cpp - Fixed comment in StmtSequence::contains that was still talking about checking for tr

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor added a comment. Change it to a namespace when merging if you prefer that :). Thanks for the review! https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 94337. teemperor added a comment. - Renamed variable from 'S' to 'Child' to make the buildbots happy (and because it's more expressive) - Fixed the name of the unit test. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:395 + + for (const Stmt *Child : S->children()) { +if (Child == nullptr) { I couldn't reproduce, but from what I assume form the warning and the crash that we confused the compiler

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor added a comment. I think for range loops work differently: #include #include #include struct Foo { int* begin() const { assert(false); } int* end() const { assert(false); } void bar() const { std::cout << "Different behavior" << std::endl; } }; int main() { std::vector F; F

[PATCH] D32113: Add path from clang to doxygen document include header

teemperor added a subscriber: cfe-commits. teemperor added a comment. https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32113: Add path from clang to doxygen document include header

teemperor added a comment. @yamaguchi Did you test the latest revision of this patch and get the desired output paths? I just tested it and it seems on my system doxygen can't handle the `@abs_srcdir@/../`. At least on my system it gets correctly generated as: STRIP_FROM_PATH= /home

[PATCH] D32113: Add path from clang to doxygen document include header

teemperor added a comment. Woops, my bad, seems like I tested just before you fixed it. Because I read in the documentation that we could also pass include paths here, we could also try something like this: STRIP_FROM_INC_PATH= @abs_srcdir@/.. STRIP_FROM_INC_PATH+= @abs_srcdir@/../i

[PATCH] D32113: Add path from clang to doxygen document include header

teemperor added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c yamaguchi wrote: > v.g.vassilev wrote: > > We should be stripping `@abs_srcd

[PATCH] D21675: New ODR checker for modules

teemperor added a comment. I feel like we have a really similar use case in the Analysis/CloneDetection{.h/.cpp} with the hashing of statements. I tried substituting the call to the statement hashing with a call to the CloneDetection API and it seems that most tests pass and the remaining fails

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

teemperor added a comment. Two thought from me on this: 1. I think we want to support completing both -cc1 and normal driver invocation. Most people use the driver, but for example during debugging people use the cc1 version, so both are valid use cases. I just saw we actually have the complet

[PATCH] D34329: [clang-diff] Initial implementation.

teemperor added a comment. I didn't have time to have a close look at this patch, but it seems you're interested in the specific TU-independent data of a Stmt to compare them. So if you are interested in the such data and don't want to write your own function to collect data it for each Stmt su

[PATCH] D34329: [clang-diff] Initial implementation.

teemperor added a comment. Yes, it does indeed skip identifiers and literals for this reason :). It was planned to make this template more configurable for use cases like yours, so I'm totally fine with adding configuration parameters. I just opened https://reviews.llvm.org/D34880 where I make

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

teemperor added a comment. > I'm not sure what you refer to by ` I just saw we actually have the > completion code in the Driver`. We are already auto completing both cc1 > options and driver options, right? Woops, I misread the code there. Never mind! > What about completing cc1 options only

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

teemperor accepted this revision. teemperor added a comment. LGTM, everything still works in the latest bash on Linux. Also thanks for the reviews Rui! https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. For the record, one can get a (maybe incomplete) list of options that are without completion via: `curl "https://teemperor.de/pub/clang_flags.txt"; | grep -v HelpText | grep -v Group`. T

[PATCH] D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API

teemperor added a comment. Yeah, we should move it, but it should land somewhere in a header in `/AST/` so that for example the StmtProfiler could make use of this. I'm open for suggestions here :) https://reviews.llvm.org/D34880 ___ cfe-commits m

[PATCH] D34329: [clang-diff] Initial implementation.

teemperor added a comment. @johannes https://reviews.llvm.org/D34880 has landed, so feel free to propose patches to the StmtDataCollector API that would help you (e.g. to support identifiers). You can see examples how to use it in the CloneDetection.cpp (once for storing data in a FoldingetSetN

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. It seems the code doesn't compile in clang because on your platform `std::vector` is implicitly included by some header, on clang+Arch however it isn`t (see the error at the en

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor added a comment. @yamaguchi yes, the reason why we have to treat the `-W...` flags specially should be documented (as they're not in the OptTable as you said). E.g. something like `// We have to query the -W flags manually as they're not in the OptTable.` and then maybe a `TODO: Find

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I have a last request in my inline comment regarding the documentation, otherwise this is good to go. Nice work! Comment at: clang/include/clang/Basic/DiagnosticIDs.h:

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

teemperor added a comment. ping. Any objections to adding this GCC alias? https://reviews.llvm.org/D34439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35762: [Bash-autocompletion] Fixed typo and add '-' after -Wno

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for the quick fix, LGTM! https://reviews.llvm.org/D35762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

teemperor accepted this revision. teemperor added a comment. LGTM. Comment at: clang/utils/bash-autocomplete.sh:60 eval local path=${COMP_WORDS[0]} - flags=$( "$path" --autocomplete="$arg" 2>/dev/null ) + flags=$( "$path" --autocomplete="$arg" 2>/dev/null | sed -e 's/\t.*.

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

teemperor added a comment. If you can't reproduce, you should try running a debug build through valgrind. It points out this issue: ==29522== Invalid read of size 4 ==29522==at 0x16EBED0: clang::LocationContext::getCurrentStackFrame() const (in /opt/clang/build/bin/clang-6.0) ==29522=

[PATCH] D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource

This revision was automatically updated to reflect the committed changes. Closed by commit rC323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D39416 Files: include/clang/Se

[PATCH] D37557: Refactor RecursiveASTVisitor test for post-order traversal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323310: Refactor RecursiveASTVisitor test for post-order traversal (authored by teemperor, committed by ). Herald added a

[PATCH] D37557: Refactor RecursiveASTVisitor test for post-order traversal

teemperor updated this revision to Diff 131204. teemperor added a comment. Herald added a subscriber: hintonda. - Rebased and clang formatted. https://reviews.llvm.org/D37557 Files: unittests/AST/CMakeLists.txt unittests/AST/PostOrderASTVisitor.cpp unittests/Tooling/CMakeLists.txt unitt

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 89084. teemperor added a comment. - Removed all the deprecated `\brief`s I couldn't find any actual regression in the code now, so from my side it's ok to merge it. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/A

[PATCH] D25604: Add support for Mageia Linux

teemperor added a comment. I just tested this on Mageia and this patch is superseded by now (it was originally written in 2013). The latest clang release is already able to correctly handle Mageia. (Also there is anyway comma missing at the end of each line) https://reviews.llvm.org/D25604

[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

teemperor added a comment. I think most of the changes are just necessary because we replaced `LLVM_MAIN_SRC_DIR` with `CMAKE_SOURCE_DIR` (all the added `../` and removed `docs`). On the other hand this is now in sync with the way the the clang doxygen.cfg is structured and it fixes the include

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. This also disables warnings for `-MD` and `-MMD` which shouldn't happen as we're actually compiling code here and are probably compiling a project. E.g. for people that use thi

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

teemperor created this revision. The UnknownPragmaHandlers added by t`DoPrintPreprocessedInput` conflict with the real PragmaHandlers from clang::Parser because they try to handle the same `#pragma` directives. This makes it impossible to use a Preprocessor (that was previously passed to DoPrin

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

teemperor updated this revision to Diff 96561. teemperor added a comment. - Now using unique_ptr instead of raw pointers. https://reviews.llvm.org/D32486 Files: lib/Frontend/PrintPreprocessedOutput.cpp Index: lib/Frontend/PrintPreprocessedOutput.cpp =

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

teemperor created this revision. As discussed in https://reviews.llvm.org/D30793, we have some unsafe calls to `isConsumerInterestedIn()`. This patch implements Richard's suggestion (from the inline comment) that we should track if we just deserialized an declaration. If we just deserialized, w

[PATCH] D33004: getIdentifierInfo now updates the returned information by default

teemperor created this revision. Calling `Preprocessor::getIdentifierInfo` is not automatically updating the returned identifier at the moment. This patch adds a flag that is ensuring by default that the returned IdentifierInfo is updated. The flag is true by default because that seems like the

[PATCH] D33004: getIdentifierInfo now updates the returned information by default

teemperor planned changes to this revision. teemperor added a comment. Work in progress patch. We probably also need to update a few other places where we call this. https://reviews.llvm.org/D33004 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor created this revision. In the current local-submodule-visibility mode, as soon as we discover a virtual destructor, we declare on demand a global delete operator. However, this causes that this delete operator is owned by the submodule which contains said virtual destructor. This mean

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor added a comment. I'm not 100% sure if that's the right fix, but I didn't see a obvious way to declare the new/delete outside the current submodule. Maybe Richard knows a better way :) https://reviews.llvm.org/D33366 ___ cfe-commits maili

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor updated this revision to Diff 99728. teemperor edited the summary of this revision. teemperor added a comment. - Now unhiding/unowning the created functions like Richard suggested. - Extended the test case to stress test the lookup with the new visibility settings. https://reviews.llv

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

teemperor added a comment. I'm really sorry @martong , but I no longer work on LLDB (or the ASTImporter) and I'm not really in the loop regarding LLDB development. (Having said that, I still happy to answer questions about my own patches/reviews that I did in the past in case there are question

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. Not sure what the backtrace is for the `clang::FieldDecl::isZeroSize` crash but what might relevant: 1. The ASTImporter test isn't using the 'Minimal' import mode that LLDB is using. In the tests we are importing all declarations directly. In LLDB we use the 'minimal

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. Sorry for the delay. I think all my points have been resolved beside the insertion SourceLoc. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) +

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I believe everything I pointed out so far has been resolved. I still have one more nit about the unit test though (just to not make it fail on some Windows setups). FWIW, given that thi

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. (Obviously this should still wait on Richard & John as I think they still have unaddressed objections) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailin

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. By the way, I set up a WIP patch for changing LLDB's import away from the current MinimalImport of records to something that is more in line with how Clang works: https://reviews.llvm.org/D101950 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

teemperor added a comment. Just to be clear, I am not sure when/if D101950 is ready. It's mostly blocked by me not having the time to work on it, so depending how my schedule is this might land soon or far in the future. Just linked it here as this (temporary)

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: whisperity. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98

[PATCH] D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe421a74108ee: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name (authored by teemperor). Herald added a subscriber: cfe-commits.

[PATCH] D99162: [ASTImporter] Split out Objective-C related unit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG274907c0a4d6: [ASTImporter] Split out Objective-C related unit tests (authored by teemperor). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D99512: [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbba533ec93: [ObjC][CodeGen] Fix missing debug info in situations where an instance and… (authored by teemperor). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D99740: Avoid calling ParseCommandLineOptions in BackendUtil if possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60854c328d87: Avoid calling ParseCommandLineOptions in BackendUtil if possible (authored by teemperor). Herald added a subscriber: cfe-commits. Repo

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Would be nice to have the motivation for this in the commit message (IIUC this is based on the suggestion from D109948

[PATCH] D102923: [clang][lex] Remark on search path usage

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. This seems to have broken compiling some versions of Foundation/Dispatch with -fmodules enabled (which breaks the LLDB test suite when it tries to compile any Objective-C tests). Can you

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

teemperor added a comment. This broke the modules build: While building module 'LLVM_Utils' imported from lvm/lib/Support/TargetParser.cpp:14: In file included from :209: llvm/include/llvm/Support/RISCVISAInfo.h:15:10: fatal error: could not build module 'LLVM_Option' #include "llvm/Opt

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

teemperor added a comment. In D105168#3071152 , @craig.topper wrote: > In D105168#3069499 , @teemperor > wrote: > >> This broke the modules build: >> >> While building module 'LLVM_Utils' imported from >> lvm

[PATCH] D108919: [clan-repl] Install clang-repl

teemperor added a comment. This is essentially what D106813 was supposed to do, so this is also LGTM. You probably want to file a bugreport for @tstellar to cherry-pick this to the release. The biggest impact from this seems to be that it increases the release

<    1   2   3   4