[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652785 , @AlexVlx wrote: > In D155775#4652780 , @dyung wrote: > >> >> At this point, would it be easier to add a REQUIRES line for the target the >> test should support rather

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

ro added a comment. In D155775#4652872 , @AlexVlx wrote: > In D155775#4652851 , @ro wrote: > >> In D155775#4652785 , @AlexVlx >> wrote: >> >>> In D155775#4652780

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro created this revision. ro added reviewers: vitalybuka, MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. As detailed in Issue #64126, several asan tests `FAIL` due to a cycle in `AsanInitInternal`.

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro added a comment. In D156325#4537237 , @MaskRay wrote: > This needs a clang/test/Driver test. Indeed, I forgot. Added now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

ro updated this revision to Diff 544660. ro added a comment. Add testcases. Re-tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156325/new/ https://reviews.llvm.org/D156325 Files: clang/l

[PATCH] D156325: [Driver] Link shared asan runtime lib with -z now on Solaris/x86

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b5149aa442e: [Driver] Link shared asan runtime lib with -z now on Solaris/x86 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 549925. ro added a comment. Herald added a subscriber: mgrang. Updated based on discussions in Issue #53709: - Sort Solaris GCC prefixes in reverse version order so the latest version is picked. - Update testcase to match. Tested on `amd64-pc-solaris2.11` and `x

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro marked an inline comment as done. ro added a comment. In D157275#4585184 , @MaskRay wrote: > Thanks for the update. Regarding testing, it seems that unittests will be > more convenience than creating so many placeholder files in `Inputs/`. > `clang/u

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 550226. ro marked an inline comment as done. ro added a comment. Herald added a subscriber: ormris. - Simplify `SolarisPrefixes` sorting. - Switch to unitest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157275/new

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae84ad15efd7: [Driver] Select newest GCC installation on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D157275?vs=55

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently lacks PIE support on Solaris. This patch fixes this. Tested on `amd6

[PATCH] D158207: [Driver] Link with crtbeginS.o/crtendS.o on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` doesn't currently use `crtbeginS.o` and `crtendS.o` on Solaris with `-p

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro marked 2 inline comments as done. ro added a comment. In D158206#4596471 , @MaskRay wrote: >> I'll submit a follow-up patch to make use of crtbeginS.o and crtendS.o >> shortly. > > I think this patch should make this change, so that the change is corr

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro updated this revision to Diff 551539. ro marked 2 inline comments as done. ro edited the summary of this revision. ro added a comment. Herald added a subscriber: jrtc27. - Merged D158207 . - Incorporate review comments. Repository: rG LLVM Github Monorepo

[PATCH] D158207: [Driver] Link with crtbeginS.o/crtendS.o on Solaris

ro abandoned this revision. ro added a comment. Merged into D158206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158207/new/ https://reviews.llvm.org/D158207 ___ cfe

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:136 +const char *crtbegin = nullptr; +if (Args.hasArg(options::OPT_shared) || IsPIE) + crtbegin = "crtbeginS.o"; MaskRay wrote: > Q: In

[PATCH] D158206: [Driver] Add PIE support on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ro marked an inline comment as done. Closed by commit rG62945bb81116: [Driver] Add PIE support on Solaris (authored by ro). Changed prior to commit: https://reviews.

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. Solaris 12 was re-christened as Solaris 11.4 while still in beta, so all references are long obsolete and

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. It seems the latest commit of this patch has (re-)introduced two failures on the Solaris/amd64 buildbot : FAIL: Clang::clang_f_opts.c FAIL: Clang::lto.c I cannot really make sense of that. Repository: rG LLVM

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4553043 , @ro wrote: > It seems the latest commit of this patch has (re-)introduced two failures on > the Solaris/amd64 buildbot > : > > FAIL: Clang::clang_f_opts

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. In D156363#4554884 , @MaskRay wrote: > In D156363#4554812 , @jhuber6 wrote: > >> >> Probably because we're not specifying the `--target=` I'll add that in my >> fix for AMDGPU I'm working

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro added a comment. In D156861#4555280 , @MaskRay wrote: > While you are modifying the lines `static const char ...[]` should look > better than `static const char *const SolarisX86Triples[]` While this would certainly avoid the ugly formatting, it does

[PATCH] D156861: [Driver] Remove references to Solaris 12

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0dc887d7ed2: [Driver] Remove references to Solaris 12 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156861/new/ https://reviews.llvm.org/

[PATCH] D155736: Fix __cfi_check not aligned to 4k on relocatable files with no executable code

ro added a comment. It seems this patch broke the Solaris/amd64 buildbot : FAIL: Clang::cfi-check-fail.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155736/new/ https://reviews.llvm.or

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Since GCC 11, the bundled Solaris/SPARC GCC uses the `sparcv8plus` subdirectory

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

ro added inline comments. Comment at: clang/test/Driver/lit.local.cfg:23 ".yaml", +".test", ] MaskRay wrote: > Instead of adding a new extension, you can just name your test `.c`? I could, but went for `.test` instead because the `clang` invocations do

[PATCH] D157013: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43dfe0f08eca: [Driver] Allow for sparcv8plus subdir with Solaris/SPARC GCC (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. As described in Issue #53709

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arrive in

[PATCH] D158955: [Driver] Improve legibility of ld -z options on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, fedor.sergeev, emaste. Herald added a project: All. ro requested review of this revision. Following the lead of the Linux code, this patch passes the `ld -z` options as two separa

[PATCH] D158959: [clang-tidy] Disambiguate calls to log

ro created this revision. ro added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, pengfei, zzheng, fedor.sergeev, xazax.hun, jyknight. Herald added a reviewer: njames93. Herald added a project: All. ro requested review of this revision. Herald added a project: clang-tools-extra. c

[PATCH] D158959: [clang-tidy] Disambiguate calls to log

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03dff0d4acaf: [clang-tidy] Disambiguate calls to log (authored by

[PATCH] D158955: [Driver] Improve legibility of ld -z options on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG779353e576ea: [Driver] Improve legibility of ld -z options on Solaris (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554711. ro retitled this revision from "[WIP][clang][Driver] Support GNU ld on Solaris" to "[Driver] Support GNU ld on Solaris". ro added a comment. Herald added subscribers: llvm-commits, Sanitizers, Enna1, ormris. Herald added a reviewer: sscalpone. Herald added

[PATCH] D159222: [clang] Consistently use isOSSolaris()

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. While looking over the Solaris GNU ld patch (D85309 ),

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305 +bool tools::isLinkerGnuLd(const ToolChain &TC, const ArgList &Args) { + // Only used if targetting Solaris. MaskRay wrote: > I suppose th

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554946. ro marked an inline comment as done. ro added a comment. Move `isLinkerGnuLd` to `Solaris.{h,cpp}` and into `solaris` namespace to make it unambigously clear where to use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:59 // RUN: %clang -### --offload-arch=gfx906 --offload-arch=gfx1030 \ -// RUN: --target=x86_64-pc-windows-msvc \ +// RUN: --target=x86_64-pc-windows-msvc -fuse-ld= \ // RUN: -nogpuinc -nog

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently defaults to DWARF 2 on Solaris. This dates back to LLVM 3.8.0. I suspect thi

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/test/CodeGen/dwarf-version.c:7 // RUN: %clang -target x86_64-linux-gnu -gdwarf -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER5 +// RUN: %clang -target i386-pc-solaris -g -S -emit-llvm -o -

[PATCH] D159352: [Driver] Don't default to DWARF 2 on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ro marked an inline comment as done. Closed by commit rGb1b1f364d633: [Driver] Don't default to DWARF 2 on Solaris (authored by ro). Changed prior to commit: https:/

[PATCH] D85309: [Driver] Support GNU ld on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd39a9e3b4d4a: [Driver] Support GNU ld on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D85309?vs=554946&id=555463#to

[PATCH] D159222: [clang] Consistently use isOSSolaris()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc7b753a5cd: [clang] Consistently use isOSSolaris() (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. This introduced a new failure on Solaris: FAIL: Flang :: Driver/pass-plugin-not-found.f90 Running the failing command manually shows: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory' whi

[PATCH] D129156: Add -fpass-plugin option to Flang

ro added a comment. In D129156#3949194 , @awarzynski wrote: > > Sorry that you are hitting this - things like this happen, sadly. I think > that the easiest to resolve it would be to tweak the expected error so that > it works on Solaris as well as

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro created this revision. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, lit complains llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS' The following patch avoids this: Solaris uses L

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro added a comment. Thanks. Could someone please commit it for me? https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

ro added a comment. Could someone please commit this for me? I've no commit access. Thanks. https://reviews.llvm.org/D39640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. What's the status here? This patch is required for my WIP sanitizers-on-Solaris work. https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

ro added a comment. In https://reviews.llvm.org/D35755#931120, @krytarowski wrote: > Do we still target Oracle Solaris or SmartOS? Just wondering and noted the > domain change in e-mail. Both, I'd say ;-) They still have much common heritage and the vast majority of linker/toolchain work on

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. Thanks. Could you please commit this for me? Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^2 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I believe there's nothing more left for me here. Is the patch ok now? Thanks. Rainer Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro created this revision. ro added reviewers: fedor.sergeev, tstellar, jyknight. This patch is meant to address the last outstanding review comment on the already approved (but not yet commited) https://reviews.llvm.org/D35755, namely making the handling of the RHEL devtoolsets Linux-specific.

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro added a comment. Thanks for the quick review. Could you commit the base patch (which had been approved some time ago) and this one? Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro added a comment. Excellent, thanks a lot. Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. ping Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^3 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro created this revision. ro added reviewers: jyknight, venkatra, efriedma, jrtc27. ro added a project: clang. Herald added a subscriber: fedor.sergeev. ro requested review of this revision. Herald added a subscriber: cfe-commits. Even after D86621 , `clang -m32` o

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > joerg wrote: > > This comment is misleading. It

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > glaubitz wrote: > > > joerg wrote

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

ro added a comment. One test `FAILs` on Solaris/sparcv9: LLVM :: CodeGen/Generic/ForceStackAlign.ll with LLVM ERROR: Function "g" required stack re-alignment, but LLVM couldn't handle it (probably because it has a dynamic alloca). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403604. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. - Clarify comment. - Use `__ATOMIC_SEQ_CST`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://r

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro updated this revision to Diff 403607. ro marked an inline comment as done. ro added a comment. Omit `sanitizer_atomic_clang.h` part, belongs to D118021 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. Ping. This hasn't been reviewed in more than a year and is still required for D91608 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3280808 , @efriedma wrote: > Testcase? I thought the 3 testcases adjusted in D91608 to use `__builtin_extract_return_addr` and fixed by this patch were enough. Otherwise, should I just aug

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3285825 , @efriedma wrote: > In D91607#3283350 , @ro wrote: > >> In D91607#3280808 , @efriedma wrote: >> >>> Testcase? >> >> I thought the 3 tes

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro updated this revision to Diff 404939. ro added a comment. Herald added a subscriber: jrtc27. - Use `CreateGEP` - Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 Files: clang/lib/CodeGen/Ta

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added a comment. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118021/new/ https://reviews.llvm.org/D118021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefdd0a29b7eb: [clang][Sparc] Fix __builtin_extract_return_addr etc. (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://revie

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro marked 2 inline comments as done. ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we use sysroot to make these tests Mas

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 409881. ro marked 2 inline comments as done. ro added a comment. Test fixes as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files: clang/lib/Driv

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6 +/// Check sparc-sun-solaris2.11, 32bit +// RUN: %clang %s -### 2>&1 \ +// RUN: --target=sparc-sun-solaris2.11 \ MaskRay wrote: > The first line is now shorter. You can move --ta

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 410083. ro added a comment. Testcase formatting improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files: clang/lib/Driver/ToolChains/Solaris.cpp clang/test

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fc966d2e41: [Driver] Support Solaris/amd64 GetTls (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D11

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro abandoned this revision. ro added a comment. Superceded by D119829 and D120048 . If absolutely necessary, D120059 could be revived if Illumos cannot implement `dlpi_tls_modid`. Reposito

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +// Solar

<    1   2   3