[libc] [libcxx] [compiler-rt] [lldb] [flang] [clang-tools-extra] [lld] [clang] [llvm] LLVM_FAULTMAPS section can be put after the DWARF section. (PR #77107)

espindola wrote: I no longer work on llvm: https://lists.llvm.org/pipermail/llvm-dev/2018-May/122922.html shamithoke ***@***.***> writes: > @espindola > > -- > Reply to this email directly or view it on GitHub: > https://github.com/llvm/llvm-project/pull/77107#issuecomment-1914952526 > You

Re: [PATCH] D11980: Add test for PR24379

rafael accepted this revision. rafael added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D11980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D12511: [LTO] Pass -no-zero-initialized-in-bss on linker command line

rafael added a subscriber: rafael. rafael added a comment. Looks like something that should be in the bitcode, no? What happens if one compile unit has it and another one doesn't? http://reviews.llvm.org/D12511 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D19952: AMDGPU: Use lld as the linker again

rafael added a subscriber: rafael. rafael added a comment. lgtm http://reviews.llvm.org/D19952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a subscriber: rafael. rafael added a comment. Can you check what GCC does? http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a comment. OK, it prints assembly with ir in it. That doesn't apply to us since .BC is not elf. I guess we could just produce assembly. A .ll cannot be used for lto. So I guess this is OK, but please wait to see what others think. Cheers, Rafael http://reviews.llvm.org/D21006

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a comment. Fair enough, let's keep it as is and try to update the build. Cheers, Rafael http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

rafael added a subscriber: rafael. rafael added a comment. This is awesome! Comment at: include/clang/CodeGen/BackendUtil.h:38 @@ -37,3 +37,3 @@ const TargetOptions &TOpts, const LangOptions &LOpts, - StringRef TDesc, llvm::Modul

Re: [PATCH] D16138: Correct setting of UserLabelPrefix for MCU target

rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far mor

Re: [PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""

rafael added a comment. Thanks for working on this, but many of the changes setting the prefix to "_" look wrong. Comment at: lib/Basic/Targets.cpp:801 @@ -818,2 +800,3 @@ LongDoubleFormat = &llvm::APFloat::PPCDoubleDouble; +UserLabelPrefix = "_"; }

Re: [PATCH] D16469: Pass --wrap=pthread_create to linker for -fsplit-stack

rafael added a subscriber: rafael. rafael added a comment. Needs a testcase. http://reviews.llvm.org/D16469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16469: Pass --wrap=pthread_create to linker for -fsplit-stack

rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D16094: Debugger tuning via gold plugin

rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16094 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D15705: Adding a scripted test for PR25717

rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM assuming you can get the test to fail by reverting the fix http://reviews.llvm.org/D15705 ___ cfe-commits m

Re: [PATCH] D16469: Pass --wrap=pthread_create to linker for -fsplit-stack

rafael closed this revision. rafael added a comment. 258698 http://reviews.llvm.org/D16469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14691: clang side of http://reviews.llvm.org/D14690

rafael created this revision. rafael added a reviewer: chandlerc. rafael added a subscriber: cfe-commits. Herald added a reviewer: tstellarAMD. http://reviews.llvm.org/D14691 Files: include/clang/Lex/HeaderSearchOptions.h include/clang/Sema/Sema.h lib/AST/VTableBuilder.cpp lib/CodeGen/CGO

Re: [PATCH] D14691: clang side of http://reviews.llvm.org/D14690

rafael abandoned this revision. rafael added a comment. In the end we changed only SetVector. http://reviews.llvm.org/D14691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15641: [Driver] Pass -O* to the gold plugin via -plugin-opt

rafael added a subscriber: rafael. rafael added a comment. This introduces a meaning to -ON during the link. That normally show up by people passing CFLAGS when linking. I think that is OK, but would like a second opinion. Comment at: lib/Driver/Tools.cpp:1815 @@ +1814,3 @@ +