[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. In unit test "DetectClangFormatOn" is my real case. I have problems with D94201 and D94217 so i tried to turn off sorting for first block (with #pragma hdrstop at the end of this block). But sorting tu

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. Currently at work we use Embarcadero Builder C++ In builder all above #pragma hdrstop is a precompiled header. And we have this #pragma at almost all cpp files, so mainInclude is ignored because is in second include block. `#pragma hdrstop( "c:\\projects\\include\\myin

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. there is no related bug. About Line.endswith("\\") -> Trimmed.endswith("\\") When i debugging clang-format, i noticed that "Line.endswith("\\")" never result with true (even if i put \ at the end of line - in my case CRLF). But when i change line ending to LF condition

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. In D94206#2483901 , @MyDeveloperDay wrote: > I'm not seeing this > > // clang-format off > #include "d.h" > #include "b.h" > // clang-format on > > #include "a.h" > #include "c.h" > #include "e.h" > > $ unix2

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. heh, maybe you seen unexpectedly closed IDE, errors while expanding list in source editor or blinking gui, etc ;D I made plugin to use clang-format in Builder. After reading the msvc documentation, I agree with you. `#pragma hdrstop( "c:\\projects\\include\\myinc.pch"

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315166. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clang/unittests/Format/SortIncludesTest.cpp

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315169. rjelonek added a comment. Add support to `#pragma hdrstop( "c:\\projects\\include\\myinc.pch" )' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittest

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315223. rjelonek added a comment. Add test to check extended form of `#pragma hdrstop` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortInclu

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. In D94217#2485178 , @curdeius wrote: > LGTM if you add a test for hdrstop(filename) and possibly with LF newline (as > the test you've already added tests CRLF). You would like to 2 unit tests called `DoNotTreatPrecompiledHeade

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315236. rjelonek added a comment. Use LF instead of CRLF for case with extended `#pragma hdrstop` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Forma

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. "Rafał Jelonek <71409580+rjelo...@users.noreply.github.com>" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. no, i upload diff file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315424. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. @curdeius Can you commit this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315428. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315431. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315509. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315513. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315516. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor