quinnp updated this revision to Diff 356719.
quinnp added a comment.
Addressing review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeG
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[NFC] This patch adds features for pwr7, pwr8, and pwr9 that can be
used for semacheking builtin func
quinnp updated this revision to Diff 356774.
quinnp added a comment.
Updating pwr10 features to include previous features.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/new/
https://reviews.llvm.org/D105501
Files:
clang/lib/Basic/Targets/
quinnp added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2
// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \
-// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s
+// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s
//
quinnp updated this revision to Diff 357297.
quinnp added a comment.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
Work in progress addressing review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/n
quinnp updated this revision to Diff 357516.
quinnp added a comment.
Adressing some review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103986/new/
https://reviews.llvm.org/D103986
Files:
clang/include/clang/Basic/BuiltinsPPC.def
cl
quinnp updated this revision to Diff 357604.
quinnp added a comment.
Feature is now working correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/new/
https://reviews.llvm.org/D105501
Files:
clang/include/clang/Basic/DiagnosticSemaKind
quinnp updated this revision to Diff 357644.
quinnp added a comment.
Parameterizing the ppc builtin arch sema error.
This change is made assuming that the SemaFeatureCheck will be used by other
builtins in the future. SemaFeatureCheck is commented to avoid an unused
function error when building
quinnp updated this revision to Diff 357942.
quinnp added a comment.
Addressing some review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/new/
https://reviews.llvm.org/D105501
Files:
clang/include/clang/Basic/DiagnosticSemaKinds
quinnp updated this revision to Diff 358004.
quinnp added a comment.
Adding tests for each of the features
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/new/
https://reviews.llvm.org/D105501
Files:
clang/include/clang/Basic/DiagnosticSema
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch is in a series of patches to provide builtins for compatibility with
the XL compiler. Thi
quinnp updated this revision to Diff 358049.
quinnp added a comment.
Addressing review comments.
Using an early exit for SemaFeatureCheck and combining the 3 test cases into 1.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105501/new/
https://revi
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch fixes `__builtin_ppc_recipdivf`, `__builtin_ppc_recipdivd`,
`__builtin_ppc_rsqrtf`, and `_
quinnp updated this revision to Diff 358609.
quinnp marked 9 inline comments as done.
quinnp added a comment.
Addressing review comment about indentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
F
quinnp updated this revision to Diff 358613.
quinnp retitled this revision from "[PowerPC] Restore FastMathFlags of Builder
for Vector FDiv Builtins " to "[PowerPC] Restore FastMathFlags of Builder for
Vector FDiv Builtins".
quinnp added a comment.
Fixing indentation.
Repository:
rG LLVM Git
quinnp updated this revision to Diff 358637.
quinnp added a comment.
Removing a misleading comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/Co
quinnp updated this revision to Diff 358639.
quinnp added a comment.
Removing another comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105360/new/
https://reviews.llvm.org/D105360
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen
quinnp created this revision.
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota,
teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,
Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst,
shauheen, rriddle, mehdi_amini, usaxena95,
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc71fbdd87b35: [NFC] Inclusive language: Remove instances of
master in URLs (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
quinnp created this revision.
Herald added a reviewer: bollu.
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota,
teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,
Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst,
shauheen, r
quinnp created this revision.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[NFC] As part of using inclusive language within the llvm project, this patch
replaces `_myMaster` with `_myLeader` in these testcases.
Repository:
rG
quinnp created this revision.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[NFC] This patch replaces `masterPort` with `mainPort` in these
testcases.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D113505
Files
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc3b15b71ce00: [NFC] Inclusive Language: change master to
main for .chm files (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113299/new/
quinnp created this revision.
Herald added a subscriber: kristof.beyls.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[NFC] As part of using inclusive language within the llvm project and to
match the renamed master branch, this pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd4b28a0fe685: [NFC][clang] Inclusive language: replace
master with main in convert_arm_neon.py (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5ed404a4abd3: [NFC][clang] Inclusive language: Rename
myMaster in testcase (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
quinnp created this revision.
Herald added subscribers: pengfei, hiraditya.
quinnp requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
[NFC] As part of using inclusive language within the llvm project, this patch
renames maste
quinnp created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
quinnp requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
[NFC] As part of using inclusive language within the llvm project, this patch
replaces
quinnp created this revision.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[NFC] As part of using inclusive language within the llvm project, this patch
replaces master with controller in `debug-info-block-helper.m`.
Repository:
quinnp marked an inline comment as done.
quinnp added inline comments.
Comment at: clang-tools-extra/clangd/Protocol.h:141
/// the server can send `null` to indicate that the version is known and the
- /// content on disk is the master (as speced with document content
owners
quinnp updated this revision to Diff 387990.
quinnp marked an inline comment as done.
quinnp added a comment.
Addressing review comments. Reverting change to `Protocol.h`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114100/new/
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a14244cc645: [NFC][clang] Inclusive language: replace
masterPort with mainPort (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113505/ne
quinnp updated this revision to Diff 388511.
quinnp added a comment.
Changing master to controller in another testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114108/new/
https://reviews.llvm.org/D114108
Files:
clang/test/CodeGenObjC/debu
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGad501054f1b5: [NFC][clang] Inclusive language: rename master
variable to controller in debug… (authored by quinnp).
Repository:
rG LLVM Github Mon
quinnp added a comment.
@sammccall could you take a look at the other changes when you have time?
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114100/new/
https://reviews.llvm.org/D114100
___
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language:
replace master with main (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D11410
quinnp accepted this revision.
quinnp added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114029/new/
https://reviews.llvm.org/D114029
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb11c66accfb1: [NFC] Inclusive language: rename master flag
to main flag (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114090/new/
http
quinnp added a comment.
Hi @MaskRay, could you please take a look at @nemanjai's suggestion?
> ...
> So I would prefer that we handle this in the CMake files if @MaskRay doesn't
> object.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1298
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG35aaf548237a: [clang][driver] fix to correctly set
devtoolset on RHEL (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
quinnp created this revision.
Herald added a project: All.
quinnp requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
This patch correctly sets the devtoolset on RHEL.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D1
quinnp updated this revision to Diff 435239.
quinnp added a comment.
Addressing review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127310/new/
https://reviews.llvm.org/D127310
Files:
clang/lib/Driver/ToolChains/Gnu.cpp
Index: clang
quinnp marked 2 inline comments as done.
quinnp added a comment.
Thank you @nemanjai! I've updated the patch based on your suggestion and tested
it for both the existing testcase and the RHEL buildbot failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
quinnp updated this revision to Diff 435914.
quinnp added a comment.
Herald added a subscriber: ormris.
Addressing review comments. Removing path without `/root/usr` prefix and
changing unit test to match.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
quinnp added a comment.
Thanks @tbaeder, @MaskRay, and @nemanjai.
> I did not remove that on purpose, so adding it back makes sense to me.
I've updated the patch to remove the path without the `/root/usr` suffix and
exclusively add the path with the `root/usr` suffix.
> This change also needs
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6a028296fe62: [PowerPC] Emit warning when SP is clobbered by
asm (authored by quinnp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
quinnp updated this revision to Diff 395687.
quinnp added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Adressing review comments. Added register alias "sp" for the register "r1".
Added a front end testcase to test the location information and all of the
aliases
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
quinnp requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This patch is in a series of patches to provide builtins for
compatabili
quinnp updated this revision to Diff 372243.
quinnp added a comment.
Adding SemaChecking for the first argument of __builitn_ppc_test_data_class so
the llvm_unreachable in CGBuiltin is actually unreachable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds range checking for some Power10 altivec builtins and
changes the signature of a built
quinnp updated this revision to Diff 372479.
quinnp added a comment.
Fixing failing test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109710/new/
https://reviews.llvm.org/D109710
Files:
clang/lib/Headers/altivec.h
clang/lib/Sema/SemaChe
quinnp created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
quinnp requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds range checking for some Power10 altivec builtins. Range
checking is done in SemaCheck
quinnp updated this revision to Diff 372541.
quinnp added a comment.
Removing an extra space.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109710/new/
https://reviews.llvm.org/D109710
Files:
clang/lib/Headers/altivec.h
clang/lib/Sema/SemaChec
101 - 153 of 153 matches
Mail list logo