[PATCH] D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin

quinnp accepted this revision. quinnp added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128288/new/ https://reviews.llvm.org/D128288 __

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 419126. quinnp added a comment. Moving testcases that require code generation from `clang/test/Sema/ppc-pair-mma-types.c` to `clang/test/CodeGen/PowerPC/ppc-mma-types.c` and `clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c`. This is because some of

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->ge

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448016. quinnp marked 5 inline comments as done. quinnp added a comment. Addressing review comments: fixing test cases and improving test case clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ h

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf565444b486d: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448036. quinnp added a comment. Adding lit config to mark tests as unsupported for non PPC targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6cc5ddc9478: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359077. quinnp added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Removing some FIXME comments and tests that are handled elsewhere with semachecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359079. quinnp added a comment. Typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ https://reviews.llvm.org/D105834 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builtins-ppc-xlcomp

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 nemanjai wrote: > Oh, I beli

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359093. quinnp marked an inline comment as done. quinnp added a comment. Adressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/C

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359116. quinnp added a comment. Adding `REQUIRES: powerpc-registered target` to front end test case`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/li

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359118. quinnp added a comment. Removing a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/built

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. This

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359310. quinnp added a comment. Adressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359325. quinnp added a comment. Fixing a syntax error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/B

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

quinnp updated this revision to Diff 359327. quinnp added a comment. Removing entry checks from front end test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsP

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 359338. quinnp added a comment. Removing entry checks from front end test and renaming a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/C

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359398. quinnp added a comment. Adding a `REQUIRES: powerpc-registered-target` to a testcase and removing checks for `entry:` in front end test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ ht

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359426. quinnp marked 8 inline comments as done. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clan

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359437. quinnp added a comment. Adding a better comment for the handling of the ppc_fsels intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inc

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359441. quinnp added a comment. Fixing a run line in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359783. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360128. quinnp added a comment. Rebasing patch. Moving macro definitions from a header file to a src file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: cla

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360261. quinnp added a comment. Rebasing to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Ta

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360408. quinnp added a comment. Rebasing to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/T

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe002d251dd34: [PowerPC] Floating Point Builtins for XL Compat. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp added a comment. In D103986#2893177 , @DavidSpickett wrote: > You missed a REQUIRES for the llvm test, I added one in: > https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5 > > So if you see Arm-AArch64 quick bot failures, that wa

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility]

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, mgorny, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch is in a series of patches to provide builtins for com

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 362400. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors `EmitPPCBuiltinExpr` in `CGBuiltin.cpp` to remove t

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 415412. quinnp added a comment. Minor formatting update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 416917. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421279. quinnp marked an inline comment as done. quinnp added a comment. Fixing some testcases that broke due to re-ordering IR in my last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https:

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Value *Y = +Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3)); return Builder.CreateOr(X, Y); nemanjai wrote: > Nit: I understand that we only

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421286. quinnp added a comment. Rebasing with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/Power

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421303. quinnp added a comment. Fixing a set of builtins added by the rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBu

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added a comment. In D121637#3437371 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/55893/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for finding this, not sure what

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp reopened this revision. quinnp added a comment. This revision is now accepted and ready to land. Re-opening the revision so that I can update it with a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch rewords a comment to replace Whitelist with Allo

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

This revision was automatically updated to reflect the committed changes. Closed by commit rG0386213352ec: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/ (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch changes the default linker for `clang`

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445628. quinnp added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Updating patch with a `clang` change to properly forward `-data-sections=0` to `libLTO`/`gold` when `-fno-data-sections` is explicitly specified. R

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445631. quinnp added a comment. Updating patch to forward `-data-sections=1` to `libLTO`/`gold` instead of just `-data-sections` when `-fdata-sections` is explicitly specified in `clang`. This is to be more explicit since `-data-sections=0` is now being forwa

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445634. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp added a comment. In D129855#3657006 , @MaskRay wrote: > This is not right as using `ld.lld` as the default linker isn't the majority > case. If you want to change the default for your distribution, set > `-DCLANG_DEFAULT_LINKER=lld`. > (Alternati

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445835. quinnp marked an inline comment as done. quinnp added a comment. Fixing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/To

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp added a comment. > If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` > sets `c.Options.DataSections = true;` to enable data sections by default. Hey @MaskRay, I'm not sure what is considered the legacy LTO interface, but this change is to make the `libLTO` codege

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445839. quinnp added a comment. Modifying a test to fix check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/ToolChains/CommonArgs.cp

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446147. quinnp marked 6 inline comments as done. quinnp added a comment. Addressing review comments. Fixing the forwarding for -fno-function-sectons and removing the ObjectFormatType check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446228. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Changing test cases to use `llvm-objdump -t` instead of `obj2yaml`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added a comment. In D129401#3666238 , @MaskRay wrote: > Mostly looks good, with a nit in the test and some suggestion to the summary. > > In D129401#3662857 , @quinnp wrote: > >>> If this is for the legacy

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446597. quinnp marked 3 inline comments as done. quinnp added a comment. Adressed review comments. - Modified how `llvm-lto` test-cases check the `llvm-objdump -t` output. - Renamed `gold-lto-sections.c` to `forwarding-sections-liblto.c` and modified the test

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:579 + else if (Args.hasArg(options::OPT_fno_data_sections)) +CmdArgs.push_back("-plugin-opt=-data-sections=0"); MaskRay wrote: > Is -plugin-opt=-data-sections=0 a problem

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 447336. quinnp marked 3 inline comments as done. quinnp added a comment. Adressing review comments. Moving tests into `function-sections.c`, using `%s` instead of creating a new file with `touch`, and modifying some `CHECK` lines to simplify checks. Reposit

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Most of the builtins already had intrinsics and only needed to be implem

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345510. quinnp added a comment. Fixed some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp Index: llvm

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345512. quinnp added a comment. [PowerPC] Fixing previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345515. quinnp added a comment. Removing redundant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def llvm/inc

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345517. quinnp added a comment. Re-added some changes that were lost in the previous updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/cl

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345519. quinnp added a comment. Removed some unused checks in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.de

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 347029. quinnp added a comment. Adding a comment in BuiltinsPPC.def for motivation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 34. quinnp added a comment. This update is motivated by comments made by @nemanjai. All of the builtin names have been changed to follow the convention of __builtin__. To fulfill the original goal of compatibility with the XL compiler, macros have been a

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 348332. quinnp added a comment. Addressing the last comments made by @nemanjai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/Buil

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the signature of the load and store vector pair builtins to match their documentat

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG57939309501c: [PowerPC] Fix signature of lxvp and stxvp builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://rev

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374000. quinnp added a comment. Adding a testcase where the second parameter of vec_splati_ins is out of the range 0,1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374064. quinnp added a comment. Separating the switch case in ISelLowering into two switch cases. One for `compare_exp_` and another for `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/ne

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374312. quinnp added a comment. Moving the semachecking of `test_data_class` from the function to the switch case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Fil

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374561. quinnp added a comment. Added a comment to the out-of-range argument test case to describe the behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 File

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374563. quinnp added a comment. Word change. valid -> expected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/Se

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9912fe4eac9: [PowerPC] Add range checks for P10 Vector Builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374605. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def c

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374610. quinnp added a comment. Addressing review comment about ISelLowering of `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/inclu

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 374847. quinnp marked 7 inline comments as done. quinnp added a comment. Updatign the patch to emit a fdiv for each of the builtins without any fast math flags. This will be safe and will still emit a software estimate when `-Ofast` is used. Repository: r

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv_MERGE efriedma wrote: >

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp updated this revision to Diff 374854. quinnp added a comment. Rebased with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builti

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0240e6c89d: [PowerPC] Add range check for vec_genpcvm builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374888. quinnp added a comment. Addressing nit in SemaChecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374891. quinnp added a comment. Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/include/cl

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375285. quinnp added a comment. Added a backend testcase which goes from `fdiv fast` to software estimate. Added a runline in the front end testcase that sets the fast math flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added a comment. In D106959#3021069 , @NeHuang wrote: > Do we already have a backend test case for `fdiv` emitting a software > estimate when `-Ofast` is used? I've added a testcase in `llvm/test/CodeGen/PowerPC/fdiv.ll` which goes from `fdiv fa

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70391b3468b8: [PowerPC] FP compare and test XL compat builtins. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375912. quinnp added a comment. Fixing failing test case after rebasing with https://reviews.llvm.org/D110213. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files:

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a3d1e27551: [PowerPC] swdiv builtins for XL compatibility (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

quinnp added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/ https://reviews.llvm.org/D110935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

quinnp added a comment. I think the commit message needs to be updated. > This patch updates the vec_popcnt builtins to take a signed int as the second > parameter... Should be: This patch updates the return type of the vec_popcnt builtins to vector unsigned... Other than that, lgtm. Reposi

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103986

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Moving the definition of the defineXLCompatMacros function from the header file clang/lib/Basic

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 352240. quinnp added a comment. Changed the target architecture of tests to follow the convention: BE-pwr7 LE-pwr8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Fi

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 353475. quinnp added a comment. Addressing comments and updating tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.d

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 353716. quinnp marked 2 inline comments as done. quinnp added a comment. Fixing the 32bit AIX run line in the testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 363189. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 354498. quinnp added a comment. Added non-vsx implementation of builtins and non-vsx backend tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inclu

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105360

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 356264. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inc

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 356272. quinnp marked 4 inline comments as done. quinnp added a comment. Fixing a typo and the format of a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files:

  1   2   >