https://github.com/mh4ck-Thales created
https://github.com/llvm/llvm-project/pull/95208
This PR fixes #55781 by adding the `--no-wasm-opt` and `--wasm-opt` flags in
clang to disable/enable the `wasm-opt` optimizations. The default is to enable
`wasm-opt` as before in order to not break existi
mh4ck-Thales wrote:
Any opinion on whether to implement a warning or not ?
https://github.com/llvm/llvm-project/pull/95208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mh4ck-Thales created
https://github.com/llvm/llvm-project/pull/100321
Add a warning when `wasm-opt` is requested with a flag (#95208) but is not
found in the path.
I'm using #77148 as reference on how to add a new warning but please tell me if
you can help in implementing t
mh4ck-Thales wrote:
`wasm-opt` is enabled by default for WASIp1, but can be disabled with the
`--no-wasm-opt` flag. Indeed if it is explicitly enabled then an error instead
of a warning would make more sense.
I'm not sure what is the problem with
> most developers I know of on wasm32-wasip1
https://github.com/mh4ck-Thales updated
https://github.com/llvm/llvm-project/pull/100321
>From b812b9c2a7b92edf5dab739eadff0295c2a1f631 Mon Sep 17 00:00:00 2001
From: Quentin Michaud
Date: Wed, 24 Jul 2024 09:54:53 +0200
Subject: [PATCH 1/2] First draft of wasm-opt warning
---
clang/lib/Drive
mh4ck-Thales wrote:
I implemented a proposition on how to proceed for correctly informing users of
wasm-opt problems:
- a warning for when no flags are passed (the default being wasm-opt enabled
for wasip1) and wasm-opt is not found
- an error for when --wasm-opt is explicitly passed but wasm-o
https://github.com/mh4ck-Thales ready_for_review
https://github.com/llvm/llvm-project/pull/100321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mh4ck-Thales wrote:
@sbc100 I tried to limit the scope of this new option to Wasm using the
corresponding group in `Options.td`
(https://github.com/ThalesGroup/llvm-project/blob/8c7052d5da074eb1d754aeddc4257d33e4e299aa/clang/include/clang/Driver/Options.td#L222),
but for some reason I was unab
mh4ck-Thales wrote:
The tests for the use of `wasm-opt` are hard to integrate into the LLVM project
as `wasm-opt` is not part of the LLVM toolchain itself (which is the initial
use case for the new `--no-wasm-opt` flag: as LLVM is not distributed with
`wasm-opt` by default a same compilation c
mh4ck-Thales wrote:
A shell script would work. I don't know how easy it is to create a shell script
inside the test suite and use it though, and it would be nice if this fake
wasm-opt script could be unique across several tests, to ensure the consistency
of those.
https://github.com/llvm/llvm
mh4ck-Thales wrote:
Seems like bash is present on the GitHub Windows runners. I shouldn't be too
hard to create a simple bash script that work both on Windows and Linux. It
would add a new dependency for the test suite on Windows however (if bash is
not already a dependency for Windows)
https
mh4ck-Thales wrote:
@alexcrichton sorry I thought that binaryen was under the bytecode alliance and
not the webassembly org. I opened the issue here :
https://github.com/WebAssembly/binaryen/issues/6728 , and proposed your idea
for a solution.
https://github.com/llvm/llvm-project/pull/98373
_
12 matches
Mail list logo
