[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

2021-12-19 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: rzurob, jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently in Clang, we have

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

2021-12-19 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: nemanjai, jsji, shchenz, PowerPC, uweigand, MaskRay. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a proj

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

2021-12-19 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. In D116016#3202148 , @MaskRay wrote: >> This is part of the efforts adding .gnu_attribute support for PowerPC. In >> Clang, an extra metadata field will be added as float-abi to show current >> long double format. So backend can e

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

2021-12-28 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 396379. qiucf marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116003/new/ https://reviews.llvm.org/D116003 Files: clang/test/CodeGen/stack-protector-guard.c Index: clang/test/Co

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

2021-12-28 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. In D109751#3191148 , @hubert.reinterpretcast wrote: > In D109751#3178494 , @qiucf wrote: > >> Thanks for the reminder. Here GCC and Clang diverges in the handling of >> `__ibm128`/`__float

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

2021-12-29 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4039d17355b7: [NFC] Specify targets for clang stack-protector-guard.c (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116395: [Clang] Emit warning for -x option without effects

2021-12-29 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: rsmith, hans, thakis, awarzynski, brad, phosek. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Things might be confusing for people not familiar with how this option works. Add thi

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-04-06 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Ping.. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2020-12-28 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 313835. qiucf marked 14 inline comments as done. qiucf added a comment. Address comments and add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py clang/inc

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2020-12-28 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6204 case HalfRank: llvm_unreachable("Complex half is not supported"); +case Ibm128Rank: llvm_unreachable("Complex __ibm128 is not supported"); case FloatRank: return FloatComplexTy;

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

2021-01-07 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Can we add tests to `builtins-ppc-altivec.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94162/new/ https://reviews.llvm.org/D94162 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

2021-01-13 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

2021-01-15 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG168be4208304: [Clang] Mutate long-double math builtins into f128 under IEEE-quad (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: rjmccall, teemperor. qiucf requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111387 Files: clang/include

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 378112. qiucf marked 2 inline comments as done. qiucf added a comment. Based on another patch to remove pre-computed complex CanQualType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109948/new/ https://reviews.

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00c0ce0655da: [NFC] [Clang] Remove pre-computed complex float types (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: rjmccall, nemanjai, aaron.ballman, erichkeane. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there're multiple float types that can be represented by `__attribute__((mo

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 378131. qiucf marked 2 inline comments as done. qiucf added a comment. Split and rebase upon D111391 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.l

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8a714722e2aa: [NFC] [Clang] Use global enum for explicit float mode (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111391/new/ https://r

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85e565898ff3: [Clang] Enable _Complex __ibm128 type (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

2021-10-08 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It should be SSSE3 instead of SSE2. Repository: rG LLVM Githu

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

2021-10-10 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc0d439a4b6: [Clang] [PowerPC] Fix header include typo in smmintrin.h (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D111482?vs=378414&id=378550#toc Repository: rG LLVM Githu

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

2021-10-10 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 378561. qiucf added a comment. Add codegen test to show generated type in IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 Files: clang/lib/Basic/TargetInfo.cpp

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

2021-10-11 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11ec6f67e45: [Clang] Enable IC/IF mode for __ibm128 (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

2021-10-19 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: nemanjai, PowerPC, jsji, shchenz. Herald added subscribers: dexonsmith, kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Gi

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

2021-10-24 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: nemanjai, jsji, PowerPC. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Glibc uses these new symbol names to support IEEE-754 128-bit flo

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

2021-10-25 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 381868. qiucf added a reviewer: rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112401/new/ https://reviews.llvm.org/D112401 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/ppc64-f128-builtin

[PATCH] D106191: [clang] Option control afn flag

2021-08-26 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Making a new option mapped to another float op flag looks reasonable, but is there any clearer motivation for this? (such as the need for `-Ofast -fno-approx-func`) Comment at: llvm/include/llvm/Target/TargetOptions.h:179 +/// with approximate calcu

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-08-26 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; rjmccall wrote: > This is necessary because it's possible to derive this type from a mode > attribute? Ye

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-08-27 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 369045. qiucf marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py clang/include/clang-c/Index

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-08-27 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5159 BT->getKind() == BuiltinType::LongDouble || +BT->getKind() == BuiltinType::Ibm128 || (getContext().getTargetInfo().hasFloat128Type() && rjmccall wrote: > qiuc

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

2021-09-01 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE Seems just adding `%clang_cc1

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2021-09-06 Thread Qiu Chaofan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfae0dfa6421e: [Clang] Add __ibm128 type to represent ppc_fp128 (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D93377?vs=36

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

2021-09-14 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: PowerPC, hubert.reinterpretcast, nemanjai, jsji. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

<    1   2   3