[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

qiucf added a comment. Thanks for this patch! If I understand correctly, only `isEmptyRecord`/`isEmptyField` and places checking any field is zero bit-width may need change for this? Since `isSingleElementStruct` and `isHomogeneousAggregate` just use them to skip empty fields in aggregate. I d

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

qiucf added a comment. > In any case, I guess it would still be good to also have test cases for this > aspect of the ABI on Power ... Sure, I'd like to do pre-commit for PPC tests. (or after this landed and enable/remove `AllowNoUniqueAddr`) CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D85874: [PowerPC] Add readflm/setflm intrinsics to Clang

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, steven.zhang, ZhangKang, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton. Herald added projects: clang, LLVM. qiucf requested review of this revision. Herald added a subscriber: wuzish. dbcfbffc

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

qiucf added a comment. Hi, it seems rG086b65340cca2648a2a91a0a47d28c7d9bafd1e5 causes build failure: llvm-project/clang/lib/Basic/OpenMPKinds.cpp:444:13: error: 97 enumeration values not handled in switch: 'OMPC_adjust_arg

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Abandon this since we have rGe2a1f8ec27b88be670cd867c43588f24516d2bbf . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00e8400e2e3: [Clang] Add option to set alternative toolchain path (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://re

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG406bde9a1513: [PowerPC] [Clang] Add SSE4 and BMI intrinsics implementation (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. Hi, > Why is --overlay-platform-toolchain added instead of using -isystem and -L? > > The functionality overlaps with -B. Unsure why introduce a new mechanism. We may want to use an extra toolchain like the Advance Toolchain (https://github.com/advancetoolchain/advance-to

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Can we re-use `err_type

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. In D121992#3418443 , @MaskRay wrote: > To add more why I think the current semantics may need more discussion before > we quickly commit to such a driver option: > > - interaction with --dyld-prefix: --sysroot does not affect the f

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Use `err_target_unsuppo

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Looks good to me in my side. Thanks for implementing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15140 + Value *fdiv = Builder.CreateFDiv(X, Y, "recipdiv"); + Builder.getFastMathFlags().operator&=(FMF); + return fdiv; Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. The PPC instructions tablegen part looks good to me. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def int

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, shchenz, anhtuyen, PowerPC. Herald added subscribers: arphaman, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the index argument of `lvx

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG240dde948252: [PowerPC] Change altivec indexed load/store builtins argument type (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

qiucf added a comment. In D106530#2903938 , @nemanjai wrote: > LGTM. Thanks for fixing this. > I am just curious, was this revealed from a real world test that used an > offset that is so large that it doesn't fit into 32 bits? No :-) It's found in back

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, jsji, nemanjai, collinbaker, rpenacob. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In some cases, we need to set alternative

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf updated this revision to Diff 417566. qiucf marked 3 inline comments as done. qiucf added a comment. - Move test to another file - Add documentation on option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://reviews.llvm.org/

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

qiucf added a comment. In D117972#3287553 , @pkubaj wrote: > Since I'm not a LLVM committer, can you commit it and merge to 14 branch? Sure. Sorry for late response, I'm on vacation these days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3304340 , @jwakely wrote: >> GCC 12 should have proper support for IEEE-754 compliant 128-bit floating >> point in libstdc++. > > Yes, but it's unconditionally disabled when including the headers with Clang. Is that bec

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3305014 , @jwakely wrote: > In D112906#3304925 , @qiucf wrote: > >> Is that because clang lacks something required by this feature? (for >> example. clang-12 doesn't have `__ibm1

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC, shchenz. Herald added subscribers: kbarton, krytarowski. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 407444. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/ppc_wrappers/bmi2

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf planned changes to this revision. qiucf added a comment. This breaks existing smm/tmm tests, will update/clean-up them before this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 __

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 409167. qiucf edited the summary of this revision. qiucf added a comment. Rebase the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMa

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, hubert.reinterpretcast, PowerPC. Herald added subscribers: jsji, steven.zhang, kbarton, krytarowski, arichardson, emaste. Herald added a project: All. qiucf requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444175. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Headers/ppc_wrapp

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444182. qiucf added a comment. Herald added a subscriber: ormris. Merge conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/ppc-emmintrin.c:631 // CHECK: %[[ADDR:[0-9a-zA-Z_.]+]] = load double*, double** %{{[0-9a-zA-Z_.]+}}, align 8 -// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]], align 8 +// CHECK: %[[VAL:[0-9a-

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } shchenz wrote: > Can we use `path::parent_path(P)` directly in `addSystemInclude()`? > `remove_fil

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 446335. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Headers/ppc_wrapp

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG708084ec379e: [PowerPC] Support x86 compatible intrinsics on AIX (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecc8520bc5b: [FPEnv] [Clang] Enable constrained FP support for PowerPC (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D85874: [PowerPC] Add readflm/setflm intrinsics to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG91039784b3c9: [PowerPC] Add readflm/setflm intrinsics to Clang (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85874/new/ https://reviews

[PATCH] D87220: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG88ff4d2ca1a0: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e85a2ba1645: [PowerPC] Implement intrinsic for DARN instruction (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#244 , @craig.topper wrote: > I don't think I understand the whole picture here. Why would only builtins > get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will > call modf128? Is there a corre

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf created this revision. qiucf added reviewers: nemanjai, rjmccall, rsmith, hubert.reinterpretcast, akyrtzi, PowerPC. Herald added subscribers: dexonsmith, steven.zhang, shchenz, arphaman, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscr

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf updated this revision to Diff 312153. qiucf edited the summary of this revision. qiucf added a comment. - Diff based on pre-commit - Restrict to PPC64 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2449236 , @craig.topper wrote: > D91675 has PowerPC only changes to make the > f128 calls get emitted. If you change the frontend in a target independent > way as proposed here, won't th

[PATCH] D90593: [Clang] Add more fp128 math library function builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG7faf62a80bfc: [Clang] Add more fp128 math library function builtins (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89242/new/ https://reviews.llvm.org/D89242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979a4d268a48: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rG2abc33683b2b: [PowerPC] [Clang] Define macros to identify quad-fp semantics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ ht

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, uweigand, PowerPC, steven.zhang, rjmccall. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. According to ELF v2 ABI, both IEEE 128-bit and IBM extend

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf updated this revision to Diff 305692. qiucf added a comment. Use another branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/ppc64le-varargs-f128.c Index: clang/test/CodeG

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. In D91596#2404514 , @rjmccall wrote: > I assume this has always been taken care of properly in the backend, so this > is just a fix for va_arg treatment? If so, LGTM. Yes. That's just fix for `va_arg`. Thanks! CHANGES SINCE LAST

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1341eb5bb7: [PowerPC] [Clang] Fix alignment of 128-bit float types (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D91596?vs=305692&id=306315#toc Repository: rG LLVM Github M

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, kbarton, PowerPC, wschmidt, rsmith. Herald added subscribers: cfe-commits, steven.zhang, pengfei, shchenz. Herald added a project: clang. qiucf requested review of this revision. This patch adds three intrinsics compatible to x86'

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf created this revision. qiucf added reviewers: craig.topper, spatel, nemanjai, jsji, steven.zhang, PowerPC, kpn, RKSimon. Herald added subscribers: cfe-commits, pengfei. Herald added a project: clang. qiucf requested review of this revision. Under `-mlong-double-128` on x86 and `-mabi=ieeelo

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2416625 , @craig.topper wrote: > gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc > here? Ah, yes, so this should be PPC-only change. But I see under x86 `-mlong-double-128`, std functions (`p

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

qiucf added a comment. Another small place also needs remove? (but not related to clang) `llvm/test/Transforms/LoopVectorize/PowerPC/vectorize-only-for-real.ll`: attributes #0 = { nounwind "target-cpu"="a2q" "target-features"="+qpx,-altivec,-bpermd,-crypto,-direct-move,-extdiv,-power8-vector,

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fca6a7844b5: [Clang] Don't adjust align for IBM extended double (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. The regression should be fixed in rG3fca6a7844b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596 ___

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay wrote: > Generall

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ hubert.reinterpretcast wr

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. Any comments...? I don't have knowledge if there's any plan about implementing `*f128` math functions on X86 libcs. But as I see so far, `*l` doesn't work well on `fp128`. Keeping this target independent currently seems reasonable to me. Repository: rG LLVM Github Mon

[PATCH] D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9378a366b2b2: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen (authored by qiucf). Herald added a project: clang. H

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90213/new/ https://reviews.llvm.org/D90213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, steven.zhang, PowerPC, kbarton. Herald added subscribers: cfe-commits, dexonsmith, shchenz. Herald added a project: clang. qiucf requested review of this revision. We have option `-mabi=ieeelongdouble` to set current `long double`

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 300887. qiucf added a comment. Remove `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/CodeGen/ppc64-long-dou

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf created this revision. qiucf added reviewers: echristo, stefanp, nemanjai, jsji, steven.zhang, PowerPC. Herald added subscribers: cfe-commits, dexonsmith, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. As Power9 introduced hardware support for IEEE

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:122 if (LongDoubleWidth == 128) { Builder.defineMacro("__LONG_DOUBLE_128__"); Builder.defineMacro("__LONGDOUBLE128"); steven.zhang wrote: > Can you please double check if we nee

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 302488. qiucf marked an inline comment as done. qiucf added a comment. Keep the `FIXME`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/CodeGen/ppc64-long

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfebbe4b5a0ab: [PowerPC] [Clang] Enable float128 feature on VSX targets (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D928

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. In D92815#2753684 , @nemanjai wrote: > Looks like this is causing failures at > https://lab.llvm.org/buildbot/#/builders/76/builds/2422 > Please revert. Yes. Already reverted in https://reviews.llvm.org/rGcbd93cee9bf014402a7405479

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

qiucf added a comment. Is there any motivation to add these builtins? I don't see them implemented in GCC. Besides, in Clang I think a prefix `__builtin` is preferred for them. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:28 +BUILTIN(__popcntb, "ULiULi", "") +BUILTI

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

qiucf created this revision. qiucf added reviewers: nemanjai, jhibbits, vit9696, kpn. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in PR50385

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c18d1136665: [SPE] Disable strict-fp for SPE by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b3071833a8: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++ (authored by qiucf, committed by ecnelises). Changed prior to commit

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target powerpc64le-unknown-l

[PATCH] D109943: [Clang] Fix long double availability check

qiucf created this revision. Herald added subscribers: steven.zhang, mstorsjo, jvesely. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. fae0dfa

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, nemanjai, PowerPC, rjmccall. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up to fae0dfa

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf created this revision. qiucf added reviewers: nemanjai, hubert.reinterpretcast, rjmccall, PowerPC, aaron.ballman. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As for 128-bit floating points on PPC, compiler should have three

[PATCH] D109943: [Clang] Fix long double availability check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0195f8621f18: [Clang] Fix long double availability check (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109943/new/ https://reviews.llvm

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target powerpc64le-unknown-l

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:336 .Default(false); + Features["quadword-atomics"] = llvm::StringSwitch(CPU) + .Case("pwr10", true) What about `ppc64`? Also,

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

qiucf added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3334 return SemaBuiltinConstantArgRange(TheCall, 3, 0, 7); + case PPC::BI__builtin_ppc_tw: { +return SemaBuiltinConstantArgRange(TheCall, 2, 1, 31); Unnecessary brace? =

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s // R

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:56 +unsigned int testrotatel4(unsigned int rs, unsigned int shift) { + return __rotatel4(rs, shift); +} For these tests against builtin mapping to an intrinsic, could we o

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

qiucf added a comment. Please provide context of the patch (`git diff -U999`) :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 ___ cfe-commits mailing list c

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:425 + Features["isa207"] = llvm::StringSwitch(CPU) + .Case("pwr9", true) Will it be better if name to `isa2_07`, `isa3_0` to make it less confusing? Besides, in

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf updated this revision to Diff 383715. qiucf added a comment. Add `nexttoward` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112401/new/ https://reviews.llvm.org/D112401 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/math-builtins-long.c clang/test/CodeGen/ppc64-f

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai, shchenz. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin_printf, "__printfieee128"}, + {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"}, jsji wrote: > Why only these

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf added a comment. In D109950#3101740 , @rjmccall wrote: > Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers > for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's > patch? There are three different

[PATCH] D112975: Fix complex types declared using mode TC

qiucf accepted this revision. qiucf added a comment. Thanks. This issue looks a little bit like D109943 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112975/new/ https://reviews.llvm.org/D112975 ___ cfe-co

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. qiucf marked 3 inline comments as done. Closed by commit rG741aeda97d63: [PowerPC] Implement longdouble pack/unpack builtins (authored by qiucf). Changed prior to comm

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf updated this revision to Diff 385709. qiucf marked an inline comment as done. qiucf added a comment. Restrict implicit conversion in arithmetic and comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109751/new/ https://reviews.llvm.org/

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327378. qiucf retitled this revision from "[PowerPC] [Clang] Enable float128 feature on Altivec targets" to "[PowerPC] [Clang] Enable float128 feature on VSX targets". qiucf edited the summary of this revision. qiucf set the repository for this revision to rG LL

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327388. qiucf added a comment. Fix redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Driver/ppc-f128-su

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 327716. qiucf marked 2 inline comments as done. qiucf added a comment. - Add helper method to count 'unordered' cases - Add missing tests (in last update) - Add test for openmp device-host case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > > hubert.reinterpretc

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 330560. qiucf marked an inline comment as done. qiucf added a comment. Update cindex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) hubert.reinterpretcast wrote: > This looks s

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3131169 , @nemanjai wrote: > Please provide a description for this patch which includes justification for > why we want to allow conversion between the two types. > I am of the impression that allowing the two types to c

  1   2   3   >