[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509360. qiongsiwu1 added a comment. Moving the `-shared` check to the AIX linker and modifying the tests so we test pure linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.ll

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 509367. qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. Fix the LTO data sections check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 F

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" hubert.reinterpretcast wrote: > This

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 500298. qiongsiwu1 added a comment. > This accepts -mno-roptr for other platforms despite having no semantic > functionality (e.g., it does not move variables to a different section for > ELF codegen). Thanks for catching this @hubert.reinterpretcast !!

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501211. qiongsiwu1 added a comment. Updating the release note and adding comments on the `-fdata-sections` requirement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D14

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501264. qiongsiwu1 added a comment. Update lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. @hubert.reinterpretcast Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mail

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501871. qiongsiwu1 added a comment. Updating `-fdata-sections` related comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rs

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:1 +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr %s 2>&1 | FileCheck %s +// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mroptr -mno-roptr %s 2>&1 | \ hubert.reinterpretc

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503437. qiongsiwu1 added a comment. Addressing review comments - fixing typos, and updating the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: cla

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503440. qiongsiwu1 added a comment. Update `-mroptr` cc1 option help text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503796. qiongsiwu1 added a comment. Rename the `ReadOnlyPointers` option in the source to `XCOFFReadOnlyPointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503934. qiongsiwu1 added a comment. Adding logic to pass `mroptr` to the backend during LTO codegen. Error check is not ideal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503941. qiongsiwu1 added a comment. Fixing release note. Adding pure linking tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNote

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503944. qiongsiwu1 added a comment. Adding tests to check that the default behaviour is identical with `-mno-roptr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503946. qiongsiwu1 added a comment. Adding LTO error check tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:37 +// LINK: "-bforceimprw" +// LTO_ROPTR: "-bplugin_opt:-mxcoff-roptr" +// NO_ROPTR-NOT: "-mxcoff-roptr" qiongsiwu1 wrote: > hubert.reinterpretcast wrote: > > This needs the backend opti

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Specifically, the option is renamed to `-mxcoff-roptr` and `-mno-xcoff-roptr` to indicate that this option only affects the `XCOFF` binary format, so it is expected to not affect `ELF` or other formats. Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148177/new/ https://reviews.llvm.org/D148177 __

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be the

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > > `cuda-resource-headers

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > qiongsiwu1 wrote: > > > tra wrote: > > > > qiongsiwu1 wrote: > > > > > Do we need an install targ

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

qiongsiwu1 added a comment. Thanks for the patch! Recently we added the options `mxcoff-roptr` and `mno-xcoff-roptr` https://reviews.llvm.org/D144190 that fall into this the scope of this patch (e.g. https://github.com/llvm/llvm-project/blob/0508ac32cfcc1a9fc5a81d16de8d418dc5a0666b/clang/lib/D

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. In D151503#4381548 , @tra wrote: > @qiongsiwu1 : I've updated the patch. PTAL. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, w2yehia. qiongsiwu1 added a project: clang. Herald added subscribers: kbarton, inglorion, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 created this revision. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, kbarton, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This patch adds clang options `-mroptr` and `-mno-rop

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 498118. qiongsiwu1 added a comment. Rebase to resolve clang release note conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 520375. qiongsiwu1 added a comment. Rebase. Ping for review @hubert.reinterpretcast . Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clan

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 522132. qiongsiwu1 added a comment. Thanks so much @hubert.reinterpretcast !! The comments are addressed. I will land the patch when the pre-commit CI finishes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Pre-commit CI x64 Debian is failing https://buildkite.com/llvm-project/premerge-checks/builds/152189 because the build machine's cmake version is too old. I am landing this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9715af434579: [AIX][clang] Storage Locations for Constant Pointers (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. This patch is causing some buildbot failures. Specifically https://lab.llvm.org/buildbot/#/builders/139/builds/40652 https://lab.llvm.org/buildbot/#/builders/258/builds/810 I am looking into them. Please revert if this cannot wait. Thanks! Repository: rG LLVM Gith

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham, MaskRay, cebowleratibm. qiongsiwu1 added a project: clang. Herald added subscribers: kristof.beyls, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald adde

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 added a comment. I can revise the case and add it as a backend/llc test case if we would like to keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150586/new/ https://reviews.llvm.org/D150586 __

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Patch to remove the problematic test case. https://reviews.llvm.org/D150586 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. https://reviews.llvm.org/D150586 has landed and the problematic test case is removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 _

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham. qiongsiwu1 added a project: clang. Herald added a subscriber: nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://r

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1f1b9079e2: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150597/new/

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. This revision is now accepted and ready to land. Thanks for the fix Zarko! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148960/new/ https://reviews.llvm.org/D148960

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. @hubert.reinterpretcast please let me know if there are comments/suggestions! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 _

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Gentle ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 529030. qiongsiwu1 added a comment. Address code review. Thanks @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 Files: clang/lib/Driv

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 added a comment. Ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152021: [clang][AIX] Fix Overly Strick LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 530903. qiongsiwu1 added a comment. Revising the logic to pass `-data-sections=` to `libLTO`. We now pass `-data-sections=1` to `libLTO` by default unless it is explicitly turned off. Old behaviour: 1. Pass `-data-sections=1` if the target requires uses

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as`

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, shchenz, Esme. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: l

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added a comment. In D152924#4421624 , @steven_wu wrote: > `lld` does not use LTOCodeGenerator. > > I am also not sure how disable integrated assembler suppose to work? Do you > have an end to end design for how to invoke assembler during linki

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > See

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { shchenz wrote: > qio

[PATCH] D152021: [clang][AIX] Fix Overly Strict LTO Option Checking against `data-sections` when `mxcoff-roptr` is in Effect

qiongsiwu1 updated this revision to Diff 532099. qiongsiwu1 added a comment. Revert to the DataSections logic. It is better not to change that in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152021/new/ https://reviews.llvm.org/D152021

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532110. qiongsiwu1 added a comment. Revising the option processing logic to not pass in `-no-integrated-as=0`. Thanks @shchenz and @MaskRay for the feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked 3 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 +CmdArgs.push_back(Args.MakeArgString( +Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegrat

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added a comment. In D152924#4426895 , @shchenz wrote: > Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does > not work as expected. Is this expected or by design(We can only

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<< A->getSpelling() << ToolChain.getTriple().g

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532241. qiongsiwu1 edited the summary of this revision. qiongsiwu1 added a comment. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: c

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 marked an inline comment as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:703 +Arg *A = Args.getLastArgNoClaim(options::OPT_fno_integrated_as); +D.Diag(diag::warn_drv_unsupported_lto_option_for_target) +<

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

qiongsiwu1 updated this revision to Diff 532256. qiongsiwu1 added a comment. Clean up code in `addLTOOptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 Files: clang/lib/Driver/ToolChains/CommonAr

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, nemanjai, MaskRay. qiongsiwu1 added projects: clang, PowerPC. Herald added subscribers: StephenFan, shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-comm

[PATCH] D139343: [Driver][PPC] Support -mtune=auto

qiongsiwu1 abandoned this revision. qiongsiwu1 added a comment. It is decided that we no longer need this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139343/new/ https://reviews.llvm.org/D139343 ___

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: nemanjai, amyk. qiongsiwu1 added a project: clang. Herald added subscribers: shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Currently `ppc::ge

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 481739. qiongsiwu1 added a comment. Update to include a new test case against the unknown target error message. Thanks for the suggestion @amyk ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files:

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:54 +auto TargetCPUName = llvm::StringSwitch(CPUName) + .Case("common", "generic") + .Case("440fp", "440") jamieschme

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 updated this revision to Diff 482137. qiongsiwu1 added a comment. Updating to revert back to `const char *` in the big `StringSwitch`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139720/new/ https://reviews.llvm.org/D139720 Files: c

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:77 + .Default(CPUName); +return TargetCPUName.str(); } jamieschmeiser wrote: > qiongsiwu1 wrote:

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 added a comment. In D139720#3989651 , @jamieschmeiser wrote: > I'm fine with handling the return for common as a separate change, if > necessary. Sounds good! In this case I will fix it in a different patch once we decide what exactly to do

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 created this revision. qiongsiwu1 added a reviewer: nemanjai. qiongsiwu1 added projects: PowerPC, clang. Herald added subscribers: shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. The ClangBuilt

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 updated this revision to Diff 483060. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp clang/test/Driver/ppc-cpus.c Index: clang/test/Driver/p

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 updated this revision to Diff 483146. qiongsiwu1 added a comment. Addressing review comments. Thanks for the review @nemanjai !! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 Files: clang/l

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 added a comment. The pre-commit CI crashes do not seem to relate to this patch. I will land it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 ___

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

qiongsiwu1 added a comment. In D115670#3220052 , @erichkeane wrote: > Should be fixed here: 2edc21e8566be8fa9b20e0bb71a83af90ec9aa97 > > > Thanks! Thanks so much for the fix Erich! I

[PATCH] D115670: Implement some constexpr vector unary operators, fix boolean-ops

qiongsiwu1 added subscribers: bmahjour, anhtuyen, qiongsiwu1. qiongsiwu1 added a comment. Hi everyone! We are encountering crashes in some of our `altivec` test cases due to this change. `clang` crashes when we have an instance of a `struct` or `union` type, and we assign the result of a unary o

[PATCH] D111406: [AIX][ZOS] Excluding merge-objc-interface.m from Tests

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: jsji, Jake-Egan. qiongsiwu1 added a project: LLVM. qiongsiwu1 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Objective C is not supported on AIX or ZOS. This patch excludes the

<    1   2