[PATCH] D30015: Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:18 +// +// CHECK-ARCHDIR: -L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath" {{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux +// CHECK-NO-ARCHDIR-NOT: -L{{.*}}Inputs/res

[PATCH] D30015: Add arch-specific directory to search path

pirama added a reviewer: rnk. pirama added a subscriber: rnk. pirama added a comment. @rnk: This patch was to address discussion in http://lists.llvm.org/pipermail/openmp-dev/2017-February/001659.html but now also addresses http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html. Can

[PATCH] D30015: Add arch-specific directory to search path

pirama marked 2 inline comments as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:289 + CmdArgs.push_back("-rpath"); + CmdArgs.push_back(Args.MakeArgString(CandidateRPath.c_str())); +} rnk wrote: > We shouldn't add rpath to eve

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 90373. pirama added a comment. Add -rpath only when a runtime is included as a shared library. And, cleanup tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inp

[PATCH] D30015: Add arch-specific directory to search path

pirama updated this revision to Diff 90532. pirama edited the summary of this revision. pirama added a comment. Fixed comment in test and added a test for -fsanitize=address without -shared-libasan. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChai

[PATCH] D30015: Add arch-specific directory to search path

pirama marked an inline comment as done. pirama added inline comments. Comment at: lib/Driver/Tools.cpp:2007-2009 + // In the cross-compilation case, arch-specific library path is likely + // unavailable at runtime. + if (TC.isCrossCompiling()) return; rnk wro

[PATCH] D30015: Add arch-specific directory to search path

This revision was automatically updated to reflect the committed changes. Closed by commit rL296927: Add arch-specific directory to search path (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D30015?vs=90532&id=90545#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D30015: Add arch-specific directory to search path

pirama added a comment. Committed. Thanks for the reviews! Repository: rL LLVM https://reviews.llvm.org/D30015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama created this revision. This patch unconditionally adds -rpath of the arch-specific subdirectory in resource directory (instead of doing so only during native compilation). This patch also re-enables test arch-specific-libdir.c which was silently unsupported because of the REQUIRES tag 'lin

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama added a comment. In https://reviews.llvm.org/D30700#694511, @rnk wrote: > I was thinking `-f[no-]compiler-rt-rpath` or something, but openmp is not > part of compiler-rt. Name recommendations welcome. \ Maybe `-f[no-]rtlib-add-rpath`? > We might also want to reconsider the default sett

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

pirama added inline comments. Comment at: lib/Driver/ToolChain.cpp:652 +// libc++ may be installed per arch. +addArchSpecificRPath(*this, Args, CmdArgs); break; `addArchSpecificRPath` is a static function in Tools.cpp and isn't visible here. https:

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91633. pirama added a comment. - Rebase - Added command line flag and updated tests. https://reviews.llvm.org/D30700 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c test/Driver/arch-specific-libdir.c test/lit.cfg

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

pirama updated this revision to Diff 91635. pirama added a comment. *Actually* add the command line flags. https://reviews.llvm.org/D30700 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/arch-specific-libdir-rpath.c test/Driver/arch-specific-libdi

[PATCH] D30733: [Driver] Add arch-specific rpath for libc++

pirama added inline comments. Comment at: lib/Driver/ToolChain.cpp:652 +// libc++ may be installed per arch. +addArchSpecificRPath(*this, Args, CmdArgs); break; Hahnfeld wrote: > pirama wrote: > > `addArchSpecificRPath` is a static function in Tools.

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama created this revision. Herald added a subscriber: mehdi_amini. Address PR32155: Skip passing -Os and -Oz to the Gold plugin using -plugin-opt. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ==

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91671. pirama added a comment. Address review comments https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ===

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama marked 3 inline comments as done. pirama added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:369 if (A->getOption().matches(options::OPT_O4) || -A->getOption().matches(options::OPT_Ofast)) +A->getOption().matches(options::OPT_Ofast)

[PATCH] D30920: Do not pass -Os and -Oz to the Gold plugin

pirama updated this revision to Diff 91738. pirama added a comment. Explicitly pass -O2 instead of relying on the default opt level. https://reviews.llvm.org/D30920 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/gold-lto.c Index: test/Driver/gold-lto.c ===

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

pirama added subscribers: pirama, srhines, kongyi. pirama added a comment. Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO). // with -flto=full or without -flto=thin, below command

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama created this revision. pirama added reviewers: MyDeveloperDay, srhines. pirama requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes PR46992. Git stores symlinks as text files and we should not format them even if they have one

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 342927. pirama added a comment. Leave two empty lines after filter_symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clan

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343171. pirama added a comment. Remove debug print(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/tools/clang-format/git-clang-format Index: clang

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added inline comments. Comment at: clang/tools/clang-format/git-clang-format:345 + for filename in list(dictionary.keys()): +print(os.getcwd()) +if os.path.islink(filename): curdeius wrote: > Is this print

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama marked an inline comment as done. pirama added a comment. In D101878#2740133 , @curdeius wrote: > LGTM but let's wait a day or two before landing, so that others can chime in. > Btw, do you have commit rights? If no, please provide "Name " for > c

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

pirama updated this revision to Diff 343194. pirama added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 Files: clang/docs/ReleaseNotes.rst clang/tools/clang-format/git-cl

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

pirama accepted this revision. pirama added a subscriber: srhines. pirama added a comment. This revision is now accepted and ready to land. Thanks for the cleanup here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/new/ https://reviews.llvm.

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android" (authored by alxu, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/

<    1   2