[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 518339. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt cla

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5f14c5fe78: [clang-tidy] Ignore declarations in bugprone-exception-escape (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148462/new/

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 518342. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 518353. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escap

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 518356. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Update, added support for comparing function pointers without exception specification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 518357. PiotrZSL added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added a comment. In D148458#4309010 , @isuckatcs wrote: > Do we really want to split these two functions apart to different test files? > Is this really NFC? Yes, `throw specifier` is removed in C++17, split allows to support C++17 and above i

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added a comment. @isuckatcs Ifdefs are ugly, to avoid messing with multiple runs in same unit test, I decided to split into 2 test files (C++11 and above, and C++11,C++14). And to be honest this change does nothing for caching (zero impact), let me explain: `super_throws_again` alone

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks fine. My main concern are lambdas (and maybe functions/classes in functions, but that should only hit performance). Please close all comments before pushing this. =

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Refactor RenamerClangTi

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

PiotrZSL added a comment. Clang-tidy related changes looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:272 + parent one. +SystemHeaders- Same as '--system-headers'. +UseColor - Same as '--use-color'.

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Overall ok, but: - add storeOptions method - clarify documentation for added option - consider supporting regexes - simplify tests, to avoid duplicating warning message ===

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://reviews.llvm.org/D151594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM (+-) - Before committing rebase this on top of main branch (looks like this base on previous release branch. - Keep in mind 80 characters limit for documentation files

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. First this looks like "misc" check, not as "readability" one. So please move it to proper module. There is no "readability" aspect of it. Second thing this is not an "absolute", a

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. One more comment, according to this whitepaper you should actually check if include is relative, simply if `current file directory + include` exists and it's actually a file that is included, then its relative include. Currently you checking only `""` and its not a thin

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. Even with that for me for example, I would consider `#include "xyz"` be fine, but `#include "../xyz"` would be a red flag, so please consider adding `StrictMode` option to check so if `StrictMode` is not set then includes from same directory, or subdirectory would be a

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL updated this revision to Diff 530185. PiotrZSL added a comment. Add comment to code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://reviews.llvm.org/D151594 Files: clang-tools-extra/clang-tidy/misc/ConfusableIdentifier

[PATCH] D151594: [clang-tidy] Optimize misc-confusable-identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fdedcd1a242: [clang-tidy] Optimize misc-confusable-identifiers (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151594/new/ https://re

[PATCH] D152625: run-clang-tidy: forward warnings-as-errors argument

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152625/new/ https://reviews.llvm.org/D152625 ___ cfe-commits mailing list cfe-commi

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. I run into false positive with this example: using UInt8 = unsigned char; UInt8 size = 5U; std::string str2(size, 'x'); // warning: string constructor arguments are proba

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 530306. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Add one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: > isuckatcs wrote: > > Please cover this line w

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:69 void StringConstructorCheck::registerMatchers(MatchFinder *Finder) { + const auto SignedCharType = qualType(isAnyCharacter(), isSignedInteger()); const auto ZeroEx

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

This revision was automatically updated to reflect the committed changes. Closed by commit rG90bbe97036a1: [clang-tidy] Readability-container-data-pointer adds new option to ignore… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL added a comment. I will push this change, no point to keep it open. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 ___ cfe-commits mailing list cfe-co

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG636c67275142: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL reopened this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks like there is missing dependency in CMake: https://lab.llvm.org/buildbot/#/builders/57/builds/27531 FAILED: lib/libclangTidyUtils.so.17git : && /home/buildbots/clang.15.0.4/bin/c

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

PiotrZSL added a comment. In D152625#4413242 , @indev29 wrote: > @PiotrZSL could you please commit? I don't think I have access yet. Author & Email please for git, under which should it be delivered. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152625: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG2499beeb5a3d: [clang-tidy] run-clang-tidy: forward warnings-as-errors argument (authored by indev29, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D152713: [clang-tidy] Correct sizeof/alignas handling in misc-redundant-expression

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, Izaron, fwolff. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

PiotrZSL added a comment. Except pointed out issues, looks fine. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:49-50 + for (const auto &Identifier : AllowedIdentifiers) { +if (!llvm::Regex(Identifier).isValid()) + configurationDiag("In

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:274-276 + if (isa(InitType)) { +return; + } instead of ignoring array types, better would be just not provide FixItHints for them, so WRN woul

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added a comment. Maybe we should still support arrays in some way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 ___ cfe-commits mailing list cfe-

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:273 + + const bool ValueInit = isa(InitExpression); + const bool CanAssign = ```const bool ValueInit = isa(InitExpression) && !isa(InitType);``` T

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

PiotrZSL added a comment. I think it should be under clang_target_link_libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150602/new/ https://reviews.llvm.org/D150602 ___ cfe-commits mailing list cf

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL accepted this revision. PiotrZSL added a comment. +-LGTM Only one thing that could be still done here, is to extract some base class from those checks, and move common code there. I will commit this tomorrow, so if you decide to change anything you can still do that, if not you can alw

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:193 +- New alias :doc:`cppcoreguidelines-noexcept-destructor + ` to + :doc`performance-noexcept-destructor you got spelling wrong in these, its clang-tidy, not tify Repositor

[PATCH] D152825: [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152825/new/ https://reviews.llvm.org/D152825 ___

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 ___

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL added a comment. Look into clang-tools-extra/test/clang-tidy/infrastructure/ for tests, probably you could base on one of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 __

[PATCH] D152825: [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted out-of-line special member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG92420f4aefbe: [clang-tidy] Fix false positive in `readability-named-parameter` for defaulted… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

This revision was automatically updated to reflect the committed changes. Closed by commit rG311091e2b007: [clang-tidy] Fix crash in `modernize-use-default-member-init` (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:43-44 + + if (!MaybeHeaderToInclude && (ReplacementPrintFunction == "std::print" || +ReplacementPrintlnFunction == "std::println")) +MaybeH

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb6ee3cfe57: [clang-tidy] Move formatDereference to FixitHintUtils (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D152589: [clang-tidy] Add readability test for not allowing relative includes

PiotrZSL added a comment. In D152589#4418649 , @ErezAmihud wrote: > I want to make sure I understand. > The ideal situation would be to create `misc-no-relative-includes` check that > checks for `..` in paths (meaning - relative paths), and have a `Stri

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG474a2b9367ad: [clang-tidy] Add more checks for functions which should be noexcept (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks fine. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:545-547 +if (isa(AliasDecl->getSingleDecl())) { + const auto *AliasDe

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4420359 , @Dinistro wrote: > I'm getting a linking error by some of the files changed in this revision. You shouldn't because this library got dependency on clangTidyPerformanceModule. Is this a blocker for you, or yo

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4421339 , @Dinistro wrote: > In D148697#4421268 , @PiotrZSL > wrote: > >> In D148697#4420359 , @Dinistro >> wrote: >> >>> I'm gettin

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. @Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable to reproduce. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148697 _

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4421739 , @Dinistro wrote: > In D148697#4421643 , @PiotrZSL > wrote: > >> @Dinistro It compiles & links with clang 16 also (shared libs). So I'm >> unable to reproduce. > > I

[PATCH] D152852: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with structured bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4359fecf02: [clang-tidy] Fix wrong code generation for `modernize-loop-convert` with… (authored by AMS21, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

PiotrZSL added a comment. Herald added subscribers: carlosgalvezp, shchenz. Herald added a project: All. Looks like this change is responsible for https://github.com/llvm/llvm-project/issues/59807 and https://github.com/llvm/llvm-project/issues/62337 issues. Repository: rL LLVM CHANGES SINC

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

PiotrZSL added a comment. In D148697#4422629 , @nemanjai wrote: > It was also causing PPC bots to break. I fixed it in > https://reviews.llvm.org/rGffd7a200fdfbd01ef296101647d2f2da91ddfd41 O, thank you. Thats explain a lot. Because when I look into cmak

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks good.. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:50 +if (!AllowedIdentifiers.back().isValid()) + configurationD

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

PiotrZSL added a comment. Overall good, my main concern is base class name & location. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptDestructorCheck.h:23 /// https://clang.llvm.org/extra/clang-tidy/checks/performance/noexcept-destructor.html -class NoexceptDes

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. The is compiler error in CI "Cannot find source file: BaseNoexceptFunctionCheck.cpp". Consider naming it NoexceptFunctionBase.cpp or NoexceptFunctionBaseCheck.cpp unless there are already

<    4   5   6   7   8   9