[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a reviewer: njames93. Crash no longer happens on main, but this change introduce nice fix for operators handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL updated this revision to Diff 558074. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125949/new/ https://reviews.llvm.org/D125949 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-t

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

PiotrZSL added a comment. This change is dangerous, it depends that elements/iterators won't be re-allocated/invalidated during insertion process. Part with removing double lookup in IncludeSorter::addInclude looks fine, but part that involve IncludeBucket is problematic. I will try to push part

[PATCH] D130639: [clang-tidy] Fix readability-redundant-string-c-str fix for overloaded operator->

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D145730 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130639/new/ https://reviews.llvm.org/D130639

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D157326 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115106/new/ https://reviews.llvm.org/D115106

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D126780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119165/new/ https://reviews.llvm.org/D119165

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 __

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL updated this revision to Diff 558075. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp c

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd867f668672d: [clang-tidy] modernize-avoid-bind: Fix handling of operators (authored by jspam, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e55fef0e98f: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression (authored by njames93, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D158657: [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158657/new/ https://reviews.llvm.org/D158657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D33531: Clang-tidy readability: avoid const value return

PiotrZSL abandoned this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. Obsolete, this check is already added. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33531/new/ https://reviews.llvm.org/D33531

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

ClockMan created this revision. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 492167. ClockMan added a comment. ClockMan updated this revision to Diff 492169. Eugene.Zelen

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

ClockMan created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan published this revision for review. ClockMan added a comment. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:31 + // Consider functions only in header files. + if (!Result.SourceManager->getFilename(SrcBegin).ends_with(".h")) +return; Probably better would

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +} or mayb

[PATCH] D142592: [clang-tidy][libc] Add an inline function checker for the libc project.

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:20 +void InlineFunctionDeclCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(decl(functionDecl()).bind("func_decl"), this); +} carlosg

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:149 + Options.HeaderFileExtensions = {"", "h", "hh", "hpp", "hxx"}; + Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"}; Options.HeaderFilterRegex = ""; -

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d02dd241816: [clang-tidy] Fix warning in portability-simd-intrinsics (authored by ClockMan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142565/new/ http

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + Looks like usecase of this is more like rtrim, then probably rtrim should be used instead

[PATCH] D142816: [clang-tidy] Add --list-unique-checks command

ClockMan created this revision. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 493024. ClockMan added a comment. ClockMan published this revision for review. Herald added a project:

[PATCH] D142816: [clang-tidy] Add --list-unique-checks command

ClockMan abandoned this revision. ClockMan added a comment. Ok, I agree that solution taken in D114317 with explicit marking of checks via misc::PrimaryCheck or conversion of type to string on preprocesor level is better. Repository: rG LLVM Github Monorepo

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Except few nits in documentation looks fine. Probably one day in future we can add same for bools. Make sure that documentation of impacted checks is correct, so it says that argument is p

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, I will rebase, push it and add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127036/new/ https://reviews.llvm.org/D127036 ___

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6780d53f41fb: [clang-tidy] Warn about arrays in bugprone-undefined-memory-manipulation (authored by fwolff, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D127036?vs=434283&i

[PATCH] D109210: [obsolete][clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

PiotrZSL abandoned this revision. PiotrZSL added a comment. No longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109210/new/ https://reviews.llvm.org/D109210 ___ cfe-commits mailing list cfe-c

[PATCH] D76477: [clang-tidy] Update path of main translation unit

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. LGTM, probably LLVM_ATTRIBUTE_UNUSED need to be added to example before committing

[PATCH] D76477: [clang-tidy][NFC] Update path of main translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rG37937b8a040c: [clang-tidy][NFC] Update path of main translation unit (authored by j-carl, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, but I'm not sure if isCopyableOrMovable will always work correctly, for a user defined special members it looks ok, but for some implicit ones I worry it may not always work. Probabl

[PATCH] D153423: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGff40c3488177: [clang-tidy] Allow explicit throwing in bugprone-exception-escape for special… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D153423?vs=534059&id=541727#toc Re

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing list cfe-comm

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.cpp:91-102 + Finder->addMatcher( + fieldDecl(unless(isMemberOfLambda()), +hasDeclContext(cxxRecordDecl(isCopyableOrMovable())), +

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

PiotrZSL accepted this revision. PiotrZSL added a comment. Looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155625/new/ https://reviews.llvm.org/D155625 ___ cfe-commits mailing list cfe-commits@

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

PiotrZSL added a comment. To be honest, all those things just should be configurable instead of hardcoding them. For example, a project that I work for got 4 different custom optional implementations, and this check is useless for all of them. And still no boost::optional support. Repository:

[PATCH] D155321: [clang][Analysis] ExprMutationAnalyzer: break infinite recursion on recursive function call

PiotrZSL added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ExprMutationAnalyzer.h:31 +if (nullptr == DeclAnalyzed) { + OwningDeclAnalyzed = std::make_unique(); + this->DeclAnalyzed = OwningDeclAnalyzed.get(); NOTE: This memory

[PATCH] D156024: [clang-tidy] Add --disable-modular-headers-expansion option

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Experimental option: Di

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL updated this revision to Diff 543185. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Add test & release notes. Cleanup commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.l

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. @Eugene.Zelenko I cannot review/accept my own patch :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 ___

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 543196. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase + Update diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files

[PATCH] D156024: [clang-tidy] Add --disable-modular-headers-expansion option

PiotrZSL updated this revision to Diff 543199. PiotrZSL added a comment. Code formating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156024/new/ https://reviews.llvm.org/D156024 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-ex

[PATCH] D156031: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commi

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

PiotrZSL updated this revision to Diff 543206. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. rebase, add release notes, move tests to separate file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://reviews.

[PATCH] D156031: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5b75bfd4d4: [clang-tidy] Ignore implcit casts in cppcoreguidelines-owning-memory (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1560

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG9644368f974a: [clang-tidy] Fix checks filter with warnings-as-errors (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D146520?vs=543185&id=543222#toc Repository: rG LLVM Gith

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e325081192b: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload` (authored by Izaron, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL marked 3 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71 + +bool EmptyCatchCheck::isLanguageVersionSupported( +const LangOptions &LangOpts) const { xgupta wrote: > This

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 543276. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Rebase (release notes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files: clang-to

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added a comment. Some release notes would be nice, looks like impacted checks are: performance-unnecessary-copy-initialization, performance-inefficient-vector-operation, performance-unnecessary-value-param, performance-for-range-copy. Some info about "Improved XYZ check by handling ha

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

PiotrZSL added a comment. Release notes are missing, and patch not not apply gracefully. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78223/new/ https://reviews.llvm.org/D78223 ___ cfe-commits mailing li

[PATCH] D126855: [clang-tidy] check_clang_tidy.py: Print output nicely in Python 3.

PiotrZSL added a comment. Herald added a subscriber: carlosgalvezp. Fixed by f7a80c3d08d4821e621fc88d6a2e435291f82dff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126855/new/ h

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, Split it multiple entry's, 1 per check, keep in alphabetical order. and maybe keep it in format; "Improv

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-unnecessary-copy-initialization + `, PiotrZSL wrote: > Split it multiple entry's, 1 per check, keep in alphabetical order. > and maybe keep i

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-for-range-copy.cpp:66-67 } + for (const S S2 : C) { + } } Those tests already exist and pass in current version. Most probably this change is obsolete. Rep

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:83 Diags.setSourceManager(&Sources); + ProcessWarningOptions(Diags, Compiler.getDiagnosticOpts()); carlosgalvezp wrote: > A bit unclear to me why we

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:523 +- Improved :doc:`performance-for-range-copy + ` sort them by name, performance checks are before readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

This revision was automatically updated to reflect the committed changes. Closed by commit rGf256fee53430: [clang-tidy] Add bugprone-empty-catch check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 543314. PiotrZSL added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add -fexceptions to tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new ForwardingDiagnosticConsumer(Compiler.getDiagnosticCl

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG047273fc9c84: [clang-tidy] Add bugprone-empty-catch check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:75 + Diags(new DiagnosticIDs, +new DiagnosticOptions(Compiler.getDiagnosticOpts()), new Forwarding

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

PiotrZSL updated this revision to Diff 543601. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Review comments fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156056/new/ https://reviews.llvm.org/D156056 Files: clang-too

[PATCH] D156024: [clang-tidy] Add --experimental-disable-module-headers-parsing option

PiotrZSL updated this revision to Diff 543641. PiotrZSL retitled this revision from "[clang-tidy] Add --disable-modular-headers-expansion option" to "[clang-tidy] Add --experimental-disable-module-headers-parsing option". PiotrZSL added a comment. Rename of option + cleanup Repository: rG LL

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

PiotrZSL added a comment. Some entry in release notes or/and check documentation would be welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 ___ cfe-commi

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/unchecked-optional-access.rst:11 This check identifies unsafe accesses to values contained in -``std::optional``, ``absl::optional``, or ``base::Optional`` +``std::optional``, ``absl::

[PATCH] D156161: [clang-tidy] Add --experimental-enable-module-headers-parsing option

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cf

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

PiotrZSL accepted this revision. PiotrZSL added a comment. +- LGTM, I will correct those nits and push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155890/new/ https://reviews.llvm.org/D155890 ___ c

[PATCH] D155890: [clang-tidy] Add folly::Optional to unchecked-optional-access

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f0630f8bc91: [clang-tidy] Add folly::Optional to unchecked-optional-access (authored by Anton Dukeman , committed by PiotrZSL)

[PATCH] D156161: [clang-tidy] Add --experimental-enable-module-headers-parsing option

PiotrZSL added a comment. @carlosgalvezp My plan was to push first change regardless (so they would be some workaround, even if hidden & undocumented), and second only if approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156161/new/ https://

[PATCH] D156024: [clang-tidy] Add --experimental-disable-module-headers-parsing option

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:202 + bool canEnableModuleHeadersParsing() const { +return !DisableModuleHeadersParsing; carlosgalvezp wrote: > Add docs? for function ? It's straight fo

[PATCH] D156056: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG992fa7be3438: [clang-tidy] Initialize DiagnosticEngine in ExpandModularHeaders (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D156024: [clang-tidy] Add --experimental-disable-module-headers-parsing option

PiotrZSL abandoned this revision. PiotrZSL added a comment. Will be integrated into D156161 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156024/new/ https://reviews.llvm.org/D156024

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL updated this revision to Diff 543708. PiotrZSL retitled this revision from "[clang-tidy] Add --experimental-enable-module-headers-parsing option" to "[clang-tidy] Add --enable-module-headers-parsing option". PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Herald a

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:266 +static cl::opt EnableModuleHeadersParsing("enable-module-headers-parsing", +desc(R"( carlosgalvezp wrote: > --e

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:39 + ID) { + NotExtendedByDeclBoundToPredicate Predicate; + Predicate.ID = ID; xgupta wrote: > Can be written using direc

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

PiotrZSL updated this revision to Diff 544034. PiotrZSL added a comment. Fix doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156161/new/ https://reviews.llvm.org/D156161 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/cla

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

This revision was automatically updated to reflect the committed changes. Closed by commit rG3397dae69e09: [clang-tidy] Add performance-enum-size check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144135?vs=543196&id=544042#toc Repository: rG LLVM Github Monorep

[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb530eeea5e76: [clang-tidy] Add --enable-module-headers-parsing option (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/reference-to-constructed-temporary.rst:10 +This construction is often the result of multiple code refactorings or a lack +of developer know

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL updated this revision to Diff 544057. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 Files: clang-tools-extra/clang-

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL marked 2 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/reference-to-constructed-temporary.rst:18 + + const std::string& value("hello"); + xgupta wrote: > PiotrZSL wrote: > > x

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

PiotrZSL updated this revision to Diff 544205. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rename value to str in doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 Files: cla

[PATCH] D156303: [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156303/new/ https://reviews.llvm.org/D156303 ___

[PATCH] D156438: [Docs] Fix code-blocks missing colon

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Thank you. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156438/new/ https://reviews.llvm.org/D156438

[PATCH] D149084: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check

This revision was automatically updated to reflect the committed changes. Closed by commit rG315946c57da2: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D149084?vs=516480&id=544795#toc Reposit

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added subscribers: mgrang, xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Sort printed o

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

PiotrZSL marked 3 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:90 +std::vector> SortedOptions; +SortedOptions.reserve(Options.size()); +for (auto &Key : Options) { carlosgalvezp

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

PiotrZSL updated this revision to Diff 544852. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156452/new/ https://reviews.llvm.org/D156452 Files: clang-tools-ext

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cdb84376752: [clang-tidy] Sort options in --dump-config (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129706: [clang-tidy] Reimplement GlobList without relying on Regex.

PiotrZSL added a comment. A litte overkill, there is llvm/include/llvm/Support/GlobPattern.h that could be used to simplify this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129706/new/ https://reviews.llvm.org/D129706

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

PiotrZSL added a comment. @thakis actually this test was already broken, simply folder '2' does not exist.. Let me fix that. Thank you for information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156452/new/ https://reviews.llvm.org/D156452 ___

[PATCH] D156452: [clang-tidy] Sort options in --dump-config

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d9a64f7d4d6: [clang-tidy] Sort options in --dump-config (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D156452?vs=544857&id=544903#toc Repository: rG LLVM Github Monorepo

[PATCH] D157367: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rG894140b4fdde: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157367?vs=548085&id=549148#toc R

[PATCH] D157376: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f29f14d0257: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix cr

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL updated this revision to Diff 549263. PiotrZSL added a comment. Add call to DiagnosticEngine::hasSourceManager() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157649/new/ https://reviews.llvm.org/D157649 Files: clang-tools-extra/clang-t

  1   2   3   4   5   6   7   8   9   >