Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added a comment. In http://reviews.llvm.org/D19201#445496, @aaron.ballman wrote: > In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > > > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > > expr in multiple noexcepts, then it returns the same object

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), you can use forFunction instead of

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:32 @@ +31,3 @@ +// token including trailing whitespace. +static SourceRange FindToken(const SourceManager &Sources, LangOptions LangOpts, + SourceLocation StartLoc, So

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek added a comment. ping http://reviews.llvm.org/D18821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), aaron.ballman wrote: > Prazek wrote

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > > http://reviews.llvm.org/D1932

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59558. Prazek added a comment. - Fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h docs/Release

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:6 @@ +5,3 @@ + +This check would look for cases when inserting new element into an STL +container, but the element is constructed temporarily or is constructed just --

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59561. Prazek marked an inline comment as done. Prazek added a comment. Fixed stuff http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/UseEmplaceCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-emplace.rst Index: docs/clang

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59562. Prazek added a comment. Learning how to use arc http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceChec

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:29 @@ +28,3 @@ + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +on(hasType(cxxRecordDecl(hasName(VectorName)))

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:31 @@ +30,3 @@ +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); + ok, std::list works for me. I just don't want to spend much time

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59568. Prazek added a comment. - Post review fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl( -

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59580. Prazek marked 4 inline comments as done. Prazek added a comment. - Review fixes http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp cla

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > I think will be good idea to try this check with LLVM STL too. You mean llvm::SmallVector stuff? http://reviews.llvm.org/D20964 ___ cfe-commits mailing lis

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added a subscriber: Prazek. Prazek added a comment. besides it lgtm Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list.

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek added inline comments. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as return type. +If check finds case like this then it function retu

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448551, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D20964#448525, @Prazek wrote: > > > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > > > > > I think will be good idea to try this check with LLVM STL too. > > >

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:43 @@ +42,3 @@ +/// matches "b(1)". +AST_MATCHER_P(CXXConstructExpr, ctorCallee, + ast_matchers::internal::Matcher, This seems like a usefull matcher. We should

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:53 @@ +52,3 @@ +/// matches the given matcher. +AST_MATCHER_P(QualType, ignoringRefsAndConsts, + ast_matchers::internal::Matcher, InnerMatcher) { {meme, src="instr

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 60662. Prazek marked an inline comment as done. Prazek added a comment. Runned on LLVM and bug fixed one thing http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/U

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. shipit LGTM Comment at: clang-tidy/modernize/UseUsingCheck.cpp:71 @@ +70,3 @@ + const auto *MatchedDecl = Result.Nodes.get

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a reviewer: hokein. Prazek added a subscriber: hokein. Prazek added a comment. @alexfh or @hokein ping http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added a comment. In http://reviews.llvm.org/D21303#460814, @alexfh wrote: > 3. What's so special about `return`? Looks like a more general problem is: > passing an lvalue to a function/constructor/operator by const reference where > it could instead be moved (the lvalue isn't used afterw

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added inline comments. Comment at: test/clang-tidy/modernize-use-emplace.cpp:2 @@ +1,3 @@ +// RUN: %check_clang_tidy %s modernize-use-emplace %t + +namespace std { hokein wrote: > Could you also add the following case in the test? > ``` > vector> v1; > v1.p

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated the summary for this revision. Prazek updated this revision to Diff 61143. http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 8 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a reviewer: sbenza. Prazek added a comment. You might be interested. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 61214. Prazek added a comment. Changes after running og llvm code base. Adding llvm::SmallVector was a good idea, because it has fired for much more cases and I have found 3 other bugs. Now check doesn't fire when argument of constructor is bitfield or new ex

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. Changes after running http://reviews.llvm.org/D21507 http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#453797, @vsk wrote: > @Eugene.Zelenko thanks for pointing this out, I had totally missed this > patch! Once we get this reviewed I'm willing to abandon my version. Some > comments inline -- I have tested it on llvm code base and I have

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Prazek added a comment. In http://reviews.llvm.org/D21507#462210, @jlebar wrote: > There seem to be many nontrivial whitespace errors introduced by this patch. > For example, > > -Attrs.push_back(HTMLStartTagComment::Attribute(Ident.getLocation(), > -

[clang-tools-extra] r273275 - [clang-tidy] Add modernize-use-emplace

Author: prazek Date: Tue Jun 21 10:23:27 2016 New Revision: 273275 URL: http://llvm.org/viewvc/llvm-project?rev=273275&view=rev Log: [clang-tidy] Add modernize-use-emplace Summary: Add check that replaces call of push_back to emplace_back Reviewers: hokein Differential Revision: http://reviews.

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rL273275: [clang-tidy] Add modernize-use-emplace (authored by Prazek). Changed prior to commit: http://reviews.llvm.org/D20964?vs=61214&id=61381#toc Repository: rL LLVM http://reviews.llvm.org/D20964

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:107-108 @@ +106,4 @@ + InnerMatcher) { + return hasDeclaration( + cxxRecordDecl(hasDescendant(cxxConstructorDecl(InnerMatcher; +} You have bug

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturnValueCopyCheck.cpp:53 @@ +52,3 @@ +/// matches the given matcher. +AST_MATCHER_P(QualType, ignoringRefsAndConsts, + ast_matchers::internal::Matcher, InnerMatcher) { This one is use

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. Thank you Samuel, that it is valuable review! I wanted to add the functionality of specifing stuff by options later. should we revert this patch? It seems that those bugs are not so critical (at least on llvm http://reviews.llvm.org/D21507). Anyway, I will fix it in one w

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Prazek added a subscriber: Prazek. Prazek added a comment. In http://reviews.llvm.org/D21185#464517, @Eugene.Zelenko wrote: > Since http://reviews.llvm.org/D20964 was committed, I think we should close > this. Yep, I think the best idea is to take all the goodies from this check and add it to

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Prazek added a comment. In http://reviews.llvm.org/D21507#464791, @vsk wrote: > Neat! It would help to upload a git-clang-format'd. Fwiw I only managed to > look over the changes in lib/{ARCMigrate,AST,Analysis}. > > Have you run check-all and the full test-suite? Yep, didn't have any problems

[PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

Prazek created this revision. Prazek added reviewers: alexfh, sbenza, hokein. Prazek added a subscriber: cfe-commits. getExprLoc returns location after dot for member call. http://reviews.llvm.org/D21642 Files: clang-tidy/boost/UseToStringCheck.cpp test/clang-tidy/boost-use-to-string.cpp In

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

Prazek updated this revision to Diff 61665. Prazek added a comment. - small fix http://reviews.llvm.org/D21642 Files: clang-tidy/boost/UseToStringCheck.cpp test/clang-tidy/boost-use-to-string.cpp Index: test/clang-tidy/boost-use-to-string.cpp ===

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

Prazek added a comment. ping anyone. This is nobrainer fix. http://reviews.llvm.org/D21642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL274001: [clang-tidy] boost-use-to-string arg expr location bugfix (authored by Prazek). Changed prior to commit: http://reviews.llvm.org/D21642?vs=61665&id=62069#toc Repository: rL LLVM http://revie

[clang-tools-extra] r274001 - [clang-tidy] boost-use-to-string arg expr location bugfix

Author: prazek Date: Tue Jun 28 03:16:20 2016 New Revision: 274001 URL: http://llvm.org/viewvc/llvm-project?rev=274001&view=rev Log: [clang-tidy] boost-use-to-string arg expr location bugfix Summary: getExprLoc returns location after dot for member call. Reviewers: alexfh, sbenza, hokein Subscr

Re: [PATCH] D21507: Changes after running check modernize-use-emplace (D20964)

Prazek added a comment. In http://reviews.llvm.org/D21507#465733, @sanjoy wrote: > One other thing to point out -- have you verified that the changes in > `unittests/` are benign (i.e. you're not semantically changing the tests)? Yes I do. Repository: rL LLVM http://reviews.llvm.org/D2150

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added a reviewer: rsmith. Prazek added a comment. Adding Richard who was working on standard defect report that deprived sense of this check. There are some corner cases that are not in the standard and probably won't be handled in the future that we could handle still. http://reviews.l

Re: [PATCH] D15121: A new clang-tidy module to find calls to `std::swap`, and change them to use ADL

Prazek added a subscriber: Prazek. Comment at: test/clang-tidy/misc-StdSwap.cpp:7-11 @@ +6,7 @@ + +// FIXME: Add something that triggers the check here. +// FIXME: Verify the applied fix. +// * Make the CHECK patterns specific enough and try to make verified lines +// unique

[PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek created this revision. Prazek added reviewers: sbenza, alexfh, aaron.ballman. Prazek added subscribers: cfe-commits, hokein, sbarzowski, mnbvmar, staronj, sbenza. Prazek set the repository for this revision to rL LLVM. Prazek added a project: clang-extra. Not everything is valid (as you se

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added a comment. BTW I've made clang-extra project on phabricator as you can see. Please use it, it will be much easier to filter reviews. Repository: rL LLVM http://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

Prazek added a subscriber: Prazek. Prazek added a comment. Very usefull check! I don't have enough time right now to check everything, so better wait for review of Alexfh or someone else. I just wanted to leave some thoughts. Comment at: clang-tidy/misc/MoveForwardingReferenceC

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:21 @@ +20,3 @@ +llvm::Optional> +getHasAnyName(const std::vector &names) { + llvm::Optional> hasMatcher; aaron.ballman wrote: > aaron.ballman wrote: > > Should be `Names` instead.

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:129 @@ -95,1 +128,3 @@ + auto CtorCallSourceRange = CharSourceRange::getTokenRange( + InnerCtorCall->getExprLoc(), CallParensRange.getBegin()); There is a bug here that I fo

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

Prazek added a subscriber: Prazek. Prazek added a comment. haven't found anything else Comment at: clang-rename/USRFindingAction.cpp:62 @@ +61,3 @@ + bool Found = false; + for (auto &OverriddenMethod : D->overridden_methods()) { +if (std::find(USRs->begin(), US

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

Prazek added inline comments. Comment at: docs/clang-tidy/checks/misc-move-forwarding-reference.rst:30 @@ +29,3 @@ +Background +-- + Nothing from me. It's just general comment https://reviews.llvm.org/D0 ___

Re: [PATCH] D22222: [ASTMatchers] isSignedInteger() and isUnsignedInteger()

Prazek added a subscriber: Prazek. Prazek closed this revision. Prazek added a comment. Already in master https://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek removed rL LLVM as the repository for this revision. Prazek updated this revision to Diff 64238. Prazek marked 6 inline comments as done. https://reviews.llvm.org/D22208 Files: clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h clang-tidy/utils/Matchers.h

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: SourceTypeInfo for long long

review: http://reviews.llvm.org/D17765 2016-03-01 15:12 GMT+01:00 Piotr Padlewski : > my pass works for things like > (note that for test purposes I use lexical_cast that doesn't do anything, > so the second one compiles) > > int a = boost::lexical_cast("42"); > long long* b = boost::lexical_cast

Re: SourceTypeInfo for long long

my pass works for things like (note that for test purposes I use lexical_cast that doesn't do anything, so the second one compiles) int a = boost::lexical_cast("42"); long long* b = boost::lexical_cast("42"); => auto a = boost::lexical_cast("42"); auto b = boost::lexical_cast("42"); but it doesn

[ASTMatcher] builtinType matcher with returns

Hi, For code like: namespace boost { template T lexical_cast(const C&) { return T(); } } int g(); long long f(int p); using namespace boost; int main() { auto s = lexical_cast(5); auto p = lexical_cast(6); long long z = lexical_cast(7); long long a2 = lexical_cast("1488");

[PATCH] D18136: boost-use-to-string check

Prazek created this revision. Prazek added a reviewer: alexfh. Prazek added a subscriber: cfe-commits. todo fix docs. Is there any better solution for the basic_string problem? http://reviews.llvm.org/D18136 Files: clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang

Re: [PATCH] D18136: boost-use-to-string check

Prazek added a comment. There is also big issue here - I don't check if the type of argument is builtinType. I don't know why but matcher "builtinType" didn't work when I tried to use it. (like I wrote in another email) Comment at: clang-tidy/boost/UseToStringCheck.cpp:33 @@ +

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:76-81 @@ +75,8 @@ +// CHECK-FIXES: fun(std::to_string(f)); + fun(boost::lexical_cast(g)); +// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use std::to_string instead of boost::lexical_cast [boost-use-t

Re: [PATCH] D18136: boost-use-to-string check

Prazek updated the summary for this revision. Prazek updated this revision to Diff 51057. Prazek added a comment. fixed many things thaks to Alexander http://reviews.llvm.org/D18136 Files: clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/boost/UseToStringChe

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek updated this revision to Diff 51086. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp docs/cla

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 12 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:5-11 @@ +4,9 @@ +namespace std { + +template class basic_string {}; + +using string = basic_string; +using wstring = basic_string; +} + +namespace boost { I don't see any test using

[PATCH] D18274: [clang-tidy] Add boost module

Prazek created this revision. Prazek added reviewers: alexfh, mclow.lists. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-ti

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek updated this revision to Diff 51087. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp docs/cla

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek added a comment. I was planning to do so. Can you look at http://reviews.llvm.org/D18136 ? http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4