Author: prazek
Date: Thu Jun 1 03:04:05 2017
New Revision: 304394
URL: http://llvm.org/viewvc/llvm-project?rev=304394&view=rev
Log:
Emit available_externally vtables opportunistically
Summary:
We can emit vtable definition having inline function
if they are all emitted.
Reviewers: rjmccall, rsm
Author: prazek
Date: Thu Jun 1 04:24:36 2017
New Revision: 304397
URL: http://llvm.org/viewvc/llvm-project?rev=304397&view=rev
Log:
Fixed warnings
Modified:
cfe/trunk/include/clang/AST/VTableBuilder.h
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/include/clang/AST/VTableBu
Author: prazek
Date: Thu Jun 1 13:39:34 2017
New Revision: 304448
URL: http://llvm.org/viewvc/llvm-project?rev=304448&view=rev
Log:
Emit invariant.group.barrier when using union field
Summary:
We need to emit barrier if the union field
is CXXRecordDecl because it might have vptrs. The testcode
w
Author: prazek
Date: Thu Jun 1 14:08:05 2017
New Revision: 304455
URL: http://llvm.org/viewvc/llvm-project?rev=304455&view=rev
Log:
Fixed broken test (strict-vtable-pointers)
Modified:
cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp
Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-poi
Author: prazek
Date: Wed Jun 13 06:55:42 2018
New Revision: 334600
URL: http://llvm.org/viewvc/llvm-project?rev=334600&view=rev
Log:
Add -fforce-emit-vtables
Summary:
In many cases we can't devirtualize
because definition of vtable is not present. Most of the
time it is caused by inline virtua
Author: prazek
Date: Thu Sep 14 10:33:08 2017
New Revision: 313278
URL: http://llvm.org/viewvc/llvm-project?rev=313278&view=rev
Log:
Enable __declspec(selectany) on any platform
Summary:
This feature was disabled probably by mistake in rL300562
This fixes bug https://bugs.llvm.org/show_bug.cgi?id
Author: prazek
Date: Thu May 3 04:03:01 2018
New Revision: 331448
URL: http://llvm.org/viewvc/llvm-project?rev=331448&view=rev
Log:
Rename invariant.group.barrier to launder.invariant.group
Summary:
This is one of the initial commit of "RFC: Devirtualization v2" proposal:
https://docs.google.com
Author: prazek
Date: Mon Jul 2 12:21:36 2018
New Revision: 336137
URL: http://llvm.org/viewvc/llvm-project?rev=336137&view=rev
Log:
[CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers
Summary:
Emmiting new intrinsic that strips invariant.groups to make
devirtulization sound, as
Prazek added a comment.
Please add tests with
long long p = static_cast(4);
and the same with const at beginning. I remember I had problems with this last
time (Type->SourceRange was returning only source range for the first token.
I will review patch later.
https://reviews.llvm.org/D25316
Prazek added a comment.
In https://reviews.llvm.org/D25316#564217, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25316#563930, @Prazek wrote:
>
> > Please add tests with
> >
> > long long p = static_cast(4);
> >
> >
> > and the same with const at beginning. I remember I had problems
Prazek added a comment.
Thanks for the patch! I think some unit test should be added.
Do you also handle cases like
unsigned long long
unsigned volatile long const long static
etc.
The problem here is that the whole type like "unsigned long long" could be in
other tokens.
I talked with Ri
Prazek added a comment.
Awesome to see this patch. After this one will make it to upstream, it will be
much easier for me to do same with template functions.
Comment at: test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp:2
+// RUN: %check_clang_tidy %s modernize-use-auto
Prazek added a comment.
In https://reviews.llvm.org/D25316#565463, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25316#565378, @Prazek wrote:
>
> > Awesome to see this patch. After this one will make it to upstream, it will
> > be much easier for me to do same with template functions.
>
Prazek added a comment.
In https://reviews.llvm.org/D25363#565445, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25363#565371, @Prazek wrote:
>
> > Thanks for the patch! I think some unit test should be added.
>
>
> Are there any existing unit tests for TypeLoc that I can add to?
>
> > D
Prazek added a comment.
In https://reviews.llvm.org/D25363#565472, @malcolm.parsons wrote:
> I've tested this with clang-query using `match typeLoc()` and a lot of
> permutations of int, short, long, unsigned and const.
I am pretty sure it works, but someone could change the implementation and
Prazek added a comment.
In https://reviews.llvm.org/D25316#565574, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25316#565567, @Prazek wrote:
>
> > functionDecl(hasName(LEXICAL_CAST_NAME),
>
>
> I was trying to avoid specifying the name of the function so that it works
> for any t
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp:25
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use auto when initializing with
a cast to avoid duplicating the type name
+ // CHECK-FIXES: auto ll = static_cast(l);
+ unsigne
Prazek added a comment.
BTW I think changing the commit name by removing bug ID would be good, because
it would be more clear that this is a feature commit, not a bug fix.
You can move t he bug id, or the link to bug to the summary section.
https://reviews.llvm.org/D25316
__
For most loop changes here applying modernize-loop-convert would be better
> ;)
>
> On Wed, Dec 14, 2016 at 4:29 PM, Piotr Padlewski via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: prazek
>> Date: Wed Dec 14 09:29:23 2016
>> New Revision
I think that the feature I mentioned is right thing to put in this check,
however you don't have to implement it right now, just leave FIXIT comment
2016-12-15 20:55 GMT+01:00 Mads Ravn :
> Hi Piotr,
>
> That is a good point. Because it is not always -1 or 1 that determines
> lexicographical high
Author: prazek
Date: Fri Dec 16 03:14:47 2016
New Revision: 289930
URL: http://llvm.org/viewvc/llvm-project?rev=289930&view=rev
Log:
[clang-tidy] fix missing anchor for MPI Module
Summary: MPIModule was not linked to plugins
Reviewers: alexfh, Alexander_Droste, hokein
Subscribers: JDevlieghere,
Firstly, please respond in phabricator if it is possible. When you send
email it doesn't appear in phabricator, it's probably a bug.
2016-12-19 8:00 GMT+01:00 Mads Ravn :
> Hi Piotr,
>
> Thank you for your detailed comments :)
>
> I would love some help with the other fixit. I have some notes on
Author: prazek
Date: Fri Dec 23 05:40:44 2016
New Revision: 290424
URL: http://llvm.org/viewvc/llvm-project?rev=290424&view=rev
Log:
Use after move bug fixes
Summary: Bunch of fixed bugs in Clang after running misc-use-after-move in
clang-tidy.
Reviewers: rsmith, mboehme
Subscribers: cfe-commi
Author: prazek
Date: Wed Dec 28 12:23:23 2016
New Revision: 290675
URL: http://llvm.org/viewvc/llvm-project?rev=290675&view=rev
Log:
Mention devirtualization in release notes
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm
Author: prazek
Date: Wed Dec 28 12:25:30 2016
New Revision: 290676
URL: http://llvm.org/viewvc/llvm-project?rev=290676&view=rev
Log:
Revert "Mention devirtualization in release notes"
Accidental commit. LLVM changes have not been pushed yet
This reverts commit 592453413690a2d16784667d1644758b9af7
Author: prazek
Date: Wed Dec 28 12:26:08 2016
New Revision: 290677
URL: http://llvm.org/viewvc/llvm-project?rev=290677&view=rev
Log:
[ItaniumABI] NFC changes
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
URL:
http://llvm.org/viewvc/llvm-
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
aaron.ballman wrote:
> Per
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
aaron.ballman wrote:
> Pra
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:32-33
@@ -31,1 +31,4 @@
+ // Calling make_smart_ptr from within a member function of a type with a
+ // private or protected constructor would be ill-formed.
+ auto CanCallCtor = unless(has(i
Prazek marked 8 inline comments as done.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
alexfh wrote:
>
Prazek marked 2 inline comments as done.
Prazek added a comment.
https://reviews.llvm.org/D23343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
In https://reviews.llvm.org/D23353#516314, @mboehme wrote:
> In https://reviews.llvm.org/D23353#511362, @Prazek wrote:
>
> > I will review it later, but my first thoughts:
> >
> > 1. I think we should make some other group, because misc seems to be
> > overloaded. I discu
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
alexfh wrote:
> Prazek wro
Prazek updated this revision to Diff 68824.
Prazek added a comment.
- fixes
https://reviews.llvm.org/D23343
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/modernize-make-shared.cpp
test/clang-tidy/modernize-make-unique.cpp
Index: test/clang-tidy
Author: prazek
Date: Tue Aug 30 19:06:55 2016
New Revision: 280180
URL: http://llvm.org/viewvc/llvm-project?rev=280180&view=rev
Log:
[clang-tidy] modernize-make-{smart_ptr} private ctor bugfix
Summary:
Bugfix for 27321. When the constructor of stored pointer
type is private then it is invalid to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280180: [clang-tidy] modernize-make-{smart_ptr} private ctor
bugfix (authored by Prazek).
Changed prior to commit:
https://reviews.llvm.org/D23343?vs=68824&id=69787#toc
Repository:
rL LLVM
https://r
Prazek added a comment.
Sorry for long delay. I had some issues with git-svn on mac.
Repository:
rL LLVM
https://reviews.llvm.org/D23343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Prazek added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:191
@@ +190,3 @@
+
+if (const Stmt *S = Node.get()) {
+ Result.push_back(S);
Dry: const auto *
https://reviews.llvm.org/D23353
__
Prazek added inline comments.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:34
@@ +33,3 @@
+ const auto *Construct =
Result.Nodes.getNodeAs("construct");
+ const auto arguments = Construct->arguments();
+
Arguments (upper case)
Repository:
Prazek added inline comments.
Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:34
@@ +33,3 @@
+ has(functionDecl(
+ isPublic(), hasName("size"), returns(isInteger()),
+ unless(anyOf(returns(isAnyCharacter()), returns(booleanType()),
---
Prazek added a subscriber: Prazek.
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D24439
___
cfe-commits m
Prazek added a subscriber: Prazek.
Comment at: lib/Sema/Sema.cpp:684
@@ +683,3 @@
+ for (auto PII : Pending)
+if (FunctionDecl *Func = dyn_cast(PII.first))
+ Func->setMarkedForPendingInstantiation();
Dry. Use auto
https://reviews.llvm.org/
Author: prazek
Date: Mon Jan 16 07:20:08 2017
New Revision: 292112
URL: http://llvm.org/viewvc/llvm-project?rev=292112&view=rev
Log:
Add -fstrict-vtable-pointers to UsersManual
Summary: Add missing flag to UsersManual
It would be good to merge it to 4.0 branch.
Reviewers: hans
Subscribers: cfe-
Author: prazek
Date: Fri Mar 3 06:42:22 2017
New Revision: 296867
URL: http://llvm.org/viewvc/llvm-project?rev=296867&view=rev
Log:
[clang-tidy] Fix modernize-use-emplace docs
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/tru
Author: prazek
Date: Fri Mar 3 11:16:11 2017
New Revision: 296888
URL: http://llvm.org/viewvc/llvm-project?rev=296888&view=rev
Log:
[clang-tidy] Yet another docs fixes
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/trunk/docs/
Author: prazek
Date: Wed Dec 14 09:29:23 2016
New Revision: 289656
URL: http://llvm.org/viewvc/llvm-project?rev=289656&view=rev
Log:
modernize-use-auto NFC fixes
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/trunk/clang-apply-replacements/lib/To
Author: prazek
Date: Wed Dec 14 09:42:23 2016
New Revision: 289658
URL: http://llvm.org/viewvc/llvm-project?rev=289658&view=rev
Log:
Deleted unused typedef
Modified:
clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cp
Author: prazek
Date: Mon Apr 24 07:58:43 2017
New Revision: 301178
URL: http://llvm.org/viewvc/llvm-project?rev=301178&view=rev
Log:
[Devirtualization] Emit invariant.group loads with empty group md
Summary:
As discussed here
http://lists.llvm.org/pipermail/llvm-dev/2017-January/109332.html
havin
Author: prazek
Date: Sat May 20 03:56:18 2017
New Revision: 303488
URL: http://llvm.org/viewvc/llvm-project?rev=303488&view=rev
Log:
[Devirtualization] insert placement new barrier with -O0
Summary:
To not break LTO with different optimizations levels, we should insert
the barrier regardles of op
Prazek added a comment.
Besides this looks good
Comment at: test/clang-tidy/modernize-make-shared.cpp:122
+ Pderived = std::shared_ptr(new Derived());
+ // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: use std::make_shared instead
+ // CHECK-FIXES: Pderived = std::make_shared();
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:70
+static const StringRef Message =
+"prefer transparent functors (aka diamond operators)";
+
The message would be much better if you would put the name of this fu
Prazek added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-transparent-functors.rst:12
+ .. code-block:: c++
+
+// Non-transparent functor
Say somewhere that you also handle cases like
std::less(arg1, arg2)
because from this documentati
Prazek added a comment.
Richard?
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-make-shared.cpp:122
+ Pderived = std::shared_ptr(new Derived());
+ // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: use std::make_shared instead
+ // CHECK-FIXES: Pderived = std::make_shared();
ma
Prazek created this revision.
Prazek added reviewers: rsmith, rengolin.
Prazek added subscribers: cfe-commits, rjmccall, nlewycky.
This patch was introduced one year ago, but because my google account
was disabled, I didn't get email with failing buildbot and I missed
revert of this commit. There
Prazek added a comment.
Here is commit from last year
https://reviews.llvm.org/D13279
https://reviews.llvm.org/D26117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
merging with master. Gonna update patch in a minute.
https://reviews.llvm.org/D26117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 76302.
Prazek added a comment.
rebae
https://reviews.llvm.org/D26117
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
=
Prazek updated this revision to Diff 76303.
Prazek added a comment.
Updated comment and reformatted
https://reviews.llvm.org/D26117
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
===
Author: prazek
Date: Sat Oct 29 10:28:25 2016
New Revision: 285496
URL: http://llvm.org/viewvc/llvm-project?rev=285496&view=rev
Log:
NFC small format
Modified:
cfe/trunk/lib/Analysis/UninitializedValues.cpp
Modified: cfe/trunk/lib/Analysis/UninitializedValues.cpp
URL:
http://llvm.org/viewvc
Author: prazek
Date: Sat Oct 29 10:28:30 2016
New Revision: 285497
URL: http://llvm.org/viewvc/llvm-project?rev=285497&view=rev
Log:
[Devirtualization] Decorate vfunction load with invariant.load
Summary:
This patch was introduced one year ago, but because my google account
was disabled, I didn't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285497: [Devirtualization] Decorate vfunction load with
invariant.load (authored by Prazek).
Changed prior to commit:
https://reviews.llvm.org/D26117?vs=76303&id=76306#toc
Repository:
rL LLVM
https:
Prazek added a comment.
I think this change is not required at first place.
It is introduced because of "modernize-use-delete" was too ambiguous because of
operator delete, so it was changed to "modernize-use-equals-delete". But this
case is not ambiguous at all, so I don't see point changing th
Prazek added inline comments.
Comment at: test/clang-tidy/misc-delete-null-pointer.cpp:11
+ }
+ // CHECK-FIXES: delete p;
+ int *p3 = new int[3];
Is there check-fixes-not? This seems to be required here, because even if the
fixit won't happen here, the test w
Hmm, right now there is no way to use alpha checks in clang tidy?
Piotr
On Nov 10, 2016 10:57, "Malcolm Parsons via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> On 9 November 2016 at 18:50, Devin Coughlin wrote:
>
> > We agree that this is a valuable checker and are committed to getting i
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky.
Prazek added a subscriber: cfe-commits.
Herald added a subscriber: sanjoy.
http://reviews.llvm.org/D12719
Files:
lib/Analysis/ScalarEvolution.cpp
test/Analysis/ScalarEvolution/avoid-assume-hang.ll
Index: test/Analysis/Sc
Prazek added inline comments.
Comment at: lib/Analysis/ScalarEvolution.cpp:6980
@@ -6991,1 +6979,3 @@
+ // Check conditions due to any @llvm.assume intrinsics.
+ for (auto &AssumeVH : AC.assumptions()) {
nlewycky wrote:
> What is it about this check which is a
Prazek added a comment.
I checked it, it is of course not infinite. I am not sure about n! in case of
assumes. I having 10 or 20 assumes will not make it slow. @rsmith was helping
me with it, and he thinks that for assumes it is O(n^2), because results are
memorized.
So it this case, 1000 assu
Prazek added a comment.
I used "hanging out" in the meaning of being very slow, not sure if it is right
word for it.
http://reviews.llvm.org/D12719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Have to accept revision to close it
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@list
Author: prazek
Date: Wed Sep 9 17:20:28 2015
New Revision: 247199
URL: http://llvm.org/viewvc/llvm-project?rev=247199&view=rev
Log:
Generating assumption loads of vptr after ctor call (fixed)
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purpose
Author: prazek
Date: Thu Sep 10 15:18:30 2015
New Revision: 247332
URL: http://llvm.org/viewvc/llvm-project?rev=247332&view=rev
Log:
Revert "Generating assumption loads of vptr after ctor call (fixed)"
It seems that there is small bug, and we can't generate assume loads
when some virtual function
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, hans, majnemer.
Prazek added a subscriber: cfe-commits.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.
Prazek updated this revision to Diff 34750.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.cpp
test/CodeGenCXX/vtable-available-externally.cpp
Index: test/CodeGenCXX/vtable
Prazek updated this revision to Diff 34761.
Prazek marked 3 inline comments as done.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.cpp
test/CodeGenCXX/vtable-available-exte
Prazek added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406
@@ +393,15 @@
+
+for (const auto &VtableComponent : VtableLayout.vtable_components()) {
+ if (VtableComponent.isRTTIKind()) {
+const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDe
Author: prazek
Date: Mon Sep 14 19:37:06 2015
New Revision: 247646
URL: http://llvm.org/viewvc/llvm-project?rev=247646&view=rev
Log:
Generating assumption loads of vptr after ctor call (fixed)
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purpose
Prazek closed this revision.
Prazek added a comment.
Assume loads released.
http://reviews.llvm.org/D12865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: prazek
Date: Mon Sep 14 19:55:29 2015
New Revision: 247650
URL: http://llvm.org/viewvc/llvm-project?rev=247650&view=rev
Log:
small test bugfix
Modified:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
URL:
http://llvm.org/v
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 34833.
http://reviews.llvm.org/D12026
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
Prazek marked an inline comment as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:3859
@@ -3848,4 +3858,3 @@
} else {
-InternalId = llvm::MDNode::getDistinct(getLLVMContext(),
- llvm::ArrayRef());
+InternalId = llvm::MDNode::ge
Prazek marked an inline comment as done.
Prazek added a comment.
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Accept to close
http://reviews.llvm.org/D12312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: prazek
Date: Tue Sep 15 16:46:55 2015
New Revision: 247725
URL: http://llvm.org/viewvc/llvm-project?rev=247725&view=rev
Log:
Decorating vptr load & stores with !invariant.group
Adding !invariant.group to vptr load/stores for devirtualization purposes.
For more goto:
http://lists.llvm.org/
Author: prazek
Date: Tue Sep 15 16:46:50 2015
New Revision: 247724
URL: http://llvm.org/viewvc/llvm-project?rev=247724&view=rev
Log:
Added llvm.module flag for strict vtable pointers
It is dangerous to do LTO on code with strict-vtable-pointers, because
one module has invariant.group.barriers, an
Author: prazek
Date: Tue Sep 15 16:46:47 2015
New Revision: 247723
URL: http://llvm.org/viewvc/llvm-project?rev=247723&view=rev
Log:
Emiting llvm.invariant.group.barrier when dynamic type changes
For more goto:
http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.html
http://reviews.llvm.org
Author: prazek
Date: Tue Sep 15 18:04:47 2015
New Revision: 247733
URL: http://llvm.org/viewvc/llvm-project?rev=247733&view=rev
Log:
invariant.group-for-vptrs test fix
Modified:
cfe/trunk/test/CodeGenCXX/invariant.group-for-vptrs.cpp
Modified: cfe/trunk/test/CodeGenCXX/invariant.group-for-vp
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky, majnemer.
Prazek added a subscriber: cfe-commits.
Using changes from http://reviews.llvm.org/D12926
http://reviews.llvm.org/D12927
Files:
lib/CodeGen/CodeGenModule.cpp
Index: lib/CodeGen/CodeGenModule.cpp
Author: prazek
Date: Thu Sep 17 15:25:46 2015
New Revision: 247933
URL: http://llvm.org/viewvc/llvm-project?rev=247933&view=rev
Log:
Using MD_invariant_group
http://reviews.llvm.org/D12927
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
UR
Prazek created this revision.
Prazek added reviewers: rsmith, samsonov, majnemer.
Prazek added a subscriber: cfe-commits.
Temporary fix till InstCombine and other possible passes will be efficient to
handle multiple assumes.
http://reviews.llvm.org/D13223
Files:
lib/CodeGen/CGClass.cpp
test
Author: prazek
Date: Mon Sep 28 15:30:22 2015
New Revision: 248734
URL: http://llvm.org/viewvc/llvm-project?rev=248734&view=rev
Log:
Generate assume loads only with -fstrict-vtable-pointers
Temporary fix till InstCombine and other possible passes will be
efficient to handle multiple assumes.
Mod
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, nlewycky, rjmccall.
Prazek added a subscriber: cfe-commits.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
Prazek updated this revision to Diff 36125.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
===
--- test/CodeGenCXX
Prazek updated this revision to Diff 36130.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
===
--- test/CodeGenCXX
Author: prazek
Date: Wed Sep 30 22:50:41 2015
New Revision: 248982
URL: http://llvm.org/viewvc/llvm-project?rev=248982&view=rev
Log:
Decorating virtual functions load with invariant.load
http://reviews.llvm.org/D13279
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
cfe/trunk/test/CodeG
Author: prazek
Date: Wed Sep 30 23:19:45 2015
New Revision: 248984
URL: http://llvm.org/viewvc/llvm-project?rev=248984&view=rev
Log:
Test fix
Modified:
cfe/trunk/test/CodeGenCXX/virtual-function-calls.cpp
Modified: cfe/trunk/test/CodeGenCXX/virtual-function-calls.cpp
URL:
http://llvm.org/vi
, Chandler Carruth
wrote:
> On Wed, Sep 30, 2015 at 8:52 PM Piotr Padlewski via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: prazek
>> Date: Wed Sep 30 22:50:41 2015
>> New Revision: 248982
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky, rjmccall, majnemer.
Prazek added a subscriber: cfe-commits.
Please review asap
http://reviews.llvm.org/D13373
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/invariant.group-for-vptrs.cpp
test/CodeGenCXX/strict-vtable-p
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 36382.
Prazek marked an inline comment as done.
http://reviews.llvm.org/D13373
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/invariant.group-for-vptrs.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: t
Author: prazek
Date: Fri Oct 2 17:12:40 2015
New Revision: 249197
URL: http://llvm.org/viewvc/llvm-project?rev=249197&view=rev
Log:
Emiting invariant.group.barrier for ctors bugfix
Ensure that the vptr store in the most-derived constructor is not behind
an invariant group barrier. Previously, th
1 - 100 of 373 matches
Mail list logo
