[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. Hi @rnk , mine is Phoebe#3036. I haven't really used it before. No sure if I invited you correctly, so I try to explain here. > My comment here refers to the alignment of argument values, not user-declared > variables. The frontend controls the alignment of user-declare

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei updated this revision to Diff 395128. pengfei added a comment. Split the LLVM datalayout to a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115441/new/ https://reviews.llvm.org/D115441 Files: clang/lib/Basic/TargetInfo.c

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei updated this revision to Diff 395129. pengfei added a comment. Split the LLVM datalayout to a different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115441/new/ https://reviews.llvm.org/D115441 Files: clang/lib/Basic/TargetInfo.c

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei created this revision. pengfei added reviewers: rnk, andrew.w.kaylor, erichkeane, craig.topper. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MSVC currently doesn't s

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. This is split from D115441 . Add a targeted LLVM test. Thanks @rnk for the advise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 _

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei created this revision. pengfei added reviewers: skan, xiangzhangllvm, craig.topper, coby. Herald added subscribers: ChuanqiXu, hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. D115225

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei added a comment. In D116090#3205828 , @skan wrote: > Thank you for the fix! LGTM Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/ https://reviews.llvm.org/D116090

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG682d01a1c1c5: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables (authored by pengfei). Repository: rG LLVM Github Monorepo

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

pengfei reopened this revision. pengfei added a comment. This revision is now accepted and ready to land. There are several buildbot fail. Need to investigate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116090/new/ https://reviews.llvm.org/D1

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG24c68ea1eb4f: Reland "[X86][MS-InlineAsm] Use exact conditions to recognize MS global… (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D116090?vs=395962&id=396145#toc Repositor

[PATCH] D116325: [X86] Add missing CET intrinsics support

pengfei added a comment. Checked we won't raise uninitialized warning, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116325/new/ https://reviews.llvm.org/D116325 ___ cfe-commits mailing list cfe

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei created this revision. pengfei added reviewers: MaskRay, hjl.tools, erichkeane, LuoYuanke, craig.topper. Herald added subscribers: dang, hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This fixe

[PATCH] D112415: [Driver] ignore -maccumulate_outgoing_args option

pengfei created this revision. pengfei added reviewers: efriedma, erichkeane, LuoYuanke. Herald added a subscriber: dang. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/bugs/show_bug.cgi?id=28145 Signed-off-

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei updated this revision to Diff 381997. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112413/new/ https://reviews.llvm.org/D112413 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D112413: [X86] Add -mskip-rax-setup support to align with GCC

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:99 +cl::desc("Skips setting up the RAX register when SSE is disabled and there " + "are no variable arguments passed in vector registers."), +cl::Hidden); joer

<    1   2   3   4   5   6