Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

blastrock added a comment. Seems fine to me, but I think you forgot to update the tests :) Repository: rL LLVM https://reviews.llvm.org/D24628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

blastrock added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9 @@ -8,3 +8,3 @@ // This test is too subtle to try on non-x86 arch for now. -// REQUIRES: x86_64-supported-target,i386-supported-target +// REQUIRES: x86-target-arch --

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Sorry, I'm not sure I got what is the workflow on this platform. This patch is now "accepted", but do I need to do something else here? The only relevant action I can do seems to be "close revision", should I do that? The developper policy page

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Oh I see! Indeed, I don't have commit rights, so I would help me if you could do it :) http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

blastrock added a comment. Thank you! http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits