[clang-tools-extra] [llvm] [clang] Dont alter cold function alignment unless using Os (PR #72387)

2023-11-15 Thread Phil Camp via cfe-commits
https://github.com/FlameTop created https://github.com/llvm/llvm-project/pull/72387 This PR alters the behaviour of function alignment for functions marked as 'cold'. Currently functions marked with a ‘cold’ attribute are also set as optimize by size. Optimize by size alters the function align

[clang] [clang-tools-extra] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2023-11-22 Thread Phil Camp via cfe-commits
FlameTop wrote: @pogo59 I agree that stating the PS ABI has an explicit function alignment unless overridden does negate the need for a new attribute. I will re-work the code to remove the new attribute and instead enforce it for the PS ABI target. https://github.com/llvm/llvm-project/pull/7

[PATCH] D27043: Remove assertion on analysis of rvalue vector

2016-11-23 Thread Phil Camp via cfe-commits
FlameTop created this revision. FlameTop added reviewers: zaks.anna, dcoughlin. FlameTop added a subscriber: cfe-commits. ExprEngine::VisitLvalArraySubscriptExpr contains an assert to ensure it is passed either a GLvalue or a small number of C exemptions. This change adds vector types to the ass

[PATCH] D19866: [Analyzer] Correct stack address escape diagnostic

2016-05-03 Thread Phil Camp via cfe-commits
FlameTop created this revision. FlameTop added reviewers: zaks.anna, dcoughlin. FlameTop added a subscriber: cfe-commits. Leaking a stack address via a static variable refers to it in the diagnostic as a 'global'. This patch corrects the diagnostic for static variables. Patch by Phil Camp, SN S

Re: [PATCH] D19866: [Analyzer] Correct stack address escape diagnostic

2016-05-09 Thread Phil Camp via cfe-commits
FlameTop updated this revision to Diff 56591. FlameTop added a comment. Thank you for your review. I have removed the changes to the bug description. Apologies, I did not realize it would alter the hash. http://reviews.llvm.org/D19866 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/Stack

Re: [PATCH] D19866: [Analyzer] Correct stack address escape diagnostic

2016-05-10 Thread Phil Camp via cfe-commits
FlameTop added a comment. Thank you for the acceptance. May I please ask you to commit the change for me as I do not have commit access? cheers Phil Camp http://reviews.llvm.org/D19866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[clang] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2024-02-22 Thread Phil Camp via cfe-commits
https://github.com/FlameTop closed https://github.com/llvm/llvm-project/pull/72387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Dont alter cold function alignment unless using Os (PR #72387)

2024-02-22 Thread Phil Camp via cfe-commits
FlameTop wrote: Closing this PR. I will redesign the change and re-submit. https://github.com/llvm/llvm-project/pull/72387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits