[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing marked 9 inline comments as done. Higuoxing added inline comments. Comment at: test/Sema/parentheses.c:20 +#define NESTING_VOID(cond) ( (void)(cond) ) +#define NESTING_VOID_WRAPPER(op0, op1, x, y, z) ( (void)(x op0 y op1 z) ) + dexonsmith wrote: > - You

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151654. Higuoxing marked an inline comment as done. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === --- test/Sema/p

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added inline comments. Comment at: test/Sema/parentheses.c:114 + NON_NESTING_VOID_0(i && i || i); // expected-warning {{'&&' within '||'}} \ + // expected-note {{place parentheses around the '&&' expression to silence this warning}} +

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151661. Higuoxing marked 12 inline comments as done. Higuoxing removed a reviewer: echristo. https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c ==

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1135284, @dexonsmith wrote: > Did you miss this comment from my previous review? > > > I would like to see tests like the following: > > > > NESTING_VOID_WRAPPER(&&, ||, i, i, i && i); // no warning. > > NESTING_VOID_WRAPPER(||, &

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing updated this revision to Diff 151736. Higuoxing added a comment. test case has been passed https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c === ---

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. Sorry, It seems a little bit difficult for me to add a proper fix-it hint for expressions in macros, because I cannot find the exact position of the last char of the token on right hand side of operator. Any suggestion? Actually, in gcc, it will emit warning for every

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

gramanas added a comment. ping! should I commit this? Repository: rC Clang https://reviews.llvm.org/D47720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48346: [X86] Rewrite the add/mul/or/and reduction intrinsics to make better use of other intrinsics and remove undef shuffle indices.

This revision was automatically updated to reflect the committed changes. Closed by commit rC335253: [X86] Rewrite the add/mul/or/and reduction intrinsics to make better use of… (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D48346 Files: lib/Headers/avx

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL335255: [DebugInfo] Inline for without DebugLocation (authored by gramanas, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47720 Files: cfe/tr

[PATCH] D48187: [Intrinsics] Add/move some builtin declarations in intrin.h to get ms-intrinsics.c to not issue warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL335259: [Intrinsics] Add/move some builtin declarations in intrin.h to get ms… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D48448: [X86] Correct the inline assembly implementations of __movsb/w/d/q and __stosw/d/q to mark registers/memory as modified

This revision was automatically updated to reflect the committed changes. Closed by commit rL335270: [X86] Correct the inline assembly implementations of __movsb/w/d/q and… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs added a comment. In https://reviews.llvm.org/D47864#1139750, @jbcoe wrote: > Would you like me to commit this for you? Sure, that would be great! I don't have commit rights so I was waiting for someone to do it. Thanks! Repository: rC Clang https://reviews.llvm.org/D47864 _

[PATCH] D48503: Fix BUILD_SHARED_LIBS=1 build of libclangHandleLLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rC335380: Fix BUILD_SHARED_LIBS=1 build of libclangHandleLLVM (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D48503?vs=152531&id=152535#toc Repository: rC Clang ht

[PATCH] D53048: [Basic] Split out -Wimplicit-int-conversion and -Wimplicit-float-conversion from -Wconversion

This revision was automatically updated to reflect the committed changes. Closed by commit rL344101: [Basic] Split out -Wimplicit-int-conversion and -Wimplicit-float-conversion… (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

This revision was automatically updated to reflect the committed changes. Closed by commit rL344117: [X86] Remove FeatureRTM from Skylake processor list (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53042?vs=168

[PATCH] D53046: [Sema] Fix an error-on-valid with friends and templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL344157: [Sema] Fix a multiple definition bug with friends and templates (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL344230: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D52673: [HIP] Remove disabled irif library

This revision was automatically updated to reflect the committed changes. Closed by commit rL344285: [HIP] Remove unused irif bitcode from test (authored by aaronenyeshi, committed by ). Herald added subscribers: llvm-commits, jvesely. Changed prior to commit: https://reviews.llvm.org/D52673?vs

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Have been looked at this far and wide too many times now. I say we roll this out and fix and improve later on, lest this only going into Clang 72. Results look promising, let's hope us

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

whisperity added a comment. Herald added subscribers: donat.nagy, Szelethus, mikhail.ramalho, rnkovacs, szepet. Herald added a reviewer: george.karpenkov. //Soft ping.// https://reviews.llvm.org/D33672 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

whisperity added a comment. @aaron.ballman Neither I nor @Charusso has commit rights, could you please commit this in our stead? https://reviews.llvm.org/D45050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D53154: [CodeGen] Handle extern references to OBJC_CLASS_$_*

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC344373: [CodeGen] Handle extern references to OBJC_CLASS_$_* (authored by epilk, committed by ). Changed prior to commit:

[PATCH] D53263: [CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol created this revision. bobsayshilol added reviewers: sberg, ahatanak. Herald added subscribers: cfe-commits, jfb. `FunctionDecl::Create()` takes as its `T` parameter the type of function that should be created, not the return type. Passing in the return type looks to have been copyp

[PATCH] D53239: [python] [tests] Disable python binding tests when building with LLVM_USE_SANITIZER=Address

This revision was automatically updated to reflect the committed changes. Closed by commit rL344537: [python] [tests] Disable python binding tests under LLVM_USE_SANITIZER=Address (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D52804: [analyzer] NFC: RetainCountChecker: Avoid dumping symbols during normal operation.

This revision was automatically updated to reflect the committed changes. Closed by commit rC344538: [analyzer] NFC: RetainCountChecker: Don't dump() symbols into program point… (authored by dergachev, committed by ). Herald added a subscriber: donat.nagy. Repository: rC Clang https://reviews.

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

This revision was automatically updated to reflect the committed changes. Closed by commit rL344539: [analyzer] Teach CallEvent about C++17 aligned operator new(). (authored by dergachev, committed by ). Herald added subscribers: llvm-commits, donat.nagy. Changed prior to commit: https://review

[PATCH] D53334: [Frontend] Show diagnostics on prebuilt module configuration mismatch too

whisperity created this revision. whisperity added reviewers: rsmith, doug.gregor. whisperity added a project: clang. Herald added subscribers: Szelethus, dkrupp, rnkovacs. The current version only emits the below error for a module (attempted to be loaded) from the `prebuilt-module-path`: er

[PATCH] D52790: [analyzer][PlistMacroExpansion] New flag to convert macro expansions to events

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Herald added a subscriber: donat.nagy. Remove the custom file paths and URLs but other than that this is pretty trivial. https://reviews.llvm.org/D52790 ___

[PATCH] D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype

whisperity added a comment. With regards to https://reviews.llvm.org/D53352: you can change the diff related to a patch whilst keeping discuccion and metadata of the diff. Please add a generic description to the diff for an easy skimming on what you are accomplishing. If I get this right, your

[PATCH] D52988: [analyzer][PlistMacroExpansion] Part 5.: Support for # and ##

whisperity added a comment. Looks good. What happens if the macro is to stringify a partially string argument? #define BOOYAH(x) #x "; ... std::string foo = BOOYAH(blabla) std::string foo2 = BOOYAH("blabla) int x = 2; Not sure if these cases are even valid C(XX), but if they ar

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

calixte added a comment. @vsk, gcc guys are ok for -fprofile-filter-files and -fprofile-exclude-files, are you ok with that ? Should these options prefixed by -Xclang or not ? Repository: rC Clang https://reviews.llvm.org/D52034 ___ cfe-commits

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

This revision was automatically updated to reflect the committed changes. Closed by commit rL344755: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C… (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D52670?vs=170108&id=17

[PATCH] D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP)

This revision was automatically updated to reflect the committed changes. Closed by commit rL344757: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D53263: [CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol updated this revision to Diff 170136. bobsayshilol edited the summary of this revision. bobsayshilol added a comment. Fixed the added assert to do the right thing. Clang can now build with a debug Clang built from this patch, and all unittests I could find pass in that built version

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344785: [clang-tidy] Resolve readability-else-after-return false positive for constexpr… (authored by mkurdej, committed by ). Changed prior to commit: https://reviews.llvm.org/D53372?vs=170152&id=170

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol updated this revision to Diff 170277. bobsayshilol retitled this revision from "[CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type" to "Fix places where the return type of a FunctionDecl was being used in place of the function t

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static locals into .cpp files. (authored by dergachev, committed by ). Herald added subscribers: llvm-commits, dkrupp, donat.nagy. Changed prior to com

[PATCH] D53460: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

This revision was automatically updated to reflect the committed changes. Closed by commit rL344824: [X86] When checking the bits in cpu_features for function multiversioning… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

This revision was automatically updated to reflect the committed changes. Closed by commit rC344915: Ensure sanitizer check function calls have a !dbg location (authored by adrian, committed by ). Repository: rC Clang https://reviews.llvm.org/D53459 Files: lib/CodeGen/CGExpr.cpp test/Code

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1266893, @vsapsai wrote: > Sorry about the delay. The change seems to be correct but `ninja check-clang` > reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look > into that? Hi, It's because the expression is

[PATCH] D53578: [CodeGen] Fix clang test for gcov profiling (follow-up of D51974)

calixte created this revision. calixte added a reviewer: vsk. Herald added a subscriber: cfe-commits. After patch https://reviews.llvm.org/D51974 has landed, this one is required to fix a test. Repository: rC Clang https://reviews.llvm.org/D53578 Files: test/CodeGen/code-coverage.c Inde

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

whisperity added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:238 + /// message on that constraint being changed. + bool isChangedOrInsertConstraint(ConstraintMap &Constraints, const Stmt *Cond, +

[PATCH] D53456: [Sema] Do not show unused parameter warnings when body is skipped

This revision was automatically updated to reflect the committed changes. Closed by commit rC345122: [Sema] Do not show unused parameter warnings when body is skipped (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D53456?vs=170268&id=170827#toc Reposi

[PATCH] D53334: [Frontend] Show diagnostics on prebuilt module configuration mismatch too

whisperity added a comment. @dblaikie I have created a test, but unfortunately `%clang_cpp` in LIT invokes `clang --driver-mode=cpp` which is not the same as if `clang++` is called. I'm trying to construct the following command-line `clang++ -fmodules-ts -fprebuilt-module-path=%t/mods --precomp

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

whisperity updated this revision to Diff 170832. whisperity retitled this revision from "[Frontend] Show diagnostics on prebuilt module configuration mismatch too" to "[Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too". whisperity added a comment. Herald added a su

[PATCH] D53347: [clangd] Simplify auto hover

This revision was automatically updated to reflect the committed changes. Closed by commit rL345128: [clangd] Simplify auto hover (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53347?vs=170273&id=170835#toc Re

[PATCH] D53520: Update the example of BS_Stroustrup to match what is done by clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rL345371: Update the example of BS_Stroustrup to match what is done by clang-format (authored by sylvestre, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

This revision was automatically updated to reflect the committed changes. Closed by commit rL345381: [clang-tidy] Re-commit: Add new 'readability-uppercase-literal-suffix' check… (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D52670?vs=171279&id=17129

[PATCH] D53772: [NFC][OpenMP] Add new test for parallel for code generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345417: [NFC][OpenMP] Add new test for parallel for code generation. (authored by gbercea, committed by ). Repository: rC Clang https://reviews.llvm.org/D53772 Files: test/OpenMP/nvptx_parallel_for_

[PATCH] D53604: [AST] Widen the bit-fields of Stmt to 8 bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rL345459: [AST] Widen the bit-fields of Stmt to 8 bytes. (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53604?vs=17073

[PATCH] D53605: [AST] Refactor PredefinedExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL345460: [AST] Refactor PredefinedExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53605?vs=171326&id=171406#toc

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol added a comment. Ping. https://reviews.llvm.org/D53263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53607: [AST] Only store the needed data in IfStmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345464: [AST] Only store the needed data in IfStmt (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D53607 Files: include/clang/AST/Stmt.h lib/AST/ASTDumper.c

[PATCH] D53609: [AST] Don't store data for GNU range case statement if not needed.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345472: [AST] Don't store data for GNU range case statement if not needed (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D53609 Files: include/clang/AST/Stmt.

[PATCH] D53621: Support for groups of attributes in #pragma clang attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL345486: Support for groups of attributes in #pragma clang attribute (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53621?

[PATCH] D53610: [AST] Check that GNU range case statements are correctly imported.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345506: [AST] Check that GNU range case statements are correctly imported. (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D53610 Files: test/Import/switch-stm

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345507: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases. (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

This revision was automatically updated to reflect the committed changes. Closed by commit rL345509: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel… (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D53714: [AST] Only store the needed data in SwitchStmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345510: [AST] Only store the needed data in SwitchStmt (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53714?vs=17133

[PATCH] D53827: [OpenMP] Fix condition.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345527: [OpenMP] Fix condition. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D53827?vs=171558&id=171559#toc Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D50269: [compiler-rt][builtins] Don't #include CoreFoundation in os_version_check.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL345551: [compiler-rt][builtins] Don't #include CoreFoundation in os_version_check.c (authored by epilk, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llv

[PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:420-465 if (ChecksEnabled[CK_InvalidatedIteratorChecker] && isAccessOperator(Func->getOverloadedOperator())) { // Check for any kind of access of invalidated iterato

[PATCH] D53837: [clang] Move two utility functions into SourceManager

This revision was automatically updated to reflect the committed changes. Closed by commit rL345594: [clang] Move two utility functions into SourceManager (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53837?vs

[PATCH] D53715: [AST] Only store the needed data in WhileStmt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345597: [AST] Only store the needed data in WhileStmt (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53715?vs=171338

[PATCH] D53716: [AST] Only store data for the NRVO candidate in ReturnStmt if needed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345605: [AST] Only store data for the NRVO candidate in ReturnStmt if needed (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D53716: [AST] Only store data for the NRVO candidate in ReturnStmt if needed.

This revision was automatically updated to reflect the committed changes. Closed by commit rC345605: [AST] Only store data for the NRVO candidate in ReturnStmt if needed (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D53716?vs=171131&id=171696#toc Re

[PATCH] D53817: [clang-tidy] cppcoreguidelines-macro-usage: print macro names

This revision was automatically updated to reflect the committed changes. Closed by commit rL345610: [clang-tidy] cppcoreguidelines-macro-usage: print macro names (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345637: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects) (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D53547?vs=170703&id=171778#toc

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

whisperity added a reviewer: dyung. whisperity added a subscriber: dyung. whisperity added a comment. In https://reviews.llvm.org/D45050#1280831, @dyung wrote: > I have attached a bzipped preprocessed file that I can confirm will show the > failure if built with clang++ version 3.7.1, specifical

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL345660: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181224. MyDeveloperDay added a comment. Address review comments - clang-format the code examples - replace "ensure" with "check" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: docs/clang-ti

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. > I think will be good idea to create generic Case/Prefix/Suffix description to > reduce size of documentation. I'm generating this documentation via a script, using the following template, (which is why its quite

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54071/new/ https://reviews.llvm.org/D54071 ___

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL350955: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 updated this revision to Diff 181371. joedaniels29 added a comment. Tried to fix Aaron Ballman's feedback. Thanks Aaron! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555 Files: clang/include/clang/Basic/Attr

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181497. MyDeveloperDay added a comment. Fix review comments s/the checker will check/the check will ensure/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: docs/clang-tidy/checks/readability

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() serge-sans-pai

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 181498. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 Files: include/clang/Basic/SourceManager.h test/Misc/no-warn-in-system-macr

[PATCH] D56066: [OpenCL] Address space for default class members

This revision was automatically updated to reflect the committed changes. Closed by commit rL351053: [OpenCL] Set generic addr space of 'this' in special class members. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D56488: clang-cl: Align help texts for /O1 and O2

This revision was automatically updated to reflect the committed changes. Closed by commit rL351061: clang-cl: Align help texts for /O1 and O2 (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56488?vs=180832&id=181533

[PATCH] D56489: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

This revision was automatically updated to reflect the committed changes. Closed by commit rL351062: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-' (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D56523: Improve a -Wunguarded-availability note

This revision was automatically updated to reflect the committed changes. Closed by commit rC351108: Improve a -Wunguarded-availability note (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56523?vs=181130&id=181616#toc Repository: rC Clang CHANGES SINC

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351105: [clang][UBSan] Sanitization for alignment assumptions. (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://rev

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 updated this revision to Diff 181692. joedaniels29 marked 2 inline comments as done. joedaniels29 added a comment. Hopefully addressed Aaron's comments. Thanks again Aaron. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 added a comment. never mind, I didnt address > It's still missing the tests in SemaObjC -- you can use > clang\test\SemaObjC\attr-root-class.m as an example of what I'm talking about. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https:/

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 added a comment. On second thought, I have addressed everything, I think. > clang/test/SemaObjC/attr-objc-non-lazy.m Aaron, would you mind taking another look? Thanks a bunch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews

[PATCH] D56429: fix python3 compability issue

roxma marked an inline comment as done. roxma added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() ---

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rC351160: [X86] Make _xgetbv/_xsetbv on non-windows platforms (authored by ctopper, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56686/new/ https://reviews.

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1356959 , @karepker wrote: > Hi all, ping on this patch. I've addressed all comments to the best of my > ability. Is there anything outstanding that needs to be changed? Round about this time of a review we norm

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1351707 , @JonasToth wrote: > > I do not have commit rights. I'm not sure what constitutes someone who can > > commit, but let me contribute a little more before taking that step, I > > have another idea for a c

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1357481 , @lebedev.ri wrote: > In D56424#1357471 , @MyDeveloperDay > wrote: > > > In D56424#1356959 , @karepker > > wrote: > > > >

[PATCH] D56646: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1, 2}d_array_t variants are OpenCL-1.2+, mark them as such

This revision was automatically updated to reflect the committed changes. Closed by commit rL351188: [OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1,2}d_array_t… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay added a comment. In D56563#1358149 , @JonasToth wrote: > > Given its length, what do you think about a short link-list at the beginning > that will point to the section in the docs? With that its easier to see whats > all handled by th

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181836. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Addressing review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: docs/clang-tidy/checks/reada

[PATCH] D56690: [Nios2] Remove Nios2 backend

This revision was automatically updated to reflect the committed changes. Closed by commit rC351230: [Nios2] Remove Nios2 backend (authored by ctopper, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56690/new/ https://reviews.llvm.org/D56690 Files:

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL351261: [clang-tidy] add options documentation to readability-identifier-naming checker (authored by paulhoad, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D56538: [NewPM][TSan] Reiterate the TSan port

This revision was automatically updated to reflect the committed changes. Closed by commit rC351314: [NewPM][TSan] Reiterate the TSan port (authored by pfaffe, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D56538?vs=181821&id=181994#to

[PATCH] D56429: fix python3 compability issue

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(content

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1359227 , @karepker wrote: > In D56424#1357484 , @MyDeveloperDay > wrote: > > > In D56424#1357481 , @lebedev.ri > > wrote: > > > >

<    8   9   10   11   12   13   14   15   16   17   >