Author: phosek
Date: Tue Jun 26 20:35:53 2018
New Revision: 335704
URL: http://llvm.org/viewvc/llvm-project?rev=335704&view=rev
Log:
[CMake] Provide direct support for building sanitized runtimes
This avoids having to rely on magic separators and special parsing.
Differential Revision: https://r
Author: phosek
Date: Tue Jun 26 22:50:43 2018
New Revision: 335708
URL: http://llvm.org/viewvc/llvm-project?rev=335708&view=rev
Log:
[CMake] Support passing FUCHSIA_SDK as the only variable
Now that the structure of Fuchsia SDK has been formalized, we no
longer need to pass all the different CFLA
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:54:08 2018
New Revision: 335810
URL: http://llvm.org/viewvc/llvm-project?rev=335810&view=rev
Log:
Handle both Linux and Windows path separator for the resource dir
The resource dir path used for the multiarch runtimes support is
constructed in a platform indepen
Author: phosek
Date: Wed Jun 27 22:15:46 2018
New Revision: 335812
URL: http://llvm.org/viewvc/llvm-project?rev=335812&view=rev
Log:
[CMake] Use explicit targets for building Linux runtimes
Previously we were using default logic when building Linux runtimes
in Fuchsia toolchain, but that leads to
Author: phosek
Date: Thu Jun 28 13:19:11 2018
New Revision: 335917
URL: http://llvm.org/viewvc/llvm-project?rev=335917&view=rev
Log:
[CMake] Build static runtimes for host in Fuchsia first stage
First stage build is only a minimal build where we don't need
a complete multiarch support, but we nee
Author: phosek
Date: Thu Jun 28 13:33:18 2018
New Revision: 335919
URL: http://llvm.org/viewvc/llvm-project?rev=335919&view=rev
Log:
[CMake] Don't build Linux targets on Darwin in Fuchsia toolchain
This is currently breaking because Linux target sysroots rely on
case sensitive filesystem which is
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
Author: phosek
Date: Sat Jul 14 20:11:43 2018
New Revision: 337117
URL: http://llvm.org/viewvc/llvm-project?rev=337117&view=rev
Log:
[CMake] Use libc++ and compiler-rt for sanitizers
When building runtimes for Linux as part of Fuchsia toolchain, use
libc++ and compiler-rt for sanitizers.
Differe
Author: phosek
Date: Sat Jul 14 21:09:35 2018
New Revision: 337118
URL: http://llvm.org/viewvc/llvm-project?rev=337118&view=rev
Log:
[CMake] Use correct variable as header install prefix
This variable is already set in CMakeLists.txt but it wasn't used
which means that the headers get installed i
Author: phosek
Date: Fri Oct 11 15:22:29 2019
New Revision: 374606
URL: http://llvm.org/viewvc/llvm-project?rev=374606&view=rev
Log:
[libunwind] Refactor CMake flag checks to match libc++ and libc++abi
libunwind was using its own set of macros/functions for flag checking
which was similar but dif
Author: phosek
Date: Fri Oct 11 18:50:57 2019
New Revision: 374624
URL: http://llvm.org/viewvc/llvm-project?rev=374624&view=rev
Log:
[libunwind] Fix issues introduced in r374606
There are few differences in compile flags introduced in r374606
which are causing libcxx-libcxxabi-libunwind-armv8-lin
Author: Petr Hosek
Date: 2019-10-24T16:35:29-07:00
New Revision: 7fff716ec4741f84358a977ddf0cd5ccf448d5c5
URL:
https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5
DIFF:
https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5.diff
LO
Author: Petr Hosek
Date: 2020-07-23T14:47:25-07:00
New Revision: 1d09ecf36175f7910ffedd6d497c07b5c74c22fb
URL:
https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb
DIFF:
https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb.diff
LO
Author: Petr Hosek
Date: 2020-07-23T15:12:42-07:00
New Revision: 38c71b7c85cac4c8de39329ff3ed682e63f61525
URL:
https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525
DIFF:
https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525.diff
LO
Thanks for the heads up, this should be addressed
by c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other
issues.
On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk added a comment.
>
> @phosek I suspect this is causing a cma
Author: Petr Hosek
Date: 2020-07-27T17:13:55-07:00
New Revision: 64d99cc6abed78c00a2a7863b02ce54911a5264f
URL:
https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f
DIFF:
https://github.com/llvm/llvm-project/commit/64d99cc6abed78c00a2a7863b02ce54911a5264f.diff
LO
Author: Petr Hosek
Date: 2020-06-04T14:25:19-07:00
New Revision: d51054217403b47f452619e11318bd214749a845
URL:
https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845
DIFF:
https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845.diff
LO
Author: Petr Hosek
Date: 2020-06-04T15:44:10-07:00
New Revision: e1ab90001a0bac1d1bebe4116ce0e89567138283
URL:
https://github.com/llvm/llvm-project/commit/e1ab90001a0bac1d1bebe4116ce0e89567138283
DIFF:
https://github.com/llvm/llvm-project/commit/e1ab90001a0bac1d1bebe4116ce0e89567138283.diff
LO
Author: Petr Hosek
Date: 2020-06-04T15:47:05-07:00
New Revision: b16ed493ddc22a100341b1e7d9b11282a8994e96
URL:
https://github.com/llvm/llvm-project/commit/b16ed493ddc22a100341b1e7d9b11282a8994e96
DIFF:
https://github.com/llvm/llvm-project/commit/b16ed493ddc22a100341b1e7d9b11282a8994e96.diff
LO
Author: Petr Hosek
Date: 2020-07-05T14:48:52-07:00
New Revision: a378c0449507e00e96534ff9ce9034e185425182
URL:
https://github.com/llvm/llvm-project/commit/a378c0449507e00e96534ff9ce9034e185425182
DIFF:
https://github.com/llvm/llvm-project/commit/a378c0449507e00e96534ff9ce9034e185425182.diff
LO
Author: Petr Hosek
Date: 2020-07-09T13:07:12-07:00
New Revision: 53e38c85a8a6cdcf7776b936d72fb94ec737dc84
URL:
https://github.com/llvm/llvm-project/commit/53e38c85a8a6cdcf7776b936d72fb94ec737dc84
DIFF:
https://github.com/llvm/llvm-project/commit/53e38c85a8a6cdcf7776b936d72fb94ec737dc84.diff
LO
Author: Petr Hosek
Date: 2020-07-09T21:07:44-07:00
New Revision: ceb76d2fe73d39f2230bf55d47b8fd68849d47d7
URL:
https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7
DIFF:
https://github.com/llvm/llvm-project/commit/ceb76d2fe73d39f2230bf55d47b8fd68849d47d7.diff
LO
Author: Petr Hosek
Date: 2020-07-14T19:30:08-07:00
New Revision: 8c1a79dc12f3cc600e16153961cd8cc50ba2c33b
URL:
https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b
DIFF:
https://github.com/llvm/llvm-project/commit/8c1a79dc12f3cc600e16153961cd8cc50ba2c33b.diff
LO
Author: Petr Hosek
Date: 2020-04-24T12:18:30-07:00
New Revision: 063128f97930c551a43a657084f1632e33245bf6
URL:
https://github.com/llvm/llvm-project/commit/063128f97930c551a43a657084f1632e33245bf6
DIFF:
https://github.com/llvm/llvm-project/commit/063128f97930c551a43a657084f1632e33245bf6.diff
LO
Author: Petr Hosek
Date: 2020-07-30T13:08:02-07:00
New Revision: 3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b
URL:
https://github.com/llvm/llvm-project/commit/3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b
DIFF:
https://github.com/llvm/llvm-project/commit/3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b.diff
LO
Author: Petr Hosek
Date: 2020-08-05T16:07:11-07:00
New Revision: 1adc494bce44f6004994deed61b30d4b71fe1d05
URL:
https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05
DIFF:
https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05.diff
LO
Author: Petr Hosek
Date: 2020-08-05T20:22:28-07:00
New Revision: 633e3dacf27ea4950b7067803502490597ba96e0
URL:
https://github.com/llvm/llvm-project/commit/633e3dacf27ea4950b7067803502490597ba96e0
DIFF:
https://github.com/llvm/llvm-project/commit/633e3dacf27ea4950b7067803502490597ba96e0.diff
LO
Author: Petr Hosek
Date: 2020-08-08T17:08:23-07:00
New Revision: a4d78d23c53451ccefe0df0adfff9a1ac3077f10
URL:
https://github.com/llvm/llvm-project/commit/a4d78d23c53451ccefe0df0adfff9a1ac3077f10
DIFF:
https://github.com/llvm/llvm-project/commit/a4d78d23c53451ccefe0df0adfff9a1ac3077f10.diff
LO
Author: Petr Hosek
Date: 2020-08-11T20:22:11-07:00
New Revision: 31e5f7120bdd2f76337686d9d169b1c00e6ee69c
URL:
https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c
DIFF:
https://github.com/llvm/llvm-project/commit/31e5f7120bdd2f76337686d9d169b1c00e6ee69c.diff
LO
Author: Petr Hosek
Date: 2020-05-09T13:42:19-07:00
New Revision: c8fbcb1e78adcbaeadca9db9188771d81f49493a
URL:
https://github.com/llvm/llvm-project/commit/c8fbcb1e78adcbaeadca9db9188771d81f49493a
DIFF:
https://github.com/llvm/llvm-project/commit/c8fbcb1e78adcbaeadca9db9188771d81f49493a.diff
LO
Author: Petr Hosek
Date: 2020-05-09T13:44:20-07:00
New Revision: 5b02be0b973a0d792bf8ce39170487f48b6cbd08
URL:
https://github.com/llvm/llvm-project/commit/5b02be0b973a0d792bf8ce39170487f48b6cbd08
DIFF:
https://github.com/llvm/llvm-project/commit/5b02be0b973a0d792bf8ce39170487f48b6cbd08.diff
LO
phosek created this revision.
phosek added a subscriber: cfe-commits.
Provide toolchain and tool support for Fuchsia operating system. Fuchsia uses
compiler-rt as the runtime library and libc++, libc++abi and libunwind as the
C++ standard library. lld is used as a default linker.
https://revie
phosek added a comment.
The patch with LLVM triple for Fuchsia is here: https://reviews.llvm.org/D25116
https://reviews.llvm.org/D25117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
phosek created this revision.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
When compiler-rt is being used as a runtime library, Clang would print an
invalid path when -print_libgcc_file_name option is used. We should print a
path to compiler-rt
phosek updated this revision to Diff 73562.
Repository:
rL LLVM
https://reviews.llvm.org/D25117
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/fuchsia.c
test/Driver/fuchsia
phosek created this revision.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz.
This change allows setting the default linker used by the Clang driver when
configuring the build.
Repository:
rL LLVM
https:
Author: phosek
Date: Thu Oct 6 01:08:09 2016
New Revision: 283420
URL: http://llvm.org/viewvc/llvm-project?rev=283420&view=rev
Log:
[Driver] Add driver support for Fuchsia
Provide toolchain and tool support for Fuchsia operating system.
Fuchsia uses compiler-rt as the runtime library and libc++,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283420: [Driver] Add driver support for Fuchsia (authored by
phosek).
Changed prior to commit:
https://reviews.llvm.org/D25117?vs=73562&id=73784#toc
Repository:
rL LLVM
https://reviews.llvm.org/D251
phosek added a comment.
I have submitted the same change https://reviews.llvm.org/D25256 a few days ago
but this one seems to be getting more traction so I'm going to abandon mine in
favor of this one.
Comment at: lib/Driver/Driver.cpp:1000
+case ToolChain::RLT_CompilerRT
phosek abandoned this revision.
phosek added a comment.
Michał Górny has submitted the same change as https://reviews.llvm.org/D25338
and his change seems to be getting more traction.
Repository:
rL LLVM
https://reviews.llvm.org/D25256
___
cfe-c
phosek added a comment.
Currently yes, we've been using libc++ (and libc++abi which doesn't need any
changes) for a few months now without any problems. Our C library is a fork of
musl so we rely on all the changes that have already been done to support it.
However, we're building libc++ with `
phosek added a comment.
> That sounds fine.
Shall I send it as a separate patch or update this one?
> PS. If your not already locked into an ABI you'll want to look into enabling
> the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION`
> configuration at the top of `__config` for
Author: phosek
Date: Mon Oct 10 13:53:32 2016
New Revision: 283788
URL: http://llvm.org/viewvc/llvm-project?rev=283788&view=rev
Log:
[libcxx] Add support for Fuchsia
Fuchsia is a new operating system which uses musl as the standard
C library, libc++ and libc++abi as the C++ standard library.
Dif
phosek created this revision.
phosek added reviewers: EricWF, mclow.lists.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz.
musl's pthread implementations use volatile types in their structs which is not
being
phosek added a comment.
libc++ was already building with musl after https://reviews.llvm.org/D21637 was
commited, but this broke recently as a consequence of r282640 which introduced
the use of `_LIBCPP_SAFE_STATIC` for libc++ internal globals. I'm not sure if
this is the best solution, but it'
phosek added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
phosek updated this revision to Diff 74402.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D25491
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
phosek updated this revision to Diff 74439.
phosek marked an inline comment as done.
Repository:
rL LLVM
https://reviews.llvm.org/D25491
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@
phosek added a comment.
Ping, do you have any other comments?
Repository:
rL LLVM
https://reviews.llvm.org/D25491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phosek
Date: Wed Nov 22 09:59:30 2017
New Revision: 318853
URL: http://llvm.org/viewvc/llvm-project?rev=318853&view=rev
Log:
[CodeGen] Fix vtable not receiving hidden visibility when using push(visibility)
This change should resolve https://bugs.llvm.org/show_bug.cgi?id=35022
Patch by Ja
Author: phosek
Date: Wed Nov 22 11:50:17 2017
New Revision: 318866
URL: http://llvm.org/viewvc/llvm-project?rev=318866&view=rev
Log:
Revert "[CodeGen] Fix vtable not receiving hidden visibility when using
push(visibility)"
This reverts commit r318853: tests are failing on Windows bots
Removed:
Author: phosek
Date: Mon Nov 27 12:29:13 2017
New Revision: 319088
URL: http://llvm.org/viewvc/llvm-project?rev=319088&view=rev
Log:
[CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain
It's used to determine whether terminal supports colors, but within LLVM
it's only used in handful o
Author: phosek
Date: Tue Nov 28 16:23:10 2017
New Revision: 319264
URL: http://llvm.org/viewvc/llvm-project?rev=319264&view=rev
Log:
[CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add
Escaping ; in list arguments passed to ExternalProject_Add doesn't seem
to be working in newe
Author: phosek
Date: Tue Nov 28 16:34:46 2017
New Revision: 319267
URL: http://llvm.org/viewvc/llvm-project?rev=319267&view=rev
Log:
[CMake] Support side-by-side checkouts in multi-stage build
Passthrough LLVM_ENABLE_{PROJECTS,RUNTIMES} to followup stages to
support the side-by-side checkouts (ak
Author: phosek
Date: Thu Nov 30 19:16:50 2017
New Revision: 319515
URL: http://llvm.org/viewvc/llvm-project?rev=319515&view=rev
Log:
Include AddLLVM needed for tests in the right context
AddLLVM is needed for several functions that are used in tests and
as such needs to be included from the right
Author: phosek
Date: Thu Nov 30 22:34:33 2017
New Revision: 319523
URL: http://llvm.org/viewvc/llvm-project?rev=319523&view=rev
Log:
[libcxx] Support getentropy as a source of randomness for std::random_device
Use this source use on Fuchsia where this is the oficially way
to obtain randomness. Th
Author: phosek
Date: Mon Dec 4 16:15:20 2017
New Revision: 319720
URL: http://llvm.org/viewvc/llvm-project?rev=319720&view=rev
Log:
[CMake] Don't use comma as an alternate separator
Using comma can break in cases when we're passing flags that already
use comma as a separator.
Fixes PR35504.
Di
Author: phosek
Date: Tue Dec 5 12:22:10 2017
New Revision: 319823
URL: http://llvm.org/viewvc/llvm-project?rev=319823&view=rev
Log:
[libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit
These are expected to be set by the shared lit scripts used from
libc++.
Differential Revisio
Author: phosek
Date: Tue Dec 5 12:48:05 2017
New Revision: 319830
URL: http://llvm.org/viewvc/llvm-project?rev=319830&view=rev
Log:
[libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set
This follows the setup used by other runtimes and is expected by
the lit configuration.
Diffe
Author: phosek
Date: Mon Dec 11 17:20:37 2017
New Revision: 320445
URL: http://llvm.org/viewvc/llvm-project?rev=320445&view=rev
Log:
[libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit
These are expected to be set by the shared lit scripts used from libc++.
Differential Revisio
Author: Petr Hosek
Date: 2022-08-29T07:26:01Z
New Revision: 279ba539a1dad609c8293b39a641d33814a2e2be
URL:
https://github.com/llvm/llvm-project/commit/279ba539a1dad609c8293b39a641d33814a2e2be
DIFF:
https://github.com/llvm/llvm-project/commit/279ba539a1dad609c8293b39a641d33814a2e2be.diff
LOG: [F
Author: Petr Hosek
Date: 2023-11-06T22:37:49Z
New Revision: c6a198c72ab0bae4bc8c322ce84feb691c190e5d
URL:
https://github.com/llvm/llvm-project/commit/c6a198c72ab0bae4bc8c322ce84feb691c190e5d
DIFF:
https://github.com/llvm/llvm-project/commit/c6a198c72ab0bae4bc8c322ce84feb691c190e5d.diff
LOG: [C
petrhosek wrote:
> > What I think would be a better design is to just omit the respective
> > sections altogether when -debug-info-correlate/-profile-correlate= is
> > enabled.
>
> I don't understand how this solves the problem you described above. Can you
> elaborate a bit more? We still nee
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/71884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
I'm fine with the feature, my only concern is to make sure we don't
unintentionally make it harder to integrate potential future extensions such as
the mutually dependent groups.
The only alternative I could come up with is representing groups as first class
concept with prop
@@ -702,6 +708,8 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure,
#define INSTR_PROF_COVMAP_COMMON __llvm_covmap
#define INSTR_PROF_COVFUN_COMMON __llvm_covfun
#define INSTR_PROF_ORDERFILE_COMMON __llvm_orderfile
petrhosek wrote:
This just a nit,
petrhosek wrote:
Can you break up all the changes to tests that replace `-debug-info-correlate`
with `--profile-correlate=debug-info` into a separate PR to reduce the size of
this PR?
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits ma
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/74809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -23,7 +23,9 @@ add_subdirectory(Tooling)
add_subdirectory(DirectoryWatcher)
add_subdirectory(Index)
add_subdirectory(IndexSerialization)
-add_subdirectory(StaticAnalyzer)
+if(CLANG_ENABLE_STATIC_ANALYZER)
petrhosek wrote:
I agree with @llvm-beanz but I'd pr
petrhosek wrote:
> Would you accept `Type: Exclusive` instead of `Exclusive: True`? It seems
> more plausible to me that there might be three kinds of group that _can't_ go
> together than three group-type flags that you can have in any combination.
I like this as it scales better to other typ
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/72538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -261,6 +261,9 @@ uint64_t __llvm_profile_get_magic(void);
/*! \brief Get the version of the file format. */
uint64_t __llvm_profile_get_version(void);
+/*! \brief If the binary is compiled with profile correlation. */
+int hasCorrelation();
petrhosek wrote:
@@ -89,3 +89,7 @@ COMPILER_RT_VISIBILITY void
__llvm_profile_reset_counters(void) {
}
lprofSetProfileDumped(0);
}
+
+inline int hasCorrelation() {
petrhosek wrote:
The function should have a hidden visibility (the `COMPILER_RT_VISIBILITY`
macro) so it's
petrhosek wrote:
I'm a bit concerned about the use of `hasCorrelation`. We require the runtime
to check the flag and omit the data and names section if set which introduces a
potential issue: since we emit the version in every TU and u se COMDAT to
deduplicate them, but that means that if you
Author: Petr Hosek
Date: 2023-11-06T08:32:59Z
New Revision: 71a43897d42c5e27f9fde1c3451c529c44dd337b
URL:
https://github.com/llvm/llvm-project/commit/71a43897d42c5e27f9fde1c3451c529c44dd337b
DIFF:
https://github.com/llvm/llvm-project/commit/71a43897d42c5e27f9fde1c3451c529c44dd337b.diff
LOG: [C
@@ -6,15 +6,52 @@ import lit.util
import os
import subprocess
-config.clang = os.path.realpath(lit.util.which('clang-bolt.inst',
config.clang_tools_dir)).replace('\\', '/')
+clang_binary = "clang"
+perf_wrapper = ""
+if config.clang_bolt_mode.lower() == "instrument":
+cla
https://github.com/petrhosek edited
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,6 +67,67 @@ def merge_fdata(args):
return 0
+def perf(args):
+parser = argparse.ArgumentParser(
+prog="perf-helper perf", description="perf wrapper for BOLT profile
collection"
+)
+parser.add_argument(
+"--lbr", action="store_true", hel
@@ -850,23 +850,38 @@ if (CLANG_ENABLE_BOOTSTRAP)
endforeach()
endif()
-if (CLANG_BOLT_INSTRUMENT AND NOT LLVM_BUILD_INSTRUMENTED)
+set(CLANG_BOLT "INSTRUMENT" CACHE STRING "Apply BOLT optimization to Clang. \
+ May be specified as Instrument or Perf or LBR to use a particu
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/67519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
I think we should close it, the current behavior is as expected.
https://github.com/llvm/llvm-project/pull/67519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/75296
This is necessary for visualization of optimization remarks.
>From a35caa1369eabff183eb192fd4ad7566e55c8ea6 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Wed, 13 Dec 2023 08:03:37 +
Subject: [PATCH] [CMa
petrhosek wrote:
Regarding `-f[no-]exceptions` handling, see
https://discourse.llvm.org/t/rfc-multilib/67494/32.
https://github.com/llvm/llvm-project/pull/75191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/69493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
I'm trying to implement support for building libunwind, libc++abi and libc++
against LLVM libc in which case we won't be able to rely on `-nostdlib++`,
we'll need to use `-nostdlib` to avoid linking the C library. We can still use
`-nostdlib++` when LLVM libc isn't being used
petrhosek wrote:
> > I'm trying to implement support for building libunwind, libc++abi and
> > libc++ against LLVM libc in which case we won't be able to rely on
> > `-nostdlib++`, we'll need to use `-nostdlib` to avoid linking the C
> > library. We can still use `-nostdlib++` when LLVM libc i
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/75884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
Out of curiosity, what's the reason for using 3-stage (rather than 2-stage)
build?
https://github.com/llvm/llvm-project/pull/75903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/75646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
I don't think it's very clear from `-f[no-]visibility-global-new-delete` what
the option does. How about `-f[no-]visibility-attribute-global-new-delete`?
https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
cfe
petrhosek wrote:
We're still seeing the following error on our builders:
```
/b/s/w/ir/x/w/llvm_build/./bin/clang --target=aarch64-unknown-linux-gnu
--sysroot=/b/s/w/ir/x/w/cipd/linux -DHAS_ASM_LSE -DVISIBILITY_HIDDEN
--target=aarch64-unknown-linux-gnu -O2 -g -DNDEBUG -fno-lto -std=c11 -fPIC
https://github.com/petrhosek requested changes to this pull request.
I agree with @smeenai, we shouldn't be setting `CLANG_VENDOR` as a global
define.
https://github.com/llvm/llvm-project/pull/75935
___
cfe-commits mailing list
cfe-commits@lists.llvm.
petrhosek wrote:
I have discovered another issue, on Fuchsia `libclang_rt.builtins.a` now has a
reference to `getauxval` which it didn't have before. This is really
undesirable because on Fuchsia, there's no `auxv` to begin with. I believe this
is because before, the `__init_cpu_features` defi
petrhosek wrote:
Can we add back the constant to the declaration? It's been a week and the
progress on #72730 seems to have stalled while our builders are still broken.
https://github.com/llvm/llvm-project/pull/71780
___
cfe-commits mailing list
cfe-c
201 - 300 of 969 matches
Mail list logo
