[PATCH] D83999: [CMake][Fuchsia] Include additional tools in the toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff7dcded213: [CMake][Fuchsia] Include additional tools in the toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85362: [CMake] Print the autodetected host linker version

phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. There's no easy way to find out what the autodetected version is, but sometimes it may be useful to confirm

[PATCH] D85362: [CMake] Print the autodetected host linker version

This revision was automatically updated to reflect the committed changes. Closed by commit rG633e3dacf27e: [CMake] Print the autodetected host linker version (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85362/new/ https://revi

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 283398. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1adc494bce44: [CMake] Simplify CMake handling for zlib (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79219?vs=283398&id=283434#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. Sorry about the breakage, that was an unintentional change. I have updated the patch and restored the original behavior on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); Another option would be `unstable`. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFil

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. How can I test this change on pre-merge bots? I haven't seen any builds posted on this change before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201109 , @lxfind wrote: > @phosek, Under this change, now when I build LLVM (with a basic config `cmake > -G Ninja --LLVM_ENABLE_PROJECTS=clang ../llvm`), in file > `build_dir/lib/cmake/llvm/LLVMExports.cmake`, I see th

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2201994 , @kuhnel wrote: > This patch broke the Windows compilation on buildbot > and pre-merge > testing

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

phosek added a comment. Would it be possible to add a test case in `clang/test/Driver/linux-ld.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85582/new/ https://reviews.llvm.org/D85582 ___ cfe-commits

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 284106. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/test/CMakeLists.txt lld/test/lit.si

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. I have finally managed to reproduce the issue on my Windows machine, the latest version of the patch should address the issue. The previous logic would fail to find zlib altogether on Windows, which is why this issue haven't manifested before. `find_package` locates the

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 284161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/test/CMakeLists.txt lld/test/lit.si

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGccbc1485b55f: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. @kuhnel do you want to take a look or is it okay if I just submit the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG31e5f7120bdd: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2203887 , @lxfind wrote: > In D79219#2201415 , @phosek wrote: > >> This is correct. That target is provided by `find_package(ZLIB)`. In >> LLVMConfig.cmake, we invoke `find_package

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:275 + if (DriverArgs.getLastArgValue(options::OPT_fcxx_abi_EQ) == "Fuchsia") +CC1Args.push_back("-fexperimental-relative-c++-abi-vtables"); } mcgrathr wrote: > It's surprising

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79665/new/ https://reviews.llvm.org/D79665 ___

[PATCH] D79667: [Clang] Pass -z max-page-size to linker for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79667/new/ https://reviews.llvm.org/D79667 ___

[PATCH] D79665: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8fbcb1e78ad: [Clang] Pass --pack-dyn-relocs=relr to lld for Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79665/new/ https://

[PATCH] D79667: [Clang] Pass -z max-page-size to linker for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b02be0b973a: [Clang] Pass -z max-page-size to linker for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79667?vs=263004&id=263037#toc Repository: rG LLVM Github Mon

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263288. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 263284. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek added a comment. In D79219#2029520 , @JDevlieghere wrote: > I'm in favor of this change. I'm not too happy with how this works in CMake, > I've expressed similar concerns when the FORCE_ON approach was suggested in > D71306

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, don't forget to include full context with your patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79974/new/ https://reviews.llvm.org/

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

phosek added a comment. Herald added a reviewer: MaskRay. @scott.linder is actually correct, the reason we write the file is precisely as he described in https://reviews.llvm.org/D79400#2021255. When you use tools like `repo` which branchless checkout, `.git/logs/HEAD` won't exist on initial ch

[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

This revision was automatically updated to reflect the committed changes. Closed by commit rL318853: [CodeGen] Fix vtable not receiving hidden visibility when using push(visibility) (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39627?vs=123399&id=123969#toc Repositor

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek added a comment. Can you please take a look at this one as well (this one is Clang, the other one was LLVM)? Repository: rL LLVM https://reviews.llvm.org/D40257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D40513: [libcxx] Support the use of compiler-rt in lit tests

phosek created this revision. Herald added subscribers: mgorny, dberris. Don't link tests against libgcc when compiler-rt is being used. Repository: rL LLVM https://reviews.llvm.org/D40513 Files: test/CMakeLists.txt test/lit.site.cfg.in utils/libcxx/test/target_info.py Index: utils/l

[PATCH] D40329: [CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL319088: [CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40329?vs=123875&id=124441#toc Repository: rL LLVM htt

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

This revision was automatically updated to reflect the committed changes. Closed by commit rL319264: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40257?vs=123710&id=124663#toc Repository: rL LL

[PATCH] D40258: [CMake] Support side-by-side checkouts in multi-stage build

This revision was automatically updated to reflect the committed changes. Closed by commit rL319267: [CMake] Support side-by-side checkouts in multi-stage build (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40258?vs=123606&id=124665#toc Repository: rL LLVM https:/

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

phosek created this revision. Herald added subscribers: Sanitizers, llvm-commits, mgorny, kubamracek. Herald added a reviewer: EricWF. This also slightly refactors the code that's checking the directory presence which allows eliminating one unnecessary variable. Repository: rCRT Compiler Runti

[PATCH] D40280: [CMake][libcxx] Include AddLLVM needed for tests in the right context

This revision was automatically updated to reflect the committed changes. Closed by commit rL319515: Include AddLLVM needed for tests in the right context (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40280?vs=123711&id=125072#toc Repository: rL LLVM https://revie

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

This revision was automatically updated to reflect the committed changes. Closed by commit rL319523: [libcxx] Support getentropy as a source of randomness for std::random_device (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40319?vs=123842&id=125076#toc Repository:

[PATCH] D40762: [CMake] Don't use comma as an alternate separator

phosek created this revision. Herald added a subscriber: mgorny. Using comma can break in cases when we're passing flags that already use comma as a separator. Fixes PR35504. Repository: rC Clang https://reviews.llvm.org/D40762 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D40501: [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXXA libc++abi https://reviews.llvm.org/D40501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D40762: [CMake] Don't use comma as an alternate separator

This revision was automatically updated to reflect the committed changes. Closed by commit rC319720: [CMake] Don't use comma as an alternate separator (authored by phosek). Repository: rC Clang https://reviews.llvm.org/D40762 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

phosek added a comment. ping Repository: rCRT Compiler Runtime https://reviews.llvm.org/D40637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40814: [libcxx] Use the correct variable name for target triple in lit

phosek created this revision. The variable representing target triple in libcxx is named LIBCXX_TARGET_TRIPLE, not TARGET_TRIPLE. Repository: rCXX libc++ https://reviews.llvm.org/D40814 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in ==

[PATCH] D40815: [libcxxabi] Use the correct variable name for target triple in lit

phosek created this revision. The variable representing target triple in libcxxabi is named LIBCXXABI_TARGET_TRIPLE, not TARGET_TRIPLE. Repository: rCXXA libc++abi https://reviews.llvm.org/D40815 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek created this revision. The variable representing target triple in libunwind is named LIBUNWIND_TARGET_TRIPLE, not TARGET_TRIPLE. Repository: rL LLVM https://reviews.llvm.org/D40816 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in

[PATCH] D40817: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit

phosek created this revision. These are expected to be set by the shared lit scripts used from libc++. Repository: rL LLVM https://reviews.llvm.org/D40817 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in === --- test/

[PATCH] D40818: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

phosek created this revision. These are expected to be set by the shared lit scripts used from libc++. Repository: rCXXA libc++abi https://reviews.llvm.org/D40818 Files: test/lit.site.cfg.in Index: test/lit.site.cfg.in === -

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek added a comment. Actually it seems to be missing in libunwind, but I see it in libc++abi and libc++ (I missed that one). Do you want me to remove it from those two or add it to libunwind? It's a little strange to be using both `LIBUNWIND_TARGET_TRIPLE` and `TARGET_TRIPLE` in the same fil

[PATCH] D40820: [libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set

phosek created this revision. Herald added a subscriber: mgorny. This follows the setup used by other runtimes and is expected by the lit configuration. Repository: rL LLVM https://reviews.llvm.org/D40820 Files: CMakeLists.txt Index: CMakeLists.txt ==

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

phosek added a comment. After some more digging through libc++ test suite, I think I understand now why these are different variables. It may be possible to remove these and just rely on plain CMake variables but this is likely going to require some more CMake and lit surgery, so for now I'm go

[PATCH] D40817: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit

This revision was automatically updated to reflect the committed changes. Closed by commit rL319823: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40817?vs=125455&id=125590#toc Repository: rL LLV

[PATCH] D40820: [libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set

This revision was automatically updated to reflect the committed changes. Closed by commit rL319830: [libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40820?vs=125458&id=125594#toc Repository: rL LLV

[PATCH] D40818: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

This revision was automatically updated to reflect the committed changes. Closed by commit rL320445: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40818?vs=125457&id=126481#toc Repository: rL LLV

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL320446: [CMake] Support runtimes and monorepo layouts when looking for libcxx (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40637?vs=124876&id=126482#toc Repository: rL LLV

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

phosek created this revision. Herald added subscribers: Sanitizers, llvm-commits, mgorny. Herald added a reviewer: EricWF. This can be used to customize the libc++ build. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 Files: cmake/Modules/AddCompilerRT.cmake Index: cma

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

phosek added a comment. This was already on my list of build system features I'd like to implement and I'm glad someone else is already looking into it, thank you! I have two high level comments about your approach. The first one is related to the use of Clang build as the training data. I thi

[PATCH] D133160: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133160/new/ https://reviews.llvm.org/D133160 ___

[PATCH] D133170: [Driver] Unsupport --print-multiarch

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133170/new/ https://reviews.llvm.org/D133170 ___

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added a comment. In D132975#3765541 , @Amir wrote: > Hi Petr, thank you for your comments! > > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to imple

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

phosek added inline comments. Comment at: clang/CMakeLists.txt:930-937 +-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} +-DCMAKE_C_COMPILER=${CLANG_INSTRUMENTED} +-DCMAKE_CXX_COMPILER=${CLANGXX_INSTRUMENTED} +-DCMAKE_

[PATCH] D133308: [cmake] do not set execution permission to regular files

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133308/new/ https://reviews.llvm.org/D133308 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133613: [clang][cmake] Remove extra brace

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133613/new/ https://reviews.llvm.org/D133613 ___

[PATCH] D128465: Zstandard as a second compression method to LLVM

phosek added a comment. I think this patch should be broken into at least two: 1. Refactor `llvm/include/llvm/Support/Compression.h` and `llvm/lib/Support/Compression.cpp` to introduce a generic interface and use it throughout the codebase. 2. zstd support in `llvm/include/llvm/Support/Compress

[PATCH] D128841: [Driver] Always use --as-needed with libunwind

phosek created this revision. phosek added reviewers: mcgrathr, saugustine. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. With libgcc, we follow the behavior of GCC for backwards compatibility,

[PATCH] D128841: [Driver] Always use --as-needed with libunwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG2482b3a9679e: [Driver] Always use --as-needed with libunwind (authored by phosek). Herald added a subscriber: mstorsjo. Changed prior to commit: https://reviews.llvm.org/D128841?vs=441093&id=441155#toc

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

phosek added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:49-51 +namespace profile = llvm::compression::zlib; + +namespace serialize = llvm::compression::zlib; I think we will need to support dynamically selecting (de)compression algorithm

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6213dba19fc0: [CMake][Fuchsia] Use libunwind as the default unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:122 set(RUNTIMES_${target}_LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D129218: [CMake][Fuchsia] Install static libuwind

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can now be used with -static-libgcc. Repository:

[PATCH] D129218: [CMake][Fuchsia] Install static libuwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd34ce04f98c3: [CMake][Fuchsia] Install static libuwind (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

phosek added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# MaskRay wrote: > How did you derive this? > > The file seems contributed by you (I don't think facebook/zstd has such a > file

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90d22704d8: [CMake] Option to select C++ library for runtimes that use it (authored by phosek). Changed prior to commit: https://reviews.llvm.or

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8e6056e2417: [CMake][Fuchsia] Use libunwind as the default unwinder (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D127887?vs=441734&id=443449#toc Repository: rG LLVM Github

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:569-573 +if (!CoverageNamesVar) { + return MadeChange; +} else if (!NeedsRuntimeHook) { +

[PATCH] D109977: LLVM Driver Multicall tool

phosek added a comment. Herald added a subscriber: StephenFan. @beanz Let me know if you need help, I'm happy to commandeer the change if you're too busy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek created this revision. phosek added reviewers: ldionne, smeenai, beanz. Herald added subscribers: abrachet, mgorny, dberris. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. co

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek updated this revision to Diff 419831. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/ https://reviews.llvm.org/D122931 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/CMakeL

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

phosek accepted this revision. phosek added a comment. LGTM we should consider removing `llvm-config` from other subprojects as a follow up cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130735/new/ https://reviews.llvm.org/D130735 __

[PATCH] D130807: [InstrProf] Add the skipprofile attribute

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130807/new/ https://reviews.llvm.org/D130807 ___

[PATCH] D130808: [InstrProf] Add new format for -fprofile-list=

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/ProfileList.h:31-38 + enum ExclusionType { +/// Profiling is allowed. +ALLOW, +/// Profiling is skipped using the \p s

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. This is similar to @Ericson2314's change D130735 which also removes `llvm-config` from LLD. I'm fine with either of the two changes. It might be better to la

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek updated this revision to Diff 450039. phosek marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130226/new/ https://reviews.llvm.org/D130226 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek updated this revision to Diff 450055. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130226/new/ https://reviews.llvm.org/D130226 Files: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp clang-tools

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea50901aa9e5: [clang-doc] Default to Standalone executor and improve documentation (authored by phosek). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D131298: [clang-doc] Read docstrings for record members

phosek added a comment. Would it be possible to extend the existing unit tests to cover this: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/unittests/clang-doc/SerializeTest.cpp

[PATCH] D107115: [CMake][Fuchsia] Use standalone unwinder in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rather than merging the unwinder into libc++, keep it separate so it can be used s

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

phosek added a comment. We're also seeing this issue on our Mac bots, is it possible to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___ cfe-commi

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0f6cfb7b9f: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D109977: LLVM Driver Multicall tool

phosek added a comment. Another potential future improvement is error reporting for subcommands: $ ./bin/llvm clang llvm: error: no input files $ ./bin/clang clang-15: error: no input files Ideally, the multicall tool would produce the same error message. C

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3372056 , @condy wrote: > IMHO, it's the duty of build systems. CMake provides > `check_cxx_compiler_flag` to report unknown options. That's only true for build systems that perform configure time checks like CMake, b

[PATCH] D121659: [CMake][Fuchsia] Use correct architecture for iossim

phosek created this revision. phosek added reviewers: abrachet, haowei, leonardchan. Herald added subscribers: pengfei, kristof.beyls, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should be

[PATCH] D121659: [CMake][Fuchsia] Use correct architecture for iossim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6ff3f4f89e: [CMake][Fuchsia] Use correct architecture for iossim (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when developing on Windows. Repo

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

phosek updated this revision to Diff 416546. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122021/new/ https://reviews.llvm.org/D122021 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ==

[PATCH] D122022: [CMake][Fuchsia] Drop Darwin architectures

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to build runtimes for all available ones.

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9a855e7c1a: [CMake][Fuchsia] Include llvm-undname (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D122022: [CMake][Fuchsia] Drop Darwin architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa014cb865042: [CMake][Fuchsia] Drop Darwin architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D122047: [CMake][Fuchsia] Switch to lld on Apple platforms

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122109: [CMake][Clang] Skip host link version detection for lld on Darwin

phosek created this revision. phosek added reviewers: smeenai, int3, oontvoo, thakis. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When lld is being used as host link

<    2   3   4   5   6   7   8   9   10   11   >