[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

phosek added a comment. In https://reviews.llvm.org/D53787#1279899, @rsmith wrote: > Replacing the global new and delete is supposed to be a whole-program > operation (you only get one global allocator). Otherwise you couldn't > allocate memory in one DSO and deallocate it in another. (And nor

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett, leonardchan. Herald added subscribers: cfe-commits, mgorny. This reorders options between the first and second stage builds to make them better lined up. The change also re-enables tests for first stage whi

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL351145: [CMake][Fuchsia] Synchronize first and second stage builds (authored by phosek, committed by ). Herald added a reviewer: alexshap. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This made the toolchain build 50% slower. Repository: rC Clang https://reviews.llvm.org/D56825 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

This revision was automatically updated to reflect the committed changes. Closed by commit rL351415: [CMake][Fuchsia] Disable modules for the second stage build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56825

[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. -DNDEBUG is no longer needed now that we don't enable assertions, modules should improve build times for the second stage. Repository: rC Clang https://r

[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL351709: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56972?vs=182692

[PATCH] D56043: [Driver] Don't pass default value to getCompilerRTArgString

This revision was automatically updated to reflect the committed changes. Closed by commit rL351710: [Driver] Don't pass default value to getCompilerRTArgString (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56043

[PATCH] D57136: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Similarly to libc++, we want to use hermetic static libc++abi. Repository: rC Clang https://reviews.llvm.org/D57136 File

[PATCH] D57136: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352018: [CMake][Fuchsia] Enable hermetic static libc++abi for Fuchsia (authored by phosek, committed by ). Changed prior

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek created this revision. phosek added reviewers: samparker, efriedma, t.p.northover, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This reverts commit r351740: this broke on platforms where unsigned long long isn't the same as uint64_t which is what ACLE specifies fo

[PATCH] D57210: [AArch64] Make the test for rsr and rsr64 stricter

phosek created this revision. phosek added reviewers: samparker, efriedma, t.p.northover, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. ACLE specifies that return type for rsr and rsr64 is uint32_t and uint64_t respectively. D56852 change

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

phosek added a comment. This broke our kernel build which uses `PRIx64` to print the return value of `__builtin_arm_rsr64`. This is correct because according to ACLE, the return type of that builtin should be `uint64_t`. Problem is that on AArch64, `unsigned long` is equivalent to `uint64_t`, n

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

phosek added a comment. Is it OK with you to land this revert, followed by D57210 , and then reland this with the appropriate fix? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57209/new/ https://reviews.llvm.org/D57209 _

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC352153: Revert "[AArch64] Use LL for 64-bit intrinsic arguments" (authored by phosek, committed by ). Changed prior to co

[PATCH] D57210: [AArch64] Make the test for rsr and rsr64 stricter

This revision was automatically updated to reflect the committed changes. Closed by commit rL352156: [AArch64] Make the test for rsr and rsr64 stricter (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57210?vs=18344

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57303/new/ https://reviews.llvm.org/D57303 ___ cfe-commits ma

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373035 , @krytarowski wrote: > + vitalybuka > > Can we fix it for everybody? It's certainly not restricted to NetBSD. As a point of reference, we use shared runtimes on Fuchsia but we don't use rpath so this is not som

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

phosek added a comment. In D57303#1373061 , @krytarowski wrote: > How do you resolve paths? Linker cache with registry of libraries? `DT_NEEDED` aren't treated as paths, they are used as object names (keys); dynamic linker passes those to the loader ser

[PATCH] D57431: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added subscribers: cfe-commits, mgorny. jakehehrlich accepted this revision. This revision is now accepted and ready to land. In addition to libc++abi and libc++, we also want to use hermetic static libunwind on Fuchsia.

[PATCH] D57432: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Turned out this is used by Flutter which uses Fuchsia Clang toolchain. Repository: rC Clang https://reviews.llvm.org/D57432 Files: clang/cmake/caches/Fuchsia-stage2.cmake I

[PATCH] D57431: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC352584: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D57431?vs=184216&id=184220#toc Repository:

[PATCH] D57432: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard

This revision was automatically updated to reflect the committed changes. Closed by commit rC352586: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D57432?vs=184218&id=184222#toc Repository:

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

phosek updated this revision to Diff 171948. phosek marked 2 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53854 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.cpp Index: clang/test/Driver/fuchsia.cpp ===

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek updated this revision to Diff 172048. phosek retitled this revision from "[Sema] Use proper visibility for global new and delete declarations" to "[Sema] Provide -fvisibility-global-new-delete-hidden option". phosek edited the summary of this revision. phosek added a comment. Following th

[PATCH] D53970: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This allows building Linux runtimes on any platform if the correct sysroot is provided via CMake option. Repository: rC Clang https://reviews.llvm.org/D53970 Files: clang/cmake/c

[PATCH] D53970: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL345889: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53970?vs=1

[PATCH] D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. We set lld as the default linker on non-Darwin platforms, but we still need to set -fuse-ld=lld explicitly in to support cross-compiling Linux runtimes on Darwin. Repository: rC Clan

[PATCH] D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes

phosek added a comment. In https://reviews.llvm.org/D54026#1285754, @mcgrathr wrote: > So the default is not per-target? It should be. Agreed, although that'll require non-trivial driver changes. Repository: rC Clang https://reviews.llvm.org/D54026 _

[PATCH] D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL346056: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC346064: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D53854?vs=171948&id=172478#toc Reposit

[PATCH] D54064: [Driver] Always match resource dir in Fuchsia driver tests

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, cryptoad. This makes the tests stricter by not only matching the runtime file name, but the entire path into the resource directory. Repository: rC Clang https://reviews.llvm.org/D54064 Fi

[PATCH] D54064: [Driver] Always match resource dir in Fuchsia driver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL346088: [Driver] Always match resource dir in Fuchsia driver tests (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54064?

[PATCH] D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. -static relies on lld's behavior, but -Bstatic/dynamic across all linkers, -lm is only needed when statically linking libc++. Repository: rC Clang https://

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

phosek closed this revision. phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static"); ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);

[PATCH] D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL346107: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54082?vs=1725

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek added a comment. @rsmith does this look reasonable to you? Repository: rC Clang https://reviews.llvm.org/D53787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

phosek created this revision. phosek added reviewers: beanz, mcgrathr. Herald added subscribers: cfe-commits, mgorny. When second stage is being cross-compiled for a different platform we need to build enough of first stage runtimes to get a working compiler. Repository: rC Clang https://revi

[PATCH] D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett. Herald added subscribers: cfe-commits, mgorny. This is needed for run-clang-tidy.py. Repository: rC Clang https://reviews.llvm.org/D54505 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches

[PATCH] D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC346827: [CMake] Include clang-apply-replacements in Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54505?vs=173969&id=173980#toc Repository:

[PATCH] D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Not all Linux targets use the ${arch}-linux-gnu spelling, so specify the list of Linux explicitly. Repository: rC Clang https://reviews.llvm.org/D54598 F

[PATCH] D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC346997: [CMake] Explicitly list Linux targets for Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54598?vs=174273&id=174280#toc Repository: r

[PATCH] D54613: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D54461: [CMake] Support cross-compiling with multi-stage builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC347025: [CMake] Support cross-compiling with multi-stage builds (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54461?vs=1

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

This revision was automatically updated to reflect the committed changes. Closed by commit rL347026: [CMake] Support cross-compiling with Fuchsia toolchain build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5446

[PATCH] D54655: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia

phosek created this revision. phosek added reviewers: juliehockett, mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: alexshap. When cross-compiling the second stage to a different target, we need to make sure that the first-stage compiler can produce

[PATCH] D54655: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL347108: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D53787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

phosek created this revision. Herald added a subscriber: cfe-commits. Drivers include -lm because standard C++ libraries such as libc++ and libstdc++ depend on libmath and when statically linking C++ library, this dependency is needed. However, when -nostdlib++ is used, there's no reason to includ

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

phosek created this revision. Herald added subscribers: cfe-commits, jfb, srhines, emaste. Existing drivers already include -lm as C++ library dependency, but that alone is not sufficient when statically linking the C++ library. To handle that case, we introduce a new method addCXXStdlibLinkDeps w

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

phosek added a comment. In https://reviews.llvm.org/D54724#1303809, @dim wrote: > I think this is the wrong direction, placing "common" code in > `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches for > different OSes? Let different OSes handle this in their own way, may

[PATCH] D54741: [Driver] Link sanitizer runtime deps on Fuchsia when needed

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added a subscriber: cfe-commits. Even though these deps weren't needed, this makes Fuchsia driver better match other drivers, and it may be necessary when trying to use different C libraries on Fuchsia. Repository: rC

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek added a comment. @rsmith friendly ping? Repository: rC Clang https://reviews.llvm.org/D53787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54741: [Driver] Link sanitizer runtime deps on Fuchsia when needed

This revision was automatically updated to reflect the committed changes. Closed by commit rC347378: [Driver] Link sanitizer runtime deps on Fuchsia when needed (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54741?vs=174728&id=174868#toc Repository: r

[PATCH] D54784: Use --push/pop-state with XRay link deps

phosek created this revision. phosek added a reviewer: dberris. Herald added a subscriber: cfe-commits. XRay runtime link deps handling passes --no-as-needed, but it never undoes it and this flag may affect other libraries that come later on the link line. To avoid this, wrap XRay link deps in --p

[PATCH] D54805: [Driver] Use --push/pop-state with Sanitizer link deps

phosek created this revision. phosek added reviewers: vitalybuka, morehouse. Herald added subscribers: cfe-commits, jfb. Sanitizer runtime link deps handling passes --no-as-needed because of PR15823, but it never undoes it and this flag may affect other libraries that come later on the link line.

[PATCH] D54805: [Driver] Use --push/pop-state with Sanitizer link deps

This revision was automatically updated to reflect the committed changes. Closed by commit rC347413: [Driver] Use --push/pop-state with Sanitizer link deps (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D54805?vs=174952&id=174966#toc Repository: rC Cla

[PATCH] D54805: [Driver] Use --push/pop-state with Sanitizer link deps

phosek added a comment. I have already reverted the change as r347430 after seeing the failure on sanitizer bots. Repository: rC Clang https://reviews.llvm.org/D54805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D52160: [Driver] Support XRay on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC347444: [Driver] Support XRay on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: mgorny. Changed prior to commit: https://reviews.llvm.org/D52160?vs=165706&id=175009#toc Reposit

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek updated this revision to Diff 176533. phosek marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53787/new/ https://reviews.llvm.org/D53787 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.t

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

This revision was automatically updated to reflect the committed changes. Closed by commit rL348234: [Sema] Provide -fvisibility-global-new-delete-hidden option (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53787

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. This is enables the use of libc++ in contexts such as device drivers. Repository: rC Clang https://reviews.llvm.org/D55405 Files: clang/cmake/cac

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek updated this revision to Diff 188999. phosek marked an inline comment as done. Herald added a subscriber: dschuff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 Files: clang/lib/CodeGen/BackendUtil.cpp clang/te

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek added a comment. In D58374#1411376 , @chandlerc wrote: > Maybe update at least some of the tests using these targets to additionally > run with the new pass manager explicitly enabled via flag? Done Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D58862: [cmake] Create exports for umbrella library targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58862/new/ https://reviews.llvm.org/D58862 ___

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek created this revision. phosek added reviewers: smeenai, beanz, jdenny. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, jdoerfert, kadircet, christof, ioeric, ilya-biryukov, mgorny. Herald added a reviewer: EricWF. Herald added projects: clang, libc++, LLVM. This change

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek marked an inline comment as done. phosek added inline comments. Comment at: libcxx/CMakeLists.txt:421 + set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/${LLVM_DEFAULT_TARGET_TRIPLE}/) + set(LIBCXX_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIP

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek updated this revision to Diff 189552. phosek marked 2 inline comments as done. Herald added a subscriber: jdoerfert. Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 Files: clang/inclu

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189643. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/linux-per-t

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189654. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189656. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek marked an inline comment as done. phosek added inline comments. Comment at: libcxx/CMakeLists.txt:420-421 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/) -

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189795. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

This revision was automatically updated to reflect the committed changes. Closed by commit rL355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59013?vs=189795&id=189813#toc Reposi

[PATCH] D56928: Support attribute used in member funcs of class templates

phosek added a comment. Herald added a project: clang. This broke the 2-stage LTO build of LLVM, the error is: ld.lld: /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/Constants.cpp:995: static llvm::Constant *llvm::ConstantArray::getImpl(llvm::ArrayType *, ArrayRef): Assert

[PATCH] D58317: [clang] Add install targets for API headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58317/new/ https://reviews.llvm.org/D58317 ___

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek created this revision. phosek added reviewers: smeenai, beanz, jdenny. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, jdoerfert, kadircet, christof, ioeric, ilya-biryukov, mgorny. Herald added a reviewer: EricWF. Herald added projects: clang, libc++, LLVM. This change

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. This is a reland of D59013 , apart from fixing the failing test on Windows, it also changes one thing where libraries are installed in `lib/clang/` rather than `lib/` based on the discussion in "RFC: Place libs in Clang-dedicated director

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. The layout currently looks as follows: compiler-rt: headers: $prefix/lib/clang/$version/include libraries: $prefix/lib/clang/$version/$triple/lib/$name.$ext libc++, libc++abi, libunwind: headers: $prefix/include/c++/v1 libraries: $prefix/lib/clang/$t

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]" +// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|}}..{{/|}}lib{{/|}}x86_64-linux-gnu

[PATCH] D59127: [CMake] Support stripping and linking output to .build-id directory

This revision was automatically updated to reflect the committed changes. Closed by commit rC355765: [CMake] Support stripping and linking output to .build-id directory (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to com

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:15 // CHECK-PER-TARGET-RUNTIME: "--sysroot=[[SYSROOT]]" +// CHECK-PER-TARGET-RUNTIME: "-L{{.*}}{{/|}}..{{/|}}lib{{/|}}x86_64-linux-gnu" // CHECK-PER-TARGET-RUNTIME: "-L[[RES

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek updated this revision to Diff 189972. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rL355891: [Driver] Support object files in addition to static and shared libraries in… (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek marked an inline comment as done. phosek added a comment. In D59168#1424968 , @smeenai wrote: > I don't think the duplicated triple is too huge of a deal. I think the layout > where the resource directory is moved inside the triple directory is a b

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek created this revision. phosek added a reviewer: echristo. Herald added subscribers: cfe-commits, jdoerfert, fedor.sergeev, dberris, srhines. Herald added a project: clang. phosek edited the summary of this revision. When compiler-rt is selected as the runtime library for Linux use its crtb

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:447 const char *crtbegin; - if (Args.hasArg(options::OPT_static)) -crtbegin = isAndroid ? "crtbegin_static.o" : "crtbeginT.o"; - else if

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

phosek added a comment. This broke our builders (see https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8918246038501974992/+/steps/clang/0/steps/test/0/stdout) because the test uses the default linker (lld in our case) instead of `wasm-ld`, it seems that the `clang`

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:89 - const char *getDefaultLinker() const override { -return "ld.lld"; - } + const char *getDefaultLinker() co

[PATCH] D59803: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin

phosek created this revision. phosek added reviewers: juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. We want to distribute only a single archive so -lc++ does the right thing and users don't have to explici

[PATCH] D59803: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rC356970: [CMake][Fuchsia] Merge static libunwind and libc++abi into libc++ on Darwin (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59803?vs=192225&id=192229#toc

[PATCH] D59974: [clang-doc] Build as clang_tool

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59974/new/ https://reviews.llvm.org/D59974 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D59975: [fuchsia] Add clang-doc to Fuchsia distribution

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59975/new/ https://reviews.llvm.org/D59975 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

phosek added a comment. This is triggering a Clang assertion failure in Fuchsia build: clang/lib/AST/ExprConstant.cpp:5032: bool (anonymous namespace)::ExprEvaluatorBase<(anonymous namespace)::PointerExprEvaluator>::VisitMemberExpr(const clang::MemberExpr *) [Derived = (anonymous namespace):

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek abandoned this revision. phosek added a comment. Herald added a subscriber: libcxx-commits. This was already implemented in D59513 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44671/new/ https://reviews.llvm.org/D4467

<    1   2   3   4   5   6   7   8   9   10   >