[PATCH] D152418: [clang] set python3 as required build dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG96962d5512fb: [clang] set python3 as required build dependency (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/ https://revie

[PATCH] D143587: [Docs] Multilib design

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/docs/Multilib.rst:231 + +However, an exception is the normalization of -march. +-march for Arm architectures contains a list of enabled and disabled extensions Use backticks to render

[PATCH] D152473: [clang-format] Add test case for issue 63170

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 ___

[PATCH] D152473: [clang-format] Add test case for issue 63170

phosek added a comment. I understand the concerns and I apologize if my LGTM came out as disrespectful, but there has been an issue reported with the original change over two days ago, including a reproducer, and given given that this issue is

[PATCH] D152604: [Driver] Default -fsanitize-address-globals-dead-stripping to true for ELF

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152604/new/ https://reviews.llvm.org/D152604 ___

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

phosek added a comment. This is unrelated to this change but related to the issue this change is addressing. The use of regular expressions for special case list with the special handling of `*` is error-prone, I've seen many people having issues it. Furthermore, regular expression for matching

[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

phosek added a comment. In D152762#4421702 , @ellis wrote: > In D152762#4421630 , @phosek wrote: > >> This is unrelated to this change but related to the issue this change is >> addressing. The use of regular exp

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

phosek added a comment. Could we add the `perf` related logic to https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? I think that's a better place since we eventually want to replace the use of `ExternalProject_Add` with

[PATCH] D28289: Fix tests with CLANG_DEFAULT_LINKER

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, thanks for handling this! https://reviews.llvm.org/D28289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D28821: [CMake] Separate LLVM_ENABLE_LTO and LLVM_ENABLE_LLD

phosek created this revision. Herald added a subscriber: mgorny. These two are options independent: it's possible to use LLD without LTO, and it's possible to do LTO build without LLD. Repository: rL LLVM https://reviews.llvm.org/D28821 Files: CMakeLists.txt Index: CMakeLists.txt ==

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

phosek added inline comments. Comment at: cfe/trunk/CMakeLists.txt:531 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +add_dependencies(clang-bootstrap-deps lld) + elseif(LLVM_BINUTILS_INCDIR) beanz wrote: > mehdi_amini wrote: > > I come back to this a bit lat

[PATCH] D28821: [CMake] Separate LLVM_ENABLE_LTO and LLVM_ENABLE_LLD

This revision was automatically updated to reflect the committed changes. Closed by commit rL292343: [CMake] Separate LLVM_ENABLE_LTO and LLVM_ENABLE_LLD (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D28821?vs=84716&id=84798#toc Repository: rL LLVM https://reviews.

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

phosek created this revision. Herald added subscribers: rengolin, aemerson. The 32-bit architectures are no longer supported by Fuchsia. Repository: rL LLVM https://reviews.llvm.org/D28974 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp =

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL292671: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D28974?vs=85199&id=85205#toc Repository: rL LLVM https://rev

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 87339. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++ cmake

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 106098. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek updated this revision to Diff 106275. Repository: rL LLVM https://reviews.llvm.org/D32613 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ==

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL307830: [Driver] Update Fuchsia driver path handling (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32613?vs=106275&id=106276#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek created this revision. Several improvements to the Fuchsia driver: - Search for C++ library headers and libraries in directories that are part of the toolchain distribution rather than sysroot. - Use LLVM support utlities to construct paths to make sure the driver is also usable on Wind

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek added a comment. I have fixed the test to also handle Windows paths properly which was causing a build breakage. Repository: rL LLVM https://reviews.llvm.org/D35328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 106311. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

phosek updated this revision to Diff 106323. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D35328 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.c

[PATCH] D35328: Reland "[Driver] Update Fuchsia driver path handling"

This revision was automatically updated to reflect the committed changes. Closed by commit rL307856: Reland "[Driver] Update Fuchsia driver path handling" (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35328?vs=106323&id=106327#toc Repository: rL LLVM https://revie

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 106349. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D35514: [CMake] Use MATCHES for regular expression comparison.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

phosek created this revision. Fuchsia uses read-only .dynamic section. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ===

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 107178. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

phosek updated this revision to Diff 107185. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ==

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL308390: [Driver] Always use -z rodynamic for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35582?vs=107185&id=107200#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

This revision was automatically updated to reflect the committed changes. Closed by commit rL308401: [scan-build-py] Patch to fix "-analyzer-config" option (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34489?vs=103490&id=107214#toc Repository: rL LLVM https://revi

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 107236. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL308412: [CMake] Build runtimes for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32817?vs=107236&id=107240#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D35705 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library in Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL308705: [CMake] Use ABI version 2 for C++ library in Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35705?vs=107600&id=107617#toc Repository: rL LLVM https://review

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

This revision was automatically updated to reflect the committed changes. Closed by commit rL308707: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize… (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35603?vs=107234&id=107620#toc Repository: rL

[PATCH] D35747: [Driver] Fuchsia defaults to -fno-math-errno

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D35747: [Driver] Fuchsia defaults to -fno-math-errno

This revision was automatically updated to reflect the committed changes. Closed by commit rL308855: [Driver] Fuchsia defaults to -fno-math-errno (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35747?vs=107752&id=107845#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

phosek created this revision. Herald added a subscriber: dberris. This makes it possible to print the name of compiler-rt libraries by using simply clang -print-file-name=libclang_rt.${runtime}-${arch}.so same as other libraries, without having to know the details of the resource directory organiz

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() I think we also need

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D35930 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: cfe-commits. When sysroot isn't explicitly set, try to use the default location which is /../ Repository: rC Clang https://reviews.llvm.org/D42019 Files: lib/Driver/ToolChains/Fuchsia.cpp Index:

[PATCH] D39963: [RISCV] Add initial RISC-V target and driver support

phosek added a comment. Herald added a subscriber: niosHD. This has broken our toolchain build, the log is here: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8957686819564148864%2F%2B%2Fsteps%2Fcheck_clang%2F0%2Fstdout. The failure is: **

[PATCH] D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

phosek created this revision. phosek added reviewers: aarongreen, mcgrathr, jakehehrlich, kcc. Herald added a subscriber: cfe-commits. libFuzzer has been ported to Fuchsia so enable it in the driver. Repository: rC Clang https://reviews.llvm.org/D42275 Files: lib/Driver/ToolChains/Fuchsia.

[PATCH] D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC322916: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D42275 Files: lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver

phosek created this revision. phosek added reviewers: jakehehrlich, mcgrathr, aarongreen. Herald added subscribers: cfe-commits, cryptoad. This adds driver tests for the Fuzzer support. Repository: rC Clang https://reviews.llvm.org/D42283 Files: test/Driver/fuchsia.c Index: test/Driver/f

[PATCH] D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL322922: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42283?vs

[PATCH] D41623: [cmake] [libcxxabi] Fix path problems when cross compiling.

phosek added a comment. Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as well. Repository: rCXXA libc++abi https://reviews.llvm.org/D41623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152 + llvm::sys::path::append(P, normalizeTriple(Triple)); + return P.str(); +} mcgrathr wrote: > The GCC behavior (if --with-sysroot is given to configure) is > tooldir/sys-root, not

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

phosek added a comment. In https://reviews.llvm.org/D29843#674111, @mcgrathr wrote: > This is for clang, not llvm. Should it be cfe-commits instead of > llvm-commits? Right, my mistake. https://reviews.llvm.org/D29843 ___ cfe-commits mailing li

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

phosek added a comment. Did you run all tests? I'd suspect that this might break `test/OpenMP/threadprivate_codegen.cpp` which is expecting `@__dso_handle = external global i8` which will now be `hidden global`? https://reviews.llvm.org/D29843 ___

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

phosek added a comment. You can use `ninja check-clang` to run Clang tests, if those pass you can use `ninja check-all` to run all tests. Testing guide has details about testing in LLVM. https://reviews.llvm.org/D29843 ___

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 88575. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++ cmake

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 88770. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++ cmake

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

This revision was automatically updated to reflect the committed changes. Closed by commit rL295480: [CMake] Add Fuchsia toolchain CMake cache files (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D26654?vs=88770&id=88958#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

phosek added a comment. Could you also please update test/Driver/fuchsia.c and add a case for `-fsanitize=safe-stack`? Repository: rL LLVM https://reviews.llvm.org/D30238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D30238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL296082: [Driver] Enable SafeStack for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D30238?vs=89393&id=89607#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D25263: [Driver] Allow setting the default linker during build

phosek updated this revision to Diff 80934. phosek marked 4 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D25263 Files: CMakeLists.txt include/clang/Config/config.h.cmake include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

[PATCH] D25263: [Driver] Allow setting the default linker during build

phosek added inline comments. Comment at: lib/Driver/ToolChain.cpp:362 + return UseLinker; + } else if (UseLinker == "ld") { +// If we're passed the argument ld, then use whatever the default system I'm wandering whether we shouldn't use `"platform"` in

[PATCH] D25263: [Driver] Allow setting the default linker during build

phosek updated this revision to Diff 81276. phosek marked 3 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D25263 Files: CMakeLists.txt include/clang/Config/config.h.cmake include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

[PATCH] D25263: [Driver] Allow setting the default linker during build

This revision was automatically updated to reflect the committed changes. Closed by commit rL289668: [Driver] Allow setting the default linker during build (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25263?vs=81276&id=81394#toc Repository: rL LLVM https://review

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

phosek created this revision. Herald added subscribers: mgorny, rengolin, aemerson. This is still used by some users of Fuchsia toolchain. Also include llc and opt which is useful for development and testing. Repository: rL LLVM https://reviews.llvm.org/D32231 Files: cmake/caches/Fuchsia-

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

phosek updated this revision to Diff 95766. Repository: rL LLVM https://reviews.llvm.org/D32231 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++ cm

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL300917: [CMake] Enable ARM target in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32231?vs=95766&id=96048#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek created this revision. Several improvements to the Fuchsia driver: - Search for C++ library headers and libraries in directories that are part of the toolchain distribution rather than sysroot. - Use LLVM support utlities to construct paths to make sure the driver is also usable

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek updated this revision to Diff 97665. phosek added a comment. Done Repository: rL LLVM https://reviews.llvm.org/D32613 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp

[PATCH] D32815: [clang-tidy][CMake] Make clang-tidy usable as distribution component

phosek created this revision. phosek added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Use add_clang_tool rather than add_clang_executable to support clang-tidy as a distribution component. Repository: rL LLVM https://reviews.llvm.org/D32815 Files: clang-tid

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek created this revision. Herald added a subscriber: mgorny. This relies on the multi-target runtimes build support. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake ===

[PATCH] D32815: [clang-tidy][CMake] Make clang-tidy usable as distribution component

This revision was automatically updated to reflect the committed changes. Closed by commit rL302688: [clang-tidy][CMake] Make clang-tidy usable as distribution component (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32815?vs=97683&id=98479#toc Repository: rL LLVM

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is no longer supported in newer SDK versions. Repository:

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

phosek updated this revision to Diff 402650. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118075/new/ https://reviews.llvm.org/D118075 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ===

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0c5309c4a8: [Fuchsia] Remove i386 from iossim architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118161: [CMake] Set sanitizer test C++ library on Linux

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We always want to use the in-tree libc++ for tests. Repository:

[PATCH] D118161: [CMake] Set sanitizer test C++ library on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39d22d1968c: [CMake] Set sanitizer test C++ library on Linux (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a subscriber: hvdijk. phosek added a comment. In D110663#3270509 , @MaskRay wrote: > Ping @phosek I apologize about the belated response, but I wanted to test this change first given the potentially large blast radius. To clarify, when I t

[PATCH] D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are no longer supported in the recent Xcode SDK ve

[PATCH] D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fcdd685bd02: [CMake][Fuchsia] Drop 32-bit ios runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D111100: enable plugins for clang-tidy

phosek added a comment. We started seeing CMake error after this change landed: CMake Error at cmake/modules/AddLLVM.cmake:683 (add_dependencies): The dependency target "clang-tidy-headers" of target "CTTestTidyModule" does not exist. Call Stack (most recent call first): /b/s/w/ir

[PATCH] D111100: enable plugins for clang-tidy

phosek added a comment. In D00#3282760 , @vtjnash wrote: > Yes, please push a revert so I can look later. Do you have a link to the > buildbot configuration, so I can reproduce that? I did some debugging and it looks like this failure is due to `-D

[PATCH] D119144: [tests][Driver] Pass an empty sysroot for `DEFAULT_SYSROOT` builds

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119144/new/ https://reviews.llvm.org/D119144 ___

[PATCH] D120280: [CMake][Fuchsia] Disable assertions and analyzer for stage 1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeec3488cf1d8: [CMake][Fuchsia] Disable assertions and analyzer for stage 1 (authored by phosek). Herald added a project: clang. Herald added a subscr

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

phosek updated this revision to Diff 413141. phosek added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119918/new/ https://reviews.llvm.org/D119918 Files: bolt/test/Unit/lit.site.cfg.py.in bolt/test/lit.site.cfg.py.in clang-tools-extra/clangd/test/lit.site.cfg.

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

phosek updated this revision to Diff 339716. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101023/new/ https://reviews.llvm.org/D101023 Files: clang/test/Driver/linux-cross.cpp Index: clang/test/Driver/linux-cross.cpp ===

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

phosek updated this revision to Diff 339723. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101023/new/ https://reviews.llvm.org/D101023 Files: clang/test/Driver/linux-cross.cpp Index: clang/test/Driver/linux-cross.cpp =

[PATCH] D101023: [Driver] Specify -ccc-install-dir for linux-cross test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45340efb4c7d: [Driver] Specify -ccc-install-dir for linux-cross test (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. FYI I had to revert this change again because it broke ubsan build. The problem is that ubsan for Darwin is built as universal shared library and it links against libc++abi, but we currently don't support building libc++ and libc++abi as universal binaries in the runtime

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek created this revision. phosek added a reviewer: MaskRay. Herald added subscribers: jgravelle-google, sbc100, dschuff. phosek requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Different platforms use different rules for multiarc

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. I don't see any checks to ensure that the selected ABI is compatible with the specified target, is that something you plan on implementing in a follow up change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ htt

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. I don't think this is sufficient. First, we want to be explicit and always list individual files to install, we don't use patterns. Second, since libscanbuild is a library, it shouldn't be installed inside the `bin` directory. I think those should go either into `lib` or

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2714206 , @MaskRay wrote: >> Different platforms use different rules for multiarch triples so it's >> difficult to provide a single method for all platforms. > > Guess this is a Linux/Hurd/Fuchsia specific thing. I don'

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2713530 , @aabbaabb wrote: > The python script assumes relative directory while finding things. For > example, for resources folder, it uses os.path.join(this_dir, 'resources') in > report.py, which means resource need

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4537c3f51bc: [Driver] Push multiarch path setup to individual drivers (authored by phosek). Herald added subscribers: libcxx-commits, s.egerton, sim

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 340743. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/

[PATCH] D101348: [Driver] Fix tests failing in per-target multiarch layout

phosek created this revision. phosek added reviewers: haowei, leonardchan. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These failures were revealed by b4537c3f51bc6c011ddd9c10b80043ac4ce16a01

[PATCH] D101348: [Driver] Fix tests failing in per-target multiarch layout

This revision was automatically updated to reflect the committed changes. Closed by commit rG887bdff8bae7: [Driver] Fix tests failing in per-target multiarch layout (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101348/new/ http

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2720761 , @bjope wrote: > Got some problems with my builds after this commit. > > My cmake commands looks like this (well, this is after having tried to fix > the problem by replacing `x86_64-unknown-linux-gnu` by `x86_

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek created this revision. phosek added reviewers: rnk, MaskRay. Herald added a subscriber: dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful in runtimes build for example which currently try to guess the correc

<    10   11   12   13   14   15   16   17   >