[PATCH] D70575: [Clang] Define Fuchsia C++ABI

phosek added a comment. In D70575#1756072 , @leonardchan wrote: > Could you add a test to show that with a fuchsia target we end up returning > `this` from constructors + destructors and ensure that this ABI is used? Done Repository: rG LLVM Github

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

phosek updated this revision to Diff 230827. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70575/new/ https://reviews.llvm.org/D70575 Files: clang/include/clang/Basic/TargetCXXABI.h clang/lib/AST/ASTContext.cpp clang/lib/Basic/Targets/OSTarget

[PATCH] D70747: [Fuchsia] Don't fail for unknown architectures

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, s.egerton, simoncook. Herald added a project: clang. When selecting the set of default sanitizers, don't fail for unknown architectures. This may be the case e.g. with x86_64-unknown-fuchsia

[PATCH] D70693: [scan-build-py] Set of small fixes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/scan-build-py/libscanbuild/clang.py:47 cmd.insert(1, '-###') +cmd.append('-fno-color-diagnostics') Alternative would

[PATCH] D70747: [Fuchsia] Don't fail for unknown architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7aeca45b23c: [Fuchsia] Don't fail for unknown architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70747/new/ https://reviews.

[PATCH] D70868: [libunwind] Emit dependent libraries only when detected by CMake

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, thanks! Would it be possible to make the same change to libc++abi and libc++ as well (since they also use dependent library feature)? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek added a comment. Sorry about the late response, I was mostly out last week. This recently came up again so I'd like to look into it but I'll have to rethink the change and come up with a better approach. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53250

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3f9b9c12b0: [Clang] Define Fuchsia C++ABI (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D70575?vs=230827&id=232023#toc Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71419/new/ https://reviews.llvm.org/D71419 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71507: [perf-training] Make training data location configurable

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71507/new/ https://reviews.llvm.org/D71507 ___

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

phosek added a comment. I'm not sure if the detection is working correctly, this is failing on our macOS toolchain bots: FAIL: Clang :: Driver/darwin-ld-platform-version-ios.c (5284 of 16450) TEST 'Clang :: Driver/darwin-ld-platform-version-ios.c' FAILED ***

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

phosek added a comment. This seems to be failing on aarch64-linux-gnu: TEST 'Clang :: CodeGenCXX/mangle-ptr-size-address-space.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/clang -cc1 -in

[PATCH] D53327: [Hexagon] Use -fuse-ld update checks.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53327/new/ https://reviews.llvm.org/D53327 ___ cfe-commits ma

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. We're not using this module in Fuchsia at the moment, so I'd be fine not having an alias at all, if we start using it again in the future we'll use the new name. Repository: rG LLVM Github

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rG7003f64c1eb2: [clang-doc] Improving Markdown Output (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D72954?vs=248338&id=248875#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75890: [libunwind] Add flag to disable logging

phosek added a comment. Herald added a reviewer: mclow.lists. I'd prefer to make this the behavior when just `NDEBUG` is set, I think it's rather unexpected to still get debug messages even after you set `NDEBUG`, but since that would be a breaking change, it deserves an email to llvm-dev to en

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you might want to wait a few more hours for other reviewers to see if anyone has objections. Comment at: libunwind/src/config.h:125 do {

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). Yes, bu

[PATCH] D76189: [Fuchsia] Use -ffile-prefix-map

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. This makes toolchain independent of the path it was built in by rewriting all absolute paths embedded in sources and debug info into relative o

[PATCH] D76204: [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This tool is used for generating and manipulating GSYM files. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76204 Files: clang/c

[PATCH] D76204: [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGc682a605eb47: [Fuchsia] Include llvm-gsymutil tool in the Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76204/new/ h

[PATCH] D76189: [Fuchsia] Use -ffile-prefix-map

This revision was automatically updated to reflect the committed changes. Closed by commit rG98223f7931f2: [Fuchsia] Use -ffile-prefix-map (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D76189?vs=250401&id=251491#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rGdeae8ee69167: [clang-doc] Improving Markdown Output (authored by phosek). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

phosek created this revision. phosek added reviewers: leonardchan, mcgrathr. Herald added subscribers: cfe-commits, mstorsjo, jfb, mgorny. Herald added a project: clang. This change adds the necessary flags for building the full Fuchsia toolchain on Windows. Repository: rG LLVM Github Monorepo

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

phosek updated this revision to Diff 241822. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73810/new/ https://reviews.llvm.org/D73810 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake =

[PATCH] D65839: [Driver] Add verbatim dry run option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. I'm fine with `-###-verbatim`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65839/new/ https://reviews.llvm.org/D65839 _

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fbaf3a7c239: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rGdac21fdd5923: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/

[PATCH] D72954: [clang-doc] Improving Markdown Output

phosek added a comment. This is failing on Windows: ../../clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp(77): error: Expected: Expected Which is: "# namespace Namespace\n\n\n\n## Namespaces\n\n* [ChildNamespace](../ChildNamespace/index.md)\n\n\n## Records\n\n* [Child

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek updated this revision to Diff 238689. phosek marked an inline comment as done. phosek added a comment. Addressed the comment and also added a test for Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D

[PATCH] D69740: [profile] Support counter relocation at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db13af7e5c: [profile] Support counter relocation at runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D69740?vs=238689&id=238901#toc Repository: rG LLVM Github Monorep

[PATCH] D72982: [Clang] Un-break scan-build after integrated-cc1 change

phosek added a comment. We're seeing `Driver/cc-print-options.c` test failures after this change: TEST 'Clang :: Driver/cc-print-options.c' FAILED Script: -- : 'RUN: at line 1'; env CC_PRINT_OPTIONS=1 CC_PRINT_OPTIONS_FILE=/b/s/w/ir/k/rec

[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73397/new/ https://reviews.llvm.org/D73397 ___

[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4261e112129: [Clang] Enable -fsanitize=leak on Fuchsia targets (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM % nit Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:586 ArgStringList &CmdArgs) { + if (Triple.isOSFuchsia()) { +// F

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdf31ae32dd2: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek updated this revision to Diff 139163. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index: libcxx/CMakeLists.txt === --- libcxx/CMakeLists.

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Building libc++ with static ABI library on Darwin is not currently supported. Repository: rC Clang https://reviews.llvm.org/D44724 Fil

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

phosek updated this revision to Diff 139249. phosek retitled this revision from "[Fuchsia] Avoid using static ABI library with libc++ on Darwin" to "[Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin". phosek edited the summary of this revision. phosek added a comment. Done, they'r

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

phosek updated this revision to Diff 139311. https://reviews.llvm.org/D44724 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake === --- clang/cmake/caches/Fuchsia-stage2.cmake +++ clang/

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL328114: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D44743: [clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, fedor.sergeev, mgorny, srhines. Using file(COPY FILE...) has several downsides. Since the file command is only executed at configuration time, any changes to headers made after the

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek added a comment. This changes has already revealed some missing libc++ dependencies in sanitizers which were masked by the use of `file(COPY FILE...)`. Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list c

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

phosek added inline comments. Comment at: clang/CMakeLists.txt:215 +set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL + "Enable the experimental new pass manager by default.") chandlerc wrote: > Does it make sense to put the word `DEFAULT` into the var

[PATCH] D44947: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers

phosek created this revision. phosek added reviewers: mcgrathr, aarongreen. Herald added a subscriber: cfe-commits. This is needed in addition to fuzzer in order to use libFuzzer. Repository: rC Clang https://reviews.llvm.org/D44947 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp Index: c

[PATCH] D44947: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rC328672: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44947?vs=139978&id=140007#toc R

[PATCH] D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests

phosek created this revision. phosek added reviewers: rnk, pirama, bkramer, mgorny. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D30700 added the -f[no-]rtlib-add-rpath flag, but that flag was never wired up in the driver and tests were updated to check whether it actually doe

[PATCH] D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests

phosek updated this revision to Diff 140668. phosek added a comment. Thanks for the suggestion, I don't think we even need to rename the function since this already matches the pattern other functions use. Repository: rC Clang https://reviews.llvm.org/D45145 Files: clang/lib/Driver/ToolCh

[PATCH] D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL329032: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45145?

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek added a comment. ping Repository: rCXX libc++ https://reviews.llvm.org/D44773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45269: [CMake] Support for monorepo layout

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, mgorny. Support finding libcxx and libunwind sources in monorepo style layout. Repository: rCXXA libc++abi https://reviews.llvm.org/D45269 Files: libcxxabi/CMakeLists.txt

[PATCH] D45270: [CMake] Support for monorepo layout

phosek created this revision. phosek added reviewers: EricWF, beanz, jroelofs. Herald added subscribers: cfe-commits, christof, mgorny. Support finding libcxx sources in monorepo style layout. Repository: rUNW libunwind https://reviews.llvm.org/D45270 Files: libunwind/CMakeLists.txt Inde

[PATCH] D45269: [CMake] Support for monorepo layout

This revision was automatically updated to reflect the committed changes. Closed by commit rL329208: [CMake] Support for monorepo layout (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45269?vs=140989&id=140992#toc

[PATCH] D45270: [CMake] Support for monorepo layout

This revision was automatically updated to reflect the committed changes. Closed by commit rL329212: [CMake] Support for monorepo layout (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45270?vs=140990&id=140998#toc

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

phosek marked an inline comment as done. phosek added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D44330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek added a comment. I don't like this but I'm not sure if there's a better way to do this, do you have any ideas? Repository: rCXX libc++ https://reviews.llvm.org/D45304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek created this revision. phosek added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof, mgorny. phosek added a comment. I don't like this but I'm not sure if there's a better way to do this, do you have any ideas? This avoids the need for a custom generated config file.

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC329366: CMake option to allow enabling experimental new pass manager by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44330?vs=137844&id=141249#toc Rep

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141442. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index: libcxx/lib/CM

[PATCH] D45422: [Driver] Allow drivers to add multiple libc++ include paths

phosek created this revision. phosek added reviewers: rsmith, dlj, rnk. Herald added subscribers: cfe-commits, sdardis, dschuff. Herald added a reviewer: EricWF. This allows toolchain drivers to add multiple libc++ include paths akin to libstdc++. This is useful in multiarch setup when some header

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

phosek updated this revision to Diff 141580. Repository: rCXX libc++ https://reviews.llvm.org/D44773 Files: libcxx/NOTES.TXT libcxx/cmake/Modules/HandleLibCXXABI.cmake libcxx/include/CMakeLists.txt libcxx/lib/CMakeLists.txt Index: libcxx/lib/CMakeLists.txt

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44773: [CMake] Use custom command and target to install libc++ headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX329544: [CMake] Use custom command and target to install libc++ headers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44773?vs=141580&id=141583#toc Repositor

[PATCH] D45422: [Driver] Allow drivers to add multiple libc++ include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rL329748: [Driver] Allow drivers to add multiple libc++ include paths (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45422

[PATCH] D45499: [Driver] Handle the default case

phosek created this revision. phosek added reviewers: rnk, rsmith, dlj. Herald added a subscriber: cfe-commits. This was omitted in https://reviews.llvm.org/D45422 resulting in a warning. Repository: rC Clang https://reviews.llvm.org/D45499 Files: clang/lib/Driver/ToolChains/NaCl.cpp Ind

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek updated this revision to Diff 141933. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D45304 Files: libcxx/include/__config Index: libcxx/include/__config === --- libcxx/include

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek updated this revision to Diff 141935. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D45304 Files: libcxx/include/__config Index: libcxx/include/__config === --- libcxx/include

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL329770: [libcxx] Set ABI version 2 as default for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45304?vs=141935

[PATCH] D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. This is now set automatically in libc++ config header. Repository: rC Clang https://reviews.llvm.org/D45511 Files: cla

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This is neeeded since the CMake value is used for the SOVERSION. Repository: rCXX libc++ https://reviews.llvm.org/D45529 Files: libcxx/CMakeLists.txt Index: libcx

[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

phosek created this revision. Herald added a subscriber: mgorny. The support for relax relocations is dependent on the linker and different toolchains within the same compiler can be using different linkers some of which may or may not support relax relocations. Give toolchains the option

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D39821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek created this revision. Herald added subscribers: mgorny, dberris. Herald added a reviewer: EricWF. Fuchsia already defaults to libc++ and compiler-rt, but we want to use these as default runtimes even on the host platform. Repository: rL LLVM https://reviews.llvm.org/D39930 Files: c

[PATCH] D40194: [libcxxabi][CMake] Provide option to disable installing of the library

phosek created this revision. Herald added a subscriber: mgorny. This is useful in cases where we only build static library and libc++abi.a is combined with libc++.a into a single archive in which case we don't want to have libc++abi.a installed separately. The same option is already provided by l

[PATCH] D40195: [libunwind][CMake] Provide option to disable instalation of the library

phosek created this revision. Herald added a subscriber: mgorny. This is useful in cases where we only build static library and libunwind.a is combined with libc++abi.a into a single archive in which case we don't want to have libunwind.a installed separately. The same option is already provided b

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek updated this revision to Diff 123432. Repository: rL LLVM https://reviews.llvm.org/D39930 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++ c

[PATCH] D40194: [libcxxabi][CMake] Provide option to disable installing of the library

This revision was automatically updated to reflect the committed changes. Closed by commit rL318568: [libcxxabi][CMake] Provide option to disable installing of the library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40194?vs=123412&id=123439#toc Repository: rL LL

[PATCH] D40195: [libunwind][CMake] Provide option to disable instalation of the library

This revision was automatically updated to reflect the committed changes. Closed by commit rL318569: [libunwind][CMake] Provide option to disable instalation of the library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40195?vs=123413&id=123440#toc Repository: rL L

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek added a comment. This is something I was already thinking about. Ideally, in our toolchain, we would build runtimes for all host and target platforms we support, i.e. on every host (Linux, macOS and Windows) we would build runtimes for i386, x86_64 and aarch64 Linux, x86_64 macOS, x86_64

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek created this revision. Herald added a subscriber: mgorny. Escaping ; in list arguments passed to ExternalProject_Add doesn't seem to be working in newer versions of CMake (see https://public.kitware.com/Bug/view.php?id=16137 for more details). Use a custom LIST_SEPARATOR instead which is th

[PATCH] D40258: [CMake] Support side-by-side checkouts in multi-stage build

phosek created this revision. Herald added a subscriber: mgorny. Passthrough LLVM_ENABLE_{PROJECTS,RUNTIMES} to followup stages to support the side-by-side checkouts (aka monorepo layout). Repository: rL LLVM https://reviews.llvm.org/D40258 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek updated this revision to Diff 123640. Repository: rL LLVM https://reviews.llvm.org/D40257 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -653,7 +653,7 @@ foreach(variableName

[PATCH] D40257: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add

phosek updated this revision to Diff 123710. Repository: rL LLVM https://reviews.llvm.org/D40257 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -653,7 +653,7 @@ foreach(variableName

[PATCH] D40280: [CMake][libcxx] Include AddLLVM needed for tests in the right context

phosek created this revision. Herald added a subscriber: mgorny. AddLLVM is needed for several functions that are used in tests and as such needs to be included from the right context which previously wasn't the case. Repository: rL LLVM https://reviews.llvm.org/D40280 Files: CMakeLists.tx

[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

phosek updated this revision to Diff 123838. phosek added a comment. Added a test case. Repository: rL LLVM https://reviews.llvm.org/D39831 Files: cmake/caches/Fuchsia-stage2.cmake include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Clang.cpp lib/Driver/

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

phosek created this revision. Use this source use on Fuchsia where this is the officially way to obtain randomness. This could be also used on other platforms that already support getentropy such as *BSD or Linux. Repository: rL LLVM https://reviews.llvm.org/D40319 Files: include/__config

[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL318816: [Driver] Make the use of relax relocations a per target option (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39831?vs=123838&id=123870#toc Repository: rL LLVM http

[PATCH] D40329: [CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. It's used to determine whether terminal supports colors, but within LLVM it's only used in handful of places and in Clang it's only used in AST dumper, otherwise Clang relies on the -fcolor-diagnostics flag which we pass explicitly f

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

phosek created this revision. phosek added reviewers: abrachet, mcgrathr. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. phosek request

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added inline comments. Comment at: clang/lib/Driver/MultilibBuilder.cpp:88 +static Multilib::flags_list getPrintOptions(const Multilib::flags_list &Flags) { + // Derive print options from flags. Would it be possible to move this method directly into `M

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

phosek updated this revision to Diff 507260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146608/new/ https://reviews.llvm.org/D146608 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake ===

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/D146155 ___

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77044a47b4de: [CMake] Build runtimes for riscv64-unknown-fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:3 +option(FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS "Use multiple distributions") +option(FUCHSIA_ENABLE_LLDB "Enable LLDB") Could we use multiple distributions unconditionally? Reposi

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D146665: [Fuchsia] Add FUCHSIA_USE_MULTIPLE_DISTRIBUTIONS.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146665/new/ https://reviews.llvm.org/D146665 ___

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145010/new/ https://reviews.llvm.org/D145010 ___

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. A more generic version might be to have a list of variables to (not) passthrough. First option is to remove `{C,CXX}_COMPILER_LAUNCHER` from `_BOOTSTRAP_DEFAULT_PASSTHROUGH` and then include it as needed by setting something like `CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH=C_CO

[PATCH] D144603: Add option to disable compiler launcher on external projects

phosek added a comment. @beanz @smeenai do you have any preferences/other ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144603/new/ https://reviews.llvm.org/D144603 ___ cfe-commits mailing list cf

<    8   9   10   11   12   13   14   15   16   17   >