[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL326151: [Driver] Add SafeStack to a map of incompatible sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43606?vs=136002&id=136004#toc Repository: rL

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, christof, mgorny. When the generated __config file is being used, it is currently only copied during installation process. However, that means that the file that gets copied int

[PATCH] D33263: [scan-build] Patch to scan-build tool to support "--target=" flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL304025: [scan-build] Patch to scan-build tool to support "--target=" flag (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D33263?vs=99219&id=100450#toc Repository: rL LLVM ht

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 100482. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- cmake/caches/Fuch

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

phosek updated this revision to Diff 102271. Repository: rL LLVM https://reviews.llvm.org/D32613 Files: lib/Driver/ToolChains/Fuchsia.cpp lib/Driver/ToolChains/Fuchsia.h test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ==

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek created this revision. When -no-canonical-prefixes option is used and argv0 contains only a program name, we need to do a PATH lookup to get an executable path, otherwise the return value won't be a valid path and any subsequent uses of it (e.g. invoking -cc1) will fail with an error. Rep

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek added inline comments. Comment at: tools/driver/driver.cpp:58 +SmallString<128> ExecutablePath(Argv0); +// Do a PATH lookup, if there are no directory components. +if (llvm::sys::path::filename(ExecutablePath) == ExecutablePath) hans wrote: > W

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

phosek updated this revision to Diff 102881. phosek marked an inline comment as done. phosek edited the summary of this revision. Repository: rL LLVM https://reviews.llvm.org/D34290 Files: tools/driver/driver.cpp Index: tools/driver/driver.cpp ==

[PATCH] D34290: [Driver] Do a PATH lookup when using only program name with -no-canonical-prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL305600: [Driver] Do a PATH lookup if needed when using -no-canonical-prefixes (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34290?vs=102881&id=102894#toc Repository: rL LLV

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

phosek added a comment. In https://reviews.llvm.org/D41103#955540, @vitalybuka wrote: > Can you please add some details about why someone wants to customize LIBXX > here? > Or even better attach a patch which uses this. I plan on using it from https://reviews.llvm.org/D37631 where I currently

[PATCH] D40513: [libcxx] Support the use of compiler-rt in lit tests

phosek added a comment. ping? Repository: rL LLVM https://reviews.llvm.org/D40513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

phosek added a comment. FWIW we've already rolled Clang that contains `-Wtautological-constant-compare` to our codebase and we had to set `-Wno-tautological-constant-compare` globally because we were getting bogus warnings in many places, similarly to https://reviews.llvm.org/D41368. If that wa

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

phosek added a comment. ping? Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL321299: [CMake] Allow passing extra CMake arguments to custom libc++ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41103?vs=126488&id=127924#toc Repository:

[PATCH] D41413: [scudo] Add -fsanitize=scudo option to Fuchsia.

This revision was automatically updated to reflect the committed changes. Closed by commit rC321314: [scudo] Add -fsanitize=scudo option to Fuchsia (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41413 Files: lib/Dr

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

This revision was automatically updated to reflect the committed changes. Closed by commit rL321316: [CMake][Fuchsia] Enable assertions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41471?vs=127801&id=127943#toc Repository: rL LLVM https://reviews.l

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

phosek added a comment. Would it be possible to split the `CMAKE_REQUIRED_FLAGS` fix into a separate change since it's unrelated to the `CMAKE_FIND_ROOT_PATH` bit? Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing l

[PATCH] D41660: [cmake] Add new linux toolchain file

phosek added a comment. @hintonda I think this should be a platform file in https://github.com/llvm-mirror/llvm/tree/master/cmake/platforms rather than Clang cache file. Platform files are concerned with the host platform (including cross-compilation), while cache files are related to the dis

[PATCH] D41102: Setup clang-doc frontend framework

phosek added a comment. In https://reviews.llvm.org/D41102#955200, @JDevlieghere wrote: > I don't know what basis is used to differentiate between the two, but should > this be part of clang tools or clang-tools-extra? AFAIK there's a general agreement that clang-tools-extra should be eventual

[PATCH] D41706: [CMake] Install resource files into a share/ directory

phosek created this revision. phosek added reviewers: beanz, smeenai, vitalybuka, fjricci. Herald added a subscriber: cfe-commits. This is related to moving the sanitizer blacklists to share/ subdirectory. Repository: rC Clang https://reviews.llvm.org/D41706 Files: lib/Driver/SanitizerArgs

[PATCH] D41706: [Driver] Update default sanitizer blacklist location

phosek updated this revision to Diff 128543. Repository: rC Clang https://reviews.llvm.org/D41706 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir/asan_blacklist.txt test/Driver/Inputs/resource_dir/hwasan_blacklist.txt test/Driver/Inputs/resource_dir/share/asan_black

[PATCH] D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows exporting the runtimes targets using the CMake export. Repository: rCXXA libc++abi https://reviews.llvm.org/D41754 Files: src/CMakeLists.txt Index: src/CMakeLists.txt

[PATCH] D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows exporting the runtimes targets using the CMake export. Repository: rCXX libc++ https://reviews.llvm.org/D41755 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt

[PATCH] D40513: [libcxx] Support the use of compiler-rt in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322044: [libcxx] Support the use of compiler-rt in lit tests (authored by phosek, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D40513 Files: test/CMakeLists.txt test/lit.site

[PATCH] D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek updated this revision to Diff 129138. Repository: rCXX libc++ https://reviews.llvm.org/D41755 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt === --- lib/CMakeLists.txt +++ lib/CMakeLists.txt @@ -356,10 +356,11 @@

[PATCH] D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek updated this revision to Diff 129140. Repository: rCXXA libc++abi https://reviews.llvm.org/D41754 Files: src/CMakeLists.txt Index: src/CMakeLists.txt === --- src/CMakeLists.txt +++ src/CMakeLists.txt @@ -180,10 +180,11

[PATCH] D41706: [Driver] Update default sanitizer blacklist location

This revision was automatically updated to reflect the committed changes. Closed by commit rC322154: [Driver] Update default sanitizer blacklist location (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D41706 Files: lib/Driver/SanitizerArgs.cpp test/Driv

[PATCH] D41918: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository

This revision was automatically updated to reflect the committed changes. Closed by commit rL38: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D41929: [Fuchsia] Disable LLDB from the toolchain distribution

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. This is currently not being used so disable it to reduce toolchain size. Repository: rC Clang https://reviews.llvm.org/D41929 Files: cmake/caches/Fuchsia-stage2.cmak

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on Linux

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. llvm-objcopy already supports all the necessary functionality for ELF. Repository: rC Clang https://reviews.llvm.org/D41930 Files: cmake/caches/Fuchsia-stage2.cmake

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts

phosek added a comment. In https://reviews.llvm.org/D41930#972923, @emaste wrote: > The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will > also use llvm-objcopy. That's a good point, updated. Repository: rC Clang https://reviews.llvm.org/D41930

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rC322252: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D41930 Files: cmake/caches/Fuchsia-stage2.cmake

[PATCH] D41929: [Fuchsia] Disable LLDB from the toolchain distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rC322253: [Fuchsia] Remove LLDB from the toolchain distribution (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41929?vs=129377&id=129393#toc Repository: rC Clan

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added a comment. Ping? Can we land this as a temporary solution until the config generator logic is rewritten? This is currently breaking the libFuzzer build for us. Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added a subscriber: cfe-commits. These paths aren't used and don't make sense on Fuchsia. Repository: rC Clang https://reviews.llvm.org/D43992 Files: clang/lib/Frontend/InitHeaderSearch.cpp Index: clang/

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL326542: [Frontend] Avoid including default system header paths on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, kcc, vitalybuka. Herald added subscribers: cfe-commits, cryptoad. phosek added a dependency: D44064: [Driver] Automatically disable incompatible default sanitizers. This is already used throughout the entire system, so make it a defa

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

phosek created this revision. phosek added reviewers: kcc, vitalybuka, mcgrathr. Herald added subscribers: cfe-commits, cryptoad. phosek added a dependent revision: D44065: [Driver] Enable SafeStack by default on Fuchsia. When a sanitizer incompatible with one of the default sanitizers is explici

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

phosek added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:369 // Check that LTO is enabled if we need it. if ((Kinds & NeedsLTO) && !D.isUsingLTO()) { D.Diag(diag::err_drv_argument_only_allowed_with) vitalybuka wrote: > Is this chang

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added a comment. Ping again? Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rC326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44064?vs=136893&id=137301#toc Repository:

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

phosek updated this revision to Diff 137312. Repository: rC Clang https://reviews.llvm.org/D44065 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Fuchsia.h clang/test/Driver/fuchsia.c Index: clang/test/Driver/fuchsia.c

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC326867: [Driver] Enable SafeStack by default on Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44065?vs=137312&id=137314#toc Repository: rC Clang htt

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

phosek created this revision. phosek added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. This CMake flag allows setting the default value for the -f[no]-experimental-new-pass-manager flag. Repository: rC Clang https://reviews.llvm.org/D44330 Files: clang/CMakeLists

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added inline comments. Comment at: libcxx/include/CMakeLists.txt:19 +DEPENDS ${LIBCXX_BINARY_DIR}/__generated_config) + set(generated_config_deps generate_config_header) +endif() compnerd wrote: > Where is `generated_config_deps` used? Line 69 Repos

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

This revision was automatically updated to reflect the committed changes. Closed by commit rL327194: [CMake] Copy the generated __config header into build directory (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44371: [Driver] Update the comment about incompatible sanitizers

phosek created this revision. phosek added a reviewer: thakis. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44371 Files: clang/lib/Driver/SanitizerArgs.cpp Index: clang/lib/Driver/SanitizerArgs.cpp ==

[PATCH] D44371: [Driver] Update the comment about incompatible sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL327249: [Driver] Update the comment about incompatible sanitizers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44371?v

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. We use DWARF 5 on Fuchsia, make it the toolchain default. Repository: rC Clang https://reviews.llvm.org/D44605 Files: clang/lib/Driver/ToolChains/Fuchsia.h clang

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek updated this revision to Diff 138882. phosek marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D39930 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake =

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rC327860: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D39930?vs=138882&id=138936#toc

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek created this revision. phosek added a reviewer: eugenis. Herald added subscribers: cfe-commits, srhines. This is needed to avoid the test failure in case when compiler-rt is set as the default runtime library for Clang. Repository: rC Clang https://reviews.llvm.org/D44655 Files: cla

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. That link seems to be pointing to this change? Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. I was actually thinking about doing the same now, more specifically using `-rtlib=platform` which is already used elsewhere in this test. Do you prefer one or the other? Repository: rC Clang https://reviews.llvm.org/D44655 _

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek updated this revision to Diff 139062. phosek added a comment. SGTM, I've made the test even more explicit. https://reviews.llvm.org/D44655 Files: clang/test/Driver/sanitizer-ld.c Index: clang/test/Driver/sanitizer-ld.c =

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC327932: Allow builtins for Cross-DSO CFI on Android (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44655?vs=139062&id=139063#toc Repository: rC Clang https:/

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, compnerd, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This seems to be working without any problems. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index:

[PATCH] D47668: [Driver][Fuchsia] Pass LTO flags to linker

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett. Herald added subscribers: cfe-commits, inglorion. Even though we use lld by default for Fuchsia, we use Gold plugin arguments like all other drivers as lld supports Gold plugin options. Repository: rC Clang https://

[PATCH] D47669: [cmake] Support LLD for CLANG_ORDER_FILE

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D47669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D47668: [Driver][Fuchsia] Pass LTO flags to linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL333979: [Driver][Fuchsia] Pass LTO flags to linker (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47668?vs=149590&id=149

[PATCH] D47758: [Fuchsia] Include install-distribution-stripped in bootstrap targets

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett. Herald added subscribers: cfe-commits, mgorny. This enables the use of install-distribution-stripped target in the 2-stage builds. Repository: rC Clang https://reviews.llvm.org/D47758 Files: clang/cmake/caches/Fu

[PATCH] D47758: [Fuchsia] Include install-distribution-stripped in bootstrap targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL334063: [Fuchsia] Include install-distribution-stripped in bootstrap targets (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek updated this revision to Diff 150838. phosek marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D47355 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt === --- clang/CMakeLists.txt ++

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

This revision was automatically updated to reflect the committed changes. Closed by commit rL334437: [CMake] Allow specifying extra dependencies of bootstrap stage (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47

[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

phosek updated this revision to Diff 150841. Repository: rC Clang https://reviews.llvm.org/D47356 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake === --- clang/cmake/caches/Fuchsia.cmake +++ cla

[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC334445: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D47356?vs=150841&id=150859#toc Repository:

[PATCH] D46552: [AArch64] Support reserving x20 register

This revision was automatically updated to reflect the committed changes. Closed by commit rC334531: [AArch64] Support reserving x20 register (authored by phosek, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D46552?vs=150601&id=151006

[PATCH] D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, chrib, mgorny. Herald added a reviewer: EricWF. This is needed for building Fuchsia drivers. Repository: rC Clang https://reviews.llvm.org/D48208 Files: clang/cmake/caches/Fuchsia-stage2

[PATCH] D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind

phosek updated this revision to Diff 152578. Repository: rC Clang https://reviews.llvm.org/D48208 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.cpp Index: clang/test/Driver/fuchsia.cpp ==

[PATCH] D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind

This revision was automatically updated to reflect the committed changes. Closed by commit rL335410: [Fuchsia] Enable static libc++, libc++abi, libunwind (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48208?vs=152

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:44 + assert(!Err); + std::string Expected = "# namespace Namespace\n" + "\n" Can we use the C++11 raw string literals here and below to t

[PATCH] D53248: [Driver] Support direct split DWARF emission for Fuchsia

phosek created this revision. phosek added reviewers: pcc, jakehehrlich, echristo. Herald added subscribers: cfe-commits, JDevlieghere, aprantl, mgorny. This enables the driver support for direct split DWARF emission for Fuchsia in addition to Linux. Repository: rC Clang https://reviews.llvm.

[PATCH] D53248: [Driver] Support direct split DWARF emission for Fuchsia

phosek added a comment. I'm fine moving the test to `test/Driver/split-debug.c` if you prefer to have all target tests in a single file. Repository: rC Clang https://reviews.llvm.org/D53248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

phosek created this revision. phosek added reviewers: sidneym, rsmith. Herald added a subscriber: cfe-commits. Hexagon relies on hexagon-link so invoke Clang to -fuse-ld=ld to always use the default linker, otherwise tests break when the Clang default linker is set to anything other than default.

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

phosek added a comment. This was introduced in https://reviews.llvm.org/D53038 which broke all our bots that use `CLANG_DEFAULT_LINKER="lld"`. The same solution was applied to other targets (e.g. https://reviews.llvm.org/D49899) and while isn't great it should at least unbreak vendors that use

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek created this revision. phosek added reviewers: rsmith, Hahnfeld. Herald added a subscriber: cfe-commits. When the toolchain overrides default linker, use it rather than the default Clang one which is unlikely to be useable for that toolchain anyway. This avoids the need to explicitly specif

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek added a comment. This should avoid workarounds such as https://reviews.llvm.org/D49899 or https://reviews.llvm.org/D53249. Repository: rC Clang https://reviews.llvm.org/D53250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D53250: [ToolChain] Use default linker if the toolchain uses a custom one

phosek added a comment. In https://reviews.llvm.org/D53250#1264708, @Hahnfeld wrote: > If I read that patch correctly, this will render `-fuse-ld` with non-absolute > paths useless if a toolchain has `DefaultLinker != "ld"`. I don't think > that's what we want to do if the user explicitly sets

[PATCH] D53219: Update hexagon driver tests

phosek added a comment. The way we addressed this for other targets in the past is to explicitly set `-fuse-ld=ld` for all tests, I made that change in https://reviews.llvm.org/D53249. Repository: rL LLVM https://reviews.llvm.org/D53219 ___ cfe

[PATCH] D53082: [clang-doc] Add unit tests for bitcode

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp:2 +//===-- clang-doc/BitcodeTest.cpp +//--===// +// Nit: I think this should be on the previous line. https://reviews.llvm.or

[PATCH] D53081: [clang-doc] Add unit tests for serialization

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:27 +comments::FullComment * +getComment(const NamedDecl *D) const { + if (RawComment *Comment = D->getASTContext().getRawCommentForDeclNoCache(D)) { Nit: this func

[PATCH] D53085: [clang-doc] Add unit tests for Markdown

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp:362 +} // namespace clang \ No newline at end of file Nit: this is relevant. https://reviews.llvm.org/D53085 ___

[PATCH] D53150: [clang-doc] Limit integration tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D53084: [clang-doc] Add unit tests for YAML

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp:45 + assert(!Err); + std::string Expected = + "---\n" Nit: use raw strings here as well, the same here below. https://reviews.llvm.org/D53084 ___

[PATCH] D53082: [clang-doc] Add unit tests for bitcode

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D53081: [clang-doc] Add unit tests for serialization

phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:320 + ExtractInfosFromCodeWithArgs( + "export module M;\n" + "int moduleFunction(int x);\n" Can you use raw strings here (and elsewhere in this file) as w

[PATCH] D53248: [Driver] Support direct split DWARF emission for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL344556: [Driver] Support direct split DWARF emission for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53248?vs

[PATCH] D53249: Force Hexagon to use default (hexagon-link) linker

phosek added a comment. In https://reviews.llvm.org/D53249#1264900, @sidneym wrote: > https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I > merged that change earlier today. I can change the test to pass -fuse-ld, > let me know. Thanks, Passing `-fuse-ld=ld` is les

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. In https://reviews.llvm.org/D45639#1243010, @ldionne wrote: > Sorry, my comment was wrong. You're right, using new libc++ headers and > linking against an old `libc++.dylib` is a supported use case, and in fact > this is exactly what happens whenever you use new libc++ h

[PATCH] D53487: [Driver] Support sanitized libraries on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: cfe-commits. When using sanitizers, add //lib/ to the list of library paths to support using sanitized version of runtime libraries if available. Repository: rC Clang https://reviews.llvm.org/D53487 F

[PATCH] D53487: [Driver] Support sanitized libraries on Fuchsia

phosek updated this revision to Diff 170805. phosek marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D53487 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Drive

[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

phosek created this revision. phosek added reviewers: rsmith, rnk. Herald added a subscriber: cfe-commits. When the global new and delete operators aren't declared, Clang provides and implicit declaration, but this declaration currently always uses the default visibility. This is a problem when th

[PATCH] D53487: [Driver] Support sanitized libraries on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC345537: [Driver] Support sanitized libraries on Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D53487?vs=170805&id=171564#toc Repository: rC Clang htt

[PATCH] D53833: [Driver] Include missing touch files for sanitized library paths

phosek created this revision. phosek added reviewers: jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, javed.absar, kubamracek. These were forgotten in r345537 causing test failures on Clang builders. Repository: rC Clang https://reviews.llvm.org/D53833 Files: clang/test

[PATCH] D53833: [Driver] Include missing touch files for sanitized library paths

This revision was automatically updated to reflect the committed changes. Closed by commit rL345540: [Driver] Include missing touch files for sanitized library paths (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D53839: [CMake][Fuchsia] Drop the LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT

phosek created this revision. phosek added reviewers: jakehehrlich, mcgrathr. Herald added subscribers: cfe-commits, mgorny. Now that libc++ uses __exclude_from_explicit_instantiation__ attribute, this is no longer needed. Repository: rC Clang https://reviews.llvm.org/D53839 Files: clang/c

[PATCH] D53839: [CMake][Fuchsia] Drop the LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT

This revision was automatically updated to reflect the committed changes. Closed by commit rL345552: [CMake][Fuchsia] Drop the LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. This avoids introducing unnecessary DT_NEEDED entries when using C++ driver for linking C code or C++ code that doesn't use C++ standard library. Repository:

<    1   2   3   4   5   6   7   8   9   10   >