[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

2016-10-04 Thread Peter Levine via cfe-commits
plevine created this revision. plevine added a reviewer: chandlerc. plevine added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. LLVM sets CMAKE_INSTALL_RPATH in its top-level CMakeLists.txt to "\$ORIGIN/../lib${LLVM_LIBDIR_SUFFIX}". When Clang is built with LLVM, this prop

[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

2016-10-05 Thread Peter Levine via cfe-commits
plevine added a comment. In https://reviews.llvm.org/D25267#561955, @mgorny wrote: > I presume you copied it out of LLVM. If that's the case, please add an > comment above stating where it's been copied from. Yes. I copied it from LLVM's top-level CMakeLists.txt and added ${LLVM_LIBRARY_DIR

[PATCH] D25267: cmake: Set CMAKE_INSTALL_RPATH in Clang when building separately from LLVM

2016-10-06 Thread Peter Levine via cfe-commits
plevine added a comment. In https://reviews.llvm.org/D25267#562941, @beanz wrote: > This is actually not the right fix here. We should actually fix this in LLVM > to setup the rpath correctly on the targets during llvm_add_executable, then > we can remove this hack from LLVM instead of copying