[libclc] r245894 - Update mailing list reference.

2015-08-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon Aug 24 17:43:24 2015 New Revision: 245894 URL: http://llvm.org/viewvc/llvm-project?rev=245894&view=rev Log: Update mailing list reference. Modified: libclc/trunk/www/index.html Modified: libclc/trunk/www/index.html URL: http://llvm.org/viewvc/llvm-project/libclc/trunk/

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-08-24 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 33020. pcc added a comment. - Address comment http://reviews.llvm.org/D11857 Files: docs/ControlFlowIntegrity.rst include/clang/AST/Mangle.h include/clang/Basic/Sanitizers.def lib/AST/ItaniumMangle.cpp lib/AST/MicrosoftMangle.cpp lib/CodeGen/CGClass

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-08-24 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:149 @@ +148,3 @@ +shared library boundaries are handled as if the callee was not compiled with +``-fsanitize=cfi-icall``. + kcc wrote: > mention that LTO is require explicitly? Done above. http

Re: [PATCH] D12038: CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType.

2015-08-24 Thread Peter Collingbourne via cfe-commits
pcc added a comment. @rsmith: Ping. http://reviews.llvm.org/D12038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

2015-08-24 Thread Peter Collingbourne via cfe-commits
pcc added a subscriber: pcc. Comment at: test/Driver/fuse-ld.c:32-33 @@ +31,4 @@ +// RUN: -B%S/Inputs/basic_freebsd_tree/usr/bin 2>&1 \ +// RUN: | FileCheck %s -check-prefix=CHECK-FREEBSD-GOLD +// CHECK-FREEBSD-LINKER-GOLD: Inputs/basic_freebsd_tree/usr/bin{{/|\\+}}ld.gold +

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

2015-08-25 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 33175. pcc added a comment. - Add apology for lack of documentation http://reviews.llvm.org/D11857 Files: docs/ControlFlowIntegrity.rst docs/ControlFlowIntegrityDesign.rst include/clang/AST/Mangle.h include/clang/Basic/Sanitizers.def lib/AST/ItaniumMa

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

2015-09-01 Thread Peter Collingbourne via cfe-commits
pcc added a comment. It's probably time to add something like the driver test I was talking about in http://reviews.llvm.org/D12021. Without that, you will have no test coverage for the functional change here. http://reviews.llvm.org/D12544 ___ cf

Re: [PATCH] D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output.

2015-09-01 Thread Peter Collingbourne via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM with nit. Comment at: test/Driver/fsanitize-blacklist.c:25 @@ -18,1 +24,3 @@ +// CHECK-DEFAULT-BLACKLIST: -fsanitize-blacklist={{.*}}asan_blacklist.txt +// CHECK-DEFAULT-BLACKL

Re: clang-tools-extra code owners

2015-09-02 Thread Peter Collingbourne via cfe-commits
SGTM. Peter On Wed, Sep 02, 2015 at 12:38:41PM -0400, Aaron Ballman wrote: > I happened to notice that CODE_OWNERS.TXT for clang-tools-extra is > rather sparse. These tools are starting to get more attention from the > community, and I am wondering whether it would make sense to populate > that s

r250388 - Headers: Switch some headers to LF line endings for consistency.

2015-10-15 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Oct 15 05:33:27 2015 New Revision: 250388 URL: http://llvm.org/viewvc/llvm-project?rev=250388&view=rev Log: Headers: Switch some headers to LF line endings for consistency. Modified: cfe/trunk/lib/Headers/avx512cdintrin.h cfe/trunk/lib/Headers/xsavecintrin.h cfe/

[PATCH] D14266: CodeGen: Update for debug info API change.Depends on D14265.

2015-11-02 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added a reviewer: dexonsmith. pcc added a subscriber: cfe-commits. http://reviews.llvm.org/D14266 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-block-decl.c test/CodeGenCXX/debug-info-static-fns.cpp test/CodeGenCXX/debug-info-windows-dtor.cpp

r252220 - CodeGen: Update for debug info API change.

2015-11-05 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Nov 5 16:04:14 2015 New Revision: 252220 URL: http://llvm.org/viewvc/llvm-project?rev=252220&view=rev Log: CodeGen: Update for debug info API change. Differential Revision: http://reviews.llvm.org/D14266 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/tes

Re: [PATCH] D14266: CodeGen: Update for debug info API change.Depends on D14265.

2015-11-05 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252220: CodeGen: Update for debug info API change. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D14266?vs=39004&id=39414#toc Repository: rL LLVM http://reviews.llvm.org/D14266

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

2015-08-07 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2060-2062 @@ -2058,2 +2059,5 @@ void CXXNameMangler::mangleType(const FunctionNoProtoType *T) { - llvm_unreachable("Can't mangle K&R function prototypes"); + // Function types without prototypes can arise when man

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

2015-08-07 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 31546. pcc added a comment. - Use a mangling distinct from (...) as suggested by Richard http://reviews.llvm.org/D11848 Files: lib/AST/ItaniumMangle.cpp lib/AST/MicrosoftMangle.cpp test/CodeGen/mangle-ms.c test/CodeGen/overloadable.c Index: test/CodeGe

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

2015-08-07 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244374: AST: Implement mangling support for function types without a prototype. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D11848?vs=31546&id=31557#toc Repository: rL LLVM h

Re: [PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-18 Thread Peter Collingbourne via cfe-commits
pcc added a comment. > An amendment to the Itanium ABI requiring that a conforming program may not > adjust a virtual table pointer loaded from an object to another virtual table > in the same virtual table group would seem to be all that would be required > to guarantee that this scheme wil

[PATCH] D22642: CodeGen: Clean up implementation of vtable initializer builder. NFC.

2016-07-21 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added a reviewer: rsmith. pcc added a subscriber: cfe-commits. - Simplify signature of CreateVTableInitializer function. - Move vtable component builder to a separate function. - Remove unnecessary accessors from VTableLayout class. This is in preparation for a futu

Re: [PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-26 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 65647. pcc added a comment. Use new representation: https://reviews.llvm.org/D22793 https://reviews.llvm.org/D22296 Files: include/clang/AST/VTableBuilder.h lib/AST/VTableBuilder.cpp lib/CodeGen/CGCXX.cpp lib/CodeGen/CGVTT.cpp lib/CodeGen/CGVTables.cp

Re: [PATCH] D22296: [wip] CodeGen: New vtable group representation: struct of vtable arrays.

2016-07-26 Thread Peter Collingbourne via cfe-commits
pcc added a comment. For reference, here is the text of the proposal I sent to cxx-abi-dev: Hi all, The ABI currently requires that virtual tables for a class appear consecutively in a virtual table group. I would like to propose a restriction that would require that compilers may only access

r259382 - docs: Clarify that cfi-unrelated-cast is based on lifetime.

2016-02-01 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon Feb 1 12:55:50 2016 New Revision: 259382 URL: http://llvm.org/viewvc/llvm-project?rev=259382&view=rev Log: docs: Clarify that cfi-unrelated-cast is based on lifetime. Also restore Makefile.sphinx which is needed to build the documentation. Added: cfe/trunk/docs/Makefil

[PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-02 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: joker.eph, pete, chandlerc. pcc added subscribers: hans, kcc, cfe-commits. This patch introduces the -fwhole-program-vtables flag, which enables the whole-program vtable optimization feature (D16795) in Clang. http://reviews.llvm.org/D16821 Files:

Re: [PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

2016-02-02 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2494 @@ +2493,3 @@ + llvm::Value *ValidVtable = nullptr; + if (CheckAndAppendValidVtable) { +llvm::Value *AllVtables = llvm::MetadataAsValue::get( eugenis wrote: > samsonov wrote: > > This is real

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

2016-02-17 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Why can't we make it so that a trap flag doesn't affect the behaviour if a sanitizer is disabled (this looks like what `CodeGenModule::NeedAllVtablesBitSet` is already doing?) Repository: rL LLVM http://reviews.llvm.org/D17360

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-17 Thread Peter Collingbourne via cfe-commits
pcc added a reviewer: rsmith. pcc added a comment. Hi Richard, can you take a look please? http://reviews.llvm.org/D16821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17360: [cfi] Fix handling of sanitize trap/recover flags in the cross-DSO CFI mode.

2016-02-19 Thread Peter Collingbourne via cfe-commits
pcc added a comment. What I meant was that it looks like a hack that this is being handled in the driver. The frontend shouldn't care what the value of a trap flag is if a sanitizer is disabled. Why are we even emitting checks for disabled sanitizers in the target DSO anyway? Can we fail open

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:904-919 @@ -900,5 +903,18 @@ + +bool CodeGenModule::IsBitSetBlacklistedRecord(const CXXRecordDecl *RD) { + std::string TypeName = RD->getQualifiedNameAsString(); + auto isInBlacklist = [&](const SanitizerBlacklist

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > > > On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > > > > One thing that I'd like to do (and this would help CFI as well) is to > > specifically recognize cases like this: > > > > ``` > > struct B { > > virtual void vf()

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-22 Thread Peter Collingbourne via cfe-commits
On Mon, Feb 22, 2016 at 03:59:01PM -0800, Mehdi Amini wrote: > > > On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: > >> > >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: > >>> > >>> One thing that I'd lik

r261767 - Add whole-program vtable optimization feature to Clang.

2016-02-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Feb 24 14:46:36 2016 New Revision: 261767 URL: http://llvm.org/viewvc/llvm-project?rev=261767&view=rev Log: Add whole-program vtable optimization feature to Clang. This patch introduces the -fwhole-program-vtables flag, which enables the whole-program vtable optimization fea

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

2016-02-24 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL261767: Add whole-program vtable optimization feature to Clang. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D16821?vs=46697&id=48968#toc Repository: rL LLVM http://reviews.ll

r261782 - Fix build by using hasFlag instead of hasArg.

2016-02-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Feb 24 16:03:06 2016 New Revision: 261782 URL: http://llvm.org/viewvc/llvm-project?rev=261782&view=rev Log: Fix build by using hasFlag instead of hasArg. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-

r261960 - Make vtables_blacklist dependency conditional on existence of clang target.

2016-02-25 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Feb 25 21:07:33 2016 New Revision: 261960 URL: http://llvm.org/viewvc/llvm-project?rev=261960&view=rev Log: Make vtables_blacklist dependency conditional on existence of clang target. Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt

Re: r261767 - Add whole-program vtable optimization feature to Clang.

2016-02-25 Thread Peter Collingbourne via cfe-commits
anks > > Steven > > > > On Feb 24, 2016, at 12:46 PM, Peter Collingbourne via cfe-commits > > wrote: > > > > Author: pcc > > Date: Wed Feb 24 14:46:36 2016 > > New Revision: 261767 > > > > URL: http://llvm.org/viewvc/llvm-project?re

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-27 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. http://reviews.llvm.org/D18635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267784 - Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-27 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Apr 27 15:39:53 2016 New Revision: 267784 URL: http://llvm.org/viewvc/llvm-project?rev=267784&view=rev Log: Rework interface for bitset-using features to use a notion of LTO visibility. Bitsets, and the compiler features they rely on (vtable opt, CFI), only have visibility w

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-27 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267784: Rework interface for bitset-using features to use a notion of LTO visibility. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D18635?vs=54439&id=55307#toc Repository: rL L

r267788 - Revert unnecessary tblgen change.

2016-04-27 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Apr 27 15:49:44 2016 New Revision: 267788 URL: http://llvm.org/viewvc/llvm-project?rev=267788&view=rev Log: Revert unnecessary tblgen change. Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp URL: http://llv

r267824 - Driver: only produce CFI -fvisibility= error when compiling.

2016-04-27 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Wed Apr 27 19:18:30 2016 New Revision: 267824 URL: http://llvm.org/viewvc/llvm-project?rev=267824&view=rev Log: Driver: only produce CFI -fvisibility= error when compiling. The -fvisibility= flag only affects compile jobs, so there's no need to error out because of it if we aren

r267903 - Re-apply r267784, r267824 and r267830.

2016-04-28 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Apr 28 12:09:37 2016 New Revision: 267903 URL: http://llvm.org/viewvc/llvm-project?rev=267903&view=rev Log: Re-apply r267784, r267824 and r267830. I have updated the compiler-rt tests. Added: cfe/trunk/docs/LTOVisibility.rst cfe/trunk/test/CodeGenCXX/bitset-inferenc

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

2016-04-30 Thread Peter Collingbourne via cfe-commits
pcc added a comment. We shouldn't be adding (much less documenting) `-mllvm` flags. Is there any reason why this behavior can't be gated on the OS? http://reviews.llvm.org/D19483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

2016-04-30 Thread Peter Collingbourne via cfe-commits
pcc added a comment. You should be using `-target x86-unknown-contiki` or similar. That should tune the behaviour to what is required for that OS. See what we have in `TargetLoweringBase::getSafeStackPointerLocation` to provide Android-specific behaviour for example. The existence of flags is

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

2016-04-30 Thread Peter Collingbourne via cfe-commits
pcc added a comment. > This makes sense for the example I gave. However, there are also more > complicated situations. Sometimes it is necessary to specify different > options for different files that are compiled for the same OS. For example, > early during the initialization of a dynamic link

Re: [PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

2016-04-30 Thread Peter Collingbourne via cfe-commits
pcc added a comment. > It appears that Clang already supports an -mthread_model=single option, so do > you recommend that I remove the -mllvm -safe-stack-usp-storage=single-thread > option and rely on -mthread_model instead? Makes sense to me. We're free to break `-mllvm` flags, they are for

r269111 - Update clang for LLVM API change.

2016-05-10 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue May 10 15:23:29 2016 New Revision: 269111 URL: http://llvm.org/viewvc/llvm-project?rev=269111&view=rev Log: Update clang for LLVM API change. Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D20339: Update clang for D20260

2016-05-17 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rafael, majnemer. pcc added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. http://reviews.llvm.org/D20339 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen

Re: [PATCH] D20339: Update clang for D20260

2016-05-17 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3 @@ -2,3 +2,3 @@ -// CHECK: @array = addrspace({{[0-9]+}}) constant +// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant __constant float array[2] = {0.0f, 1.0f};

[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-18 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: dexonsmith, dblaikie, aprantl. pcc added a subscriber: cfe-commits. http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunct

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-18 Thread Peter Collingbourne via cfe-commits
pcc planned changes to this revision. pcc added a comment. One thing that I forgot to do here was to add a test covering my changes to `CGDebugInfo::EmitGlobalVariable`. I'll do that momentarily. http://reviews.llvm.org/D20415 ___ cfe-commits maili

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-19 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 57809. pcc added a comment. - Add a test for DW_OP_stack_value http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/Code

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-20 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( aprantl wrote: > Are we regressin

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-20 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( aprantl wrote: > pcc wrote: > > a

[PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-03-30 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rsmith, eugenis, aaron.ballman, cfe-commits. pcc added subscribers: joker.eph, pete. Bitsets, and the compiler features they rely on (vtable opt, CFI), only have scope within the linkage unit. Therefore, only enable these features for classes with li

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-03-31 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:271 @@ +270,3 @@ +linkage-unit scope. With this flag enabled, the compiler will emit cross-DSO +CFI checks for all classes, except for those which appear in the CFI blacklist +or which use a ``no_sanitize`` attri

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-03-31 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > Can you use some word other than "scope" here? "Class scope" is already a > term of art in C++, meaning something completely different.

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-03-31 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > pcc wrote: > > rsmith wrote: > > > Can you use some word other than "scope" here? "Class scope" is already a > > > term of art in C++, m

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-03-31 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: docs/ClassScope.rst:2 @@ +1,3 @@ +=== +Class Scope +=== rsmith wrote: > pcc wrote: > > rsmith wrote: > > > pcc wrote: > > > > rsmith wrote: > > > > > Can you use some word other than "scope" here? "Class scope

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-04-05 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 52730. pcc added a comment. - Rewrite docs http://reviews.llvm.org/D18635 Files: docs/ControlFlowIntegrity.rst docs/LTOVisibility.rst docs/UsersManual.rst docs/index.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Bas

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-04-05 Thread Peter Collingbourne via cfe-commits
pcc added a comment. I have updated the documentation for the new design; PTAL before I proceed with implementation. http://reviews.llvm.org/D18635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-04-05 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 52732. pcc added a comment. - Update command line flag docs http://reviews.llvm.org/D18635 Files: docs/ControlFlowIntegrity.rst docs/LTOVisibility.rst docs/UsersManual.rst docs/index.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of class scope.

2016-04-05 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 52759. pcc added a comment. - New implementation http://reviews.llvm.org/D18635 Files: docs/ControlFlowIntegrity.rst docs/LTOVisibility.rst docs/UsersManual.rst docs/index.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/cla

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-19 Thread Peter Collingbourne via cfe-commits
pcc added a comment. @rsmith Ping. http://reviews.llvm.org/D18635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-20 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 54439. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments http://reviews.llvm.org/D18635 Files: docs/ControlFlowIntegrity.rst docs/LTOVisibility.rst docs/UsersManual.rst docs/index.rst include/clang/Basic/Attr.td in

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-20 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Thanks for the comments. I've also taken another pass over the docs and changed them to specify that classes defined in translation units compiled without LTO receive public LTO visibility. This seems more precise to me, but please let me know what you think. I have also a

r270634 - docs: Document how safestack handles setjmp and exceptions.

2016-05-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue May 24 18:38:02 2016 New Revision: 270634 URL: http://llvm.org/viewvc/llvm-project?rev=270634&view=rev Log: docs: Document how safestack handles setjmp and exceptions. Modified: cfe/trunk/docs/SafeStack.rst Modified: cfe/trunk/docs/SafeStack.rst URL: http://llvm.org/vi

[PATCH] D20749: Introduce support for relative C++ ABI gated on LTO visibility.

2016-05-27 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rsmith, rjmccall, rafael, mehdi_amini, aaron.ballman, majnemer, rnk. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. I'd like to propose this patch as an alternative to D17893 and D18199 that approaches the user interfac

r271063 - docs: Clarify that LTO visibility is based on source-level symbol visibility.

2016-05-27 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri May 27 17:31:30 2016 New Revision: 271063 URL: http://llvm.org/viewvc/llvm-project?rev=271063&view=rev Log: docs: Clarify that LTO visibility is based on source-level symbol visibility. Modified: cfe/trunk/docs/LTOVisibility.rst Modified: cfe/trunk/docs/LTOVisibility.rs

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-31 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. http://reviews.llvm.org/D20415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-06-01 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 59260. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/

[PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

2016-06-06 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: mehdi_amini, kcc. pcc added a subscriber: cfe-commits. pcc added a dependency: D21053: IR: New representation for CFI and virtual call optimization pass metadata.. Herald added a subscriber: mehdi_amini. Depends on D21053 http://reviews.llvm.org/D2

[PATCH] D21122: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

2016-06-08 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: eugenis, mehdi_amini, kcc. pcc added a subscriber: cfe-commits. pcc added a dependency: D21121: IR: Introduce llvm.type.checked.load intrinsic.. Depends on D21121 http://reviews.llvm.org/D21122 Files: lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGen

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272710 - Update clang for D20348

2016-06-14 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 14 16:02:05 2016 New Revision: 272710 URL: http://llvm.org/viewvc/llvm-project?rev=272710&view=rev Log: Update clang for D20348 Differential Revision: http://reviews.llvm.org/D20339 Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk/lib/CodeGen/CGExpr.cpp

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272710: Update clang for D20348 (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D20339?vs=57527&id=60747#toc Repository: rL LLVM http://reviews.llvm.org/D20339 Files: cfe/trunk

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Thanks, the patch I committed adds `-cl-opt-disable` to the tests. Repository: rL LLVM http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-06-20 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added a reviewer: rsmith. pcc added a subscriber: cfe-commits. This changes the CompilerInstance::createOutputFile function to return a std::unique_ptr, rather than an llvm::raw_ostream implicitly owned by the CompilerInstance. This in most cases required that I move

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-06-20 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 61317. pcc added a comment. - Move EmitAssemblyHelper's pass managers into CreatePasses http://reviews.llvm.org/D21537 Files: include/clang/CodeGen/BackendUtil.h include/clang/CodeGen/ObjectFilePCHContainerOperations.h include/clang/Frontend/ASTConsumers.

[PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-20 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added a reviewer: tejohnson. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. This new test tests that functions are capable of being imported, rather than that the import pass is run. This new test is compatible with the approach being de

[PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-06-20 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: tejohnson, mehdi_amini. pcc added a subscriber: cfe-commits. pcc added dependencies: D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test., D20268: [wip] Resolution-based LTO API., D21537: Frontend: Simplify ownership model

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Should be fine. This is testing an unusual feature of clang that takes IR as input, so IR is the appropriate input type here. http://reviews.llvm.org/D21542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273347: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21542?vs=61328&id=61479#toc Repository: rL LLVM h

r273347 - CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 19:57:26 2016 New Revision: 273347 URL: http://llvm.org/viewvc/llvm-project?rev=273347&view=rev Log: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test. This new test tests that functions are capable of being imported, rather than that the import p

r273351 - Add missing test dependency.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:03:15 2016 New Revision: 273351 URL: http://llvm.org/viewvc/llvm-project?rev=273351&view=rev Log: Add missing test dependency. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

r273356 - Specify a target triple to fix the test on non-Linux.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:17:30 2016 New Revision: 273356 URL: http://llvm.org/viewvc/llvm-project?rev=273356&view=rev Log: Specify a target triple to fix the test on non-Linux. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll URL:

r273361 - Require an x86 target for the thinlto_backend.ll test.

2016-06-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 21 20:40:47 2016 New Revision: 273361 URL: http://llvm.org/viewvc/llvm-project?rev=273361&view=rev Log: Require an x86 target for the thinlto_backend.ll test. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll URL

r273590 - Add a test case for the regression in -Wfor-loop-analysis caused by r273548.

2016-06-23 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Jun 23 13:11:19 2016 New Revision: 273590 URL: http://llvm.org/viewvc/llvm-project?rev=273590&view=rev Log: Add a test case for the regression in -Wfor-loop-analysis caused by r273548. Modified: cfe/trunk/test/SemaCXX/warn-loop-analysis.cpp Modified: cfe/trunk/test/Sema

r273589 - Revert r273548, "Rearrange condition handling so that semantic checks on a condition variable"

2016-06-23 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Thu Jun 23 13:11:15 2016 New Revision: 273589 URL: http://llvm.org/viewvc/llvm-project?rev=273589&view=rev Log: Revert r273548, "Rearrange condition handling so that semantic checks on a condition variable" as it caused a regression in -Wfor-loop-analysis. Modified: cfe/tru

r273730 - CodeGen: Update Clang to use the new type metadata.

2016-06-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jun 24 16:21:46 2016 New Revision: 273730 URL: http://llvm.org/viewvc/llvm-project?rev=273730&view=rev Log: CodeGen: Update Clang to use the new type metadata. Differential Revision: http://reviews.llvm.org/D21054 Added: cfe/trunk/test/CodeGenCXX/lto-visibility-inferenc

Re: [PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

2016-06-24 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273730: CodeGen: Update Clang to use the new type metadata. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21054?vs=59821&id=61842#toc Repository: rL LLVM http://reviews.llvm.o

Re: [PATCH] D21542: CodeGen: Replace test/CodeGen/thinlto_backend.c with a functional test.

2016-06-24 Thread Peter Collingbourne via cfe-commits
pcc added a comment. This is testing a clang feature that reads IR and runs the ThinLTO backend. This feature is part of ThinLTO's distributed build support (search for "Distributed Build Support" in http://blog.llvm.org/2016/06/thinlto-scalable-and-incremental-lto.html). In a future change I

Re: [PATCH] D21122: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

2016-06-24 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273757: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole… (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D21122?vs=60006&id=61864#toc Repository: rL LLVM

r273757 - CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled.

2016-06-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jun 24 19:24:06 2016 New Revision: 273757 URL: http://llvm.org/viewvc/llvm-project?rev=273757&view=rev Log: CodeGen: Start emitting checked loads when both trapping CFI and -fwhole-program-vtables are enabled. Differential Revision: http://reviews.llvm.org/D21122 Modified:

r273760 - Fix bad test expectation.

2016-06-24 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Fri Jun 24 19:37:14 2016 New Revision: 273760 URL: http://llvm.org/viewvc/llvm-project?rev=273760&view=rev Log: Fix bad test expectation. Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp Modified: cfe/trunk/test/CodeGenCXX/type-metadata.cpp URL: http://llvm.org/viewvc

[PATCH] D21825: Driver: Forbid -fthinlto-index with output formats other than object files.

2016-06-28 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added a reviewer: tejohnson. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. The other output formats aren't really useful to end users. The equivalent functionality can still be accessed by developers with tools such as llvm-lto. http:/

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-06-28 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 62160. pcc marked 2 inline comments as done. pcc added a comment. - Use ComputeCrossModuleImportForModule http://reviews.llvm.org/D21545 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt Index: lib/CodeGen/CMakeLists.txt ===

[PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-12 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rsmith, eugenis. pcc added subscribers: cfe-commits, krasin. pcc added a dependency: D22295: Introduce !splitpoint metadata and GlobalSplit pass.. This metadata can be used to annotate global variables with split points. Each split point specifies a

Re: [PATCH] D21825: Driver: Forbid -fthinlto-index with output formats other than object files.

2016-07-13 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. http://reviews.llvm.org/D21825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-07-13 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 63908. pcc added a comment. Refresh http://reviews.llvm.org/D21545 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt Index: lib/CodeGen/CMakeLists.txt === --- lib/CodeGen/CMakeList

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-07-14 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. https://reviews.llvm.org/D21537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

2016-07-14 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 64043. pcc added a comment. - Add a FIXME https://reviews.llvm.org/D21545 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt Index: lib/CodeGen/CMakeLists.txt === --- lib/CodeGen/CM

<    1   2   3   4   >