pbos created this revision.
pbos added a reviewer: hans.
Herald added projects: All, clang, clang-format.
Herald added a subscriber: cfe-commits.
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
pbos requested review of this revision.
Herald added a comment.
NOTE: Clang
pbos added a comment.
Does this need additional testing besides
clang/unittests/Format/BracesInserterTest.cpp ?
I haven't seen tests that EXPECT_TRUE(getChromiumStyle(lang).InsertBraces);
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147969/new/
pbos added a comment.
What defines a code-modifying feature? This shouldn't change control flow, so
are superfluous {}s seen as code-modifying while additional spaces/tabs/whatnot
are not?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147969/new/
pbos added a comment.
That's reasonable. If I don't hear something else we'll own InsertBraces on our
end. Is there anything I can point to regarding the decision to not let
clang-format add/rearrange tokens by default so that I can refer to that in a
comment saying why it won't be upstreamed?
