[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

2022-03-27 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Looks good. Thanks for doing this, Emil! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122542/new/ https://reviews.llvm.org/D1225

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

2021-07-20 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105881/new/ https://reviews.llvm.org/D105881 ___

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

2021-06-03 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://reviews.llvm.org/D103613 ___

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. Thanks for doing this. These changes look good, but I can't get them to build successfully. I'm using the GNU 9.3 C++ compiler. My build fails to link the bin/flang-new executable. Here's an excerpt of the error messages: [4436/4439] Generating ../../../../i

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. Stay tuned a little, I think I spotted the problem ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 ___ cfe-commits mailing li

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-15 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Looks great! Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 _

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-16 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. In D104305#2822589 , @klausler wrote: > The non-shared-library build of the current llvm-project/main tree fails on > this new test; it looks as if gfortran is being invoked and passed an option > that it does not recogniz

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

2021-06-16 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. For what it's worth, here's my cmake command that results in a successful static full build: cmake -G Ninja ../llvm \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_LIT_ARGS=-v \ -DFLANG_ENABLE_WERROR=On \ -DCMAKE_C_COMPILER=/home/sw/thirdparty/gcc/gcc-9.3.0

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

2021-06-24 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 ___

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

2021-07-13 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld requested changes to this revision. PeteSteinfeld added a comment. This revision now requires changes to proceed. This built OK, but when I run `check-flang`, I see errors for `.../Driver/driver-help.f90` and `.../Driver/driver-help-hidden.f90`. I'm building on a Linux system usin

[PATCH] D153379: Remove -flang-experimental-exec flag

2023-06-21 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. All builds and tests correctly and looks good. @everythingfunctional, can you please post on Discourse about this change when you merge? Since we've discussed this with the community, I think we should let them know that this

[PATCH] D143301: [flang] Handle unsupported warning flags

2023-02-21 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. In D143301#4143108 , @vzakhari wrote: > The new tests fail to link: That is, these new tests cause check-flang to fail. @elmcdonough, can you please fix things so that check-flang no longer fails? Repository: rG LLVM

[PATCH] D143301: [flang] Handle unsupported warning flags

2023-02-21 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld added a comment. > @PeteSteinfeld, I think vzakhari's most recent commit > > fixes this. Thanks, @ elmcdonough, and @vzakhari! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

2022-01-06 Thread Pete Steinfeld via Phabricator via cfe-commits
PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. Thanks for doing this! After adopting this change, I did an in tree build followed by an out of tree build -- both without creating or using the install area. Both builds were