[PATCH] D14104: clang-format: Add an additional value to AlignAfterOpenBracket: AlwaysBreak.

2017-12-08 Thread Paweł Bylica via Phabricator via cfe-commits
chfast added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:173 + + someLongFunction(argument1, + argument2); I think this example is not achievable. clang-format seems to prefer putting all arguments on the next line if th

[PATCH] D18914: [clang-tidy] new readability-redundant-inline

2020-11-17 Thread Paweł Bylica via Phabricator via cfe-commits
chfast added a comment. This check can be useful in other case like this: inline constexpr const int x = 1; where `inline` and `const` are redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18914/new/ https://reviews.llvm.org/D18914 ___

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

2022-01-09 Thread Paweł Bylica via Phabricator via cfe-commits
chfast added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5320 + if (!(Cleanup && Cleanup->getCleanup()->isRedundantBeforeReturn())) +CGM.ErrorUnsupported(MustTailCall, "tail call skipping over cleanups"); +} I reported a related iss