r332228 - [CodeGen] Disable aggressive structor optimizations at -O0

Author: labath Date: Mon May 14 04:02:23 2018 New Revision: 332228 URL: http://llvm.org/viewvc/llvm-project?rev=332228&view=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0 Summary: Removing the full structor and replacing all usages with the base one can degrade debug quality

r332232 - Revert "[CodeGen] Disable aggressive structor optimizations at -O0"

Author: labath Date: Mon May 14 04:35:44 2018 New Revision: 332232 URL: http://llvm.org/viewvc/llvm-project?rev=332232&view=rev Log: Revert "[CodeGen] Disable aggressive structor optimizations at -O0" It breaks the sanitizer build

r332839 - [CodeGen] Disable aggressive structor optimizations at -O0, take 2

Author: labath Date: Mon May 21 04:47:45 2018 New Revision: 332839 URL: http://llvm.org/viewvc/llvm-project?rev=332839&view=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0, take 2 The first version of the patch (r332228) was flawed because it was putting structors into C5/D5 c

r341472 - Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)

Author: labath Date: Wed Sep 5 07:38:44 2018 New Revision: 341472 URL: http://llvm.org/viewvc/llvm-project?rev=341472&view=rev Log: Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames) Summary: DWARF v5 accelerator tables provide a considerable performance impr

r341492 - Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)"

Author: labath Date: Wed Sep 5 13:20:28 2018 New Revision: 341492 URL: http://llvm.org/viewvc/llvm-project?rev=341492&view=rev Log: Revert "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)" This reverts commit r341472 due to breakage in green dragon bots.

r341564 - Re-commit "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)""

Author: labath Date: Thu Sep 6 10:01:45 2018 New Revision: 341564 URL: http://llvm.org/viewvc/llvm-project?rev=341564&view=rev Log: Re-commit "Enable DWARF accelerator tables by default when tuning for lldb (-glldb => -gpubnames)"" This recommits r341472, which was reverted due to test failures

r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

Author: labath Date: Thu Jul 19 07:05:22 2018 New Revision: 337456 URL: http://llvm.org/viewvc/llvm-project?rev=337456&view=rev Log: [CodeGen] Disable aggressive structor optimizations at -O0, take 3 The previous version of this patch (r332839) was reverted because it was causing "definition with

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

8 at 03:15, Chandler Carruth wrote: > > On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth wrote: >> >> On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits >> wrote: >>> >>> Author: labath >>> Date: Thu Jul 19 07:05:22 2018 >>> New R

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

. > > > > > > > On Sun, 29 Jul 2018 at 03:15, Chandler Carruth wrote: > > > > On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth > > wrote: > >> > >> On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits > >> wrote: >

r321167 - Remove llvm::MemoryBuffer const_casts

Author: labath Date: Wed Dec 20 03:34:38 2017 New Revision: 321167 URL: http://llvm.org/viewvc/llvm-project?rev=321167&view=rev Log: Remove llvm::MemoryBuffer const_casts Summary: llvm has grown a WritableMemoryBuffer class, which is convertible (inherits from) a MemoryBuffer. We can use it to av

r322268 - [Lex] Use WritableMemoryBuffer in ScratchBuffer.cpp

Author: labath Date: Thu Jan 11 02:43:45 2018 New Revision: 322268 URL: http://llvm.org/viewvc/llvm-project?rev=322268&view=rev Log: [Lex] Use WritableMemoryBuffer in ScratchBuffer.cpp This avoids the need to const_cast the buffer contents to write to it. NFCI. Modified: cfe/trunk/lib/Lex/S

r327383 - clang-import-test: fix build with clang-3.8

Author: labath Date: Tue Mar 13 04:28:27 2018 New Revision: 327383 URL: http://llvm.org/viewvc/llvm-project?rev=327383&view=rev Log: clang-import-test: fix build with clang-3.8 clang-3.8 complains that constructor for '...' must explicitly initialize the const object. Newer clangs and gcc seem to

r327491 - StaticAnalyzer: fix compiler warning. NFC

Author: labath Date: Wed Mar 14 03:16:40 2018 New Revision: 327491 URL: http://llvm.org/viewvc/llvm-project?rev=327491&view=rev Log: StaticAnalyzer: fix compiler warning. NFC My compiler (clang-3.8) complains that the RCC variable is unused. That's not really true, as it's checked by the if-decla

r334399 - Move VersionTuple from clang/Basic to llvm/Support

Author: labath Date: Mon Jun 11 03:28:04 2018 New Revision: 334399 URL: http://llvm.org/viewvc/llvm-project?rev=334399&view=rev Log: Move VersionTuple from clang/Basic to llvm/Support Summary: This kind of functionality is useful to other project apart from clang. LLDB works with version numbers

r351317 - [Support] Remove error return value from one overload of fs::make_absolute

Author: labath Date: Wed Jan 16 01:55:32 2019 New Revision: 351317 URL: http://llvm.org/viewvc/llvm-project?rev=351317&view=rev Log: [Support] Remove error return value from one overload of fs::make_absolute Summary: The version of make_absolute which accepted a specific directory to use as the "

[clang-tools-extra] r351319 - Fix build breakage from llvm r351317

Author: labath Date: Wed Jan 16 02:26:52 2019 New Revision: 351319 URL: http://llvm.org/viewvc/llvm-project?rev=351319&view=rev Log: Fix build breakage from llvm r351317 The two-argument version of llvm::sys::fs::make_absolute no longer returns an error code. Modified: clang-tools-extra/tru

[llvm] [compiler-rt] [clang] [clang-tools-extra] [compiler-rt] Mark more calls as blocking (PR #77789)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/77789 >From 97c29cab7c7d8af9bf7a5d79baf468154bb83fad Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 11 Jan 2024 12:50:37 +0100 Subject: [PATCH] [compiler-rt] Mark more calls as blocking If we're in a blocking c

Re: [Lldb-commits] [lldb] aee4925 - Recommit: Compress formatting of array type names (int [4] -> int[4])

On 26/10/2021 23:14, Jim Ingham via lldb-commits wrote: On Oct 26, 2021, at 12:45 PM, David Blaikie wrote: On Tue, Oct 26, 2021 at 12:15 PM Raphael Isemann wrote: Not sure how many LLDB users would (or can) write AST matchers though. And (lldb) type summary add "foo[4]" ... is arguably

r292141 - [StaticAnalyzer] Fix android build

Author: labath Date: Mon Jan 16 09:57:07 2017 New Revision: 292141 URL: http://llvm.org/viewvc/llvm-project?rev=292141&view=rev Log: [StaticAnalyzer] Fix android build std::to_string is not available in the android NDK. Use llvm::to_string instead. Committing as obvious. Modified: cfe/trunk

r292914 - Replace use of chdir with llvm::sys::fs::set_current_path

Author: labath Date: Tue Jan 24 05:14:29 2017 New Revision: 292914 URL: http://llvm.org/viewvc/llvm-project?rev=292914&view=rev Log: Replace use of chdir with llvm::sys::fs::set_current_path NFCI Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSy

r284964 - Adjust for TimePoint interface change in llvm: D25730. NFC

Author: labath Date: Mon Oct 24 05:59:13 2016 New Revision: 284964 URL: http://llvm.org/viewvc/llvm-project?rev=284964&view=rev Log: Adjust for TimePoint interface change in llvm: D25730. NFC Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h cfe/trunk/lib/Driver/Tools.cpp Modif

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

labath created this revision. labath added reviewers: benlangmuir, zturner. labath added a subscriber: cfe-commits. NFCI https://reviews.llvm.org/D25948 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileSystemStatCache.cpp lib/Basic/VirtualFileSystem.cpp lib/Frontend/ASTUnit.

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

labath added a comment. If noone objects, I am going to commit this tomorrow. https://reviews.llvm.org/D25948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

This revision was automatically updated to reflect the committed changes. Closed by commit rL286356: [VFS] Replace TimeValue usage with std::chrono (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25948?vs=75723&id=77330#toc Repository: rL LLVM https://reviews.llvm.o

r286356 - [VFS] Replace TimeValue usage with std::chrono

Author: labath Date: Wed Nov 9 04:52:22 2016 New Revision: 286356 URL: http://llvm.org/viewvc/llvm-project?rev=286356&view=rev Log: [VFS] Replace TimeValue usage with std::chrono Summary: NFCI Reviewers: benlangmuir, zturner Subscribers: cfe-commits Differential Revision: https://reviews.llvm

r286357 - Replace TimeValue with TimePoint in BuildSystem.cpp. NFC.

Author: labath Date: Wed Nov 9 05:19:39 2016 New Revision: 286357 URL: http://llvm.org/viewvc/llvm-project?rev=286357&view=rev Log: Replace TimeValue with TimePoint in BuildSystem.cpp. NFC. Modified: cfe/trunk/tools/libclang/BuildSystem.cpp Modified: cfe/trunk/tools/libclang/BuildSystem.cpp

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. I'll just observe this one. Someone with more knowledge of clang needs to review this. Repository: rL LLVM http://reviews.llvm.org/D13959 ___ cfe-comm

[PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

labath created this revision. labath added a reviewer: beanz. labath added a subscriber: cfe-commits. When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targets. cmake 2.8 silently ignored this situation, but with cmake_minimum_required(3.4

r271533 - [cmake] Fix builds with LLVM_ENABLE_PIC=0

Author: labath Date: Thu Jun 2 11:35:24 2016 New Revision: 271533 URL: http://llvm.org/viewvc/llvm-project?rev=271533&view=rev Log: [cmake] Fix builds with LLVM_ENABLE_PIC=0 Summary: When this flag is specified, the target llvm-lto is not built, but is still used as a dependency of the test targ

Re: [PATCH] D20883: [cmake] Fix builds with LLVM_ENABLE_PIC=0

This revision was automatically updated to reflect the committed changes. Closed by commit rL271533: [cmake] Fix builds with LLVM_ENABLE_PIC=0 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20883?vs=59293&id=59405#toc Repository: rL LLVM http://reviews.llvm.org/D208

r271565 - [cmake] Fix-up r271533

Author: labath Date: Thu Jun 2 13:49:42 2016 New Revision: 271565 URL: http://llvm.org/viewvc/llvm-project?rev=271565&view=rev Log: [cmake] Fix-up r271533 I was appending to the wrong variable (over-zealous copy-paste from llvm on my part). Modified: cfe/trunk/test/CMakeLists.txt Modified

[PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

labath created this revision. labath added a reviewer: akyrtzi. labath added a subscriber: cfe-commits. ASTImporter was importing this attribute only on destructor and constructor decls, as they take it in the constructor, but other decls can have this attribute as well, notably the global opera

Re: [PATCH] D17845: [ASTImporter] Import "implicit" attribute of FunctionDecls

labath added a subscriber: lldb-commits. labath added a comment. I noticed this while debugging an importing issue in LLDB. I am not sure if I have selected the right reviewer, and also how/if to test this... http://reviews.llvm.org/D17845 ___ cfe

[PATCH] D17847: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

labath created this revision. labath added a reviewer: nlewycky. labath added subscribers: cfe-commits, lldb-commits. While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which expect to be called with a valid source location. This causes an assertion failure if the locatio

r262700 - [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

Author: labath Date: Fri Mar 4 04:00:08 2016 New Revision: 262700 URL: http://llvm.org/viewvc/llvm-project?rev=262700&view=rev Log: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations Summary: While diagnosing a CXXNewExpr warning, we were calling isInSystemHeader(), which

Re: [PATCH] D17847: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL262700: [SemaExprCXX] Avoid calling isInSystemHeader for invalid source locations (authored by labath). Changed prior to commit: http://reviews.llvm.org/D17847?vs=49725&id=49805#toc Repository: rL LL

[clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

labath wrote: I don't have the full context but I can definitely run the lldb test suite for you. I'm building now. (BTW, I see there are some merge conflicts on the PR.) https://github.com/llvm/llvm-project/pull/98795 ___ cfe-commits mailing list cfe

[clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

labath wrote: > I don't have the full context but I can definitely run the lldb test suite > for you. I'm building now. (BTW, I see there are some merge conflicts on the > PR.) I have the results now. The patch is based on a fairly old revision, so it didn't work for me without a python 3.12

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

labath wrote: > (btw, @labath is the alignment miscalculation still causing issues for you > internally? or did you find a workaround?) The fire has been extinguished by #110648, but it's not ideal that any structure with a [[no_unique_address]] is treated as packed. It's not causing any issu

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

labath wrote: I'm worried about the same thing as Michael. My question is: if the promotion type can be computed from the information in dwarf (can it always?), and clang already has code to compute it (not from DWARF, but from.. clang AST I guess), can we refactor that code somehow so that it

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

labath wrote: > Skipping empty fields does seem like a better heuristic here FWIW, I (independently) came to the same conclusion when investigating the fallout of #76756, though it's not fully clear to me whether the PR has been updated to do that. https://github.com/llvm/llvm-project/pull/9

[clang] [clang] Avoid unnecessary call to clang::NamespaceDecl::isRedundantInlineQualifierFor(). (PR #115196)

labath wrote: This makes sense to me, but I'll leave the review to someone from the clang team. https://github.com/llvm/llvm-project/pull/115196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

labath wrote: BTW, the main loop changes are something that you should be able to upstream quite easily. It sounds like the main problem is that you don't have a ppoll syscall, but the last round of changes means that ppoll is not actually necessary for its operation (the only reason to use it

[clang] Allow packing fields into tail padding of record fields (PR #122197)

labath wrote: I don't feel qualified to review this, but thank you for working on it. https://github.com/llvm/llvm-project/pull/122197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

labath wrote: FWIW, I came across another no_unique_address-related crash today: ``` $ cat a.cc struct S { private: int i; short s; }; static_assert(sizeof(S) == 8); struct T { [[no_unique_address]] S s; char c; }; static_assert(sizeof(T) == 8); T t; $ clang++ -c -o /tmp/a.out /tmp/a.cc

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

labath wrote: (I'm going to remove all the labels to try to avoid pinging everyone each time you rebase) https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

labath wrote: > Cherry picking this onto the 20.x release branch requires #125791 to be > cherry-picked first. But this is just a bugfix for that PR, right? (IOW, if there's no reason to cherry-pick that PR, then there's also no reason cherry-pick this fix) https://github.com/llvm/llvm-projec

[clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

labath wrote: Okay, nevermind me then. :) Thanks for the explanation. https://github.com/llvm/llvm-project/pull/126215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

labath wrote: IIUC, your debugger parses all of debug info upfront and builds up a vtable pointer->class DIE map. That's not something we would want to do in lldb, but I think we could still make use of this by first searching for the type using the name from the vtable (like we do now) and th