https://github.com/pogo59 approved this pull request.
Re-approving.
https://github.com/llvm/llvm-project/pull/74629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/78613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/79048
These are largely copy-pasted from the corresponding function descriptions.
Added \see cross-references. Also changed tags to \c.
>From 5a3f36a9276e0919d72cb48a7d30c2951b542c79 Mon Sep 17 00:00:00 2001
From: Pau
pogo59 wrote:
I note that these macros are just name substitutions, unlike the function-style
macros in ia32intrin.h. I didn't change the definitions.
https://github.com/llvm/llvm-project/pull/79048
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/79048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/70481
Our doc tooling complained about this missing directive.
>From a6bcb7b93d3d856a367b40b08a42c641c87217f3 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Fri, 27 Oct 2023 10:00:00 -0700
Subject: [PATCH] [Headers
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/70481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Are there interactions between `optdebug` and other attributes that should be
enforced by the verifier? Like, can't be mixed with `optnone`?
https://github.com/llvm/llvm-project/pull/66632
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/67613
Also add the filename to the comments it emits, to help identify where included
text ends.
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/67684
This option will cause -E to preserve the #include directives
for system headers, rather than expanding them into the output.
This can greatly reduce the volume of preprocessed source text
in a test case, making t
@@ -98,7 +98,7 @@
// == file2.h
// REWRITE: #if 0
// REWRITE: #include "file2.h"
-// REWRITE: #endif
+// REWRITE: #else /* file2.h expanded
pogo59 wrote:
Yes it does, but the point here is simply to identify that this is the correct
`#else`. The Preprocessor
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/2] Make -frewrite-includes put an endif at the end of the
includ
@@ -332,12 +346,14 @@ void InclusionRewriter::CommentOutDirective(Lexer
&DirectiveLex,
// OutputContentUpTo() would not output anything anyway.
return;
}
- OS << "#if 0 /* expanded by -frewrite-includes */" << MainEOL;
+ OS << "#if 0 /* " << getIncludedFileName(Inc
@@ -332,12 +346,14 @@ void InclusionRewriter::CommentOutDirective(Lexer
&DirectiveLex,
// OutputContentUpTo() would not output anything anyway.
return;
}
- OS << "#if 0 /* expanded by -frewrite-includes */" << MainEOL;
+ OS << "#if 0 /* " << getIncludedFileName(Inc
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/3] Make -frewrite-includes put an endif at the end of the
includ
pogo59 wrote:
Toggles done. Also got rid of some of the extra whitespace changes in the
output.
https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/3] [NFC] Change a reference member to pointer
This will allow th
pogo59 wrote:
@jrtc27 I've beefed up the help text some. I'm unable to find any "rendered
documentation" for `-E` and friends; if you can point me to it, I'd be happy to
add the new option there.
https://github.com/llvm/llvm-project/pull/67684
___
cf
pogo59 wrote:
Aha! Thank you. I should have found that third one in my searches, although it
doesn't really describe the options that affect `-E` mode. The first link does,
somewhat, and seems like the right place to add this new option. I'll have a go
at that.
https://github.com/llvm/llvm-pr
pogo59 wrote:
> The first link does, somewhat, and seems like the right place to add this new
> option. I'll have a go at that.
Well, that one appears to be generated from the Options.td file, and simply
includes the help text, so in effect I've already done that. :)
UsersManual.html doesn't
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/4] [NFC] Change a reference member to pointer
This will allow th
pogo59 wrote:
Also added a release note.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/4] Make -frewrite-includes put an endif at the end of the
includ
pogo59 wrote:
Ping @erichkeane were you willing to approve both this and #67613?
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Ping
https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/5] Make -frewrite-includes put an endif at the end of the
includ
pogo59 wrote:
Many of the clang-format complaints on this one are from the first commit,
which I wanted to make as minimalist as possible. I believe I didn't make the
file any _less_ conformant in that commit. :) I will fix the others.
https://github.com/llvm/llvm-project/pull/67684
_
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/6] Make -frewrite-includes put an endif at the end of the
includ
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow th
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow th
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow th
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Something got screwed up when I tried to squash all but the first commit
together. I put it back together manually. The NFC commit was pushed as
9500616, the functional stuff squashed and committed as 71d83bb.
https://github.com/llvm/llvm-project/pull/67684
__
pogo59 wrote:
Something got screwed up when I tried to squash all but the first commit
together. I put it back together manually. The NFC commit was pushed as
9500616, the functional stuff squashed and committed as 71d83bb.
https://github.com/llvm/llvm-project/pull/67684
__
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
In general, you cannot combine suffixes in the same directive. FileCheck will
detect and complain about some combinations, but it doesn't detect all of them.
I believe `CHECK-DAG-SAME` does not work the way you want it to, and in fact
acts as a no-op. This would be easy to verify
pogo59 wrote:
> Does this issue not apply to other platforms?
There is a deliberate layout/ABI choice that MSVC made ages ago and will never
change. It will only pack bitfields into the same word if the neighboring
bitfield declarations have the same base type. This is relatively well known.
pogo59 wrote:
I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to
use on Windows. (When I install Visual Studio, it creates a widget that brings
up a `cmd` shell with the right environment. I'm not aware of a similar widget
for PowerShell.) While I rarely try to copy-
pogo59 wrote:
I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to
use on Windows. (When I install Visual Studio, it creates a widget that brings
up a `cmd` shell with the right environment. I'm not aware of a similar widget
for PowerShell.) While I rarely try to copy-
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f s
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision `f8d7d77c06936315286eb5
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision `f8d7d77c06936315286eb5
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 commented:
Nice to see the LLVM intrusion into googletest proper is very minimized!
IME, testing on Linux with both gcc and clang as build compilers is very
helpful. With Windows/MSVC that covers the three main cases.
https://github.com/llvm/llvm-project/pull/65823
__
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f s
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f s
pogo59 wrote:
I'm happy with this, the bots will catch any environmental issues that you
haven't found yet. LGTM.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
@@ -2325,6 +2325,7 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::Naked);
// OptimizeNone wins over OptimizeForSize and MinSize.
+F->removeFnAttr(llvm::Attribute::OptimizeForDebugging);
--
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 opened https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/65485:
The test was looking only for the bitcode writer pass; it should check the full
pipeline to make sure the choice is as intended.
>From 6f5968e8e17ac4faae27bcaf2132a0df439f4c0f Mon Sep 17 00:00:00 2001
From: Paul
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
This came up because Sony makes slightly different choices downstream, and we
didn't get it exactly right in all cases.
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/82422
In Sony's document processing, the first "paragraph" of the description is
copied to a Brief Description section. Add paragraph breaks to make those brief
descriptions less verbose.
In fmaintrin.h we were includ
pogo59 wrote:
@cflores this is the upstream review I mentioned
https://github.com/llvm/llvm-project/pull/82422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2099,9 +2099,11 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS
_mm_add_epi64(__m128i __a,
}
/// Adds, with saturation, the corresponding elements of two 128-bit
-///signed [16 x i8] vectors, saving each sum in the corresponding element
of
-///a 128-bit result ve
@@ -2099,9 +2099,11 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS
_mm_add_epi64(__m128i __a,
}
/// Adds, with saturation, the corresponding elements of two 128-bit
-///signed [16 x i8] vectors, saving each sum in the corresponding element
of
-///a 128-bit result ve
https://github.com/pogo59 closed
https://github.com/llvm/llvm-project/pull/106463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 commented:
According to [gcc
docs](https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html) `--sysroot`
applies to headers and libraries, and `-isysroot` overrides it for headers
only. This is different from the "independence" described for World 2. That is,
if we
pogo59 wrote:
FTR I have no good explanation for why the PS4 handling is in the state it's
in--thanks for sorting this!
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
@@ -1,42 +1,64 @@
-// Check that PS4 clang doesn't report a warning message when locating
-// system header files (either by looking at the value of SCE_ORBIS_SDK_DIR
-// or relative to the location of the compiler driver), if "-nostdinc",
-// "--sysroot" or "-isysroot" option is
https://github.com/pogo59 edited
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args, StringRef Platform,
const char *EnvVar)
: Generic_ELF(D, Triple, Args) {
- // D
https://github.com/pogo59 approved this pull request.
LGTM, but pointed out the need for a test comment update (& replicate to the
PS5 equivalent test).
https://github.com/llvm/llvm-project/pull/107410
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/94514
There were four tests in Driver that actually tested bits of Driver and bits of
CodeGen, and therefore had target restrictions. Rework those four tests into
one Driver test (with no target restrictions) and two t
pogo59 wrote:
I wonder if a lot of the new target-specific headers don't need to be in
clang/include. That subtree is for headers that declare the exported interface
(exported to other libs/layers); if the target-specific headers are just there
for splitting up the module, they can stay in cl
pogo59 wrote:
@MaskRay @tru How do we proceed with this? The current state is broken.
https://github.com/llvm/llvm-project/pull/89775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/94514
>From 19ddcbdf2eabb812b65bd194085777abc48eade4 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 5 Jun 2024 11:15:46 -0700
Subject: [PATCH 1/2] [Driver] Rearrange some Apple version testing
There were four
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/94514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,9 @@
+; Test emitting version_min directives.
+
+; RUN: llc %s -filetype=asm -o - --mtriple arm64-apple-tvos9.0.0 | FileCheck
%s --check-prefix=TVOS
pogo59 wrote:
Right, this test has one arm64 command and two thumb commands.
I just now pushed #9510
pogo59 wrote:
> For my toolchain I can continue to carry a patch until this is all sorted.
Same here; I'm just professionally offended by the brokenness. But I'm not the
right person to drive an RFC. If nobody else is willing to, I'll abandon this
and we'll do what we need to downstream to ha
pogo59 wrote:
Well, hmmm, I dunno, a radical change like this really wants an RFC and weeks
of debate, right?
😄
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
pogo59 wrote:
You should have a look at [this imminent
patch](https://github.com/llvm/llvm-project/pull/91724) which will affect your
test.
https://github.com/llvm/llvm-project/pull/95298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
pogo59 wrote:
Abandoning this. We'll work around the brokenness in our downstream repo.
https://github.com/llvm/llvm-project/pull/89775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/89775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
What @SLTozer said. I don't want "members" to mean "some but not all members"
and "methods" was shorter than "member-functions" (but I'm okay with
"member-functions").
https://github.com/llvm/llvm-project/pull/87018
___
cfe-commits mail
pogo59 wrote:
Mildly curious that there isn't a SemaX86?
https://github.com/llvm/llvm-project/pull/93179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/93960
None
>From efbbb7b729ba4a24413f3d2a1769effba3581d8f Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Fri, 31 May 2024 06:11:30 -0700
Subject: [PATCH] [CUDA] Fix a couple of driver tests that really weren't bein
pogo59 wrote:
I found these because while I normally build with all targets, I don't usually
bother running check-all. The other day I did, and these two tests failed.
Driver tests normally should not need *-registered-target constraints, and
these tests were looking at the host's CUDA install
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/93960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/93988
Reverts llvm/llvm-project#93960
The change to offloading-interoperability.c broke many bots.
>From 8ce093226b730338a8faacb4ef09f97bcbc17515 Mon Sep 17 00:00:00 2001
From: Paul T Robinson
Date: Fri, 31 May 2024 1
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/93988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Reverted; the change to offloading-interoperability.c is not correct. I have
someone willing to run experiments for me to find another solution.
It would be good if the cuda/nvptx/etc bots ran check-clang-driver as well as
the llvm tests. These just never get run.
https://github
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/94000
…g run" (#93988)"
This reverts commit 6416958067179c2987af0ef4568cd57f98b7e347.
Fix bots by using different options.
>From 100fb8de09303d15def2dd8db1bf1e6a106e4763 Mon Sep 17 00:00:00 2001
From: Paul Robinson
D
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/94000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/94055
Removed foo-registered-target constraints from a bunch of tests, because mostly
the driver doesn't need to have a target availabile. I ran check-clang-driver
using a build with only the XCore target, and these al
@@ -1,6 +1,4 @@
// REQUIRES: system-linux
pogo59 wrote:
I hope you feel empowered to post more cleanup patches upstream!
https://github.com/llvm/llvm-project/pull/94055
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/94055
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Yeah lit is not so good at this; it means clang exited with an error, but lit
is somehow eating the error message. @erichkeane If you could run that clang
command manually and report the output, that would be extremely helpful.
https://github.com/llvm/llvm-project/pull/94000
pogo59 wrote:
If you add `--no-cuda-version-check` does the error go away?
https://github.com/llvm/llvm-project/pull/94000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 336 matches
Mail list logo
